summaryrefslogtreecommitdiffhomepage
path: root/include
diff options
context:
space:
mode:
authorAmlal El Mahrouss <amlal@nekernel.org>2025-12-12 14:45:09 +0100
committerAmlal El Mahrouss <amlal@nekernel.org>2025-12-12 14:45:09 +0100
commitfb094b222027aad36ebc294c0b21909dfe20b3f9 (patch)
tree13735af600898d719deb00c47f678cf57cc99f73 /include
parent358bcc6a52793dc7043415b242169af9ec78f6b4 (diff)
chore: performance improvements and tweaks.
Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
Diffstat (limited to 'include')
-rw-r--r--include/NeBuildKit/IManifestBuilder.h6
-rw-r--r--include/NeBuildKit/JSONManifestBuilder.h2
-rw-r--r--include/NeBuildKit/TOMLManifestBuilder.h2
3 files changed, 5 insertions, 5 deletions
diff --git a/include/NeBuildKit/IManifestBuilder.h b/include/NeBuildKit/IManifestBuilder.h
index c42f257..8223506 100644
--- a/include/NeBuildKit/IManifestBuilder.h
+++ b/include/NeBuildKit/IManifestBuilder.h
@@ -8,7 +8,7 @@
#include <NeBuildKit/Detail/Config.h>
#include <string_view>
-#define NEBUILD_MANIFEST_BUILDER : public ::NeBuild::IManifestBuilder
+#define NEBUILD_MANIFEST_BUILDER final : public ::NeBuild::IManifestBuilder
namespace NeBuild {
/// =========================================================== ///
@@ -29,11 +29,11 @@ class IManifestBuilder {
/// @retval true building has succeeded.
/// @retval false fail to build, see error message.
/// =========================================================== ///
- virtual bool BuildTarget(BuildConfig& config) = 0;
+ virtual bool BuildTarget(BuildConfig& config) { return false; }
/// =========================================================== ///
/// @brief Returns the build system name.
/// =========================================================== ///
- virtual const std::string_view BuildSystem() = 0;
+ virtual const std::string_view BuildSystem() { return "(null)"; }
};
} // namespace NeBuild \ No newline at end of file
diff --git a/include/NeBuildKit/JSONManifestBuilder.h b/include/NeBuildKit/JSONManifestBuilder.h
index 9f1afdc..4f3cec5 100644
--- a/include/NeBuildKit/JSONManifestBuilder.h
+++ b/include/NeBuildKit/JSONManifestBuilder.h
@@ -12,7 +12,7 @@
namespace NeBuild {
/// @brief JSON builder
-class JSONManifestBuilder final NEBUILD_MANIFEST_BUILDER {
+class JSONManifestBuilder NEBUILD_MANIFEST_BUILDER {
public:
JSONManifestBuilder() = default;
~JSONManifestBuilder() override = default;
diff --git a/include/NeBuildKit/TOMLManifestBuilder.h b/include/NeBuildKit/TOMLManifestBuilder.h
index 1c6bb1b..b4d61b8 100644
--- a/include/NeBuildKit/TOMLManifestBuilder.h
+++ b/include/NeBuildKit/TOMLManifestBuilder.h
@@ -12,7 +12,7 @@
namespace NeBuild {
/// @brief TOML builder
-class TOMLManifestBuilder final NEBUILD_MANIFEST_BUILDER {
+class TOMLManifestBuilder NEBUILD_MANIFEST_BUILDER {
public:
TOMLManifestBuilder() = default;
~TOMLManifestBuilder() override = default;