From db5d7e371e7183e4b5db26632ae2f511db4e0e41 Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Thu, 18 Dec 2025 01:43:51 +0100 Subject: chore: make `run_after_build` inactive. (JSON) Signed-off-by: Amlal El Mahrouss --- include/NeBuildKit/Detail/Config.h | 2 +- include/NeBuildKit/IManifestBuilder.h | 5 ++++- src/lib/JSONManifestBuilder.cc | 3 +++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/NeBuildKit/Detail/Config.h b/include/NeBuildKit/Detail/Config.h index ddf93c1..fc2e9cc 100644 --- a/include/NeBuildKit/Detail/Config.h +++ b/include/NeBuildKit/Detail/Config.h @@ -36,7 +36,7 @@ struct BuildConfig final { explicit operator bool() { return has_failed_; } - BuildConfig() = default; + BuildConfig() = default; ~BuildConfig() = default; }; } // namespace NeBuild diff --git a/include/NeBuildKit/IManifestBuilder.h b/include/NeBuildKit/IManifestBuilder.h index 8223506..95fb6b4 100644 --- a/include/NeBuildKit/IManifestBuilder.h +++ b/include/NeBuildKit/IManifestBuilder.h @@ -8,7 +8,10 @@ #include #include -#define NEBUILD_MANIFEST_BUILDER final : public ::NeBuild::IManifestBuilder +#define NEBUILD_MANIFEST_BUILDER \ + final: \ + public \ + ::NeBuild::IManifestBuilder namespace NeBuild { /// =========================================================== /// diff --git a/src/lib/JSONManifestBuilder.cc b/src/lib/JSONManifestBuilder.cc index 62fea22..fcb9204 100644 --- a/src/lib/JSONManifestBuilder.cc +++ b/src/lib/JSONManifestBuilder.cc @@ -96,6 +96,8 @@ bool JSONManifestBuilder::BuildTarget(BuildConfig& config) { return false; } + // FIXME: segfault. +#if 0 if (!config.dry_run_) { auto run_after_build = json_obj["run_after_build"].get(); @@ -110,6 +112,7 @@ bool JSONManifestBuilder::BuildTarget(BuildConfig& config) { } } } +#endif } catch (std::exception& err) { NeBuild::Logger::info() << "error: exit with message: " << err.what() << "" << std::endl; config.has_failed_ = true; -- cgit v1.2.3