From 635401b6a71dd7466604f25a1591ba324125d133 Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Wed, 31 Dec 2025 11:17:44 +0100 Subject: feat: codebase improvements introduce 'b_internal' keyword for SDK code. Signed-off-by: Amlal El Mahrouss --- src/cli/main.cc | 11 ++++++----- src/lib/JSONManifestBuilder.cc | 2 +- src/lib/TOMLManifestBuilder.cc | 2 +- 3 files changed, 8 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/cli/main.cc b/src/cli/main.cc index 5a10d07..61ab3c7 100644 --- a/src/cli/main.cc +++ b/src/cli/main.cc @@ -23,7 +23,7 @@ int main(int argc, char** argv) { NeBuild::Logger::info() << "NeBuild (" << NEBUILD_VERSION << ")\n"; return EXIT_SUCCESS; } else if (index_path == "-dry-run" || index_path == "-n") { - config.dry_run_ = true; + config.dry_run(true); continue; } else if (index_path == "-h" || index_path == "-help") { NeBuild::Logger::info() << "usage: nebuild .\n"; @@ -41,8 +41,9 @@ int main(int argc, char** argv) { if (index_path.ends_with(kJsonExtension)) { builder = std::make_unique(); + /// report failed build to config. if (!builder) { - config.has_failed_ = true; + config.has_failed(true); return; } } else { @@ -52,7 +53,7 @@ int main(int argc, char** argv) { if (!index_path.ends_with(kTomlExtension)) { NeBuild::Logger::info() << "error: file '" << index_path << "' is not a manifest file!" << std::endl; - config.has_failed_ = true; + config.has_failed(true); return; } } @@ -68,10 +69,10 @@ int main(int argc, char** argv) { NeBuild::Logger::info() << "building manifest: " << index_path << std::endl; - config.path_ = index_path; + config.path(index_path); if (builder && !builder->BuildTarget(config)) { - config.has_failed_ = true; + config.has_failed(true); } }); diff --git a/src/lib/JSONManifestBuilder.cc b/src/lib/JSONManifestBuilder.cc index bda523c..9dce796 100644 --- a/src/lib/JSONManifestBuilder.cc +++ b/src/lib/JSONManifestBuilder.cc @@ -95,7 +95,7 @@ bool JSONManifestBuilder::BuildTarget(BuildConfig& config) { config.has_failed_ = true; return false; } - } catch (std::exception& err) { + } catch (const std::exception& err) { NeBuild::Logger::info() << "error: exit with message: " << err.what() << "" << std::endl; config.has_failed_ = true; return false; diff --git a/src/lib/TOMLManifestBuilder.cc b/src/lib/TOMLManifestBuilder.cc index 0ed3668..c28b6bd 100644 --- a/src/lib/TOMLManifestBuilder.cc +++ b/src/lib/TOMLManifestBuilder.cc @@ -100,7 +100,7 @@ bool TOMLManifestBuilder::BuildTarget(BuildConfig& config) { config.has_failed_ = true; return false; } - } catch (std::runtime_error& err) { + } catch (const std::exception& err) { NeBuild::Logger::info() << "error: exit with message: " << err.what() << "" << std::endl; config.has_failed_ = true; return false; -- cgit v1.2.3