MHR-31: Detect all types of cores except the boot one.

Signed-off-by: amlal <amlalelmahrouss@icloud.com>

34 files changed, 113 insertions, 107 deletions

diff --git a/Boot/NetBoot/NetBoot.hxx b/Boot/NetBoot/NetBoot.hxx
index ccb43290..e3119c5f 100644
--- a/Boot/NetBoot/NetBoot.hxx
+++ b/Boot/NetBoot/NetBoot.hxx
@@ -19,9 +19,8 @@ typedef struct NetBootInternetHeader
 	CharacterTypeUTF8 NB3; /// magic char 3 'T'
 	CharacterTypeUTF8 NB4; /// magic char 4 'B'
 
-	CharacterTypeUTF8 PatchName[255]; /// example: ColdChoco
-	NewOS::Int32 PatchLength; /// the patch length.
+	CharacterTypeUTF8 PatchName[255];	/// example: ColdChoco
+	NewOS::Int32	  PatchLength;		/// the patch length.
 	CharacterTypeUTF8 PatchTarget[255]; /// the target file.
-	NewOS::Boolean ImpliesROM; /// does it implies EEPROM patching?
+	NewOS::Boolean	  ImpliesROM;		/// does it implies EEPROM patching?
 } NetBootInternetHeader;
-
diff --git a/Boot/Sources/HEL/AMD64/BootMain.cxx b/Boot/Sources/HEL/AMD64/BootMain.cxx
index 5ab7914a..fab212ee 100644
--- a/Boot/Sources/HEL/AMD64/BootMain.cxx
+++ b/Boot/Sources/HEL/AMD64/BootMain.cxx
@@ -81,8 +81,8 @@ STATIC Bool CheckBootDevice(BootDeviceATA& ataDev)
 EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr	  ImageHandle,
 							  EfiSystemTable* SystemTable)
 {
-	InitEFI(SystemTable);	   ///! Init the EFI library.
-	InitVideoFB(); ///! Init the GOP.
+	InitEFI(SystemTable); ///! Init the EFI library.
+	InitVideoFB();		  ///! Init the GOP.
 
 	BTextWriter writer;
 
@@ -146,13 +146,13 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr	  ImageHandle,
 	GXInit();
 
 	GXDraw(RGB(9d, 9d, 9d), handoverHdrPtr->f_GOP.f_Height,
-					handoverHdrPtr->f_GOP.f_Width, 0, 0);
+		   handoverHdrPtr->f_GOP.f_Width, 0, 0);
 
 	GXFini();
 
 	GXDrawImg(NewBoot, NEWBOOT_HEIGHT, NEWBOOT_WIDTH,
-					(handoverHdrPtr->f_GOP.f_Width - NEWBOOT_WIDTH) / 2,
-					(handoverHdrPtr->f_GOP.f_Height - NEWBOOT_HEIGHT) / 2);
+			  (handoverHdrPtr->f_GOP.f_Width - NEWBOOT_WIDTH) / 2,
+			  (handoverHdrPtr->f_GOP.f_Height - NEWBOOT_HEIGHT) / 2);
 
 	GXFini();
 
diff --git a/Boot/makefile b/Boot/makefile
index 4bee19a2..e54b1aa8 100644
--- a/Boot/makefile
+++ b/Boot/makefile
@@ -26,7 +26,7 @@ BIOS=OVMF.fd
 IMG=epm.img
 IMG_2=epm-slave.img
 
-EMU_FLAGS=-net none -smp 4 -serial stdio -m 4G -M q35 \
+EMU_FLAGS=-net none -smp 4 -m 4G -M q35 \
 			-bios $(BIOS) -device piix3-ide,id=ide \
 			-drive id=disk,file=$(IMG),format=raw,if=none \
 			-device ide-hd,drive=disk,bus=ide.0 -drive \
diff --git a/DDK/KernelCall.c b/DDK/KernelCall.c
index a16a5278..7dc5761c 100644
--- a/DDK/KernelCall.c
+++ b/DDK/KernelCall.c
@@ -9,13 +9,14 @@
 #include <DDK/KernelStd.h>
 #include <stdarg.h>
 
+/// @brief this is an internal call, do not use it.
 DK_EXTERN __attribute__((naked)) void* __kernelDispatchCall(const char* name, int32_t cnt, void* data, size_t sz);
 
 /// @brief Execute a function on the kernel.
 /// @param kernelRpcName the name of the function.
 /// @param cnt number of arguments.
-/// @param  
-/// @return 
+/// @param
+/// @return
 DK_EXTERN void* kernelCall(const char* kernelRpcName, int32_t cnt, void* data, size_t sz)
 {
 	if (!kernelRpcName || cnt == 0)
diff --git a/DDK/KernelStd.h b/DDK/KernelStd.h
index 63df4c2a..0486479c 100644
--- a/DDK/KernelStd.h
+++ b/DDK/KernelStd.h
@@ -20,9 +20,9 @@
 #include <stddef.h>
 
 /// @brief Call kernel (interrupt 0x33)
-/// @param kernelRpcName 
-/// @param cnt 
-/// @param dat 
-/// @param sz 
-/// @return 
+/// @param kernelRpcName
+/// @param cnt
+/// @param dat
+/// @param sz
+/// @return
 DK_EXTERN void* kernelCall(const char* kernelRpcName, int32_t cnt, void* dat, size_t sz);
diff --git a/Kernel/ArchKit/ArchKit.hpp b/Kernel/ArchKit/ArchKit.hpp
index 6407a0d8..c889c93c 100644
--- a/Kernel/ArchKit/ArchKit.hpp
+++ b/Kernel/ArchKit/ArchKit.hpp
@@ -83,8 +83,8 @@ typedef NewOS::Void (*rt_syscall_proc)(NewOS::VoidPtr);
 
 struct RTSyscallInfoHdr final
 {
-	NewOS::Int64 fHash;
-	NewOS::Bool fHooked;
+	NewOS::Int64	fHash;
+	NewOS::Bool		fHooked;
 	rt_syscall_proc fProc;
 };
 
diff --git a/Kernel/FirmwareKit/EFI/API.hxx b/Kernel/FirmwareKit/EFI/API.hxx
index c6d02a3e..0f7da5a4 100644
--- a/Kernel/FirmwareKit/EFI/API.hxx
+++ b/Kernel/FirmwareKit/EFI/API.hxx
@@ -92,8 +92,8 @@ Bascially frees everything we have in the EFI side.
 		GXInit();
 
 		GXDrawImg(NewBootFatal, NEWBOOTFATAL_HEIGHT, NEWBOOTFATAL_WIDTH,
-						(kHandoverHeader->f_GOP.f_Width - NEWBOOTFATAL_WIDTH) / 2,
-						(kHandoverHeader->f_GOP.f_Height - NEWBOOTFATAL_HEIGHT) / 2);
+				  (kHandoverHeader->f_GOP.f_Width - NEWBOOTFATAL_WIDTH) / 2,
+				  (kHandoverHeader->f_GOP.f_Height - NEWBOOTFATAL_HEIGHT) / 2);
 
 		GXFini();
 
diff --git a/Kernel/FirmwareKit/EPM.hxx b/Kernel/FirmwareKit/EPM.hxx
index 7c4b37b6..93f4730e 100644
--- a/Kernel/FirmwareKit/EPM.hxx
+++ b/Kernel/FirmwareKit/EPM.hxx
@@ -117,16 +117,16 @@ typedef struct PartitionBlock PartitionBlockType;
 
 ///! @brief partition must start at this address.
 ///! Anything below is reserved for Data backup by the Main OS.
-#define kEPMStartPartitionBlk 	(sizeof(BootBlock))
+#define kEPMStartPartitionBlk (sizeof(BootBlock))
 
 ///! @brief Current EPM revision (2)
-#define kEPMRevision 			(3)
+#define kEPMRevision (3)
 
 ///! @brief Current EPM revision (2)
-#define kEPMRevisionUEFI 		(0xF)
+#define kEPMRevisionUEFI (0xF)
 
 /* @brief Maximum block count. */
-#define kEPMMaxBlks 			(128)
+#define kEPMMaxBlks (128)
 
 /// END OF SPECS
 
diff --git a/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp b/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
index 51570b86..e9c0941c 100644
--- a/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
+++ b/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
@@ -82,8 +82,7 @@ EXTERN_C NewOS::Void hal_system_call_enter(NewOS::UIntPtr rcx, NewOS::UIntPtr rd
 /// @brief Enter kernel call from assembly (DDK only).
 /// @param stack the stack pushed from assembly routine.
 /// @return nothing.
-EXTERN_C NewOS::Void hal_kernel_call_enter(NewOS::UIntPtr rcx, NewOS::UIntPtr rdx,
-											NewOS::UIntPtr r8, NewOS::UIntPtr r9)
+EXTERN_C NewOS::Void hal_kernel_call_enter(NewOS::UIntPtr rcx, NewOS::UIntPtr rdx, NewOS::UIntPtr r8, NewOS::UIntPtr r9)
 {
 	if (rcx != 0)
 	{
diff --git a/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp b/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
index c15a7b55..37a681ab 100644
--- a/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
+++ b/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
@@ -113,10 +113,16 @@ namespace NewOS::HAL
 
 	///////////////////////////////////////////////////////////////////////////////////////
 
-	STATIC MadtType* kApicInfoBlock			 = nullptr;
-	STATIC UIntPtr	 kApicMadtAddresses[255] = {0};
-	STATIC SizeT	 kApicMadtAddressesCount = 0UL;
-	STATIC UIntPtr	 cBaseAddressAPIC		 = 0xFEE00000;
+	STATIC MadtType* kApicInfoBlock = nullptr;
+
+	STATIC struct
+	{
+		UIntPtr fAddress{0};
+		UInt32	fKind{0};
+	} kApicMadtAddresses[255] = {};
+
+	STATIC SizeT   kApicMadtAddressesCount = 0UL;
+	STATIC UIntPtr cBaseAddressAPIC		   = 0xFEE00000;
 
 	/// @brief this will help us schedule our cores.
 	STATIC Boolean* cProgramInitialized = nullptr;
@@ -156,7 +162,6 @@ namespace NewOS::HAL
 
 	EXTERN_C Void hal_apic_acknowledge_cont(Void)
 	{
-	    ProcessHelper::StartScheduling();
 		_hal_spin_core();
 	}
 
@@ -202,21 +207,23 @@ namespace NewOS::HAL
 
 		if (kApicMadt != nullptr)
 		{
-			MadtType* madt = (MadtType*)kApicMadt;
+			MadtType* madt = reinterpret_cast<MadtType*>(kApicMadt);
 
 			constexpr auto cMaxProbableCores = 4; // the amount of cores we want.
 			constexpr auto cStartAt			 = 0; // start here to avoid boot core.
 
 			for (SizeT coreAt = cStartAt; coreAt < cMaxProbableCores; ++coreAt)
 			{
-				if (madt->MadtRecords[coreAt].Flags == kThreadLAPIC) // if local apic.
+				if (madt->MadtRecords[coreAt].Flags != kThreadBoot) // if local apic.
 				{
 					MadtType::MadtAddress& madtRecord = madt->MadtRecords[coreAt];
 
 					// then register as a core for scheduler.
-					kcout << "newoskrnl: register core as scheduler thread.\r";
+					kcout << "newoskrnl: Register Local APIC.\r";
+
+					kApicMadtAddresses[kApicMadtAddressesCount].fAddress = madtRecord.Address;
+					kApicMadtAddresses[kApicMadtAddressesCount].fKind	 = madt->MadtRecords[coreAt].Flags;
 
-					kApicMadtAddresses[kApicMadtAddressesCount] = madtRecord.Address;
 					++kApicMadtAddressesCount;
 				}
 			}
@@ -241,7 +248,7 @@ namespace NewOS::HAL
 			cProgramInitialized = new Boolean(true);
 
 			constexpr auto cWhereToInterrupt = 0x40;
-			constexpr auto cWhatCore = 1;
+			constexpr auto cWhatCore		 = 1;
 
 			hal_send_start_ipi(cWhatCore, cWhereToInterrupt, cBaseAddressAPIC);
 		}
diff --git a/Kernel/HALKit/AMD64/HalKernelMain.cxx b/Kernel/HALKit/AMD64/HalKernelMain.cxx
index 7064183b..9b605e1a 100644
--- a/Kernel/HALKit/AMD64/HalKernelMain.cxx
+++ b/Kernel/HALKit/AMD64/HalKernelMain.cxx
@@ -79,8 +79,8 @@ EXTERN_C void hal_init_platform(
 	constexpr auto cDummyInterrupt = 0x10; // 16
 
 	kSyscalls[cDummyInterrupt].Leak().Leak()->fProc = [](NewOS::VoidPtr sf) -> void {
-	    const char* msg = (const char*)sf;
-	    NewOS::kcout << "newoskrnl: " << msg << "\r";
+		const char* msg = (const char*)sf;
+		NewOS::kcout << "newoskrnl: " << msg << "\r";
 	};
 
 	kSyscalls[cDummyInterrupt].Leak().Leak()->fHooked = true;
@@ -93,5 +93,6 @@ EXTERN_C void hal_init_platform(
 	NewOS::HAL::hal_system_get_cores(kHandoverHeader->f_HardwareTables.f_RsdPtr);
 
 	while (true)
-	{}
+	{
+	}
 }
diff --git a/Kernel/HALKit/AMD64/PCI/Iterator.cxx b/Kernel/HALKit/AMD64/PCI/Iterator.cxx
index 297aa89c..d3167b46 100644
--- a/Kernel/HALKit/AMD64/PCI/Iterator.cxx
+++ b/Kernel/HALKit/AMD64/PCI/Iterator.cxx
@@ -7,7 +7,7 @@
 #include <KernelKit/PCI/Iterator.hpp>
 
 #define PCI_ITERATOR_FIND_AND_UNWRAP(DEV, SZ) \
-	if (DEV.Leak().Leak())                           \
+	if (DEV.Leak().Leak())                    \
 		return *DEV.Leak().Leak();
 
 namespace NewOS::PCI
diff --git a/Kernel/HALKit/AXP/CoreSyscallHandlerDEC.cpp b/Kernel/HALKit/AXP/CoreSyscallHandlerDEC.cpp
index 3217a660..f308b0b5 100644
--- a/Kernel/HALKit/AXP/CoreSyscallHandlerDEC.cpp
+++ b/Kernel/HALKit/AXP/CoreSyscallHandlerDEC.cpp
@@ -8,7 +8,7 @@
 #include <HALKit/AXP/Processor.hpp>
 
 /// @brief Internal call for syscall, to work with C++.
-/// @param stack 
+/// @param stack
 /// @return nothing.
 EXTERN_C void rt_syscall_handle(NewOS::HAL::StackFrame* stack)
 {
diff --git a/Kernel/KernelKit/DriveManager.hxx b/Kernel/KernelKit/DriveManager.hxx
index e78c350e..df7d5f28 100644
--- a/Kernel/KernelKit/DriveManager.hxx
+++ b/Kernel/KernelKit/DriveManager.hxx
@@ -14,10 +14,10 @@
 #include <NewKit/Defines.hpp>
 #include <NewKit/String.hpp>
 
-#define kDriveManagerCount 	(4U)
+#define kDriveManagerCount (4U)
 
-#define kDriveInvalidID 	(-1)
-#define kDriveNameLen		(32)
+#define kDriveInvalidID (-1)
+#define kDriveNameLen	(32)
 
 namespace NewOS
 {
diff --git a/Kernel/KernelKit/FileManager.hpp b/Kernel/KernelKit/FileManager.hpp
index 71f3cfd0..b06b926e 100644
--- a/Kernel/KernelKit/FileManager.hpp
+++ b/Kernel/KernelKit/FileManager.hpp
@@ -134,7 +134,7 @@ namespace NewOS
 		void SetDataFork(const char* forkName);
 
 		/// @brief Get internal parser.
-		/// @return 
+		/// @return
 		NewFSParser* GetParser() noexcept;
 
 	private:
diff --git a/Kernel/KernelKit/Framebuffer.hpp b/Kernel/KernelKit/Framebuffer.hpp
index 3437fed1..ebe983c8 100644
--- a/Kernel/KernelKit/Framebuffer.hpp
+++ b/Kernel/KernelKit/Framebuffer.hpp
@@ -39,7 +39,7 @@ namespace NewOS
 			: fFrameBufferAddr(addr)
 		{
 		}
-		
+
 		~Framebuffer()
 		{
 		}
diff --git a/Kernel/KernelKit/KernelHeap.hpp b/Kernel/KernelKit/KernelHeap.hpp
index 7b8cbc7c..6be94a63 100644
--- a/Kernel/KernelKit/KernelHeap.hpp
+++ b/Kernel/KernelKit/KernelHeap.hpp
@@ -37,8 +37,8 @@ namespace NewOS
 	/// @return if it valid: point has crc now., otherwise fail.
 	Boolean ke_protect_ke_heap(VoidPtr heapPtr);
 
-    /// @brief Makes a kernel heap page.
-    /// @param heapPtr 
-    /// @return 
-    Int32 ke_make_ke_page(VoidPtr heapPtr);
+	/// @brief Makes a kernel heap page.
+	/// @param heapPtr
+	/// @return
+	Int32 ke_make_ke_page(VoidPtr heapPtr);
 } // namespace NewOS
diff --git a/Kernel/KernelKit/ProcessScheduler.hxx b/Kernel/KernelKit/ProcessScheduler.hxx
index 1ac19053..637fc8c4 100644
--- a/Kernel/KernelKit/ProcessScheduler.hxx
+++ b/Kernel/KernelKit/ProcessScheduler.hxx
@@ -162,8 +162,8 @@ namespace NewOS
 
 		enum
 		{
-			kAppKind	= 1,
-			kShLibKind	= 2,
+			kAppKind   = 1,
+			kShLibKind = 2,
 			kKindCount,
 		};
 
@@ -231,14 +231,14 @@ namespace NewOS
 	/// The main class which you call to schedule an app.
 	class ProcessScheduler final
 	{
-	    explicit ProcessScheduler() = default;
+		explicit ProcessScheduler() = default;
 
 	public:
 		~ProcessScheduler() = default;
 
 		NEWOS_COPY_DEFAULT(ProcessScheduler)
 
-		operator bool();
+			 operator bool();
 		bool operator!();
 
 	public:
diff --git a/Kernel/KernelKit/SMPManager.hpp b/Kernel/KernelKit/SMPManager.hpp
index ba706cf6..1840dd20 100644
--- a/Kernel/KernelKit/SMPManager.hpp
+++ b/Kernel/KernelKit/SMPManager.hpp
@@ -99,8 +99,8 @@ namespace NewOS
 
 	public:
 		Ref<HardwareThread*> operator[](const SizeT& idx);
-		bool				operator!() noexcept;
-							operator bool() noexcept;
+		bool				 operator!() noexcept;
+							 operator bool() noexcept;
 
 	public:
 		/// @brief Shared instance of the SMP Manager.
diff --git a/Kernel/KernelKit/XCOFF.hxx b/Kernel/KernelKit/XCOFF.hxx
index 4574fcf7..0d74b3ef 100644
--- a/Kernel/KernelKit/XCOFF.hxx
+++ b/Kernel/KernelKit/XCOFF.hxx
@@ -16,7 +16,7 @@
 
 #include <NewKit/Defines.hpp>
 
-#define cXCOFF64Magic 	 (0x01F7)
+#define cXCOFF64Magic (0x01F7)
 
 #define cXCOFFRelFlg	 (0x0001)
 #define cXCOFFExecutable (0x0002)
@@ -41,10 +41,11 @@ typedef struct XCoffFileHeader
 #define cForkNameLen (255)
 
 /// @brief This the executable manifest fork.
-typedef struct XCoffForkHeader {
-	NewOS::Char	   fPropertiesXMLFork[cForkNameLen];
-	NewOS::Char	   fDynamicLoaderFork[cForkNameLen];
-	NewOS::Char	   fCodeSignFork[cForkNameLen];
+typedef struct XCoffForkHeader
+{
+	NewOS::Char fPropertiesXMLFork[cForkNameLen];
+	NewOS::Char fDynamicLoaderFork[cForkNameLen];
+	NewOS::Char fCodeSignFork[cForkNameLen];
 } XCoffForkHeader;
 
 #endif // ifndef __XCOFF__
diff --git a/Kernel/NetworkKit/IPCEP.hxx b/Kernel/NetworkKit/IPCEP.hxx
index a00fa98e..72efae73 100644
--- a/Kernel/NetworkKit/IPCEP.hxx
+++ b/Kernel/NetworkKit/IPCEP.hxx
@@ -50,8 +50,8 @@ namespace NewOS
 		IPCEPAddressType IpcFrom;
 		IPCEPAddressType IpcTo;
 		UInt32			 IpcCRC32;
-		UInt32           IpcMsg;
-		UInt32           IpcMsgSz;
+		UInt32			 IpcMsg;
+		UInt32			 IpcMsgSz;
 	} PACKED IPCEPConnectionHeader;
 } // namespace NewOS
 
diff --git a/Kernel/NewKit/Array.hpp b/Kernel/NewKit/Array.hpp
index dca5c13f..b0b94584 100644
--- a/Kernel/NewKit/Array.hpp
+++ b/Kernel/NewKit/Array.hpp
@@ -26,7 +26,6 @@ namespace NewOS
 			if (At > N)
 				return {};
 
-			kcout << "Returning element\r";
 			return ErrorOr<T*>(&fArray[At]);
 		}
 
diff --git a/Kernel/NewKit/MutableArray.hpp b/Kernel/NewKit/MutableArray.hpp
index a3ad4cb1..6be9c15e 100644
--- a/Kernel/NewKit/MutableArray.hpp
+++ b/Kernel/NewKit/MutableArray.hpp
@@ -173,8 +173,8 @@ namespace NewOS
 
 			if (!iterationNode)
 			{
-    			fFirstNode = new  MutableLinkedList<T>();
-    			iterationNode = fFirstNode;
+				fFirstNode	  = new MutableLinkedList<T>();
+				iterationNode = fFirstNode;
 			}
 
 			MUST_PASS(iterationNode);
diff --git a/Kernel/Sources/HError.cxx b/Kernel/Sources/HError.cxx
index 1f36d020..5ba02049 100644
--- a/Kernel/Sources/HError.cxx
+++ b/Kernel/Sources/HError.cxx
@@ -13,7 +13,7 @@ namespace NewOS
 	/// @return if error-free: true, otherwise false.
 	Boolean ke_bug_check(void) noexcept
 	{
-	/// TODO:
+		/// TODO:
 		return false;
 	}
 } // namespace NewOS
diff --git a/Kernel/Sources/KeMain.cxx b/Kernel/Sources/KeMain.cxx
index 9be8a026..58c76dc4 100644
--- a/Kernel/Sources/KeMain.cxx
+++ b/Kernel/Sources/KeMain.cxx
@@ -68,7 +68,7 @@ namespace NewOS::Detail
 						}
 
 						catalogDir = fNewFS->GetParser()->CreateCatalog(cDirStr[dirIndx], 0,
-																	  kNewFSCatalogKindDir);
+																		kNewFSCatalogKindDir);
 
 						NewFork theFork{0};
 
@@ -157,8 +157,8 @@ namespace NewOS::Detail
 
 					fNewFS->GetParser()->CreateFork(catalogDisk, theDiskFork);
 					fNewFS->GetParser()->WriteCatalog(catalogDisk,
-													(NewOS::VoidPtr)diskFolder.CData(),
-													kNewFSSectorSz, cSrcName);
+													  (NewOS::VoidPtr)diskFolder.CData(),
+													  kNewFSSectorSz, cSrcName);
 
 					delete catalogDisk;
 				}
diff --git a/Kernel/Sources/KernelHeap.cxx b/Kernel/Sources/KernelHeap.cxx
index 00dfce8c..c3e8e86b 100644
--- a/Kernel/Sources/KernelHeap.cxx
+++ b/Kernel/Sources/KernelHeap.cxx
@@ -76,8 +76,8 @@ namespace NewOS
 	}
 
 	/// @brief Makes a page heap.
-	/// @param heapPtr 
-	/// @return 
+	/// @param heapPtr
+	/// @return
 	Int32 ke_make_ke_page(VoidPtr heapPtr)
 	{
 		if (kHeapCount < 1)
diff --git a/Kernel/Sources/SMPManager.cxx b/Kernel/Sources/SMPManager.cxx
index 683343ff..5002e880 100644
--- a/Kernel/Sources/SMPManager.cxx
+++ b/Kernel/Sources/SMPManager.cxx
@@ -110,8 +110,8 @@ namespace NewOS
 			fStack->R11 = stack->R11;
 
 			fStack->R10 = stack->R10;
-			fStack->R9 = stack->R9;
-			fStack->R8 = stack->R8;
+			fStack->R9	= stack->R9;
+			fStack->R8	= stack->R8;
 
 			fStack->Rcx = this->fID;
 		}
@@ -219,7 +219,7 @@ namespace NewOS
 
 			if (!fakeThread)
 			{
-			    fakeThread = new HardwareThread();
+				fakeThread = new HardwareThread();
 			}
 
 			fakeThread->fKind = kInvalidHart;
diff --git a/Kernel/Sources/UserHeap.cxx b/Kernel/Sources/UserHeap.cxx
index ad3c4aa4..d1de13a6 100644
--- a/Kernel/Sources/UserHeap.cxx
+++ b/Kernel/Sources/UserHeap.cxx
@@ -37,8 +37,8 @@ namespace NewOS
 	 */
 	class UserHeapManager final
 	{
-		UserHeapManager()  = delete;
-		
+		UserHeapManager() = delete;
+
 	public:
 		~UserHeapManager() = default;
 
@@ -47,12 +47,12 @@ namespace NewOS
 		{
 			return s_NumPools;
 		}
-		
+
 		STATIC Ref<Pmm>& Leak()
 		{
 			return s_Pmm;
 		}
-		
+
 		STATIC Boolean& IsEnabled()
 		{
 			return s_PoolsAreEnabled;
diff --git a/Usr/Sys/CoreSystem/Headers/Defines.h b/Usr/Sys/CoreSystem/Headers/Defines.h
index 2c04c3f1..f659fa76 100644
--- a/Usr/Sys/CoreSystem/Headers/Defines.h
+++ b/Usr/Sys/CoreSystem/Headers/Defines.h
@@ -11,12 +11,12 @@
 #endif
 
 #ifdef _DEBUG
-#define CS_MUST_PASS(e)                                                                                             \
-	{                                                                                                               \
-		if (!e)                                                                                                     \
-		{                                                                                                           \
+#define CS_MUST_PASS(e)                                                                                                         \
+	{                                                                                                                           \
+		if (!e)                                                                                                                 \
+		{                                                                                                                       \
 			UiAlert("Assertion failed.\nExpression :%s\nFile: %s\nLine: %i", #e, __FILE__, __LINE__) RtAssertTriggerInterrupt() \
-		}                                                                                                           \
+		}                                                                                                                       \
 	}
 #else
 #define CS_MUST_PASS(e) CS_UNREFERENCED_PARAMETER(e)
@@ -124,7 +124,7 @@ typedef CharacterTypeUTF8 BooleanType;
 #define CS_CONSTEXPR
 #endif // __cplusplus
 
-enum 
+enum
 {
 	kCallAllocPtr = 1,
 	kCallFreePtr,
@@ -173,8 +173,7 @@ typedef struct ApplicationInterface
 {
 	VoidType (*Release)(struct ApplicationInterface* Self, DWordType ExitCode);
 	IntPtrType (*Invoke)(struct ApplicationInterface* Self, DWordType Sel, ...);
-	VoidType (*Query)(struct ApplicationInterface* Self, PtrVoidType* Dst, 
-						SizeType SzDst, struct GUID* GuidOf);
+	VoidType (*Query)(struct ApplicationInterface* Self, PtrVoidType* Dst, SizeType SzDst, struct GUID* GuidOf);
 } ApplicationInterface, *ApplicationInterfaceRef;
 
 #ifdef __cplusplus
@@ -214,12 +213,12 @@ CS_EXTERN_C ApplicationInterfaceRef RtGetAppPointer(VoidType);
 /// @brief Get argument count
 /// @param
 /// @return
-CS_EXTERN_C SizeType 				RtGetAppArgumentsCount(VoidType);
+CS_EXTERN_C SizeType RtGetAppArgumentsCount(VoidType);
 
 /// @brief Get argument pointer.
 /// @param
 /// @return
-CS_EXTERN_C CharacterTypeUTF8** 	RtGetAppArgumentsPtr(VoidType);
+CS_EXTERN_C CharacterTypeUTF8** RtGetAppArgumentsPtr(VoidType);
 
 /// @brief Shared application interface.
 CS_EXTERN_C ApplicationInterfaceRef kSharedApplication;
diff --git a/Usr/Sys/CoreSystem/Headers/File.h b/Usr/Sys/CoreSystem/Headers/File.h
index 66bc6549..12dfb033 100644
--- a/Usr/Sys/CoreSystem/Headers/File.h
+++ b/Usr/Sys/CoreSystem/Headers/File.h
@@ -51,7 +51,7 @@ CS_EXTERN_C BooleanType CSIsValidPath(const CharacterTypeUTF8* path);
 
 /// @brief Flush file
 /// @param refCS the file reference.
-/// @return 
+/// @return
 CS_EXTERN_C VoidType CSFlushFile(FSRef refCS);
 
 /// END OF FILE
diff --git a/Usr/Sys/CoreSystem/Headers/Intl.h b/Usr/Sys/CoreSystem/Headers/Intl.h
index c9eae306..afc7431c 100644
--- a/Usr/Sys/CoreSystem/Headers/Intl.h
+++ b/Usr/Sys/CoreSystem/Headers/Intl.h
@@ -14,12 +14,12 @@ typedef UInt64Type IntlRef;
 
 /// @brief Get app locale.
 /// @param name locale name.
-/// @return 
-IntlRef		IntlGetLocale(const char* name);
+/// @return
+IntlRef IntlGetLocale(const char* name);
 
 /// @brief Set app locale.
 /// @param intl the locale
-/// @return 
+/// @return
 BooleanType IntlSetLocale(const IntlRef intl);
 
 /// @brief locale helpers.
diff --git a/Usr/Sys/CoreSystem/Headers/Transport.h b/Usr/Sys/CoreSystem/Headers/Transport.h
index 671621c8..996e69cc 100644
--- a/Usr/Sys/CoreSystem/Headers/Transport.h
+++ b/Usr/Sys/CoreSystem/Headers/Transport.h
@@ -28,19 +28,19 @@ CS_EXTERN_C CS_CONST TptStreamType CSOpenSocket(UInt32Type afType, UInt32Type so
 
 /// @brief Close a STREAMS socket.
 /// @param streams The streams socket.
-/// @return 
+/// @return
 CS_EXTERN_C VoidType CSCloseSocket(CS_CONST TptStreamType streams);
 
 /// @brief Get OpenTransport version.
 /// @param void
-/// @return 
+/// @return
 CS_EXTERN_C CS_CONST Int32Type CSGetVersion(VoidType);
 
 enum
 {
 	TrSocketProtoTCP, /// TCP socket
 	TrSocketProtoUDP, /// UDP socket
-	TrSocketProtoUN, /// IPC  socket
+	TrSocketProtoUN,  /// IPC  socket
 	TrSocketProtoRaw, /// Raw socket
 	TrSocketProtoCount,
 };
diff --git a/Usr/Sys/CoreSystem/Sources/CRTStartup.c b/Usr/Sys/CoreSystem/Sources/CRTStartup.c
index faefe9b7..2dc9b1c4 100644
--- a/Usr/Sys/CoreSystem/Sources/CRTStartup.c
+++ b/Usr/Sys/CoreSystem/Sources/CRTStartup.c
@@ -8,5 +8,5 @@
 
 VoidType __DllMainCRTStartup(VoidType)
 {
-    kSharedApplication = RtGetAppPointer();
+	kSharedApplication = RtGetAppPointer();
 }
\ No newline at end of file
diff --git a/Usr/Sys/CoreSystem/Sources/File.c b/Usr/Sys/CoreSystem/Sources/File.c
index 9f6b3b35..2e34d782 100644
--- a/Usr/Sys/CoreSystem/Sources/File.c
+++ b/Usr/Sys/CoreSystem/Sources/File.c
@@ -19,7 +19,7 @@ enum FileOp
 /// @brief Opens a new file.
 /// @param path where to find it.
 /// @param rest the restrict (rw, rwe, r+, w+, r, w)
-/// @return FSRef the file.
+/// @return FSRef file reference.
 CS_EXTERN_C FSRef CSOpenFile(const CharacterTypeUTF8* path,
 							 const CharacterTypeUTF8* rest)
 {
@@ -33,7 +33,7 @@ CS_EXTERN_C FSRef CSOpenFile(const CharacterTypeUTF8* path,
 
 /// @brief Closes the file and flushes it to the said file.
 /// @param refCS the filesystem reference.
-/// @return
+/// @return void
 CS_EXTERN_C VoidType CSCloseFile(FSRef refCS)
 {
 	CS_MUST_PASS(kSharedApplication);
@@ -45,7 +45,7 @@ CS_EXTERN_C VoidType CSCloseFile(FSRef refCS)
 
 /// @brief Flush file
 /// @param refCS the file reference.
-/// @return 
+/// @return void
 CS_EXTERN_C VoidType CSFlushFile(FSRef refCS)
 {
 	CS_MUST_PASS(kSharedApplication);
@@ -54,16 +54,16 @@ CS_EXTERN_C VoidType CSFlushFile(FSRef refCS)
 }
 
 /// @brief Check if filesystem path is valid.
-/// @param path 
-/// @return 
+/// @param path the filesystem path.
+/// @return if the path is valid or not.
 CS_EXTERN_C BooleanType CSIsValidPath(const CharacterTypeUTF8* path)
 {
 	CS_MUST_PASS(kSharedApplication);
 	CS_MUST_PASS(path);
 
 	return kSharedApplication->Invoke(kSharedApplication, kCallFileExists, path) ||
-			kSharedApplication->Invoke(kSharedApplication, kCallDirectoryExists, path) ||
-			kSharedApplication->Invoke(kSharedApplication, kCallSymlinkExists, path) ||
-			kSharedApplication->Invoke(kSharedApplication, kCallDriveExists, path) ||
-			kSharedApplication->Invoke(kSharedApplication, kCallDeviceExists, path);
+		   kSharedApplication->Invoke(kSharedApplication, kCallDirectoryExists, path) ||
+		   kSharedApplication->Invoke(kSharedApplication, kCallSymlinkExists, path) ||
+		   kSharedApplication->Invoke(kSharedApplication, kCallDriveExists, path) ||
+		   kSharedApplication->Invoke(kSharedApplication, kCallDeviceExists, path);
 }
\ No newline at end of file