diff options
| author | Amlal El Mahrouss <amlal@nekernel.org> | 2025-11-29 15:01:34 -0500 |
|---|---|---|
| committer | Amlal El Mahrouss <amlal@nekernel.org> | 2025-11-29 15:01:34 -0500 |
| commit | ceabd82ac8e796249feacf39c836034ed5e11c6d (patch) | |
| tree | e446d471a0eaf4ed7ac67e878ce4fb02334a2acb | |
| parent | 0376382a848ef5ebbb0e02428c9d1df8a099d8b4 (diff) | |
chore: source code review and fixes.
Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
122 files changed, 408 insertions, 446 deletions
diff --git a/docs/tex/binary_mutex.tex b/docs/tex/binary_mutex.tex index 583dffeb..66869fd2 100644 --- a/docs/tex/binary_mutex.tex +++ b/docs/tex/binary_mutex.tex @@ -44,10 +44,10 @@ class BinaryMutex final { public: bool IsLocked() const; - bool Unlock() noexcept; + bool Unlock() ; public: - BOOL WaitForProcess(const UInt32& sec) noexcept; + BOOL WaitForProcess(const UInt32& sec) ; public: bool Lock(USER_PROCESS* process); diff --git a/docs/tex/core_process_scheduler.tex b/docs/tex/core_process_scheduler.tex index 4be38308..1722040e 100644 --- a/docs/tex/core_process_scheduler.tex +++ b/docs/tex/core_process_scheduler.tex @@ -55,7 +55,7 @@ class UserProcessTeam final { Array<USER_PROCESS, kSchedProcessLimitPerTeam>& AsArray(); Ref<USER_PROCESS>& AsRef(); - ProcessID& Id() noexcept; + ProcessID& Id() ; public: USER_PROCESS_ARRAY mProcessList; diff --git a/public/frameworks/CoreFoundation.fwrk/headers/Foundation.h b/public/frameworks/CoreFoundation.fwrk/headers/Foundation.h index 68b00264..a8a31559 100644 --- a/public/frameworks/CoreFoundation.fwrk/headers/Foundation.h +++ b/public/frameworks/CoreFoundation.fwrk/headers/Foundation.h @@ -69,8 +69,8 @@ struct CFRect final { operator bool(); - BOOL SizeMatches(CFRect& rect) noexcept; - BOOL PositionMatches(CFRect& rect) noexcept; + BOOL SizeMatches(CFRect& rect); + BOOL PositionMatches(CFRect& rect); }; union CFGUID final { diff --git a/public/frameworks/CoreFoundation.fwrk/headers/Property.h b/public/frameworks/CoreFoundation.fwrk/headers/Property.h index b8784f68..d16f7742 100644 --- a/public/frameworks/CoreFoundation.fwrk/headers/Property.h +++ b/public/frameworks/CoreFoundation.fwrk/headers/Property.h @@ -42,12 +42,11 @@ class CFProperty final CF_OBJECT { CFString& GetKey(); private: - CFString* fName{nullptr}; - CFPropertyId fValue{0UL}; - CFRef<CFGUID> fGUID{}; + CFString* fName{nullptr}; + CFPropertyId fValue{0UL}; + CFRef<CFGUID> fGUID{}; }; template <SizeT N> using CFPropertyArray = CFArray<CFProperty, N>; } // namespace CF - diff --git a/public/frameworks/CoreFoundation.fwrk/headers/Ref.h b/public/frameworks/CoreFoundation.fwrk/headers/Ref.h index 6757daac..0bc728ce 100644 --- a/public/frameworks/CoreFoundation.fwrk/headers/Ref.h +++ b/public/frameworks/CoreFoundation.fwrk/headers/Ref.h @@ -44,16 +44,16 @@ class CFRef final CF_OBJECT { return *fClass; } - T& Leak() noexcept { return *fClass; } + T& Leak() { return *fClass; } - T& TryLeak() const noexcept { + T& TryLeak() const { MUST_PASS(*fClass); return *fClass; } T operator*() { return *fClass; } - operator bool() noexcept { return fClass; } + operator bool() { return fClass; } private: T* fClass{nullptr}; @@ -83,4 +83,3 @@ class CFNonNullRef final { CFRef<T> fRef{nullptr}; }; } // namespace CF - diff --git a/public/frameworks/CoreFoundation.fwrk/headers/String.h b/public/frameworks/CoreFoundation.fwrk/headers/String.h index 247d3894..2a44d1cb 100644 --- a/public/frameworks/CoreFoundation.fwrk/headers/String.h +++ b/public/frameworks/CoreFoundation.fwrk/headers/String.h @@ -19,7 +19,7 @@ class CFStringBuilder; class CFString final CF_OBJECT { public: CFString() = delete; - + explicit CFString(const SizeT sz); explicit CFString(const Char* str); @@ -40,7 +40,7 @@ class CFStringBuilder final { public: static CFRef<CFString> Construct(const Char*); static const Char* FromBool(const Char*, BOOL); - static const Char* Format(const Char*, const Char*); + static const Char* Format(const Char*, const Char*); static BOOL Equals(const Char, const Char*); static BOOL Equals(const Char*, const Char*); diff --git a/public/frameworks/CoreFoundation.fwrk/src/Foundation.cc b/public/frameworks/CoreFoundation.fwrk/src/Foundation.cc index e5de94a7..d50dbd7b 100644 --- a/public/frameworks/CoreFoundation.fwrk/src/Foundation.cc +++ b/public/frameworks/CoreFoundation.fwrk/src/Foundation.cc @@ -16,14 +16,14 @@ CF::CFRect::operator bool() { /***********************************************************************************/ /// @brief returns true if size matches. /***********************************************************************************/ -BOOL CF::CFRect::SizeMatches(CF::CFRect& rect) noexcept { +BOOL CF::CFRect::SizeMatches(CF::CFRect& rect) { return rect.height == height && rect.width == width; } /***********************************************************************************/ /// @brief returns true if position matches. /***********************************************************************************/ -BOOL CF::CFRect::PositionMatches(CF::CFRect& rect) noexcept { +BOOL CF::CFRect::PositionMatches(CF::CFRect& rect) { return rect.y == y && rect.x == x; } diff --git a/public/frameworks/DiskImage.fwrk/headers/DiskImage.h b/public/frameworks/DiskImage.fwrk/headers/DiskImage.h index 01cfc04a..9028592d 100644 --- a/public/frameworks/DiskImage.fwrk/headers/DiskImage.h +++ b/public/frameworks/DiskImage.fwrk/headers/DiskImage.h @@ -45,16 +45,16 @@ struct DI_DISK_IMAGE { /// @brief Format with an EPM partition. /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DIFormatPartitionEPM(struct DI_DISK_IMAGE& img) noexcept; +SInt32 DIFormatPartitionEPM(struct DI_DISK_IMAGE& img); /// @brief NeFS format over EPM. /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DIFormatFilesystemNeFS(struct DI_DISK_IMAGE& img) noexcept; +SInt32 DIFormatFilesystemNeFS(struct DI_DISK_IMAGE& img); /// @brief OpenHeFS format over EPM. /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DIFormatFilesystemHeFS(struct DI_DISK_IMAGE& img) noexcept; +SInt32 DIFormatFilesystemHeFS(struct DI_DISK_IMAGE& img); } // namespace DI diff --git a/public/frameworks/DiskImage.fwrk/src/DiskImage+EPM.cc b/public/frameworks/DiskImage.fwrk/src/DiskImage+EPM.cc index 28c0cd7d..ab533e20 100644 --- a/public/frameworks/DiskImage.fwrk/src/DiskImage+EPM.cc +++ b/public/frameworks/DiskImage.fwrk/src/DiskImage+EPM.cc @@ -15,7 +15,7 @@ /// @brief EPM format disk /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DI::DIFormatPartitionEPM(struct DI_DISK_IMAGE& img) noexcept { +SInt32 DI::DIFormatPartitionEPM(struct DI_DISK_IMAGE& img) { if (!img.sector_sz || (img.sector_sz % 512 != 0)) return kDIFailureStatus; if (!img.fs_version) return kDIFailureStatus; if (*img.out_name == 0 || *img.disk_name == 0) return kDIFailureStatus; diff --git a/public/frameworks/DiskImage.fwrk/src/DiskImage+HeFS.cc b/public/frameworks/DiskImage.fwrk/src/DiskImage+HeFS.cc index 297650dc..f57de649 100644 --- a/public/frameworks/DiskImage.fwrk/src/DiskImage+HeFS.cc +++ b/public/frameworks/DiskImage.fwrk/src/DiskImage+HeFS.cc @@ -15,7 +15,7 @@ /// @brief format OpenHeFS over an EPM disk. /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DI::DIFormatFilesystemHeFS(struct DI_DISK_IMAGE& img) noexcept { +SInt32 DI::DIFormatFilesystemHeFS(struct DI_DISK_IMAGE& img) { if (!img.sector_sz || (img.sector_sz % kDISectorSz != 0)) return kDIFailureStatus; if (*img.out_name == 0 || *img.disk_name == 0) return kDIFailureStatus; diff --git a/public/frameworks/DiskImage.fwrk/src/DiskImage+NeFS.cc b/public/frameworks/DiskImage.fwrk/src/DiskImage+NeFS.cc index 30c20cf7..562eb598 100644 --- a/public/frameworks/DiskImage.fwrk/src/DiskImage+NeFS.cc +++ b/public/frameworks/DiskImage.fwrk/src/DiskImage+NeFS.cc @@ -15,7 +15,7 @@ /// @brief format NeFS over an EPM disk. /// @param img disk image structure. /// @return Status code upon completion. -SInt32 DI::DIFormatFilesystemNeFS(struct DI_DISK_IMAGE& img) noexcept { +SInt32 DI::DIFormatFilesystemNeFS(struct DI_DISK_IMAGE& img) { if (!img.sector_sz || (img.sector_sz % kDISectorSz != 0)) return kDIFailureStatus; if (*img.out_name == 0 || *img.disk_name == 0) return kDIFailureStatus; diff --git a/public/frameworks/KernelTest.fwrk/headers/TestCase.h b/public/frameworks/KernelTest.fwrk/headers/TestCase.h index c040ca0f..26325d42 100644 --- a/public/frameworks/KernelTest.fwrk/headers/TestCase.h +++ b/public/frameworks/KernelTest.fwrk/headers/TestCase.h @@ -13,7 +13,10 @@ /// @file TestCase.h /// ================================================================================ -#define KT_RUN_TEST(OBJECT) {KTTestCase##OBJECT{}.Run();} +#define KT_RUN_TEST(OBJECT) \ + { \ + KTTestCase##OBJECT{}.Run(); \ + } #define KT_MUST_PASS(MSG, LEFT_COND, RIGHT_COND) \ if (LEFT_COND != RIGHT_COND) { \ diff --git a/public/frameworks/LaunchHelpers.fwrk/headers/Foundation.h b/public/frameworks/LaunchHelpers.fwrk/headers/Foundation.h index de4e6b09..36ce50ac 100644 --- a/public/frameworks/LaunchHelpers.fwrk/headers/Foundation.h +++ b/public/frameworks/LaunchHelpers.fwrk/headers/Foundation.h @@ -25,5 +25,5 @@ struct LHLaunchInfo final { /// @brief Get launch information. /// @return the launch information structure. -LHLaunchInfo* LHGetLaunchInfo(Void) noexcept; +LHLaunchInfo* LHGetLaunchInfo(Void); } // namespace LaunchHelpers
\ No newline at end of file diff --git a/public/tools/diutil/vendor/Dialogs.h b/public/tools/diutil/vendor/Dialogs.h index a59bada3..e5e6d83a 100644 --- a/public/tools/diutil/vendor/Dialogs.h +++ b/public/tools/diutil/vendor/Dialogs.h @@ -175,7 +175,7 @@ namespace internal { #elif __EMSCRIPTEN__ void start(int exit_code); #else - void start_process(std::vector<std::string> const& command); + void start_process(std::vector<std::string> const& command); #endif ~executor(); @@ -490,10 +490,10 @@ inline settings::settings(bool resync) { #if _WIN32 flags(flag::is_vista) = internal::is_vista(); #elif !__APPLE__ - flags(flag::has_zenity) = check_program("zenity"); + flags(flag::has_zenity) = check_program("zenity"); flags(flag::has_matedialog) = check_program("matedialog"); - flags(flag::has_qarma) = check_program("qarma"); - flags(flag::has_kdialog) = check_program("kdialog"); + flags(flag::has_qarma) = check_program("qarma"); + flags(flag::has_kdialog) = check_program("kdialog"); // If multiple helpers are available, try to default to the best one if (flags(flag::has_zenity) && flags(flag::has_kdialog)) { @@ -540,7 +540,7 @@ inline bool settings::check_program(std::string const& program) { (void) program; return false; #else - int exit_code = -1; + int exit_code = -1; internal::executor async; async.start_process({"/bin/sh", "-c", "which " + program}); async.result(&exit_code); @@ -604,7 +604,7 @@ inline std::string path::home() { if (size_max != -1) len = size_t(size_max); #endif std::vector<char> buf(len); - struct passwd pwd, *result; + struct passwd pwd, *result; if (getpwuid_r(getuid(), &pwd, buf.data(), buf.size(), &result) == 0) return result->pw_dir; #endif return "/"; @@ -717,7 +717,7 @@ inline void internal::executor::start_process(std::vector<std::string> const& co } close(in[1]); - m_fd = out[0]; + m_fd = out[0]; auto flags = fcntl(m_fd, F_GETFL); fcntl(m_fd, F_SETFL, flags | O_NONBLOCK); @@ -753,7 +753,7 @@ inline bool internal::executor::ready(int timeout /* = default_wait_timeout */) // FIXME: do something (void) timeout; #else - char buf[BUFSIZ]; + char buf[BUFSIZ]; ssize_t received = read(m_fd, buf, BUFSIZ); // Flawfinder: ignore if (received > 0) { m_stdout += std::string(buf, received); @@ -764,7 +764,7 @@ inline bool internal::executor::ready(int timeout /* = default_wait_timeout */) // (this happens when the calling application handles or ignores SIG_CHLD) and results in // waitpid() failing with ECHILD. Otherwise we assume the child is running and we sleep for // a little while. - int status; + int status; pid_t child = waitpid(m_pid, &status, WNOHANG); if (child != m_pid && (child >= 0 || errno != ECHILD)) { // FIXME: this happens almost always at first iteration @@ -782,8 +782,7 @@ inline bool internal::executor::ready(int timeout /* = default_wait_timeout */) inline void internal::executor::stop() { // Loop until the user closes the dialog - while (!ready()) - ; + while (!ready()); } // dll implementation @@ -879,11 +878,11 @@ inline std::vector<std::string> internal::dialog::desktop_helper() const { #if __APPLE__ return {"osascript"}; #else - return {flags(flag::has_zenity) ? "zenity" + return {flags(flag::has_zenity) ? "zenity" : flags(flag::has_matedialog) ? "matedialog" - : flags(flag::has_qarma) ? "qarma" - : flags(flag::has_kdialog) ? "kdialog" - : "echo"}; + : flags(flag::has_qarma) ? "qarma" + : flags(flag::has_kdialog) ? "kdialog" + : "echo"}; #endif } @@ -1125,9 +1124,9 @@ inline internal::file_dialog::file_dialog(type in_type, std::string const& title // Split the pattern list to check whether "*" is in there; if it // is, we have to disable filters because there is no mechanism in // OS X for the user to override the filter. - std::regex sep("\\s+"); - std::string filter_list; - bool has_filter = true; + std::regex sep("\\s+"); + std::string filter_list; + bool has_filter = true; std::sregex_token_iterator iter(patterns.begin(), patterns.end(), sep, -1); std::sregex_token_iterator end; for (; iter != end; ++iter) { @@ -1236,7 +1235,7 @@ inline std::vector<std::string> internal::file_dialog::vector_result() { return m_vector_result; #else std::vector<std::string> ret; - auto result = m_async->result(); + auto result = m_async->result(); for (;;) { // Split result along newline characters auto i = result.find('\n'); @@ -1569,7 +1568,7 @@ inline message::message(std::string const& title, std::string const& text, if_cancel = button::ok; break; } - m_mappings[1] = if_cancel; + m_mappings[1] = if_cancel; m_mappings[256] = if_cancel; // XXX: I think this was never correct script += " with icon "; switch (_icon) { @@ -1656,7 +1655,7 @@ inline message::message(std::string const& title, std::string const& text, if (_choice == choice::yes_no_cancel) flag += "cancel"; command.push_back(flag); if (_choice == choice::yes_no || _choice == choice::yes_no_cancel) { - m_mappings[0] = button::yes; + m_mappings[0] = button::yes; m_mappings[256] = button::no; } } diff --git a/src/boot/BootKit/BootKit.h b/src/boot/BootKit/BootKit.h index e1a2b628..55392ef6 100644 --- a/src/boot/BootKit/BootKit.h +++ b/src/boot/BootKit/BootKit.h @@ -40,7 +40,7 @@ /***********************************************************************************/ namespace Boot { -void ThrowError(const WideChar* errorCode, const WideChar* reason) noexcept; +void ThrowError(const WideChar* errorCode, const WideChar* reason); class BootTextWriter; class BootFileReader; @@ -205,7 +205,7 @@ class BDiskFormatFactory final { Boolean Format(const Char* part_name); /// @brief check if partition is good. - Bool IsPartitionValid() noexcept { + Bool IsPartitionValid() { #if defined(BOOTZ_EPM_SUPPORT) fDiskDev.Leak().mBase = (kEPMBootBlockLba); fDiskDev.Leak().mSize = sizeof(EPM_PART_BLOCK); @@ -293,16 +293,16 @@ inline Boolean BDiskFormatFactory<BootDev>::Format(const Char* part_name) { CopyMem(gpt_part->Signature, reinterpret_cast<VoidPtr>(const_cast<Char*>(kMagicGPT)), StrLen(kMagicGPT)); - gpt_part->Revision = 0x00010000; + gpt_part->Revision = 0x00010000; gpt_part->HeaderSize = sizeof(GPT_PARTITION_TABLE); gpt_part->CRC32 = 0x00000000; - gpt_part->Reserved1 = 0x00000000; - gpt_part->LBAHeader = 0x00000000; - gpt_part->LBAAltHeader = 0x00000000; + gpt_part->Reserved1 = 0x00000000; + gpt_part->LBAHeader = 0x00000000; + gpt_part->LBAAltHeader = 0x00000000; gpt_part->FirstGPTEntry = 0x00000000; - gpt_part->LastGPTEntry = 0x00000000; + gpt_part->LastGPTEntry = 0x00000000; gpt_part->Guid.Data1 = 0x00000000; gpt_part->Guid.Data2 = 0x0000; @@ -312,10 +312,10 @@ inline Boolean BDiskFormatFactory<BootDev>::Format(const Char* part_name) { gpt_part->Revision = 0x00010000; - gpt_part->StartingLBA = 0x00000000; + gpt_part->StartingLBA = 0x00000000; gpt_part->NumPartitionEntries = 0x00000000; - gpt_part->SizeOfEntries = 0x00000000; - gpt_part->CRC32PartEntry = 0x00000000; + gpt_part->SizeOfEntries = 0x00000000; + gpt_part->CRC32PartEntry = 0x00000000; SetMem(gpt_part->Reserved2, 0, kSectorAlignGPT_PartTbl); diff --git a/src/boot/BootKit/HW/ATA.h b/src/boot/BootKit/HW/ATA.h index 25629869..7ebf296d 100644 --- a/src/boot/BootKit/HW/ATA.h +++ b/src/boot/BootKit/HW/ATA.h @@ -18,7 +18,7 @@ class BootDeviceATA final : public Device { kSecondary = ATA_SECONDARY_IO, }; - explicit BootDeviceATA() noexcept; + explicit BootDeviceATA(); ~BootDeviceATA() = default; enum { kSectorSize = kATASectorSize }; @@ -34,8 +34,8 @@ class BootDeviceATA final : public Device { public: operator bool(); - SizeT GetSectorsCount() noexcept; - SizeT GetDiskSize() noexcept; + SizeT GetSectorsCount(); + SizeT GetDiskSize(); BootDeviceATA& Read(Char* Buf, SizeT SecCount) override; BootDeviceATA& Write(Char* Buf, SizeT SecCount) override; diff --git a/src/boot/BootKit/HW/SATA.h b/src/boot/BootKit/HW/SATA.h index 07ce7611..68ed30c8 100644 --- a/src/boot/BootKit/HW/SATA.h +++ b/src/boot/BootKit/HW/SATA.h @@ -14,7 +14,7 @@ class BootDeviceSATA final { public: - explicit BootDeviceSATA() noexcept; + explicit BootDeviceSATA(); ~BootDeviceSATA() = default; NE_COPY_DEFAULT(BootDeviceSATA) diff --git a/src/boot/BootKit/Qr.h b/src/boot/BootKit/Qr.h index f537aa5e..f5ac5f2e 100644 --- a/src/boot/BootKit/Qr.h +++ b/src/boot/BootKit/Qr.h @@ -235,7 +235,7 @@ template <int V> struct Qr { private: friend class QrDelegate; - bool draw(int x, int y) noexcept; + bool draw(int x, int y); public: constexpr auto side_size() const { return SIDE; } @@ -303,7 +303,7 @@ bool Qr<V>::module(int x, int y) { /// @brief draw a new QR code. template <int V> -bool Qr<V>::draw(int whereX, int whereY) noexcept { +bool Qr<V>::draw(int whereX, int whereY) { if (!this->status) return false; // it may be invalid. cg_init(); @@ -784,7 +784,7 @@ class QrDelegate final { /// @brief Draw method delegate. template <Int32 V> - bool draw(Qr<V>& subject, Int32 x, Int32 y) noexcept { + bool draw(Qr<V>& subject, Int32 x, Int32 y) { return subject.draw(x, y); } }; diff --git a/src/boot/modules/BootNet/BootNet.cc b/src/boot/modules/BootNet/BootNet.cc index 20d1a6c9..21981ad3 100644 --- a/src/boot/modules/BootNet/BootNet.cc +++ b/src/boot/modules/BootNet/BootNet.cc @@ -12,8 +12,8 @@ #include <FirmwareKit/EFI/API.h> #include <modules/BootNet/BootNet.h> -STATIC EFI_GUID kEfiSimpleProtoGUID = EFI_SIMPLE_NETWORK_PROTOCOL_GUID; -STATIC EFI_SIMPLE_NETWORK_PROTOCOL* kEfiProtocol = nullptr; +STATIC EFI_GUID kEfiSimpleProtoGUID = EFI_SIMPLE_NETWORK_PROTOCOL_GUID; +STATIC EFI_SIMPLE_NETWORK_PROTOCOL* kEfiProtocol = nullptr; STATIC Void bootnet_read_ip_packet(BOOTNET_INTERNET_HEADER inet, BOOTNET_INTERNET_HEADER** inet_out); diff --git a/src/boot/src/BootThread.cc b/src/boot/src/BootThread.cc index 55aebd49..336c5f9e 100644 --- a/src/boot/src/BootThread.cc +++ b/src/boot/src/BootThread.cc @@ -82,8 +82,8 @@ BootThread::BootThread(VoidPtr blob) : fStartAddress(nullptr), fBlob(blob) { LDR_SECTION_HEADER_PTR sectPtr = (LDR_SECTION_HEADER_PTR) (((Char*) opt_header_ptr) + header_ptr->SizeOfOptionalHeader); - constexpr auto sectionForCode = ".text"; - constexpr auto sectionForBootZ = ".ldr"; + constexpr auto sectionForCode = ".text"; + constexpr auto sectionForBootZ = ".ldr"; constexpr auto sectionForBootZAlt = ".botz"; for (SizeT sectIndex = 0; sectIndex < numSecs; ++sectIndex) { @@ -113,7 +113,7 @@ BootThread::BootThread(VoidPtr blob) : fStartAddress(nullptr), fBlob(blob) { #endif } else if (StrCmp(sectionForBootZ, sect->Name) == 0 || - StrCmp(sectionForBootZAlt, sect->Name) == 0) { + StrCmp(sectionForBootZAlt, sect->Name) == 0) { struct HANDOVER_INFORMATION_STUB { UInt64 HandoverMagic; UInt32 HandoverType; diff --git a/src/boot/src/HEL/AMD64/BootATA.cc b/src/boot/src/HEL/AMD64/BootATA.cc index 02051471..0276ca4c 100644 --- a/src/boot/src/HEL/AMD64/BootATA.cc +++ b/src/boot/src/HEL/AMD64/BootATA.cc @@ -88,8 +88,7 @@ ATAInit_Retry: /// fetch serial info /// model, speed, number of sectors... - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); for (SizeT indexData = 0ul; indexData < kATADataLen; ++indexData) { kATAData[indexData] = rt_in16(IO + ATA_REG_DATA); @@ -115,15 +114,14 @@ Void boot_ata_read(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeASCII* Buf, rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + SectorSz) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); rt_out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO); - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); for (SizeT IndexOff = 0; IndexOff < Size; IndexOff += 2) { boot_ata_wait_io(IO); @@ -149,15 +147,14 @@ Void boot_ata_write(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeASCII* Buf rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + (SectorSz)) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); rt_out8(IO + ATA_REG_COMMAND, ATA_CMD_WRITE_PIO); - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); for (SizeT IndexOff = 0; IndexOff < Size; IndexOff += 2) { boot_ata_wait_io(IO); @@ -191,7 +188,7 @@ Boolean boot_ata_detected(Void) { * @brief ATA Device constructor. * @param void none. */ -BootDeviceATA::BootDeviceATA() noexcept { +BootDeviceATA::BootDeviceATA() { if (boot_ata_init(ATA_PRIMARY_IO, true, this->Leak().mBus, this->Leak().mMaster) || boot_ata_init(ATA_SECONDARY_IO, true, this->Leak().mBus, this->Leak().mMaster)) { kATADetected = true; @@ -260,10 +257,10 @@ BootDeviceATA::ATATrait& BootDeviceATA::Leak() { /*** @brief Getter, gets the number of sectors inside the drive. */ -SizeT BootDeviceATA::GetSectorsCount() noexcept { +SizeT BootDeviceATA::GetSectorsCount() { return (kATAData[61] << 16) | kATAData[60]; } -SizeT BootDeviceATA::GetDiskSize() noexcept { +SizeT BootDeviceATA::GetDiskSize() { return this->GetSectorsCount() * BootDeviceATA::kSectorSize; } diff --git a/src/boot/src/HEL/AMD64/BootEFI.cc b/src/boot/src/HEL/AMD64/BootEFI.cc index 331ded5f..7558ec62 100644 --- a/src/boot/src/HEL/AMD64/BootEFI.cc +++ b/src/boot/src/HEL/AMD64/BootEFI.cc @@ -32,7 +32,7 @@ EXTERN_C Kernel::VoidPtr boot_read_cr3(); // @brief Page directory inside cr3 r /** @brief Finds and stores the GOP object. */ -STATIC Bool boot_init_fb() noexcept { +STATIC Bool boot_init_fb() { kGopGuid = EFI_GUID(EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID); kGop = nullptr; diff --git a/src/boot/src/HEL/AMD64/BootSATA.cc b/src/boot/src/HEL/AMD64/BootSATA.cc index 1364c58b..b184e02e 100644 --- a/src/boot/src/HEL/AMD64/BootSATA.cc +++ b/src/boot/src/HEL/AMD64/BootSATA.cc @@ -38,7 +38,7 @@ using namespace Boot; * @brief ATA Device constructor. * @param void none. */ -BootDeviceSATA::BootDeviceSATA() noexcept { +BootDeviceSATA::BootDeviceSATA() { UInt16 pi = 0u; drv_std_init(pi); } diff --git a/src/boot/src/HEL/ARM64/BootEFI.cc b/src/boot/src/HEL/ARM64/BootEFI.cc index ac5eb030..7f4b152c 100644 --- a/src/boot/src/HEL/ARM64/BootEFI.cc +++ b/src/boot/src/HEL/ARM64/BootEFI.cc @@ -38,7 +38,7 @@ EXTERN EfiBootServices* BS; /** @brief Finds and stores the GOP object. */ -STATIC Bool boot_init_fb() noexcept { +STATIC Bool boot_init_fb() { kGopGuid = EFI_GUID(EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID); kGop = nullptr; diff --git a/src/boot/src/HEL/ARM64/BootPlatform.cc b/src/boot/src/HEL/ARM64/BootPlatform.cc index 2ad9b776..9da3a2a6 100644 --- a/src/boot/src/HEL/ARM64/BootPlatform.cc +++ b/src/boot/src/HEL/ARM64/BootPlatform.cc @@ -13,8 +13,7 @@ using namespace Boot; EXTERN_C void rt_halt() { - while (Yes) - ; + while (Yes); } EXTERN_C void rt_cli() {} diff --git a/src/boot/src/New+Delete.cc b/src/boot/src/New+Delete.cc index a66d8464..dcbd31de 100644 --- a/src/boot/src/New+Delete.cc +++ b/src/boot/src/New+Delete.cc @@ -17,8 +17,7 @@ void* operator new(size_t sz) { void* buf = nullptr; - while (BS->AllocatePool(EfiMemoryType::EfiLoaderData, sz, &buf) != kEfiOk) - ; + while (BS->AllocatePool(EfiMemoryType::EfiLoaderData, sz, &buf) != kEfiOk); return buf; } @@ -35,7 +34,7 @@ void* operator new[](size_t sz) { /// @brief Deletes the object. /// @param buf the object. -void operator delete(void* buf) noexcept { +void operator delete(void* buf) { if (!buf) return; BS->FreePool(buf); @@ -43,7 +42,7 @@ void operator delete(void* buf) noexcept { /// @brief Deletes the object. /// @param buf the object. -void operator delete[](void* buf) noexcept { +void operator delete[](void* buf) { if (!buf) return; BS->FreePool(buf); diff --git a/src/kernel/ArchKit/ArchKit.h b/src/kernel/ArchKit/ArchKit.h index 626f1e0b..63f8f406 100644 --- a/src/kernel/ArchKit/ArchKit.h +++ b/src/kernel/ArchKit/ArchKit.h @@ -45,7 +45,7 @@ inline SizeT rt_hash_seed(const Char* seed, UInt32 mul) { /// @param reg the register. /// @param value the write to write on it. template <typename DataKind> -inline Void ke_dma_write(UIntPtr base, DataKind reg, DataKind value) noexcept { +inline Void ke_dma_write(UIntPtr base, DataKind reg, DataKind value) { *(volatile DataKind*) (base + reg) = value; } @@ -54,7 +54,7 @@ inline Void ke_dma_write(UIntPtr base, DataKind reg, DataKind value) noexcept { /// @param reg the register. /// @return the value inside the register. template <typename DataKind> -inline UInt32 ke_dma_read(UIntPtr base, DataKind reg) noexcept { +inline UInt32 ke_dma_read(UIntPtr base, DataKind reg) { return *(volatile DataKind*) (base + reg); } diff --git a/src/kernel/CFKit/GUIDWrapper.h b/src/kernel/CFKit/GUIDWrapper.h index 2bf7b64e..f58c489a 100644 --- a/src/kernel/CFKit/GUIDWrapper.h +++ b/src/kernel/CFKit/GUIDWrapper.h @@ -39,8 +39,8 @@ class GUID final { NE_COPY_DEFAULT(GUID) public: - GUIDSequence& operator->() noexcept { return fUUID; } - GUIDSequence& Leak() noexcept { return fUUID; } + GUIDSequence& operator->() { return fUUID; } + GUIDSequence& Leak() { return fUUID; } private: GUIDSequence fUUID; diff --git a/src/kernel/FSKit/Ext2+IFS.h b/src/kernel/FSKit/Ext2+IFS.h index 01ca4c90..a010f8b1 100644 --- a/src/kernel/FSKit/Ext2+IFS.h +++ b/src/kernel/FSKit/Ext2+IFS.h @@ -32,15 +32,15 @@ class Ext2Context final { } } - Ext2Context(const Ext2Context&) = delete; + Ext2Context(const Ext2Context&) = delete; Ext2Context& operator=(const Ext2Context&) = delete; - Ext2Context(Ext2Context&& other) noexcept : drive(other.drive), superblock(other.superblock) { + Ext2Context(Ext2Context&& other) : drive(other.drive), superblock(other.superblock) { other.drive = nullptr; other.superblock = nullptr; } - Ext2Context& operator=(Ext2Context&& other) noexcept { + Ext2Context& operator=(Ext2Context&& other) { if (this != &other) { if (superblock) { Kernel::mm_free_ptr(superblock); diff --git a/src/kernel/FSKit/IndexableProperty.h b/src/kernel/FSKit/IndexableProperty.h index a89e78b8..9eb64f81 100644 --- a/src/kernel/FSKit/IndexableProperty.h +++ b/src/kernel/FSKit/IndexableProperty.h @@ -36,7 +36,7 @@ namespace Indexer { NE_COPY_DEFAULT(IndexableProperty) public: - Index& Leak() noexcept; + Index& Leak(); public: Void AddFlag(UInt16 flag); diff --git a/src/kernel/FSKit/NeFS.h b/src/kernel/FSKit/NeFS.h index 54861dec..c91d858d 100644 --- a/src/kernel/FSKit/NeFS.h +++ b/src/kernel/FSKit/NeFS.h @@ -408,6 +408,6 @@ class NeFileSystemJournal final { }; namespace NeFS { - Boolean fs_init_nefs(Void) noexcept; + Boolean fs_init_nefs(Void); } // namespace NeFS } // namespace Kernel diff --git a/src/kernel/FSKit/OpenHeFS.h b/src/kernel/FSKit/OpenHeFS.h index bd392fc3..1adfd873 100644 --- a/src/kernel/FSKit/OpenHeFS.h +++ b/src/kernel/FSKit/OpenHeFS.h @@ -115,11 +115,11 @@ typedef UInt64 ATime; struct PACKED HEFS_BOOT_NODE final {
Char fMagic[kOpenHeFSMagicLen]; /// @brief Magic number of the filesystem.
Utf8Char fVolName[kOpenHeFSPartNameLen]; /// @brief Volume name.
- UInt32 fVersion; /// @brief Version of the filesystem.
- UInt64 fBadSectors; /// @brief Number of bad sectors in the filesystem.
- UInt64 fSectorCount; /// @brief Number of sectors in the filesystem.
- UInt64 fSectorSize; /// @brief Size of the sector.
- UInt32 fChecksum; /// @brief Checksum of the boot node.
+ UInt32 fVersion; /// @brief Version of the filesystem.
+ UInt64 fBadSectors; /// @brief Number of bad sectors in the filesystem.
+ UInt64 fSectorCount; /// @brief Number of sectors in the filesystem.
+ UInt64 fSectorSize; /// @brief Size of the sector.
+ UInt32 fChecksum; /// @brief Checksum of the boot node.
UInt8 fDiskKind; /// @brief Kind of the drive. (Hard Drive, Solid State Drive, Optical
/// Drive, etc).
UInt8 fEncoding; /// @brief Encoding of the filesystem. (UTF-8, UTF-16, etc).
@@ -234,7 +234,7 @@ namespace Kernel::Detail { /// @param raw_atime the raw ATime value.
/// @return the year value.
/// @note The year is stored in the upper 32 bits of the ATime value.
-inline UInt32 hefs_year_get(ATime raw_atime) noexcept {
+inline UInt32 hefs_year_get(ATime raw_atime) {
return (raw_atime) >> 32;
}
@@ -242,7 +242,7 @@ inline UInt32 hefs_year_get(ATime raw_atime) noexcept { /// @param raw_atime the raw ATime value.
/// @return the month value.
/// @note The month is stored in the upper 24 bits of the ATime value.
-inline UInt32 hefs_month_get(ATime raw_atime) noexcept {
+inline UInt32 hefs_month_get(ATime raw_atime) {
return (raw_atime) >> 24;
}
@@ -250,7 +250,7 @@ inline UInt32 hefs_month_get(ATime raw_atime) noexcept { /// @param raw_atime the raw ATime value.
/// @return the day value.
/// @note The day is stored in the upper 16 bits of the ATime value.
-inline UInt32 hefs_day_get(ATime raw_atime) noexcept {
+inline UInt32 hefs_day_get(ATime raw_atime) {
return (raw_atime) >> 16;
}
@@ -258,7 +258,7 @@ inline UInt32 hefs_day_get(ATime raw_atime) noexcept { /// @param raw_atime the raw ATime value.
/// @return the hour value.
/// @note The hour is stored in the upper 8 bits of the ATime value.
-inline UInt32 hefs_hour_get(ATime raw_atime) noexcept {
+inline UInt32 hefs_hour_get(ATime raw_atime) {
return (raw_atime) >> 8;
}
@@ -266,8 +266,8 @@ inline UInt32 hefs_hour_get(ATime raw_atime) noexcept { /// @param raw_atime the raw ATime value.
/// @return the minute value.
/// @note The minute is stored in the lower 8 bits of the ATime value.
-inline UInt32 hefs_minute_get(ATime raw_atime) noexcept {
- return (raw_atime) &0xFF;
+inline UInt32 hefs_minute_get(ATime raw_atime) {
+ return (raw_atime) & 0xFF;
}
inline constexpr UInt32 kOpenHeFSBaseYear = 1970;
@@ -276,7 +276,7 @@ inline constexpr UInt32 kOpenHeFSBaseDay = 1; inline constexpr UInt32 kOpenHeFSBaseHour = 0;
inline constexpr UInt32 kOpenHeFSBaseMinute = 0;
-inline const Char* hefs_status_to_string(UInt16 status) noexcept {
+inline const Char* hefs_status_to_string(UInt16 status) {
switch (status) {
case kOpenHeFSStatusUnlocked:
return "Unlocked";
@@ -291,7 +291,7 @@ inline const Char* hefs_status_to_string(UInt16 status) noexcept { }
}
-inline const Char* hefs_drive_kind_to_string(UInt8 kind) noexcept {
+inline const Char* hefs_drive_kind_to_string(UInt8 kind) {
switch (kind) {
case kOpenHeFSHardDrive:
return "Hard Drive";
@@ -311,7 +311,7 @@ inline const Char* hefs_drive_kind_to_string(UInt8 kind) noexcept { }
}
-inline const Char* hefs_encoding_to_string(UInt8 encoding) noexcept {
+inline const Char* hefs_encoding_to_string(UInt8 encoding) {
switch (encoding) {
case kOpenHeFSEncodingFlagsUTF8:
return "UTF-8";
@@ -336,7 +336,7 @@ inline const Char* hefs_encoding_to_string(UInt8 encoding) noexcept { }
}
-inline const Char* hefs_file_kind_to_string(UInt16 kind) noexcept {
+inline const Char* hefs_file_kind_to_string(UInt16 kind) {
switch (kind) {
case kOpenHeFSFileKindRegular:
return "Regular File";
@@ -358,7 +358,7 @@ inline const Char* hefs_file_kind_to_string(UInt16 kind) noexcept { }
}
-inline const Char* hefs_file_flags_to_string(UInt32 flags) noexcept {
+inline const Char* hefs_file_flags_to_string(UInt32 flags) {
switch (flags) {
case kOpenHeFSFlagsNone:
return "No Flags";
@@ -387,10 +387,10 @@ class HeFileSystemParser final { ~HeFileSystemParser() = default;
public:
- HeFileSystemParser(const HeFileSystemParser&) = delete;
+ HeFileSystemParser(const HeFileSystemParser&) = delete;
HeFileSystemParser& operator=(const HeFileSystemParser&) = delete;
- HeFileSystemParser(HeFileSystemParser&&) = delete;
+ HeFileSystemParser(HeFileSystemParser&&) = delete;
HeFileSystemParser& operator=(HeFileSystemParser&&) = delete;
public:
@@ -429,6 +429,6 @@ namespace OpenHeFS { /// @brief Initialize OpenHeFS inside the main disk.
/// @return Whether it successfuly formated it or not.
- Boolean fs_init_openhefs(Void) noexcept;
+ Boolean fs_init_openhefs(Void);
} // namespace OpenHeFS
} // namespace Kernel
diff --git a/src/kernel/FirmwareKit/EFI/API.h b/src/kernel/FirmwareKit/EFI/API.h index 24fceb2b..1d087367 100644 --- a/src/kernel/FirmwareKit/EFI/API.h +++ b/src/kernel/FirmwareKit/EFI/API.h @@ -31,7 +31,7 @@ EXTERN_C void rt_halt(); namespace Boot { /// @brief Halt and clear interrut flag on x86. /// @return -inline Void Stop() noexcept { +inline Void Stop() { while (YES) { rt_cli(); rt_halt(); @@ -42,13 +42,13 @@ inline Void Stop() noexcept { @brief Exit EFI API to let the OS load correctly. Bascially frees everything we have in the EFI side. */ -inline Void ExitBootServices(UInt64 MapKey, EfiHandlePtr ImageHandle) noexcept { +inline Void ExitBootServices(UInt64 MapKey, EfiHandlePtr ImageHandle) { if (!ST) return; ST->BootServices->ExitBootServices(ImageHandle, MapKey); } -inline UInt32 Platform() noexcept { +inline UInt32 Platform() { return kPeMachineAMD64; } @@ -57,7 +57,7 @@ inline UInt32 Platform() noexcept { * @param ErrorCode error code to be print. * @param Reason reason to be print. */ -inline void ThrowError(const EfiCharType* ErrorCode, const EfiCharType* Reason) noexcept { +inline void ThrowError(const EfiCharType* ErrorCode, const EfiCharType* Reason) { ST->ConOut->OutputString(ST->ConOut, L"\r*** STOP ***\r"); ST->ConOut->OutputString(ST->ConOut, L"*** ERROR: "); @@ -72,7 +72,7 @@ inline void ThrowError(const EfiCharType* ErrorCode, const EfiCharType* Reason) } } // namespace Boot -inline void fw_init_efi(EfiSystemTable* SystemTable) noexcept { +inline void fw_init_efi(EfiSystemTable* SystemTable) { if (!SystemTable) return; ST = SystemTable; diff --git a/src/kernel/FirmwareKit/EFI/EFI.h b/src/kernel/FirmwareKit/EFI/EFI.h index 240fb9ea..966e3780 100644 --- a/src/kernel/FirmwareKit/EFI/EFI.h +++ b/src/kernel/FirmwareKit/EFI/EFI.h @@ -57,7 +57,7 @@ typedef Char16 EfiChar16Type; /// @brief Core Handle Kind /// Self is like NT's Win32 HANDLE type. typedef struct EfiHandle { -} * EfiHandlePtr; +}* EfiHandlePtr; /* UEFI uses wide characters by default. */ typedef WideChar EfiCharType; @@ -239,64 +239,42 @@ typedef struct EfiTableHeader { UInt32 Reserved; } EfiTableHeader; -#define EFI_ACPI_TABLE_PROTOCOL_GUID \ - { \ - 0xffe06bdd, 0x6107, 0x46a6, { 0x7b, 0xb2, 0x5a, 0x9c, 0x7e, 0xc5, 0x27, 0x5c } \ - } +#define EFI_ACPI_TABLE_PROTOCOL_GUID \ + {0xffe06bdd, 0x6107, 0x46a6, {0x7b, 0xb2, 0x5a, 0x9c, 0x7e, 0xc5, 0x27, 0x5c}} -#define EFI_LOAD_FILE_PROTOCOL_GUID \ - { \ - 0x56EC3091, 0x954C, 0x11d2, { 0x8e, 0x3f, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_LOAD_FILE_PROTOCOL_GUID \ + {0x56EC3091, 0x954C, 0x11d2, {0x8e, 0x3f, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} -#define EFI_LOAD_FILE2_PROTOCOL_GUID \ - { \ - 0x4006c0c1, 0xfcb3, 0x403e, { 0x99, 0x6d, 0x4a, 0x6c, 0x87, 0x24, 0xe0, 0x6d } \ - } +#define EFI_LOAD_FILE2_PROTOCOL_GUID \ + {0x4006c0c1, 0xfcb3, 0x403e, {0x99, 0x6d, 0x4a, 0x6c, 0x87, 0x24, 0xe0, 0x6d}} -#define EFI_LOADED_IMAGE_PROTOCOL_GUID \ - { \ - 0x5B1B31A1, 0x9562, 0x11d2, { 0x8E, 0x3F, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B } \ - } +#define EFI_LOADED_IMAGE_PROTOCOL_GUID \ + {0x5B1B31A1, 0x9562, 0x11d2, {0x8E, 0x3F, 0x00, 0xA0, 0xC9, 0x69, 0x72, 0x3B}} -#define EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID \ - { \ - 0x9042a9de, 0x23dc, 0x4a38, { 0x96, 0xfb, 0x7a, 0xde, 0xd0, 0x80, 0x51, 0x6a } \ - } +#define EFI_GRAPHICS_OUTPUT_PROTOCOL_GUID \ + {0x9042a9de, 0x23dc, 0x4a38, {0x96, 0xfb, 0x7a, 0xde, 0xd0, 0x80, 0x51, 0x6a}} -#define EFI_SIMPLE_NETWORK_PROTOCOL_GUID \ - { \ - 0xA19832B9, 0xAC25, 0x11D3, { 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d } \ - } +#define EFI_SIMPLE_NETWORK_PROTOCOL_GUID \ + {0xA19832B9, 0xAC25, 0x11D3, {0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d}} #define EFI_SIMPLE_NETWORK_PROTOCOL_REVISION 0x00010000 -#define EFI_IP4_PROTOCOL_GUID \ - { \ - 0x41d94cd2, 0x35b6, 0x455a, { 0x82, 0x58, 0xd4, 0xe5, 0x13, 0x34, 0xaa, 0xdd } \ - } +#define EFI_IP4_PROTOCOL_GUID \ + {0x41d94cd2, 0x35b6, 0x455a, {0x82, 0x58, 0xd4, 0xe5, 0x13, 0x34, 0xaa, 0xdd}} #define EFI_LOADED_IMAGE_PROTOCOL_REVISION 0x1000 -#define EFI_SIMPLE_FILE_SYSTEM_PROTOCOL_GUID \ - { \ - 0x0964e5b22, 0x6459, 0x11d2, { 0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_SIMPLE_FILE_SYSTEM_PROTOCOL_GUID \ + {0x0964e5b22, 0x6459, 0x11d2, {0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} -#define EFI_LOADED_IMAGE_DEVICE_PATH_PROTOCOL_GUID \ - { \ - 0xbc62157e, 0x3e33, 0x4fec, { 0x99, 0x20, 0x2d, 0x3b, 0x36, 0xd7, 0x50, 0xdf } \ - } +#define EFI_LOADED_IMAGE_DEVICE_PATH_PROTOCOL_GUID \ + {0xbc62157e, 0x3e33, 0x4fec, {0x99, 0x20, 0x2d, 0x3b, 0x36, 0xd7, 0x50, 0xdf}} -#define EFI_DEVICE_PATH_PROTOCOL_GUID \ - { \ - 0x9576e91, 0x6d3f, 0x11d2, { 0x8e, 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_DEVICE_PATH_PROTOCOL_GUID \ + {0x9576e91, 0x6d3f, 0x11d2, {0x8e, 0x39, 0x0, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} -#define EFI_SIMPLE_FILE_SYSTEM_PROTOCOL_GUID \ - { \ - 0x0964e5b22, 0x6459, 0x11d2, { 0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_SIMPLE_FILE_SYSTEM_PROTOCOL_GUID \ + {0x0964e5b22, 0x6459, 0x11d2, {0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} typedef UInt64(EfiImageUnload)(EfiHandlePtr ImageHandle); @@ -351,17 +329,17 @@ typedef struct { typedef EFI_STATUS(EFIAPI* EFI_SIMPLE_NETWORK_TRANSMIT)(IN EFI_SIMPLE_NETWORK_PROTOCOL* This, IN UInt32 HeaderSize, IN UInt32 BufferSize, - IN Void* Buffer, - IN EfiMacAddress* SrcAddr OPTIONAL, + IN Void* Buffer, + IN EfiMacAddress* SrcAddr OPTIONAL, IN EfiMacAddress* DestAddr OPTIONAL, - IN UInt16* Protocol OPTIONAL); + IN UInt16* Protocol OPTIONAL); typedef EFI_STATUS(EFIAPI* EFI_SIMPLE_NETWORK_RECEIVE)(IN EFI_SIMPLE_NETWORK_PROTOCOL* This, - OUT UInt32* HeaderSize OPTIONAL, + OUT UInt32* HeaderSize OPTIONAL, IN OUT UInt32* BufferSize, OUT Void* Buffer, - OUT EfiMacAddress* SrcAddr OPTIONAL, + OUT EfiMacAddress* SrcAddr OPTIONAL, OUT EfiMacAddress* DestAddr OPTIONAL, - OUT UInt16* Protocol OPTIONAL); + OUT UInt16* Protocol OPTIONAL); typedef struct EFI_SIMPLE_NETWORK_PROTOCOL { UInt64 Revision; @@ -506,10 +484,8 @@ typedef struct EFI_GUID EFI_FINAL { * Protocol stuff... */ -#define EFI_SIMPLE_TEXT_INPUT_PROTOCOL_GUID \ - { \ - 0x387477c1, 0x69c7, 0x11d2, { 0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_SIMPLE_TEXT_INPUT_PROTOCOL_GUID \ + {0x387477c1, 0x69c7, 0x11d2, {0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} /** some helpers */ #define EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL 0x00000001 @@ -607,7 +583,7 @@ typedef struct { } EfiInputKey; typedef EfiStatusType(EFI_API* EfiInputReadKey)(IN EfiSimpleTextInputProtocol* This, - OUT EfiInputKey* Key); + OUT EfiInputKey* Key); typedef EfiStatusType(EFI_API* EfiInputReset)(IN EfiSimpleTextInputProtocol* This, IN Boolean ExtendedChk); @@ -665,7 +641,7 @@ typedef struct EfiSystemTable { struct { EFI_GUID VendorGUID; VoidPtr VendorTable; - } * ConfigurationTable; + }* ConfigurationTable; } EfiSystemTable; #define kEfiOk 0 @@ -726,10 +702,8 @@ enum { #define EFI_EXTRA_DESCRIPTOR_SIZE 8 -#define EFI_MP_SERVICES_PROTOCOL_GUID \ - { \ - 0x3fdda605, 0xa76e, 0x4f46, { 0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08 } \ - } +#define EFI_MP_SERVICES_PROTOCOL_GUID \ + {0x3fdda605, 0xa76e, 0x4f46, {0xad, 0x29, 0x12, 0xf4, 0x53, 0x1b, 0x3d, 0x08}} #define PROCESSOR_AS_BSP_BIT 0x00000001 #define PROCESSOR_ENABLED_BIT 0x00000002 @@ -825,10 +799,8 @@ typedef struct EfiTime { UInt8 Pad2; } EfiTime; -#define EFI_FILE_INFO_GUID \ - { \ - 0x09576e92, 0x6d3f, 0x11d2, { 0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b } \ - } +#define EFI_FILE_INFO_GUID \ + {0x09576e92, 0x6d3f, 0x11d2, {0x8e, 0x39, 0x00, 0xa0, 0xc9, 0x69, 0x72, 0x3b}} struct EfiFileInfo EFI_FINAL { /// @brief Structure size. @@ -896,8 +868,8 @@ typedef EfiStatusType EFI_API (*EfiMpServicesStartupThisAP)( IN Void* ProcedureArgument OPTIONAL, OUT Boolean* Finished OPTIONAL); typedef EfiStatusType EFI_API (*EfiMpServicesDisableThisAP)(IN struct _EfiMpServicesProtocol* Self, - IN UInt32 ProcessorNumber, - IN Boolean EnableAP, + IN UInt32 ProcessorNumber, + IN Boolean EnableAP, IN UInt32* HealthFlag OPTIONAL); typedef EfiStatusType EFI_API (*EfiMpServicesWhoAmI)(IN struct _EfiMpServicesProtocol* Self, diff --git a/src/kernel/HALKit/AMD64/HalAPICDmaWrapper.cc b/src/kernel/HALKit/AMD64/HalAPICDmaWrapper.cc index 36a027a2..79013b26 100644 --- a/src/kernel/HALKit/AMD64/HalAPICDmaWrapper.cc +++ b/src/kernel/HALKit/AMD64/HalAPICDmaWrapper.cc @@ -18,7 +18,7 @@ LAPICDmaWrapper::~LAPICDmaWrapper() = default; /// @brief Read from APIC controller. /// @param reg register. /***********************************************************************************/ -UInt32 LAPICDmaWrapper::Read(UInt16 reg) noexcept { +UInt32 LAPICDmaWrapper::Read(UInt16 reg) { MUST_PASS(this->fApic); UInt32 volatile* io_apic = (UInt32 volatile*) this->fApic; @@ -30,7 +30,7 @@ UInt32 LAPICDmaWrapper::Read(UInt16 reg) noexcept { /// @param reg register. /// @param value value. /***********************************************************************************/ -Void LAPICDmaWrapper::Write(UInt16 reg, UInt32 value) noexcept { +Void LAPICDmaWrapper::Write(UInt16 reg, UInt32 value) { MUST_PASS(this->fApic); UInt32 volatile* io_apic = (UInt32 volatile*) this->fApic; diff --git a/src/kernel/HALKit/AMD64/HalApplicationProcessor.cc b/src/kernel/HALKit/AMD64/HalApplicationProcessor.cc index 02d7f885..9b352dcc 100644 --- a/src/kernel/HALKit/AMD64/HalApplicationProcessor.cc +++ b/src/kernel/HALKit/AMD64/HalApplicationProcessor.cc @@ -134,7 +134,7 @@ EXTERN_C BOOL mp_register_task(HAL::StackFramePtr stack_frame, ThreadID thrdid) /// @return True if YES, False if not. /***********************************************************************************/ -Bool mp_is_smp(Void) noexcept { +Bool mp_is_smp(Void) { return kSMPAware; } @@ -143,7 +143,7 @@ Bool mp_is_smp(Void) noexcept { /// @param vendor_ptr SMP containing structure. /***********************************************************************************/ -Void mp_init_cores(VoidPtr vendor_ptr) noexcept { +Void mp_init_cores(VoidPtr vendor_ptr) { if (!vendor_ptr) return; PowerFactoryInterface hw_and_pow_int{vendor_ptr}; diff --git a/src/kernel/HALKit/AMD64/HalCoreInterruptHandler.cc b/src/kernel/HALKit/AMD64/HalCoreInterruptHandler.cc index f19e49b5..3745fe3c 100644 --- a/src/kernel/HALKit/AMD64/HalCoreInterruptHandler.cc +++ b/src/kernel/HALKit/AMD64/HalCoreInterruptHandler.cc @@ -61,8 +61,7 @@ EXTERN_C void idt_handle_scheduler(Kernel::UIntPtr rsp) { hal_idt_send_eoi(32); - while (kIsRunning) - ; + while (kIsRunning); kIsRunning = YES; diff --git a/src/kernel/HALKit/AMD64/HalDebugOutput.cc b/src/kernel/HALKit/AMD64/HalDebugOutput.cc index 8e5f4cbd..f35e7a57 100644 --- a/src/kernel/HALKit/AMD64/HalDebugOutput.cc +++ b/src/kernel/HALKit/AMD64/HalDebugOutput.cc @@ -26,7 +26,7 @@ namespace Detail { /// @brief Init COM1. /// @return template <UInt16 PORT> - bool hal_serial_init() noexcept { + bool hal_serial_init() { if (kState == kStateReady || kState == kStateTransmit) return true; HAL::rt_out8(PORT + 1, 0x00); // Disable all interrupts @@ -211,14 +211,14 @@ EXTERN_C void ke_io_read(DeviceInterface<const Char*>*, const Char* bytes) { #endif // __DEBUG__ } -TerminalDevice TerminalDevice::The() noexcept { +TerminalDevice TerminalDevice::The() { TerminalDevice out(Kernel::ke_io_write, Kernel::ke_io_read); return out; } Utf8TerminalDevice::~Utf8TerminalDevice() = default; -Utf8TerminalDevice Utf8TerminalDevice::The() noexcept { +Utf8TerminalDevice Utf8TerminalDevice::The() { Utf8TerminalDevice out(Kernel::ke_utf_io_write, [](DeviceInterface<const Utf8Char*>*, const Utf8Char*) -> Void {}); return out; diff --git a/src/kernel/HALKit/AMD64/HalKernelMain.cc b/src/kernel/HALKit/AMD64/HalKernelMain.cc index e23c5bc1..5f1d2430 100644 --- a/src/kernel/HALKit/AMD64/HalKernelMain.cc +++ b/src/kernel/HALKit/AMD64/HalKernelMain.cc @@ -154,7 +154,6 @@ EXTERN_C Kernel::Void hal_real_init(Kernel::Void) { HAL::IDTLoader idt_loader; idt_loader.Load(idt_reg); - while (YES) - ; + while (YES); } #endif // ifndef __NE_MODULAR_KERNEL_COMPONENTS__ diff --git a/src/kernel/HALKit/AMD64/HalKernelPanic.cc b/src/kernel/HALKit/AMD64/HalKernelPanic.cc index 12538667..73121cbc 100644 --- a/src/kernel/HALKit/AMD64/HalKernelPanic.cc +++ b/src/kernel/HALKit/AMD64/HalKernelPanic.cc @@ -22,7 +22,7 @@ namespace Kernel { /// @brief Dumping factory class. class RecoveryFactory final { public: - STATIC Void Recover() noexcept; + STATIC Void Recover(); }; /***********************************************************************************/ @@ -39,7 +39,7 @@ Void ke_panic(const Kernel::Int32& id, const Char* message) { RecoveryFactory::Recover(); } -Void RecoveryFactory::Recover() noexcept { +Void RecoveryFactory::Recover() { while (YES) { HAL::rt_halt(); } diff --git a/src/kernel/HALKit/AMD64/HalProcessor.cc b/src/kernel/HALKit/AMD64/HalProcessor.cc index d202a758..cebf5e38 100644 --- a/src/kernel/HALKit/AMD64/HalProcessor.cc +++ b/src/kernel/HALKit/AMD64/HalProcessor.cc @@ -16,7 +16,7 @@ */ namespace Kernel::HAL { -inline Bool hal_has_msr() noexcept { +inline Bool hal_has_msr() { static UInt32 eax, unused, edx; // eax, edx __get_cpuid(1, &eax, &unused, &unused, &edx); @@ -25,12 +25,12 @@ inline Bool hal_has_msr() noexcept { return edx & (1 << 5); } -Void hal_get_msr(UInt32 msr, UInt32* lo, UInt32* hi) noexcept { +Void hal_get_msr(UInt32 msr, UInt32* lo, UInt32* hi) { if (!lo || !hi) return; asm volatile("rdmsr" : "=a"(*lo), "=d"(*hi) : "c"(msr)); } -Void hal_set_msr(UInt32 msr, UInt32 lo, UInt32 hi) noexcept { +Void hal_set_msr(UInt32 msr, UInt32 lo, UInt32 hi) { asm volatile("wrmsr" : : "a"(lo), "d"(hi), "c"(msr)); } diff --git a/src/kernel/HALKit/AMD64/HalTimer.cc b/src/kernel/HALKit/AMD64/HalTimer.cc index f6488b05..8d5c0737 100644 --- a/src/kernel/HALKit/AMD64/HalTimer.cc +++ b/src/kernel/HALKit/AMD64/HalTimer.cc @@ -79,7 +79,7 @@ HardwareTimer::~HardwareTimer() { /// @brief Wait for the timer to stop spinning.
/***********************************************************************************/
-BOOL HardwareTimer::Wait() noexcept {
+BOOL HardwareTimer::Wait() {
if (fWaitFor < 1) return NO;
if (fWaitFor > 1'000'000) return NO; // max 1000s = 16 minutes
diff --git a/src/kernel/HALKit/AMD64/Network/Generic+Basic+RTL8139.cc b/src/kernel/HALKit/AMD64/Network/Generic+Basic+RTL8139.cc index f9865139..db839994 100644 --- a/src/kernel/HALKit/AMD64/Network/Generic+Basic+RTL8139.cc +++ b/src/kernel/HALKit/AMD64/Network/Generic+Basic+RTL8139.cc @@ -25,7 +25,7 @@ STATIC UInt8* kRXBuffer = nullptr; ///@brief RTL8139 Init routine. /***********************************************************************************/ -EXTERN_C BOOL rtl_init_nic_rtl8139(UInt16 io_base) noexcept { +EXTERN_C BOOL rtl_init_nic_rtl8139(UInt16 io_base) { if (kTXRXEnabled) return NO; kRTLIOBase = io_base; diff --git a/src/kernel/HALKit/AMD64/Paging.h b/src/kernel/HALKit/AMD64/Paging.h index a938700e..3325d2c7 100644 --- a/src/kernel/HALKit/AMD64/Paging.h +++ b/src/kernel/HALKit/AMD64/Paging.h @@ -57,7 +57,9 @@ namespace Detail { kPageEnable = 31, }; - inline UInt8 control_register_cast(ControlRegisterBits reg) { return static_cast<UInt8>(reg); } + inline UInt8 control_register_cast(ControlRegisterBits reg) { + return static_cast<UInt8>(reg); + } } // namespace Detail auto mm_alloc_bitmap(Boolean wr, Boolean user, SizeT size, Bool is_page, SizeT pad = 0) -> VoidPtr; diff --git a/src/kernel/HALKit/AMD64/Processor.h b/src/kernel/HALKit/AMD64/Processor.h index db1ed573..ec94a3f1 100644 --- a/src/kernel/HALKit/AMD64/Processor.h +++ b/src/kernel/HALKit/AMD64/Processor.h @@ -162,20 +162,20 @@ class IDTLoader final { /// @return True if YES, False if not. /***********************************************************************************/ -Bool mp_is_smp(Void) noexcept; +Bool mp_is_smp(Void); /***********************************************************************************/ /// @brief Fetch and enable SMP scheduler. /// @param vendor_ptr SMP containing structure. /***********************************************************************************/ -Void mp_init_cores(VoidPtr vendor_ptr) noexcept; +Void mp_init_cores(VoidPtr vendor_ptr); /***********************************************************************************/ /// @brief Do a cpuid to check if MSR exists on CPU. /// @retval true it does exists. /// @retval false it doesn't. /***********************************************************************************/ -Bool hal_has_msr() noexcept; +Bool hal_has_msr(); /***********************************************************************************/ /// @brief Get Model specific register inside core. @@ -183,13 +183,13 @@ Bool hal_has_msr() noexcept; /// @param lo low byte /// @param hi high byte /***********************************************************************************/ -Void hal_get_msr(UInt32 msr, UInt32* lo, UInt32* hi) noexcept; +Void hal_get_msr(UInt32 msr, UInt32* lo, UInt32* hi); /// @brief Set Model-specific register. /// @param msr MSR /// @param lo low byte /// @param hi high byte -Void hal_set_msr(UInt32 msr, UInt32 lo, UInt32 hi) noexcept; +Void hal_set_msr(UInt32 msr, UInt32 lo, UInt32 hi); /// @brief Processor specific namespace. namespace Detail { @@ -234,8 +234,8 @@ class LAPICDmaWrapper final { NE_COPY_DEFAULT(LAPICDmaWrapper) public: - UInt32 Read(UInt16 reg) noexcept; - Void Write(UInt16 reg, UInt32 value) noexcept; + UInt32 Read(UInt16 reg); + Void Write(UInt16 reg, UInt32 value); private: VoidPtr fApic{nullptr}; diff --git a/src/kernel/HALKit/AMD64/Storage/AHCI+Generic.cc b/src/kernel/HALKit/AMD64/Storage/AHCI+Generic.cc index 14b40b98..51e73fca 100644 --- a/src/kernel/HALKit/AMD64/Storage/AHCI+Generic.cc +++ b/src/kernel/HALKit/AMD64/Storage/AHCI+Generic.cc @@ -64,11 +64,11 @@ STATIC ALIGN(kib_cast(4)) UInt8 kIdentifyData[kAHCISectorSize] = {0} template <BOOL Write, BOOL CommandOrCTRL, BOOL Identify> STATIC Void drv_std_input_output_ahci(UInt64 lba, UInt8* buffer, SizeT sector_sz, - SizeT size_buffer) noexcept; + SizeT size_buffer); -STATIC Int32 drv_find_cmd_slot_ahci(HbaPort* port) noexcept; +STATIC Int32 drv_find_cmd_slot_ahci(HbaPort* port); -STATIC Void drv_compute_disk_ahci() noexcept; +STATIC Void drv_compute_disk_ahci(); STATIC SizeT drv_get_size_ahci(); @@ -77,7 +77,7 @@ STATIC SizeT drv_get_sector_count_ahci(); /***********************************************************************************/ /// @brief Identify device and read LBA info, Disk OEM vendor. /***********************************************************************************/ -STATIC Void drv_compute_disk_ahci() noexcept { +STATIC Void drv_compute_disk_ahci() { kSATASectorCount = 0UL; rt_set_memory(kIdentifyData, 0, kAHCISectorSize); @@ -114,7 +114,7 @@ STATIC Void drv_compute_disk_ahci() noexcept { /// @param port The port to search on. /// @return The slot, or -1. /***********************************************************************************/ -STATIC Int32 drv_find_cmd_slot_ahci(HbaPort* port) noexcept { +STATIC Int32 drv_find_cmd_slot_ahci(HbaPort* port) { UInt32 slots = port->Sact | port->Ci; for (Int32 i = 0; i < kSATAPortCnt; ++i) // AHCI supports up to 32 slots @@ -134,7 +134,7 @@ STATIC Int32 drv_find_cmd_slot_ahci(HbaPort* port) noexcept { /***********************************************************************************/ template <BOOL Write, BOOL CommandOrCTRL, BOOL Identify> STATIC Void drv_std_input_output_ahci(UInt64 lba, UInt8* buffer, SizeT sector_sz, - SizeT size_buffer) noexcept { + SizeT size_buffer) { if (sector_sz == 0) { kout << "ahci: Invalid sector size.\r"; err_global_get() = kErrorDisk; @@ -294,8 +294,7 @@ STATIC Void drv_std_input_output_ahci(UInt64 lba, UInt8* buffer, SizeT sector_sz goto ahci_io_end; } else { kout << "ahci: Disk still busy after command completion!\r"; - while (kSATAHba->Ports[kSATAIndex].Tfd & (kSATASRBsy | kSATASRDrq)) - ; + while (kSATAHba->Ports[kSATAIndex].Tfd & (kSATASRBsy | kSATASRDrq)); } ahci_io_end: @@ -308,13 +307,15 @@ STATIC Void drv_std_input_output_ahci(UInt64 lba, UInt8* buffer, SizeT sector_sz @brief Gets the number of sectors inside the drive. @return Sector size in bytes. */ -STATIC ATTRIBUTE(unused) SizeT drv_get_sector_count_ahci() { +STATIC ATTRIBUTE(unused) +SizeT drv_get_sector_count_ahci() { return kSATASectorCount; } /// @brief Get the drive size. /// @return Disk size in bytes. -STATIC ATTRIBUTE(unused) SizeT drv_get_size_ahci() { +STATIC ATTRIBUTE(unused) +SizeT drv_get_size_ahci() { return drv_std_get_sector_count() * kAHCISectorSize; } diff --git a/src/kernel/HALKit/AMD64/Storage/DMA+Generic.cc b/src/kernel/HALKit/AMD64/Storage/DMA+Generic.cc index cf6147d9..5a51d685 100644 --- a/src/kernel/HALKit/AMD64/Storage/DMA+Generic.cc +++ b/src/kernel/HALKit/AMD64/Storage/DMA+Generic.cc @@ -105,7 +105,7 @@ Void drv_std_read(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT SectorSz rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + SectorSz - 1) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); @@ -123,8 +123,7 @@ Void drv_std_read(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT SectorSz rt_out8(kATADevice.Bar(0x20) + 0x00, 0x09); // Start DMA engine - while (rt_in8(kATADevice.Bar(0x20) + ATA_REG_STATUS) & 0x01) - ; + while (rt_in8(kATADevice.Bar(0x20) + ATA_REG_STATUS) & 0x01); rt_out8(kATADevice.Bar(0x20) + 0x00, 0x00); // Stop DMA engine @@ -147,7 +146,7 @@ Void drv_std_write(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT SectorS rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + (SectorSz - 1)) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); @@ -163,8 +162,7 @@ Void drv_std_write(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT SectorS rt_out8(IO + 0x00, 0x09); // Start DMA engine - while (rt_in8(kATADevice.Bar(0x20) + ATA_REG_STATUS) & 0x01) - ; + while (rt_in8(kATADevice.Bar(0x20) + ATA_REG_STATUS) & 0x01); rt_out8(kATADevice.Bar(0x20) + 0x00, 0x00); // Stop DMA engine diff --git a/src/kernel/HALKit/AMD64/Storage/PIO+Generic.cc b/src/kernel/HALKit/AMD64/Storage/PIO+Generic.cc index 0516be39..81a79c6f 100644 --- a/src/kernel/HALKit/AMD64/Storage/PIO+Generic.cc +++ b/src/kernel/HALKit/AMD64/Storage/PIO+Generic.cc @@ -83,8 +83,7 @@ ATAInit_Retry: rt_out8(OutBus + ATA_REG_COMMAND, ATA_CMD_IDENTIFY); - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); /// fetch serial info /// model, speed, number of sectors... @@ -117,15 +116,14 @@ Void drv_pio_std_read(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT Sect rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + SectorSz) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); rt_out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO); - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); for (SizeT IndexOff = 0; IndexOff < Size; IndexOff += 2) { drv_pio_std_wait_io(IO); @@ -149,15 +147,14 @@ Void drv_pio_std_write(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf, SizeT Sec rt_out8(IO + ATA_REG_SEC_COUNT0, ((Size + SectorSz) / SectorSz)); - rt_out8(IO + ATA_REG_LBA0, (Lba) &0xFF); + rt_out8(IO + ATA_REG_LBA0, (Lba) & 0xFF); rt_out8(IO + ATA_REG_LBA1, (Lba) >> 8); rt_out8(IO + ATA_REG_LBA2, (Lba) >> 16); rt_out8(IO + ATA_REG_LBA3, (Lba) >> 24); rt_out8(IO + ATA_REG_COMMAND, ATA_CMD_WRITE_PIO); - while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)) - ; + while (!(rt_in8(IO + ATA_REG_STATUS) & ATA_SR_DRQ)); for (SizeT IndexOff = 0; IndexOff < Size; IndexOff += 2) { drv_pio_std_wait_io(IO); diff --git a/src/kernel/HALKit/ARM64/ApplicationProcessor.h b/src/kernel/HALKit/ARM64/ApplicationProcessor.h index 208bf82e..9768cebc 100644 --- a/src/kernel/HALKit/ARM64/ApplicationProcessor.h +++ b/src/kernel/HALKit/ARM64/ApplicationProcessor.h @@ -15,5 +15,5 @@ /************************************************** */ namespace Kernel { -Void mp_init_cores(Void) noexcept; +Void mp_init_cores(Void); }
\ No newline at end of file diff --git a/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc b/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc index 2a3c73e5..fff4282f 100644 --- a/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc +++ b/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc @@ -131,7 +131,7 @@ EXTERN_C Bool mp_register_task(HAL::StackFramePtr stack_frame, ProcessID thrdid) /// @brief Initialize the Global Interrupt Controller.
/// @internal
/***********************************************************************************/
-Void mp_init_cores(Void) noexcept {
+Void mp_init_cores(Void) {
if (!Detail::kGICEnabled) {
Detail::kGICEnabled = YES;
Detail::mp_setup_gic_el0();
diff --git a/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc b/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc index b89f68bd..3c18e837 100644 --- a/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc +++ b/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc @@ -56,8 +56,7 @@ EXTERN_C void int_handle_scheduler(Kernel::UIntPtr rsp) { hal_int_send_eoi(32); - while (kIsRunning) - ; + while (kIsRunning); kIsRunning = YES; diff --git a/src/kernel/HALKit/ARM64/HalDebugOutput.cc b/src/kernel/HALKit/ARM64/HalDebugOutput.cc index c0da9c3a..22a41dbf 100644 --- a/src/kernel/HALKit/ARM64/HalDebugOutput.cc +++ b/src/kernel/HALKit/ARM64/HalDebugOutput.cc @@ -63,7 +63,7 @@ EXTERN_C void ke_io_read(DeviceInterface<const Char*>* self, const Char* bytes) #endif // __DEBUG__ } -TerminalDevice TerminalDevice::The() noexcept { +TerminalDevice TerminalDevice::The() { TerminalDevice out(Kernel::ke_io_write, Kernel::ke_io_read); return out; } diff --git a/src/kernel/HALKit/ARM64/HalKernelMain.cc b/src/kernel/HALKit/ARM64/HalKernelMain.cc index e36535c3..1cd10838 100644 --- a/src/kernel/HALKit/ARM64/HalKernelMain.cc +++ b/src/kernel/HALKit/ARM64/HalKernelMain.cc @@ -57,7 +57,6 @@ EXTERN_C void hal_init_platform(Kernel::HEL::BootInfoHeader* handover_hdr) { Kernel::mp_init_cores(); - while (YES) - ; + while (YES); } #endif diff --git a/src/kernel/HALKit/ARM64/HalKernelPanic.cc b/src/kernel/HALKit/ARM64/HalKernelPanic.cc index 6837ba1c..6c3afe83 100644 --- a/src/kernel/HALKit/ARM64/HalKernelPanic.cc +++ b/src/kernel/HALKit/ARM64/HalKernelPanic.cc @@ -22,7 +22,7 @@ namespace Kernel { /// @brief Dumping factory class. class RecoveryFactory final { public: - STATIC Void Recover() noexcept; + STATIC Void Recover(); }; /***********************************************************************************/ @@ -37,7 +37,7 @@ Void ke_panic(const Kernel::Int32& id, const Char* message) { RecoveryFactory::Recover(); } -Void RecoveryFactory::Recover() noexcept { +Void RecoveryFactory::Recover() { while (YES) { HAL::rt_halt(); } diff --git a/src/kernel/HALKit/ARM64/Paging.h b/src/kernel/HALKit/ARM64/Paging.h index 766210b3..e8bd0ac1 100644 --- a/src/kernel/HALKit/ARM64/Paging.h +++ b/src/kernel/HALKit/ARM64/Paging.h @@ -41,14 +41,10 @@ /// Long format address range -#define cPageMAll \ - { 0b000, 0b000 } -#define cPageMToMax(M) \ - { M, 0b000 } -#define cPageMaxToM(M) \ - { 0b000, M } -#define cPageMToN(M, N) \ - { M, N } +#define cPageMAll {0b000, 0b000} +#define cPageMToMax(M) {M, 0b000} +#define cPageMaxToM(M) {0b000, M} +#define cPageMToN(M, N) {M, N} namespace Kernel::HAL { struct PACKED PTE_4KB final { @@ -86,7 +82,9 @@ namespace Detail { PageEnable = 31, }; - inline UInt8 control_register_cast(ControlRegisterBits reg) { return static_cast<UInt8>(reg); } + inline UInt8 control_register_cast(ControlRegisterBits reg) { + return static_cast<UInt8>(reg); + } } // namespace Detail struct PDE_4KB final { diff --git a/src/kernel/HALKit/ARM64/Processor.h b/src/kernel/HALKit/ARM64/Processor.h index 716d317b..de9f932e 100644 --- a/src/kernel/HALKit/ARM64/Processor.h +++ b/src/kernel/HALKit/ARM64/Processor.h @@ -60,7 +60,7 @@ struct PACKED StackFrame { typedef StackFrame* StackFramePtr; -inline Void rt_halt() noexcept { +inline Void rt_halt() { while (Yes) { } } diff --git a/src/kernel/HALKit/POWER/HalApplicationProcessor.cc b/src/kernel/HALKit/POWER/HalApplicationProcessor.cc index 84d9b1c1..fa65deae 100644 --- a/src/kernel/HALKit/POWER/HalApplicationProcessor.cc +++ b/src/kernel/HALKit/POWER/HalApplicationProcessor.cc @@ -12,8 +12,7 @@ namespace Kernel::Detail { STATIC void mp_hang_fn(void) { - while (YES) - ; + while (YES); } } // namespace Kernel::Detail diff --git a/src/kernel/HALKit/RISCV/HalApplicationProcessor.cc b/src/kernel/HALKit/RISCV/HalApplicationProcessor.cc index 520481d1..16c9e33f 100644 --- a/src/kernel/HALKit/RISCV/HalApplicationProcessor.cc +++ b/src/kernel/HALKit/RISCV/HalApplicationProcessor.cc @@ -13,8 +13,7 @@ using namespace Kernel; namespace Kernel {
namespace Detail {
STATIC void mp_hang_fn(void) {
- while (YES)
- ;
+ while (YES);
}
} // namespace Detail
diff --git a/src/kernel/KernelKit/BinaryMutex.h b/src/kernel/KernelKit/BinaryMutex.h index 5431ab72..46d11b8d 100644 --- a/src/kernel/KernelKit/BinaryMutex.h +++ b/src/kernel/KernelKit/BinaryMutex.h @@ -21,10 +21,10 @@ class BinaryMutex final { public: bool IsLocked() const; - bool Unlock() noexcept; + bool Unlock(); public: - BOOL WaitForProcess(const UInt32& sec) noexcept; + BOOL WaitForProcess(const UInt32& sec); public: bool Lock(USER_PROCESS* process); diff --git a/src/kernel/KernelKit/CodeMgr.h b/src/kernel/KernelKit/CodeMgr.h index e537b26d..f3260f1f 100644 --- a/src/kernel/KernelKit/CodeMgr.h +++ b/src/kernel/KernelKit/CodeMgr.h @@ -38,12 +38,12 @@ typedef void (*rtl_cxx_dtor_kind)(void); /// accessible. /// @param main the start of the process. /// @return The team's process id. -BOOL rtl_create_kernel_task(HAL::StackFramePtr main, const KID kid) noexcept; +BOOL rtl_create_kernel_task(HAL::StackFramePtr main, const KID kid); /// @brief Executes a new process from a function. User code only. /// @note This sets up a new stack, anything on the main function that calls the Kernel will not be /// accessible. /// @param main the start of the process. /// @return The team's process id. -ProcessID rtl_create_user_process(rtl_main_kind main, const Char* process_name) noexcept; +ProcessID rtl_create_user_process(rtl_main_kind main, const Char* process_name); } // namespace Kernel diff --git a/src/kernel/KernelKit/DebugOutput.h b/src/kernel/KernelKit/DebugOutput.h index 3f9b5125..301a3a9e 100644 --- a/src/kernel/KernelKit/DebugOutput.h +++ b/src/kernel/KernelKit/DebugOutput.h @@ -37,7 +37,7 @@ class TerminalDevice final NE_DEVICE<const Char*> { NE_COPY_DEFAULT(TerminalDevice) - STATIC TerminalDevice The() noexcept; + STATIC TerminalDevice The(); }; class Utf8TerminalDevice final NE_DEVICE<const Utf8Char*> { @@ -54,7 +54,7 @@ class Utf8TerminalDevice final NE_DEVICE<const Utf8Char*> { NE_COPY_DEFAULT(Utf8TerminalDevice) - STATIC Utf8TerminalDevice The() noexcept; + STATIC Utf8TerminalDevice The(); }; inline TerminalDevice end_line() { diff --git a/src/kernel/KernelKit/DriveMgr.h b/src/kernel/KernelKit/DriveMgr.h index daf93b89..9f66e31c 100644 --- a/src/kernel/KernelKit/DriveMgr.h +++ b/src/kernel/KernelKit/DriveMgr.h @@ -74,7 +74,7 @@ struct DriveTrait final { Void (*fOutput)(DrivePacket& packet){nullptr}; Void (*fVerify)(DrivePacket& packet){nullptr}; Void (*fInit)(DrivePacket& packet){nullptr}; - const Char* (*fProtocol)(Void){nullptr}; + const Char* (*fProtocol)(Void) {nullptr}; }; namespace Probe { @@ -143,7 +143,7 @@ class IMountpoint final { /// @brief Unimplemented drive. /// @param pckt the packet to read. /// @return -Void io_drv_unimplemented(DriveTrait::DrivePacket* pckt) noexcept; +Void io_drv_unimplemented(DriveTrait::DrivePacket* pckt); /// @brief Gets the drive kind (ATA, SCSI, AHCI...) /// @param void none. @@ -152,16 +152,16 @@ const Char* io_drv_kind(Void); /// @brief Makes a new drive. /// @return the new drive as a trait. -DriveTrait io_construct_blank_drive(Void) noexcept; +DriveTrait io_construct_blank_drive(Void); /// @brief Fetches the main drive. /// @param trait the new drive as a trait. -Void io_construct_main_drive(DriveTrait& trait) noexcept; +Void io_construct_main_drive(DriveTrait& trait); /// @brief Fetches the main drive. /// @return the new drive as a trait. /// @deprecated use io_construct_main_drive(DriveTrait& trait) instead. -DriveTrait io_construct_main_drive(Void) noexcept; +DriveTrait io_construct_main_drive(Void); namespace Detect { Void io_detect_drive(DriveTrait& trait); diff --git a/src/kernel/KernelKit/FileMgr.h b/src/kernel/KernelKit/FileMgr.h index 93d5f580..9aebe1e9 100644 --- a/src/kernel/KernelKit/FileMgr.h +++ b/src/kernel/KernelKit/FileMgr.h @@ -169,7 +169,7 @@ class NeFileSystemMgr final : public IFilesystemMgr { public: /// @brief Get NeFS parser class. /// @return The filesystem parser class. - NeFileSystemParser* GetParser() noexcept; + NeFileSystemParser* GetParser(); private: NeFileSystemParser* mParser{nullptr}; @@ -215,7 +215,7 @@ class Ext2FileSystemMgr final : public IFilesystemMgr { public: /// @brief Get NeFS parser class. /// @return The filesystem parser class. - Ext2FileSystemParser* GetParser() noexcept; + Ext2FileSystemParser* GetParser(); private: Ext2FileSystemParser* mParser{nullptr}; @@ -261,7 +261,7 @@ class HeFileSystemMgr final : public IFilesystemMgr { public: /// @brief Get NeFS parser class. /// @return The filesystem parser class. - HeFileSystemParser* GetParser() noexcept; + HeFileSystemParser* GetParser(); private: HeFileSystemParser* mParser{nullptr}; @@ -285,7 +285,7 @@ class FileStream final { FileStream(const FileStream&); public: - ErrorOr<Int64> Write(SizeT offset, const VoidPtr data, SizeT len) noexcept { + ErrorOr<Int64> Write(SizeT offset, const VoidPtr data, SizeT len) { if (this->fFileRestrict != kFileMgrRestrictReadWrite && this->fFileRestrict != kFileMgrRestrictReadWriteBinary && this->fFileRestrict != kFileMgrRestrictWrite && @@ -304,7 +304,7 @@ class FileStream final { return ErrorOr<Int64>(kErrorInvalidData); } - ErrorOr<Int64> Write(const Char* name, const VoidPtr data, SizeT len) noexcept { + ErrorOr<Int64> Write(const Char* name, const VoidPtr data, SizeT len) { if (this->fFileRestrict != kFileMgrRestrictReadWrite && this->fFileRestrict != kFileMgrRestrictReadWriteBinary && this->fFileRestrict != kFileMgrRestrictWrite && @@ -323,7 +323,7 @@ class FileStream final { return ErrorOr<Int64>(kErrorInvalidData); } - VoidPtr Read(const Char* name, SizeT sz) noexcept { + VoidPtr Read(const Char* name, SizeT sz) { if (this->fFileRestrict != kFileMgrRestrictReadWrite && this->fFileRestrict != kFileMgrRestrictReadWriteBinary && this->fFileRestrict != kFileMgrRestrictRead && @@ -366,7 +366,7 @@ class FileStream final { /// @brief Leak MIME. /// @return The MIME. - Char* MIME() noexcept { return const_cast<Char*>(fMime); } + Char* MIME() { return const_cast<Char*>(fMime); } enum { kFileMgrRestrictRead = 100, diff --git a/src/kernel/KernelKit/HardwareThreadScheduler.h b/src/kernel/KernelKit/HardwareThreadScheduler.h index 36a870ba..6493e550 100644 --- a/src/kernel/KernelKit/HardwareThreadScheduler.h +++ b/src/kernel/KernelKit/HardwareThreadScheduler.h @@ -54,18 +54,18 @@ class HardwareThread final { operator bool(); public: - void Wake(const BOOL wakeup = false) noexcept; - void Busy(const BOOL busy = false) noexcept; + void Wake(const BOOL wakeup = false); + void Busy(const BOOL busy = false); public: BOOL Switch(HAL::StackFramePtr frame); - BOOL IsWakeup() noexcept; + BOOL IsWakeup(); public: - HAL::StackFramePtr StackFrame() noexcept; - ThreadKind& Kind() noexcept; - BOOL IsBusy() noexcept; - ThreadID& ID() noexcept; + HAL::StackFramePtr StackFrame(); + ThreadKind& Kind(); + BOOL IsBusy(); + ThreadID& ID(); private: HAL::StackFramePtr fStack{nullptr}; @@ -95,12 +95,12 @@ class HardwareThreadScheduler final : public ISchedulable { NE_COPY_DEFAULT(HardwareThreadScheduler) public: - HAL::StackFramePtr Leak() noexcept; + HAL::StackFramePtr Leak(); public: Ref<HardwareThread*> operator[](SizeT idx); - bool operator!() noexcept; - operator bool() noexcept; + bool operator!(); + operator bool(); Bool IsUser() override { return Yes; } @@ -116,7 +116,7 @@ class HardwareThreadScheduler final : public ISchedulable { public: /// @brief Returns the amount of threads present in the system. /// @returns SizeT the amount of cores present. - SizeT Capacity() noexcept; + SizeT Capacity(); private: Array<HardwareThread, kMaxAPInsideSched> fThreadList; diff --git a/src/kernel/KernelKit/ILoader.h b/src/kernel/KernelKit/ILoader.h index 28dd1ed9..c6c87411 100644 --- a/src/kernel/KernelKit/ILoader.h +++ b/src/kernel/KernelKit/ILoader.h @@ -23,9 +23,9 @@ class ILoader { public: virtual _Output ErrorOr<VoidPtr> GetBlob() = 0; - virtual _Output const Char* AsString() = 0; - virtual _Output const Char* MIME() = 0; - virtual _Output const Char* Path() = 0; + virtual _Output const Char* AsString() = 0; + virtual _Output const Char* MIME() = 0; + virtual _Output const Char* Path() = 0; virtual _Output ErrorOr<VoidPtr> FindStart() = 0; virtual _Output ErrorOr<VoidPtr> FindSymbol(_Input const Char* name, _Input Int32 kind) = 0; }; diff --git a/src/kernel/KernelKit/IPEFDylibObject.h b/src/kernel/KernelKit/IPEFDylibObject.h index 17ef02d5..54cfdcb1 100644 --- a/src/kernel/KernelKit/IPEFDylibObject.h +++ b/src/kernel/KernelKit/IPEFDylibObject.h @@ -38,7 +38,7 @@ class IPEFDylibObject final NE_DYLIB_OBJECT { DylibTraits* Get() { return fMounted; } public: - void Mount(DylibTraits* to_mount) noexcept { + void Mount(DylibTraits* to_mount) { if (!to_mount || !to_mount->ImageObject) return; fMounted = to_mount; @@ -53,7 +53,7 @@ class IPEFDylibObject final NE_DYLIB_OBJECT { } } - void Unmount() noexcept { + void Unmount() { if (fMounted) fMounted = nullptr; }; diff --git a/src/kernel/KernelKit/KPC.h b/src/kernel/KernelKit/KPC.h index dbdc2a93..c712ac98 100644 --- a/src/kernel/KernelKit/KPC.h +++ b/src/kernel/KernelKit/KPC.h @@ -74,5 +74,5 @@ inline constexpr KPCError kErrorUnimplemented = -1; /// @brief Does a system wide bug check. /// @param void no params are needed. /// @return if error-free: false, otherwise true. -Boolean err_bug_check_raise(Void) noexcept; +Boolean err_bug_check_raise(Void); } // namespace Kernel diff --git a/src/kernel/KernelKit/PCI/DMA.h b/src/kernel/KernelKit/PCI/DMA.h index 80103dab..0cc642c1 100644 --- a/src/kernel/KernelKit/PCI/DMA.h +++ b/src/kernel/KernelKit/PCI/DMA.h @@ -47,7 +47,7 @@ class DMAWrapper final { T* Get(UIntPtr off = 0); public: - operator bool(); + operator bool(); bool operator!(); public: diff --git a/src/kernel/KernelKit/PE32CodeMgr.h b/src/kernel/KernelKit/PE32CodeMgr.h index 52bc22b4..38ebce72 100644 --- a/src/kernel/KernelKit/PE32CodeMgr.h +++ b/src/kernel/KernelKit/PE32CodeMgr.h @@ -66,7 +66,7 @@ class PE32Loader : public ILoader { ErrorOr<VoidPtr> GetBlob() override; public: - bool IsLoaded() noexcept; + bool IsLoaded(); private: #ifdef __FSKIT_INCLUDES_NEFS__ @@ -87,5 +87,5 @@ enum { kPETypeInvalid, kPETypeText = 100, kPETypeData, kPETypeBSS }; typedef LDR_SECTION_HEADER PE_SECTION_INFO; -ProcessID rtl_create_user_process(PE32Loader& exec, const Int32& process_kind) noexcept; +ProcessID rtl_create_user_process(PE32Loader& exec, const Int32& process_kind); } // namespace Kernel
\ No newline at end of file diff --git a/src/kernel/KernelKit/PEFCodeMgr.h b/src/kernel/KernelKit/PEFCodeMgr.h index 41b135e0..d076adca 100644 --- a/src/kernel/KernelKit/PEFCodeMgr.h +++ b/src/kernel/KernelKit/PEFCodeMgr.h @@ -50,7 +50,7 @@ class PEFLoader : public ILoader { ErrorOr<VoidPtr> GetBlob() override; public: - bool IsLoaded() noexcept; + bool IsLoaded(); private: #ifdef __FSKIT_INCLUDES_NEFS__ @@ -68,7 +68,7 @@ class PEFLoader : public ILoader { }; namespace Utils { - ProcessID rtl_create_user_process(PEFLoader& exec, const Int32& procKind) noexcept; + ProcessID rtl_create_user_process(PEFLoader& exec, const Int32& procKind); } // namespace Utils } // namespace Kernel diff --git a/src/kernel/KernelKit/ThreadLocalStorage.h b/src/kernel/KernelKit/ThreadLocalStorage.h index 205d6df9..7ee3572b 100644 --- a/src/kernel/KernelKit/ThreadLocalStorage.h +++ b/src/kernel/KernelKit/ThreadLocalStorage.h @@ -36,21 +36,21 @@ Kernel::Boolean tls_check_tib(THREAD_INFORMATION_BLOCK* the_tib); ///! @brief new ptr syscall. template <typename T> -T* tls_new_ptr(void) noexcept; +T* tls_new_ptr(void); ///! @brief delete ptr syscall. template <typename T> -Kernel::Boolean tls_delete_ptr(T* ptr) noexcept; +Kernel::Boolean tls_delete_ptr(T* ptr); //! @brief Delete process pointer. //! @param obj The pointer to delete. template <typename T> -inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T> obj) noexcept; +inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T> obj); //! @brief Delete process pointer. //! @param obj The pointer to delete. template <typename T> -inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T*> obj) noexcept; +inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T*> obj); template <typename T, typename... Args> T* tls_new_class(Args&&... args); @@ -59,7 +59,7 @@ T* tls_new_class(Args&&... args); EXTERN_C Kernel::Void rt_install_tib(THREAD_INFORMATION_BLOCK* TIB, THREAD_INFORMATION_BLOCK* PIB); /// @brief TLS check (syscall) -EXTERN_C Kernel::Bool tls_check_syscall_impl(Kernel::VoidPtr TIB) noexcept; +EXTERN_C Kernel::Bool tls_check_syscall_impl(Kernel::VoidPtr TIB); #include <KernelKit/ThreadLocalStorage.inl> diff --git a/src/kernel/KernelKit/ThreadLocalStorage.inl b/src/kernel/KernelKit/ThreadLocalStorage.inl index 66a3d282..c3c96c30 100644 --- a/src/kernel/KernelKit/ThreadLocalStorage.inl +++ b/src/kernel/KernelKit/ThreadLocalStorage.inl @@ -12,7 +12,7 @@ #endif template <typename T> -inline T* tls_new_ptr(void) noexcept { +inline T* tls_new_ptr(void) { using namespace Kernel; auto ref_process = UserProcessScheduler::The().TheCurrentProcess(); @@ -28,7 +28,7 @@ inline T* tls_new_ptr(void) noexcept { //! @brief Delete process pointer. //! @param obj The pointer to delete. template <typename T> -inline Kernel::Bool tls_delete_ptr(T* obj) noexcept { +inline Kernel::Bool tls_delete_ptr(T* obj) { using namespace Kernel; if (!obj) return No; @@ -44,14 +44,14 @@ inline Kernel::Bool tls_delete_ptr(T* obj) noexcept { //! @brief Delete process pointer. //! @param obj The pointer to delete. template <typename T> -inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T> obj) noexcept { +inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T> obj) { return tls_delete_ptr(obj.Leak()); } //! @brief Delete process pointer. //! @param obj The pointer to delete. template <typename T> -inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T*> obj) noexcept { +inline Kernel::Bool tls_delete_ptr(Kernel::ErrorOr<T*> obj) { return tls_delete_ptr(obj->Leak()); } diff --git a/src/kernel/KernelKit/Timer.h b/src/kernel/KernelKit/Timer.h index 46db5671..605cd0fa 100644 --- a/src/kernel/KernelKit/Timer.h +++ b/src/kernel/KernelKit/Timer.h @@ -25,7 +25,7 @@ class TimerInterface { NE_COPY_DEFAULT(TimerInterface) public: - virtual BOOL Wait() noexcept; + virtual BOOL Wait(); }; class SoftwareTimer final : public TimerInterface { @@ -37,7 +37,7 @@ class SoftwareTimer final : public TimerInterface { NE_COPY_DEFAULT(SoftwareTimer) public: - BOOL Wait() noexcept override; + BOOL Wait() override; private: UIntPtr* fDigitalTimer{nullptr}; @@ -53,7 +53,7 @@ class HardwareTimer final : public TimerInterface { NE_COPY_DEFAULT(HardwareTimer) public: - BOOL Wait() noexcept override; + BOOL Wait() override; private: volatile UInt8* fDigitalTimer{nullptr}; diff --git a/src/kernel/KernelKit/TraceSrv.h b/src/kernel/KernelKit/TraceSrv.h index 4af5e2ae..176c86d9 100644 --- a/src/kernel/KernelKit/TraceSrv.h +++ b/src/kernel/KernelKit/TraceSrv.h @@ -18,6 +18,6 @@ namespace Detail { inline constexpr auto kDebugDelim = ';'; inline constexpr auto kDebugEnd = '\r'; - typedef UInt64 dk_socket_type; + typedef UInt64 dk_socket_type; } // namespace Detail } // namespace Kernel
\ No newline at end of file diff --git a/src/kernel/KernelKit/UserMgr.h b/src/kernel/KernelKit/UserMgr.h index 3ce6254d..4f41ecdb 100644 --- a/src/kernel/KernelKit/UserMgr.h +++ b/src/kernel/KernelKit/UserMgr.h @@ -64,23 +64,23 @@ class User final { public: /// @brief Get software ring - const UserRingKind& Ring() noexcept; + const UserRingKind& Ring(); /// @brief Get user name - Char* Name() noexcept; + Char* Name(); /// @brief Is he a standard user? - Bool IsStdUser() noexcept; + Bool IsStdUser(); /// @brief Is she a super user? - Bool IsSuperUser() noexcept; + Bool IsSuperUser(); /// @brief Saves a password from the public key. - Bool Save(const UserPublicKey password) noexcept; + Bool Save(const UserPublicKey password); /// @brief Checks if a password matches the **password**. /// @param password the password to check. - Bool Login(const UserPublicKey password) noexcept; + Bool Login(const UserPublicKey password); private: UserRingKind mUserRing{UserRingKind::kRingStdUser}; diff --git a/src/kernel/KernelKit/UserProcessScheduler.h b/src/kernel/KernelKit/UserProcessScheduler.h index b2ab7dc2..fa34b966 100644 --- a/src/kernel/KernelKit/UserProcessScheduler.h +++ b/src/kernel/KernelKit/UserProcessScheduler.h @@ -128,23 +128,23 @@ class USER_PROCESS final { /***********************************************************************************/ //! @brief Gets the local exit code. /***********************************************************************************/ - KPCError& GetExitCode() noexcept; + KPCError& GetExitCode(); /***********************************************************************************/ ///! @brief Get the process's name ///! @example 'C Runtime Library' /***********************************************************************************/ - const Char* GetName() noexcept; + const Char* GetName(); /***********************************************************************************/ //! @brief return local error code of process. //! @return Int32 local error code. /***********************************************************************************/ - KPCError& GetLocalCode() noexcept; + KPCError& GetLocalCode(); - const User* GetOwner() noexcept; - const ProcessStatusKind& GetStatus() noexcept; - const AffinityKind& GetAffinity() noexcept; + const User* GetOwner(); + const ProcessStatusKind& GetStatus(); + const AffinityKind& GetAffinity(); private: KPCError LastExitCode{0}; @@ -168,7 +168,7 @@ class UserProcessTeam final { Array<USER_PROCESS, kSchedProcessLimitPerTeam>& AsArray(); Ref<USER_PROCESS>& AsRef(); - ProcessID& Id() noexcept; + ProcessID& Id(); public: USER_PROCESS_ARRAY mProcessList; @@ -209,7 +209,7 @@ class UserProcessScheduler final : public ISchedulable { public: USER_PROCESS_REF& TheCurrentProcess(); - SizeT Run() noexcept; + SizeT Run(); public: STATIC UserProcessScheduler& The(); diff --git a/src/kernel/KernelKit/ZXD.h b/src/kernel/KernelKit/ZXD.h index 81df0ade..88094d4b 100644 --- a/src/kernel/KernelKit/ZXD.h +++ b/src/kernel/KernelKit/ZXD.h @@ -17,7 +17,7 @@ struct ZXD_STUB_HEADER; enum ZXD_FLAGS { kZXDFlagsInvalid = 0, - kZXDFlagsDriver = 120, + kZXDFlagsDriver = 120, kZXDFlagsBoot, kZXDFlagsKernel, kZXDFlagsCount = kZXDFlagsKernel - kZXDFlagsDriver + 1, diff --git a/src/kernel/NeKit/Crc32.h b/src/kernel/NeKit/Crc32.h index 3c6a904f..125ee5b7 100644 --- a/src/kernel/NeKit/Crc32.h +++ b/src/kernel/NeKit/Crc32.h @@ -14,7 +14,7 @@ #include <NeKit/Defines.h> namespace Kernel { -UInt32 ke_calculate_crc32(const VoidPtr crc, Int32 len) noexcept; +UInt32 ke_calculate_crc32(const VoidPtr crc, Int32 len); } // namespace Kernel #endif // !NEKIT_CRC32_H diff --git a/src/kernel/NeKit/Defines.h b/src/kernel/NeKit/Defines.h index 1a6a2cf6..e53616a9 100644 --- a/src/kernel/NeKit/Defines.h +++ b/src/kernel/NeKit/Defines.h @@ -127,7 +127,7 @@ class ICodec { /// @param type (a1) the data. /// @return a1 as Char* template <typename T> - const Char* AsBytes(T type) noexcept { + const Char* AsBytes(T type) { NE_UNUSED(type); return nullptr; } @@ -137,7 +137,7 @@ class ICodec { /// @param type (a1) the data. /// @return a1 as Char* template <typename OutputClass, typename FactoryClass> - OutputClass* Construct(Char* type) noexcept { + OutputClass* Construct(Char* type) { FactoryClass class_fac; return class_fac.template From<OutputClass>(type); } @@ -148,7 +148,7 @@ class ICodec { /// @param type the class to cast. /// @return the class as Y. template <typename T, typename Y> - Y As(T type) noexcept { + Y As(T type) { if (type.template IsSerializable()) { return reinterpret_cast<Char*>(type); } diff --git a/src/kernel/NeKit/Function.h b/src/kernel/NeKit/Function.h index 70242bc3..5dea8f85 100644 --- a/src/kernel/NeKit/Function.h +++ b/src/kernel/NeKit/Function.h @@ -41,11 +41,9 @@ class Function final { bool operator!() { return !fFn; } private: - T(*fFn) - (Args... args){nullptr}; + T (*fFn)(Args... args){nullptr}; }; template <typename T, typename... Args> using FunctionOr = ErrorOr<Function<T, Args...>>; } // namespace Kernel - diff --git a/src/kernel/NeKit/Json.h b/src/kernel/NeKit/Json.h index 1e804354..82ce3b99 100644 --- a/src/kernel/NeKit/Json.h +++ b/src/kernel/NeKit/Json.h @@ -34,16 +34,15 @@ class JsonObject final { key += kNeJsonNullValue; this->AsKey() = key; - this->AsValue() = key; + this->AsValue() = key; } explicit JsonObject(SizeT lhsLen, SizeT rhsLen) : fKey(lhsLen), fValue(rhsLen) { - KBasicString<CharKind> key = KString(lhsLen); - this->AsKey() = key; + this->AsKey() = key; KBasicString<CharKind> value = KString(rhsLen); - this->AsValue() = value; + this->AsValue() = value; } ~JsonObject() = default; @@ -54,7 +53,7 @@ class JsonObject final { Bool& IsUndefined() { return fUndefined; } private: - Bool fUndefined; // is this instance undefined? + Bool fUndefined; // is this instance undefined? KBasicString<CharKind> fKey; KBasicString<CharKind> fValue; diff --git a/src/kernel/NeKit/Macros.h b/src/kernel/NeKit/Macros.h index 5949b414..80a2ff6c 100644 --- a/src/kernel/NeKit/Macros.h +++ b/src/kernel/NeKit/Macros.h @@ -16,7 +16,7 @@ #endif #ifndef kib_cast -#define kib_cast(X) (Kernel::UInt64)((X) *1024) +#define kib_cast(X) (Kernel::UInt64)((X) * 1024) #endif #ifndef MIB @@ -117,7 +117,7 @@ #define NE_UNUSED(X) ((Kernel::Void) X) #ifndef RGB -#define RGB(R, G, B) ((Kernel::UInt32)((0xFF << 24) | ((R) << 16) | ((G) << 8) | (B))) +#define RGB(R, G, B) ((Kernel::UInt32) ((0xFF << 24) | ((R) << 16) | ((G) << 8) | (B))) #endif // !RGB #ifdef __NE_AMD64__ diff --git a/src/kernel/NeKit/MutableArray.h b/src/kernel/NeKit/MutableArray.h index e1138b3b..e14afbfe 100644 --- a/src/kernel/NeKit/MutableArray.h +++ b/src/kernel/NeKit/MutableArray.h @@ -180,7 +180,7 @@ class MutableArray : public NullableMutableArray<voidPtr, nullptr> { SizeT Count() const { return fNodeCount; } - bool Contains(T& value) noexcept { + bool Contains(T& value) { MutableLinkedList<T>* first = fFirstNode; while (first) { diff --git a/src/kernel/NeKit/New.h b/src/kernel/NeKit/New.h index 36830129..bd986347 100644 --- a/src/kernel/NeKit/New.h +++ b/src/kernel/NeKit/New.h @@ -15,6 +15,6 @@ typedef __SIZE_TYPE__ size_t; void* operator new(size_t); void* operator new[](size_t); -void operator delete(void*) noexcept; +void operator delete(void*); void operator delete(void*, unsigned long); -void operator delete[](void*) noexcept; +void operator delete[](void*); diff --git a/src/kernel/NeKit/OwnPtr.h b/src/kernel/NeKit/OwnPtr.h index c8ceb1a2..bec2813b 100644 --- a/src/kernel/NeKit/OwnPtr.h +++ b/src/kernel/NeKit/OwnPtr.h @@ -50,7 +50,7 @@ class OwnPtr final { Ref<T> AsRef() { return Ref<T>(fCls); } - operator bool() { return fCls; } + operator bool() { return fCls; } bool operator!() { return !fCls; } private: diff --git a/src/kernel/NeKit/Ref.h b/src/kernel/NeKit/Ref.h index dac701e0..59991442 100644 --- a/src/kernel/NeKit/Ref.h +++ b/src/kernel/NeKit/Ref.h @@ -37,13 +37,13 @@ class Ref final { public: T operator->() const { return fClass; } - T& Leak() noexcept { return fClass; } + T& Leak() { return fClass; } - T& TryLeak() noexcept { return fClass; } + T& TryLeak() { return fClass; } T operator*() { return fClass; } - operator bool() noexcept { return true; } + operator bool() { return true; } private: T fClass; diff --git a/src/kernel/NeKit/Variant.h b/src/kernel/NeKit/Variant.h index 7bcd0dff..1b0fbe5d 100644 --- a/src/kernel/NeKit/Variant.h +++ b/src/kernel/NeKit/Variant.h @@ -8,8 +8,8 @@ #include <NeKit/Defines.h> #include <NeKit/Json.h> -#include <NeKit/TOML.h> #include <NeKit/KString.h> +#include <NeKit/TOML.h> #include <SwapKit/DiskSwap.h> namespace Kernel { @@ -17,7 +17,7 @@ class Variant final { public: enum class VariantKind { kInvalid = 0, - kString = 200, + kString = 200, kBlob, kNull, kJson, @@ -55,10 +55,10 @@ class Variant final { /// @brief Returns the underlying pointer. /// @return the underlying pointer. /// ======================================================================== - VoidPtr Leak(); + VoidPtr Leak(); template <typename T> - T* As() noexcept { + T* As() { return reinterpret_cast<T*>(fPtr); } diff --git a/src/kernel/NetworkKit/IPC.h b/src/kernel/NetworkKit/IPC.h index c08a9457..fb6a07ee 100644 --- a/src/kernel/NetworkKit/IPC.h +++ b/src/kernel/NetworkKit/IPC.h @@ -38,10 +38,10 @@ struct PACKED IPC_ADDR final { // some operators. //////////////////////////////////// - BOOL operator==(const IPC_ADDR& addr) noexcept; - BOOL operator==(IPC_ADDR& addr) noexcept; - BOOL operator!=(const IPC_ADDR& addr) noexcept; - BOOL operator!=(IPC_ADDR& addr) noexcept; + BOOL operator==(const IPC_ADDR& addr); + BOOL operator==(IPC_ADDR& addr); + BOOL operator!=(const IPC_ADDR& addr); + BOOL operator!=(IPC_ADDR& addr); }; typedef struct IPC_ADDR IPC_ADDR; @@ -73,7 +73,7 @@ typedef struct IPC_MSG final { UInt8 IpcData[kIPCMsgSize]; UInt32 IpcLock; /// @brief Passes the message to target, could be anything, HTTP packet, JSON or whatever. - static Bool Pass(IPC_MSG* self, IPC_MSG* target) noexcept; + static Bool Pass(IPC_MSG* self, IPC_MSG* target); } PACKED ALIGN(8) IPC_MSG; /// @brief Sanitize packet function diff --git a/src/kernel/StorageKit/SCSI.h b/src/kernel/StorageKit/SCSI.h index 12eb52d3..f31d36f0 100644 --- a/src/kernel/StorageKit/SCSI.h +++ b/src/kernel/StorageKit/SCSI.h @@ -6,9 +6,9 @@ #pragma once -#include <modules/SCSI/SCSI.h> #include <KernelKit/DriveMgr.h> #include <NeKit/OwnPtr.h> +#include <modules/SCSI/SCSI.h> namespace Kernel { class SCSIDeviceInterface final NE_DEVICE<IMountpoint*> { diff --git a/src/kernel/src/AsciiUtils.cc b/src/kernel/src/AsciiUtils.cc index 1f1ab0f6..525dfe7d 100644 --- a/src/kernel/src/AsciiUtils.cc +++ b/src/kernel/src/AsciiUtils.cc @@ -72,8 +72,7 @@ Void rt_zero_memory(voidPtr pointer, Size len) { #ifdef __NE_ENFORCE_DEPRECATED_WARNINGS [[deprecated("Use rt_set_memory_safe instead")]] #endif -voidPtr -rt_set_memory(voidPtr src, UInt32 value, Size len) { +voidPtr rt_set_memory(voidPtr src, UInt32 value, Size len) { if (!src) return nullptr; auto p = reinterpret_cast<UInt8*>(src); UInt8 v = static_cast<UInt8>(value & 0xFF); diff --git a/src/kernel/src/BinaryMutex.cc b/src/kernel/src/BinaryMutex.cc index 3c332b33..f3c580ec 100644 --- a/src/kernel/src/BinaryMutex.cc +++ b/src/kernel/src/BinaryMutex.cc @@ -12,7 +12,7 @@ namespace Kernel { /// @brief Unlocks the binary mutex. /***********************************************************************************/ -Bool BinaryMutex::Unlock() noexcept { +Bool BinaryMutex::Unlock() { if (fLockingProcess->Status == ProcessStatusKind::kRunning) { fLockingProcess = nullptr; @@ -61,7 +61,7 @@ Bool BinaryMutex::LockAndWait(USER_PROCESS* process, TimerInterface* timer) { /// @param sec seconds. /***********************************************************************************/ -BOOL BinaryMutex::WaitForProcess(const UInt32& sec) noexcept { +BOOL BinaryMutex::WaitForProcess(const UInt32& sec) { HardwareTimer hw_timer(rtl_milliseconds(sec)); hw_timer.Wait(); diff --git a/src/kernel/src/BitMapMgr.cc b/src/kernel/src/BitMapMgr.cc index d7ecb810..98e34afe 100644 --- a/src/kernel/src/BitMapMgr.cc +++ b/src/kernel/src/BitMapMgr.cc @@ -106,7 +106,7 @@ namespace HAL { this->GetBitMapStatus(ptr_bit_set); UInt32 flags = this->MakeMMFlags(wr, user); - mm_map_page(ptr_bit_set, (VoidPtr)mm_get_page_addr(ptr_bit_set), flags); + mm_map_page(ptr_bit_set, (VoidPtr) mm_get_page_addr(ptr_bit_set), flags); if (biggest < (size + pad)) biggest = size + pad; @@ -122,7 +122,7 @@ namespace HAL { this->GetBitMapStatus(ptr_bit_set); UInt32 flags = this->MakeMMFlags(wr, user); - mm_map_page(ptr_bit_set, (VoidPtr)mm_get_page_addr(ptr_bit_set), flags); + mm_map_page(ptr_bit_set, (VoidPtr) mm_get_page_addr(ptr_bit_set), flags); if (biggest < (size + pad)) biggest = (size + pad); diff --git a/src/kernel/src/CodeMgr.cc b/src/kernel/src/CodeMgr.cc index 7b7add6d..da9900aa 100644 --- a/src/kernel/src/CodeMgr.cc +++ b/src/kernel/src/CodeMgr.cc @@ -15,7 +15,7 @@ namespace Kernel { /// accessible. /// @param main the start of the process. /// @return The team's process id. -BOOL rtl_create_kernel_task(HAL::StackFramePtr task, const KID kid) noexcept { +BOOL rtl_create_kernel_task(HAL::StackFramePtr task, const KID kid) { if (!kid || task == nullptr) return FALSE; return KernelTaskHelper::Add(task, kid); } @@ -28,7 +28,7 @@ BOOL rtl_create_kernel_task(HAL::StackFramePtr task, const KID kid) noexcept { /// @return if the process was started or not. /***********************************************************************************/ -ProcessID rtl_create_user_process(rtl_main_kind main, const Char* process_name) noexcept { +ProcessID rtl_create_user_process(rtl_main_kind main, const Char* process_name) { if (!process_name || *process_name == 0) return kSchedInvalidPID; return UserProcessScheduler::The().Spawn(process_name, reinterpret_cast<VoidPtr>(main), nullptr); } diff --git a/src/kernel/src/Crc32.cc b/src/kernel/src/Crc32.cc index 88a9b73a..715d19b9 100644 --- a/src/kernel/src/Crc32.cc +++ b/src/kernel/src/Crc32.cc @@ -51,7 +51,7 @@ UInt32 kChecksumPolys[kCrcCnt] = { /// @param in the data to compute. /// @param len the length of the data. /// @return CRC32 of **in**. -UInt32 ke_calculate_crc32(const VoidPtr inp, Int32 len) noexcept { +UInt32 ke_calculate_crc32(const VoidPtr inp, Int32 len) { if (!inp) return ~0; UInt32 crc = 0xffffffff; diff --git a/src/kernel/src/DriveMgr.cc b/src/kernel/src/DriveMgr.cc index 8f2611a4..37e0a8a9 100644 --- a/src/kernel/src/DriveMgr.cc +++ b/src/kernel/src/DriveMgr.cc @@ -124,13 +124,13 @@ const Char* io_drv_kind(Void) { /// @brief Unimplemented drive function. /// @param pckt the packet to read. -Void io_drv_unimplemented(DriveTrait::DrivePacket& pckt) noexcept { +Void io_drv_unimplemented(DriveTrait::DrivePacket& pckt) { NE_UNUSED(pckt); } /// @brief Makes a new drive. /// @return the new blank drive. -DriveTrait io_construct_blank_drive() noexcept { +DriveTrait io_construct_blank_drive() { DriveTrait trait; constexpr auto kBlankDrive = "/media/blank/"; @@ -216,7 +216,7 @@ namespace Probe { /// @brief Fetches the main drive. /// @return the new drive. (returns kEPMDrive if EPM formatted) -DriveTrait io_construct_main_drive() noexcept { +DriveTrait io_construct_main_drive() { constexpr auto kMainDrive = "/media/main/"; DriveTrait trait; @@ -237,7 +237,7 @@ DriveTrait io_construct_main_drive() noexcept { /// @brief Replacement for io_construct_main_drive that works with IMountpoint. /// @return the new drive. (returns kEPMDrive if EPM formatted) -Void io_construct_main_drive(DriveTrait& trait) noexcept { +Void io_construct_main_drive(DriveTrait& trait) { constexpr auto kMainDrive = "/media/main/"; rt_copy_memory((VoidPtr) kMainDrive, trait.fName, rt_string_len(kMainDrive)); diff --git a/src/kernel/src/FS/NeFS+FileMgr.cc b/src/kernel/src/FS/NeFS+FileMgr.cc index 0fdabd6f..764093c1 100644 --- a/src/kernel/src/FS/NeFS+FileMgr.cc +++ b/src/kernel/src/FS/NeFS+FileMgr.cc @@ -243,7 +243,7 @@ _Output Bool NeFileSystemMgr::Rewind(NodePtr node) { } /// @brief Returns the parser of NeFS. -_Output NeFileSystemParser* NeFileSystemMgr::GetParser() noexcept { +_Output NeFileSystemParser* NeFileSystemMgr::GetParser() { return mParser; } diff --git a/src/kernel/src/FS/NeFS+FileSystemParser.cc b/src/kernel/src/FS/NeFS+FileSystemParser.cc index bfb8d63a..101a9b22 100644 --- a/src/kernel/src/FS/NeFS+FileSystemParser.cc +++ b/src/kernel/src/FS/NeFS+FileSystemParser.cc @@ -154,8 +154,8 @@ _Output BOOL NeFileSystemParser::CreateFork(_Input NEFS_FORK_STRUCT& the_fork) { /// @return the newly found fork. /***********************************************************************************/ _Output NEFS_FORK_STRUCT* NeFileSystemParser::FindFork(_Input NEFS_CATALOG_STRUCT* catalog, - _Input const Char* name, - _Input Boolean is_data) { + _Input const Char* name, + _Input Boolean is_data) { if (!catalog || !name) return nullptr; auto& drive = kMountpoint.A(); @@ -217,7 +217,7 @@ _Output NEFS_CATALOG_STRUCT* NeFileSystemParser::CreateCatalog(_Input const Char /// @param kind the catalog kind. /// @return catalog pointer. /***********************************************************************************/ -_Output NEFS_CATALOG_STRUCT* NeFileSystemParser::CreateCatalog(_Input const Char* name, +_Output NEFS_CATALOG_STRUCT* NeFileSystemParser::CreateCatalog(_Input const Char* name, _Input const Int32& flags, _Input const Int32& kind) { kout << "CreateCatalog(*...*)\r"; @@ -857,7 +857,7 @@ namespace Kernel::NeFS { /***********************************************************************************/ /// @brief Construct NeFS drives. /***********************************************************************************/ -Boolean fs_init_nefs(Void) noexcept { +Boolean fs_init_nefs(Void) { kout << "Creating OpenHeFS disk...\r"; kMountpoint.A() = io_construct_main_drive(); if (kMountpoint.A().fPacket.fPacketReadOnly == YES) diff --git a/src/kernel/src/FS/OpenHeFS+FileMgr.cc b/src/kernel/src/FS/OpenHeFS+FileMgr.cc index 7340514a..4c49ac11 100644 --- a/src/kernel/src/FS/OpenHeFS+FileMgr.cc +++ b/src/kernel/src/FS/OpenHeFS+FileMgr.cc @@ -182,7 +182,7 @@ _Output Bool HeFileSystemMgr::Rewind(NodePtr node) { } /// @brief Returns the parser of OpenHeFS. -_Output HeFileSystemParser* HeFileSystemMgr::GetParser() noexcept { +_Output HeFileSystemParser* HeFileSystemMgr::GetParser() { return mParser; } } // namespace Kernel diff --git a/src/kernel/src/FS/OpenHeFS+FileSystemParser.cc b/src/kernel/src/FS/OpenHeFS+FileSystemParser.cc index d6aeb992..ffa8a1f6 100644 --- a/src/kernel/src/FS/OpenHeFS+FileSystemParser.cc +++ b/src/kernel/src/FS/OpenHeFS+FileSystemParser.cc @@ -803,7 +803,8 @@ _Output Bool HeFileSystemParser::Format(_Input _Output DriveTrait* mnt, _Input c rt_string_len("fs/hefs-packet"), sizeof(mnt->fPacket.fPacketMime)); urt_copy_memory((VoidPtr) vol_name, boot->fVolName, urt_string_len(vol_name) + 1); - rt_copy_memory_safe((VoidPtr) kOpenHeFSMagic, boot->fMagic, kOpenHeFSMagicLen - 1, sizeof(boot->fMagic)); + rt_copy_memory_safe((VoidPtr) kOpenHeFSMagic, boot->fMagic, kOpenHeFSMagicLen - 1, + sizeof(boot->fMagic)); if (mnt->fLbaStart > mnt->fLbaEnd) { err_global_get() = kErrorDiskIsCorrupted; @@ -1145,7 +1146,7 @@ STATIC IMountpoint kMountpoint; /// @brief Initialize the OpenHeFS filesystem. /// @return To check its status, see err_local_get(). -Boolean OpenHeFS::fs_init_openhefs(Void) noexcept { +Boolean OpenHeFS::fs_init_openhefs(Void) { io_construct_main_drive(kMountpoint.A()); if (kMountpoint.A().fPacket.fPacketReadOnly == YES) { @@ -1153,7 +1154,8 @@ Boolean OpenHeFS::fs_init_openhefs(Void) noexcept { return YES; } - return HeFileSystemParser{}.Format(&kMountpoint.A(), kOpenHeFSEncodingFlagsUTF8, kOpenHeFSDefaultVolumeName); + return HeFileSystemParser{}.Format(&kMountpoint.A(), kOpenHeFSEncodingFlagsUTF8, + kOpenHeFSDefaultVolumeName); } } // namespace Kernel diff --git a/src/kernel/src/HardwareThreadScheduler.cc b/src/kernel/src/HardwareThreadScheduler.cc index 577659ba..d1adc490 100644 --- a/src/kernel/src/HardwareThreadScheduler.cc +++ b/src/kernel/src/HardwareThreadScheduler.cc @@ -41,14 +41,14 @@ HardwareThread::~HardwareThread() = default; /***********************************************************************************/ //! @brief returns the id of the thread. /***********************************************************************************/ -ThreadID& HardwareThread::ID() noexcept { +ThreadID& HardwareThread::ID() { return fID; } /***********************************************************************************/ //! @brief returns the kind of thread we have. /***********************************************************************************/ -ThreadKind& HardwareThread::Kind() noexcept { +ThreadKind& HardwareThread::Kind() { return fKind; } @@ -56,7 +56,7 @@ ThreadKind& HardwareThread::Kind() noexcept { //! @brief is the thread busy? //! @return whether the thread is busy or not. /***********************************************************************************/ -Bool HardwareThread::IsBusy() noexcept { +Bool HardwareThread::IsBusy() { return fBusy; } @@ -64,12 +64,12 @@ Bool HardwareThread::IsBusy() noexcept { /// @brief Get processor stack frame. /***********************************************************************************/ -HAL::StackFramePtr HardwareThread::StackFrame() noexcept { +HAL::StackFramePtr HardwareThread::StackFrame() { MUST_PASS(this->fStack); return this->fStack; } -Void HardwareThread::Busy(Bool busy) noexcept { +Void HardwareThread::Busy(Bool busy) { this->fBusy = busy; } @@ -81,7 +81,7 @@ HardwareThread::operator bool() { /// @brief Wakeup the processor. /***********************************************************************************/ -Void HardwareThread::Wake(const bool wakeup) noexcept { +Void HardwareThread::Wake(const bool wakeup) { this->fWakeup = wakeup; } @@ -107,7 +107,7 @@ Bool HardwareThread::Switch(HAL::StackFramePtr frame) { /***********************************************************************************/ ///! @brief Tells if processor is waked up. /***********************************************************************************/ -bool HardwareThread::IsWakeup() noexcept { +bool HardwareThread::IsWakeup() { return this->fWakeup; } @@ -133,7 +133,7 @@ HardwareThreadScheduler& HardwareThreadScheduler::The() { /***********************************************************************************/ /// @brief Get Stack Frame of AP. /***********************************************************************************/ -HAL::StackFramePtr HardwareThreadScheduler::Leak() noexcept { +HAL::StackFramePtr HardwareThreadScheduler::Leak() { return fThreadList[fCurrentThreadIdx].fStack; } @@ -160,7 +160,7 @@ Ref<HardwareThread*> HardwareThreadScheduler::operator[](SizeT idx) { * @return */ /***********************************************************************************/ -HardwareThreadScheduler::operator bool() noexcept { +HardwareThreadScheduler::operator bool() { return !fThreadList.Empty(); } @@ -170,7 +170,7 @@ HardwareThreadScheduler::operator bool() noexcept { * @return */ /***********************************************************************************/ -bool HardwareThreadScheduler::operator!() noexcept { +bool HardwareThreadScheduler::operator!() { return fThreadList.Empty(); } @@ -178,7 +178,7 @@ bool HardwareThreadScheduler::operator!() noexcept { /// @brief Returns the amount of core present. /// @return the number of APs. /***********************************************************************************/ -SizeT HardwareThreadScheduler::Capacity() noexcept { +SizeT HardwareThreadScheduler::Capacity() { return fThreadList.Count(); } } // namespace Kernel diff --git a/src/kernel/src/IDylibObject.cc b/src/kernel/src/IDylibObject.cc index 97aec28f..16c1261b 100644 --- a/src/kernel/src/IDylibObject.cc +++ b/src/kernel/src/IDylibObject.cc @@ -9,4 +9,3 @@ #include <KernelKit/DebugOutput.h> #include <KernelKit/IDylibObject.h> - diff --git a/src/kernel/src/IndexableProperty.cc b/src/kernel/src/IndexableProperty.cc index 85207d4b..c7a52f38 100644 --- a/src/kernel/src/IndexableProperty.cc +++ b/src/kernel/src/IndexableProperty.cc @@ -18,13 +18,21 @@ namespace Kernel { namespace Indexer { - Index& IndexableProperty::Leak() noexcept { return fIndex; } + Index& IndexableProperty::Leak() { + return fIndex; + } - Void IndexableProperty::AddFlag(UInt16 flag) { fFlags |= flag; } + Void IndexableProperty::AddFlag(UInt16 flag) { + fFlags |= flag; + } - Void IndexableProperty::RemoveFlag(UInt16 flag) { fFlags &= ~(flag); } + Void IndexableProperty::RemoveFlag(UInt16 flag) { + fFlags &= ~(flag); + } - UInt16 IndexableProperty::HasFlag(UInt16 flag) { return fFlags & flag; } + UInt16 IndexableProperty::HasFlag(UInt16 flag) { + return fFlags & flag; + } /// @brief Index a file into the indexer instance. /// @param filename filesystem path to access. diff --git a/src/kernel/src/KPC.cc b/src/kernel/src/KPC.cc index 4318b9cd..6862d589 100644 --- a/src/kernel/src/KPC.cc +++ b/src/kernel/src/KPC.cc @@ -14,7 +14,7 @@ STATIC Bool kRaiseOnBugCheck = false; /// @brief Does a system wide bug check. /// @param void no params are needed. /// @return if error-free: false, otherwise true. -Boolean err_bug_check_raise(Void) noexcept { +Boolean err_bug_check_raise(Void) { Char* ptr = new Char[512]; if (ptr == nullptr) goto bug_check_fail; diff --git a/src/kernel/src/Network/IPCAddress.cc b/src/kernel/src/Network/IPCAddress.cc index 2da5ac0a..deb1f473 100644 --- a/src/kernel/src/Network/IPCAddress.cc +++ b/src/kernel/src/Network/IPCAddress.cc @@ -9,19 +9,19 @@ #include <NetworkKit/IPC.h> namespace Kernel { -bool IPC_ADDR::operator==(const IPC_ADDR& addr) noexcept { +bool IPC_ADDR::operator==(const IPC_ADDR& addr) { return addr.UserProcessID == this->UserProcessID && addr.UserProcessTeam == this->UserProcessTeam; } -bool IPC_ADDR::operator==(IPC_ADDR& addr) noexcept { +bool IPC_ADDR::operator==(IPC_ADDR& addr) { return addr.UserProcessID == this->UserProcessID && addr.UserProcessTeam == this->UserProcessTeam; } -bool IPC_ADDR::operator!=(const IPC_ADDR& addr) noexcept { +bool IPC_ADDR::operator!=(const IPC_ADDR& addr) { return addr.UserProcessID != this->UserProcessID || addr.UserProcessTeam != this->UserProcessTeam; } -bool IPC_ADDR::operator!=(IPC_ADDR& addr) noexcept { +bool IPC_ADDR::operator!=(IPC_ADDR& addr) { return addr.UserProcessID != this->UserProcessID || addr.UserProcessTeam != this->UserProcessTeam; } } // namespace Kernel diff --git a/src/kernel/src/Network/IPCMessage.cc b/src/kernel/src/Network/IPCMessage.cc index b376b7c8..d625e54a 100644 --- a/src/kernel/src/Network/IPCMessage.cc +++ b/src/kernel/src/Network/IPCMessage.cc @@ -100,7 +100,7 @@ Bool ipc_construct_packet(_Output IPC_MSG** pckt_in) { /// @param src Source message. /// @param target Target message. /***********************************************************************************/ -Bool IPC_MSG::Pass(IPC_MSG* src, IPC_MSG* target) noexcept { +Bool IPC_MSG::Pass(IPC_MSG* src, IPC_MSG* target) { if (src && target && (target != src)) { if (src->IpcMsgSz > target->IpcMsgSz) return No; if (target->IpcMsgSz > src->IpcMsgSz) return No; diff --git a/src/kernel/src/New+Delete.cc b/src/kernel/src/New+Delete.cc index ba37e7ec..2ff75643 100644 --- a/src/kernel/src/New+Delete.cc +++ b/src/kernel/src/New+Delete.cc @@ -19,13 +19,13 @@ void* operator new(size_t sz) { return Kernel::mm_alloc_ptr(sz, true, false); } -void operator delete[](void* ptr) noexcept { +void operator delete[](void* ptr) { if (ptr == nullptr) return; Kernel::mm_free_ptr(ptr); } -void operator delete(void* ptr) noexcept { +void operator delete(void* ptr) { if (ptr == nullptr) return; Kernel::mm_free_ptr(ptr); diff --git a/src/kernel/src/PE32CodeMgr.cc b/src/kernel/src/PE32CodeMgr.cc index a8440c23..0327f921 100644 --- a/src/kernel/src/PE32CodeMgr.cc +++ b/src/kernel/src/PE32CodeMgr.cc @@ -20,7 +20,7 @@ namespace Detail { /// @brief Get the PE32+ platform signature according to the compiled architecture. /***********************************************************************************/ - UInt32 ldr_get_platform_pe(void) noexcept { + UInt32 ldr_get_platform_pe(void) { #if defined(__NE_AMD64__) return kPEPlatformAMD64; #elif defined(__NE_ARM64__) @@ -183,7 +183,7 @@ ErrorOr<VoidPtr> PE32Loader::FindStart() { /// @brief Tells if the executable is loaded or not. /// @return Whether it's not bad and is cached. -bool PE32Loader::IsLoaded() noexcept { +bool PE32Loader::IsLoaded() { return !fBad && fCachedBlob; } @@ -216,7 +216,7 @@ ErrorOr<VoidPtr> PE32Loader::GetBlob() { } namespace Utils { - ProcessID rtl_create_user_process(PE32Loader& exec, const Int32& process_kind) noexcept { + ProcessID rtl_create_user_process(PE32Loader& exec, const Int32& process_kind) { auto errOrStart = exec.FindStart(); if (errOrStart.Error() != kErrorSuccess) return kSchedInvalidPID; diff --git a/src/kernel/src/PEFCodeMgr.cc b/src/kernel/src/PEFCodeMgr.cc index c0a79c32..05a4af01 100644 --- a/src/kernel/src/PEFCodeMgr.cc +++ b/src/kernel/src/PEFCodeMgr.cc @@ -31,7 +31,7 @@ namespace Detail { /***********************************************************************************/ /// @brief Get the PEF platform signature according to the compiled architecture. /***********************************************************************************/ - static UInt32 ldr_get_platform(void) noexcept { + static UInt32 ldr_get_platform(void) { #if defined(__NE_32X0__) return kPefArch32x0; #elif defined(__NE_64X0__) @@ -261,7 +261,7 @@ ErrorOr<VoidPtr> PEFLoader::FindStart() { /// @brief Tells if the executable is loaded or not. /// @return Whether it's not bad and is cached. -bool PEFLoader::IsLoaded() noexcept { +bool PEFLoader::IsLoaded() { return !fBad && fCachedBlob; } @@ -294,7 +294,7 @@ ErrorOr<VoidPtr> PEFLoader::GetBlob() { } namespace Utils { - ProcessID rtl_create_user_process(PEFLoader& exec, const Int32& process_kind) noexcept { + ProcessID rtl_create_user_process(PEFLoader& exec, const Int32& process_kind) { auto errOrStart = exec.FindStart(); if (errOrStart.Error() != kErrorSuccess) return kSchedInvalidPID; diff --git a/src/kernel/src/SoftwareTimer.cc b/src/kernel/src/SoftwareTimer.cc index eafe8db6..91d0e993 100644 --- a/src/kernel/src/SoftwareTimer.cc +++ b/src/kernel/src/SoftwareTimer.cc @@ -25,7 +25,7 @@ SoftwareTimer::~SoftwareTimer() { fWaitFor = 0; } -BOOL SoftwareTimer::Wait() noexcept { +BOOL SoftwareTimer::Wait() { if (fWaitFor < 1) return NO; while (*fDigitalTimer < (*fDigitalTimer + fWaitFor)) { diff --git a/src/kernel/src/ThreadLocalStorage.cc b/src/kernel/src/ThreadLocalStorage.cc index fa445d84..8e010b12 100644 --- a/src/kernel/src/ThreadLocalStorage.cc +++ b/src/kernel/src/ThreadLocalStorage.cc @@ -40,7 +40,7 @@ Boolean tls_check_tib(THREAD_INFORMATION_BLOCK* tib_ptr) { * @param tib_ptr The TIB record. * @return if the TIB record is valid or not. */ -EXTERN_C Bool tls_check_syscall_impl(Kernel::VoidPtr tib_ptr) noexcept { +EXTERN_C Bool tls_check_syscall_impl(Kernel::VoidPtr tib_ptr) { if (!tib_ptr) { kout << "TLS: Failed because of an invalid TIB...\r"; return No; diff --git a/src/kernel/src/Timer.cc b/src/kernel/src/Timer.cc index 648cc92b..ecfc8e08 100644 --- a/src/kernel/src/Timer.cc +++ b/src/kernel/src/Timer.cc @@ -14,6 +14,6 @@ using namespace Kernel; /// @brief Unimplemented as it is an interface. -BOOL TimerInterface::Wait() noexcept { +BOOL TimerInterface::Wait() { return NO; } diff --git a/src/kernel/src/UserMgr.cc b/src/kernel/src/UserMgr.cc index 103e8ec9..9759b6fd 100644 --- a/src/kernel/src/UserMgr.cc +++ b/src/kernel/src/UserMgr.cc @@ -76,7 +76,7 @@ User::User(const UserRingKind& ring_kind, const Char* user_name) : mUserRing(rin //////////////////////////////////////////////////////////// User::~User() = default; -Bool User::Save(const UserPublicKey password) noexcept { +Bool User::Save(const UserPublicKey password) { if (!password || *password == 0) return No; this->mUserFNV = Detail::user_fnv_generator(password, this); @@ -86,7 +86,7 @@ Bool User::Save(const UserPublicKey password) noexcept { return Yes; } -Bool User::Login(const UserPublicKey password) noexcept { +Bool User::Login(const UserPublicKey password) { if (!password || !*password) return No; auto ret = this->mUserFNV == Detail::user_fnv_generator(password, this); @@ -108,7 +108,7 @@ Bool User::operator!=(const User& lhs) { /// @brief Returns the user's name. //////////////////////////////////////////////////////////// -Char* User::Name() noexcept { +Char* User::Name() { return this->mUserName; } @@ -117,15 +117,15 @@ Char* User::Name() noexcept { /// @return The king of ring the user is attached to. //////////////////////////////////////////////////////////// -const UserRingKind& User::Ring() noexcept { +const UserRingKind& User::Ring() { return this->mUserRing; } -Bool User::IsStdUser() noexcept { +Bool User::IsStdUser() { return this->Ring() == UserRingKind::kRingStdUser; } -Bool User::IsSuperUser() noexcept { +Bool User::IsSuperUser() { return this->Ring() == UserRingKind::kRingSuperUser; } } // namespace Kernel diff --git a/src/kernel/src/UserProcessScheduler.cc b/src/kernel/src/UserProcessScheduler.cc index 264bddf3..7c2d6d6a 100644 --- a/src/kernel/src/UserProcessScheduler.cc +++ b/src/kernel/src/UserProcessScheduler.cc @@ -59,7 +59,7 @@ USER_PROCESS::operator bool() { /// @return Int32 the last exit code. /***********************************************************************************/ -KPCError& USER_PROCESS::GetExitCode() noexcept { +KPCError& USER_PROCESS::GetExitCode() { return this->LastExitCode; } @@ -67,7 +67,7 @@ KPCError& USER_PROCESS::GetExitCode() noexcept { /// @brief Error code variable getter. /***********************************************************************************/ -KPCError& USER_PROCESS::GetLocalCode() noexcept { +KPCError& USER_PROCESS::GetLocalCode() { return this->LocalCode; } @@ -122,7 +122,7 @@ ErrorOr<VoidPtr> USER_PROCESS::New(SizeT sz, SizeT pad_amount) { hal_write_cr3(vm_register); #else - auto ptr = mm_alloc_ptr(sz, Yes, Yes, pad_amount); + auto ptr = mm_alloc_ptr(sz, Yes, Yes, pad_amount); #endif if (!this->HeapTree) { @@ -203,7 +203,7 @@ ErrorOr<VoidPtr> USER_PROCESS::New(SizeT sz, SizeT pad_amount) { /// @brief Gets the name of the current process. /***********************************************************************************/ -const Char* USER_PROCESS::GetName() noexcept { +const Char* USER_PROCESS::GetName() { return this->Name; } @@ -211,12 +211,12 @@ const Char* USER_PROCESS::GetName() noexcept { /// @brief Gets the owner of the process. /***********************************************************************************/ -const User* USER_PROCESS::GetOwner() noexcept { +const User* USER_PROCESS::GetOwner() { return this->Owner; } /// @brief USER_PROCESS status getter. -const ProcessStatusKind& USER_PROCESS::GetStatus() noexcept { +const ProcessStatusKind& USER_PROCESS::GetStatus() { return this->Status; } @@ -226,7 +226,7 @@ const ProcessStatusKind& USER_PROCESS::GetStatus() noexcept { */ /***********************************************************************************/ -const AffinityKind& USER_PROCESS::GetAffinity() noexcept { +const AffinityKind& USER_PROCESS::GetAffinity() { return this->Affinity; } @@ -492,7 +492,7 @@ Bool UserProcessScheduler::HasMP() { /// @return USER_PROCESS count executed within a team. /***********************************************************************************/ -SizeT UserProcessScheduler::Run() noexcept { +SizeT UserProcessScheduler::Run() { if (mTeam.mProcessCur < 1) { return 0UL; } diff --git a/src/kernel/src/UserProcessTeam.cc b/src/kernel/src/UserProcessTeam.cc index e5b7a7eb..9b124d75 100644 --- a/src/kernel/src/UserProcessTeam.cc +++ b/src/kernel/src/UserProcessTeam.cc @@ -40,7 +40,7 @@ Array<USER_PROCESS, kSchedProcessLimitPerTeam>& UserProcessTeam::AsArray() { /// @return The team's ID. /***********************************************************************************/ -ProcessID& UserProcessTeam::Id() noexcept { +ProcessID& UserProcessTeam::Id() { return this->mTeamId; } diff --git a/src/libDDK/DriverKit/c++/ddk.h b/src/libDDK/DriverKit/c++/ddk.h index 2c83f935..d8576a57 100644 --- a/src/libDDK/DriverKit/c++/ddk.h +++ b/src/libDDK/DriverKit/c++/ddk.h @@ -9,5 +9,5 @@ #pragma once +#include <DriverKit/c++/checksum.h> #include <DriverKit/c++/driver_base.h> -#include <DriverKit/c++/checksum.h> diff --git a/src/libDDK/DriverKit/c++/driver_base.h b/src/libDDK/DriverKit/c++/driver_base.h index 89cc04d8..a0c22216 100644 --- a/src/libDDK/DriverKit/c++/driver_base.h +++ b/src/libDDK/DriverKit/c++/driver_base.h @@ -29,10 +29,10 @@ class IDriverBase { using PtrType = VoidPtr; - virtual BOOL IsCastable() { return NO; } - virtual constexpr BOOL IsActive() { return NO; } - virtual PtrType Leak() { return nullptr; } - virtual constexpr Int32 Type() { return 0; } + virtual BOOL IsCastable() { return NO; } + virtual constexpr BOOL IsActive() { return NO; } + virtual PtrType Leak() { return nullptr; } + virtual constexpr Int32 Type() { return 0; } }; /// @brief This concept requires the Driver to be IDriverBase compliant. @@ -43,6 +43,6 @@ concept IsValidDriver = requires(T a) { /// @brief Consteval helper to detect whether a template is truly based on IDriverBase. /// @note This helper is consteval only. -template<IsValidDriver T> +template <IsValidDriver T> inline consteval void ce_ddk_is_valid(T) {} } // namespace Kernel::DDK diff --git a/src/libDDK/src/ddk_kernel_call.c b/src/libDDK/src/ddk_kernel_call.c index 92652969..f4bf9130 100644 --- a/src/libDDK/src/ddk_kernel_call.c +++ b/src/libDDK/src/ddk_kernel_call.c @@ -12,8 +12,8 @@ #include <stdarg.h> /// @brief this is an internal call, do not use it. -DDK_EXTERN ATTRIBUTE(naked) ptr_t - __ke_call_dispatch(const int32_t name, int32_t cnt, void* data, size_t sz); +DDK_EXTERN ATTRIBUTE(naked) +ptr_t __ke_call_dispatch(const int32_t name, int32_t cnt, void* data, size_t sz); /// @brief This function hashes the path into a FNV symbol. /// @param path the path to hash. diff --git a/src/libSystem/SystemKit/Macros.h b/src/libSystem/SystemKit/Macros.h index aac2bf1b..b30db701 100644 --- a/src/libSystem/SystemKit/Macros.h +++ b/src/libSystem/SystemKit/Macros.h @@ -94,7 +94,7 @@ typedef nullPtr NullPtr; #endif #ifndef kib_cast -#define kib_cast(X) (UInt64)((X) *1024) +#define kib_cast(X) (UInt64)((X) * 1024) #endif #ifndef MIB diff --git a/src/modules/CoreGfx/CoreAccess.h b/src/modules/CoreGfx/CoreAccess.h index 942a1ad5..c0ebf255 100644 --- a/src/modules/CoreGfx/CoreAccess.h +++ b/src/modules/CoreGfx/CoreAccess.h @@ -24,9 +24,9 @@ class CGAccessibilty final { public: NE_COPY_DELETE(CGAccessibilty) - static UInt64 Width() noexcept { return kHandoverHeader->f_GOP.f_Width; } + static UInt64 Width() { return kHandoverHeader->f_GOP.f_Width; } - static UInt64 Height() noexcept { return kHandoverHeader->f_GOP.f_Height; } + static UInt64 Height() { return kHandoverHeader->f_GOP.f_Height; } }; } // namespace FB diff --git a/src/modules/CoreGfx/CoreGfx.h b/src/modules/CoreGfx/CoreGfx.h index e1bfe462..c217fbe3 100644 --- a/src/modules/CoreGfx/CoreGfx.h +++ b/src/modules/CoreGfx/CoreGfx.h @@ -111,7 +111,7 @@ #endif // ifndef CORE_GFX_ACCESSIBILITY_H namespace FB { -inline Void cg_clear_video() noexcept { +inline Void cg_clear_video() { FBDrawInRegion(cg_get_clear_clr(), FB::CGAccessibilty::Height(), FB::CGAccessibilty::Width(), 0, 0); } diff --git a/tools/chk.hefs.cc b/tools/chk.hefs.cc index 41c04b0f..a520d231 100644 --- a/tools/chk.hefs.cc +++ b/tools/chk.hefs.cc @@ -57,8 +57,8 @@ int main(int argc, char** argv) { output_device.read(reinterpret_cast<char*>(&boot_node), sizeof(boot_node)); - if (strncmp(boot_node.magic, kOpenHeFSMagic, kOpenHeFSMagicLen) != 0 || boot_node.sectorCount < 1 || - boot_node.sectorSize < kMkFsSectorSz) { + if (strncmp(boot_node.magic, kOpenHeFSMagic, kOpenHeFSMagicLen) != 0 || + boot_node.sectorCount < 1 || boot_node.sectorSize < kMkFsSectorSz) { mkfs::console_out() << "hefs: error: Device is not an OpenHeFS disk: " << opt_disk << "\n"; return EXIT_FAILURE; } diff --git a/tools/mkfs.hefs.cc b/tools/mkfs.hefs.cc index 507d9bab..6cf71bd1 100644 --- a/tools/mkfs.hefs.cc +++ b/tools/mkfs.hefs.cc @@ -153,8 +153,8 @@ int main(int argc, char** argv) { "BootNode::magic too small to hold kOpenHeFSMagicLen"); std::memset(boot_node.magic, 0, sizeof(boot_node.magic)); - size_t magic_copy = - (sizeof(boot_node.magic) < kOpenHeFSMagicLen - 1) ? sizeof(boot_node.magic) : (kOpenHeFSMagicLen - 1); + size_t magic_copy = (sizeof(boot_node.magic) < kOpenHeFSMagicLen - 1) ? sizeof(boot_node.magic) + : (kOpenHeFSMagicLen - 1); std::memcpy(boot_node.magic, kOpenHeFSMagic, magic_copy); boot_node.magic[magic_copy] = 0; |