MHR-31: Lots of fixes and improvements regarding the kernel.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>

15 files changed, 114 insertions, 145 deletions

diff --git a/Kernel/ArchKit/ArchKit.hpp b/Kernel/ArchKit/ArchKit.hpp
index c2e5a967..6407a0d8 100644
--- a/Kernel/ArchKit/ArchKit.hpp
+++ b/Kernel/ArchKit/ArchKit.hpp
@@ -79,7 +79,7 @@ namespace NewOS
 
 #define kKernelMaxSystemCalls (256)
 
-typedef NewOS::Void (*rt_syscall_proc)(NewOS::HAL::StackFramePtr);
+typedef NewOS::Void (*rt_syscall_proc)(NewOS::VoidPtr);
 
 struct RTSyscallInfoHdr final
 {
@@ -95,7 +95,7 @@ inline NewOS::Array<RTSyscallInfoHdr,
 inline NewOS::Array<RTSyscallInfoHdr,
 					kKernelMaxSystemCalls>
 	kKerncalls;
-	
+
 EXTERN_C NewOS::HAL::StackFramePtr rt_get_current_context();
 EXTERN_C NewOS::Void rt_do_context_switch(NewOS::HAL::StackFramePtr stackFrame);
 
diff --git a/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp b/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
index a21a4c47..51570b86 100644
--- a/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
+++ b/Kernel/HALKit/AMD64/HalCoreInterruptHandlerAMD64.cpp
@@ -12,11 +12,6 @@
 /// @param rsp
 EXTERN_C void idt_handle_gpf(NewOS::UIntPtr rsp)
 {
-	MUST_PASS(NewOS::ProcessScheduler::The().Leak().GetCurrent());
-
-	NewOS::kcout << "newoskrnl: Stack Pointer: "
-				 << NewOS::StringBuilder::FromInt("rsp{%}", rsp);
-
 	NewOS::kcout
 		<< "newoskrnl: General Protection Fault, caused by "
 		<< NewOS::ProcessScheduler::The().Leak().GetCurrent().Leak().GetName();
@@ -28,9 +23,6 @@ EXTERN_C void idt_handle_gpf(NewOS::UIntPtr rsp)
 /// @param rsp
 EXTERN_C void idt_handle_pf(NewOS::UIntPtr rsp)
 {
-	MUST_PASS(NewOS::ProcessScheduler::The().Leak().GetCurrent());
-	NewOS::kcout << NewOS::StringBuilder::FromInt("rsp{%}", rsp);
-
 	NewOS::kcout
 		<< "newoskrnl: Segmentation Fault, caused by "
 		<< NewOS::ProcessScheduler::The().Leak().GetCurrent().Leak().GetName();
@@ -42,9 +34,6 @@ EXTERN_C void idt_handle_pf(NewOS::UIntPtr rsp)
 /// @param rsp
 EXTERN_C void idt_handle_math(NewOS::UIntPtr rsp)
 {
-	MUST_PASS(NewOS::ProcessScheduler::The().Leak().GetCurrent());
-	NewOS::kcout << NewOS::StringBuilder::FromInt("rsp{%}", rsp);
-
 	NewOS::kcout
 		<< "newoskrnl: Math error, caused by "
 		<< NewOS::ProcessScheduler::The().Leak().GetCurrent().Leak().GetName();
@@ -56,9 +45,6 @@ EXTERN_C void idt_handle_math(NewOS::UIntPtr rsp)
 /// @param rsp
 EXTERN_C void idt_handle_generic(NewOS::UIntPtr rsp)
 {
-	MUST_PASS(NewOS::ProcessScheduler::The().Leak().GetCurrent());
-	NewOS::kcout << NewOS::StringBuilder::FromInt("sp{%}", rsp);
-
 	NewOS::kcout
 		<< "newoskrnl: Execution error, caused by "
 		<< NewOS::ProcessScheduler::The().Leak().GetCurrent().Leak().GetName();
@@ -70,11 +56,6 @@ EXTERN_C void idt_handle_generic(NewOS::UIntPtr rsp)
 /// @param rsp
 EXTERN_C void idt_handle_ud(NewOS::UIntPtr rsp)
 {
-	MUST_PASS(NewOS::ProcessScheduler::The().Leak().GetCurrent());
-
-	NewOS::kcout << "newoskrnl: Stack Pointer: "
-				 << NewOS::StringBuilder::FromInt("rsp{%}", rsp);
-
 	NewOS::kcout
 		<< "newoskrnl: Invalid interrupt, caused by "
 		<< NewOS::ProcessScheduler::The().Leak().GetCurrent().Leak().GetName();
@@ -91,10 +72,8 @@ EXTERN_C NewOS::Void hal_system_call_enter(NewOS::UIntPtr rcx, NewOS::UIntPtr rd
 	{
 		NewOS::kcout << "newoskrnl: syscall: enter.\r";
 
-		NewOS::kcout << "rcx: " << NewOS::number(rcx) << NewOS::endl; 
-
-		if (kSyscalls[rcx].Leak().Leak().fHooked)
-			(kSyscalls[rcx].Leak().Leak().fProc)((NewOS::HAL::StackFramePtr)rdx);
+		if (kSyscalls[rcx].Leak().Leak()->fHooked)
+			(kSyscalls[rcx].Leak().Leak()->fProc)((NewOS::VoidPtr)rdx);
 
 		NewOS::kcout << "newoskrnl: syscall: exit.\r";
 	}
diff --git a/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp b/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
index e2520332..c15a7b55 100644
--- a/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
+++ b/Kernel/HALKit/AMD64/HalCoreMultiProcessingAMD64.cpp
@@ -16,9 +16,6 @@
 #define kAPIC_SIPI_Vector 0x00500
 #define kAPIC_EIPI_Vector 0x00400
 
-/// @brief This symbol is the kernel main symbol.
-EXTERN_C void KeMain();
-
 /// @brief assembly routine. internal use only.
 EXTERN_C void _hal_enable_smp(void);
 
@@ -159,9 +156,7 @@ namespace NewOS::HAL
 
 	EXTERN_C Void hal_apic_acknowledge_cont(Void)
 	{
-		/// TODO: better init code.
-		KeMain();
-
+	    ProcessHelper::StartScheduling();
 		_hal_spin_core();
 	}
 
diff --git a/Kernel/HALKit/AMD64/HalHardwareMP.cpp b/Kernel/HALKit/AMD64/HalHart.cpp
index 92e075aa..92e075aa 100644
--- a/Kernel/HALKit/AMD64/HalHardwareMP.cpp
+++ b/Kernel/HALKit/AMD64/HalHart.cpp
diff --git a/Kernel/HALKit/AMD64/HalInterruptAPI.asm b/Kernel/HALKit/AMD64/HalInterruptAPI.asm
index e88ffc0d..150cfc10 100644
--- a/Kernel/HALKit/AMD64/HalInterruptAPI.asm
+++ b/Kernel/HALKit/AMD64/HalInterruptAPI.asm
@@ -201,11 +201,15 @@ IntNormal 49
 __NEW_INT_50:
     cli
 
+    push rcx
+    push rdx
     push rax
 
     call hal_system_call_enter
 
     pop rax
+    pop rdx
+    pop rcx
 
     sti
     iretq
@@ -213,47 +217,19 @@ __NEW_INT_50:
 __NEW_INT_51:
     cli
 
-    push 0
-    push 51
-    push rax
     push rcx
     push rdx
-    push rbx
-    push rbp
-    push rsi
-    push rdi
     push r8
     push r9
-    push r10
-    push r11
-    push r12
-    push r13
-    push r14
-    push r15
-    push gs
-    push fs
-
-    mov rcx, rbp
+    push rax
 
     call hal_kernel_call_enter
 
-    pop fs
-    pop gs
-    pop r15
-    pop r14
-    pop r13
-    pop r12
-    pop r11
-    pop r10
+    pop rax
     pop r9
     pop r8
-    pop rdi
-    pop rsi
-    pop rbp
-    pop rbx
     pop rdx
     pop rcx
-    pop rax
 
     sti
     iretq
@@ -278,13 +254,18 @@ IntNormal 60
 ;; testing interrupts.
 _ke_power_on_self_test:
     mov rcx, 0x10
-    int 0x32
-    int 0x32
-    int 0x32
+    mov rdx, _ke_string_post
+
     int 0x32
 
     ret
 
+section .data
+_ke_string_post:
+    db "POST has been successful.", 0
+
+section .text
+
 [global hal_load_gdt]
 
 hal_load_gdt:
diff --git a/Kernel/HALKit/AMD64/HalKernelMain.cxx b/Kernel/HALKit/AMD64/HalKernelMain.cxx
index 708004b3..6f01734e 100644
--- a/Kernel/HALKit/AMD64/HalKernelMain.cxx
+++ b/Kernel/HALKit/AMD64/HalKernelMain.cxx
@@ -14,6 +14,10 @@
 #include <KernelKit/ProcessScheduler.hxx>
 #include <KernelKit/UserHeap.hpp>
 #include <NewKit/Json.hpp>
+#include <KernelKit/CodeManager.hpp>
+
+/// @brief This symbol is the kernel main symbol.
+EXTERN_C void KeMain();
 
 EXTERN_C NewOS::VoidPtr kInterruptVectorTable[];
 
@@ -72,13 +76,24 @@ EXTERN_C void hal_init_platform(
 
 	/// START POST
 
+	constexpr auto cDummyInterrupt = 0x10; // 16
+
+	kSyscalls[cDummyInterrupt].Leak().Leak()->fProc = [](NewOS::VoidPtr sf) -> void {
+	    const char* msg = (const char*)sf;
+	    NewOS::kcout << "newoskrnl: " << msg << "\r";
+	};
+
+	kSyscalls[cDummyInterrupt].Leak().Leak()->fHooked = true;
+
 	NewOS::HAL::Detail::_ke_power_on_self_test();
 
+	auto cLoaderName = "newoskrnl";
+	NewOS::execute_from_image(KeMain, cLoaderName);
+
 	NewOS::HAL::hal_system_get_cores(kHandoverHeader->f_HardwareTables.f_RsdPtr);
 
 	NewOS::kcout << "newoskrnl: We're done here...\r";
 
 	while (true)
-	{
-	}
+	{}
 }
diff --git a/Kernel/HALKit/AMD64/PCI/Iterator.cxx b/Kernel/HALKit/AMD64/PCI/Iterator.cxx
index 8675f171..297aa89c 100644
--- a/Kernel/HALKit/AMD64/PCI/Iterator.cxx
+++ b/Kernel/HALKit/AMD64/PCI/Iterator.cxx
@@ -7,8 +7,8 @@
 #include <KernelKit/PCI/Iterator.hpp>
 
 #define PCI_ITERATOR_FIND_AND_UNWRAP(DEV, SZ) \
-	if (DEV.Leak())                           \
-		return DEV.Leak();
+	if (DEV.Leak().Leak())                           \
+		return *DEV.Leak().Leak();
 
 namespace NewOS::PCI
 {
@@ -25,7 +25,7 @@ namespace NewOS::PCI
 
 					if (dev.Class() == (UChar)type)
 					{
-						fDevices[bus].Leak().Leak() = dev;
+						*fDevices[bus].Leak().Leak() = dev;
 					}
 				}
 			}
diff --git a/Kernel/KernelKit/ProcessScheduler.hxx b/Kernel/KernelKit/ProcessScheduler.hxx
index c6e090e4..8c1971b0 100644
--- a/Kernel/KernelKit/ProcessScheduler.hxx
+++ b/Kernel/KernelKit/ProcessScheduler.hxx
@@ -17,7 +17,7 @@
 #define kSchedMinMicroTime (AffinityKind::kHartStandard)
 #define kSchedInvalidPID   (-1)
 
-#define kSchedProcessLimitPerTeam (100U)
+#define kSchedProcessLimitPerTeam (16U)
 
 ////////////////////////////////////////////////////
 
@@ -134,7 +134,6 @@ namespace NewOS
 		explicit ProcessHeader(VoidPtr startImage = nullptr)
 			: Image(startImage)
 		{
-			MUST_PASS(startImage);
 		}
 
 		~ProcessHeader() = default;
@@ -145,7 +144,7 @@ namespace NewOS
 		void SetEntrypoint(UIntPtr& imageStart) noexcept;
 
 	public:
-		Char			   Name[kProcessLen] = {"NewOS Process"};
+		Char			   Name[kProcessLen] = {"Process"};
 		ProcessSubsystem   SubSystem{ProcessSubsystem::eProcessSubsystemInvalid};
 		ProcessSelector	   Selector{ProcessSelector::kRingUser};
 		HAL::StackFramePtr StackFrame{nullptr};
@@ -240,23 +239,15 @@ namespace NewOS
 	/// The main class which you call to schedule an app.
 	class ProcessScheduler final
 	{
-	private:
-		explicit ProcessScheduler() = default;
+	    explicit ProcessScheduler() = default;
 
 	public:
 		~ProcessScheduler() = default;
 
 		NEWOS_COPY_DEFAULT(ProcessScheduler)
 
-		operator bool()
-		{
-			return mTeam.AsArray().Count() > 0;
-		}
-
-		bool operator!()
-		{
-			return mTeam.AsArray().Count() == 0;
-		}
+		operator bool();
+		bool operator!();
 
 	public:
 		ProcessTeam& CurrentTeam();
diff --git a/Kernel/KernelKit/SMPManager.hpp b/Kernel/KernelKit/SMPManager.hpp
index 985050f1..ba706cf6 100644
--- a/Kernel/KernelKit/SMPManager.hpp
+++ b/Kernel/KernelKit/SMPManager.hpp
@@ -94,11 +94,11 @@ namespace NewOS
 		NEWOS_COPY_DEFAULT(SMPManager);
 
 	public:
-		bool			   Switch(HAL::StackFrame* the);
-		HAL::StackFramePtr GetStackFrame() noexcept;
+		bool			   Switch(HAL::StackFramePtr the);
+		HAL::StackFramePtr Leak() noexcept;
 
 	public:
-		Ref<HardwareThread> operator[](const SizeT& idx);
+		Ref<HardwareThread*> operator[](const SizeT& idx);
 		bool				operator!() noexcept;
 							operator bool() noexcept;
 
diff --git a/Kernel/NewKit/Array.hpp b/Kernel/NewKit/Array.hpp
index 1c89f365..dca5c13f 100644
--- a/Kernel/NewKit/Array.hpp
+++ b/Kernel/NewKit/Array.hpp
@@ -21,13 +21,13 @@ namespace NewOS
 		Array& operator=(const Array&) = default;
 		Array(const Array&)			   = default;
 
-		ErrorOr<T> operator[](Size At)
+		ErrorOr<T*> operator[](Size At)
 		{
 			if (At > N)
 				return {};
 
 			kcout << "Returning element\r";
-			return ErrorOr<T>(fArray[At]);
+			return ErrorOr<T*>(&fArray[At]);
 		}
 
 		Boolean Empty() const
diff --git a/Kernel/NewKit/MutableArray.hpp b/Kernel/NewKit/MutableArray.hpp
index f9c79301..a3ad4cb1 100644
--- a/Kernel/NewKit/MutableArray.hpp
+++ b/Kernel/NewKit/MutableArray.hpp
@@ -170,6 +170,13 @@ namespace NewOS
 		Boolean Add(const T val)
 		{
 			auto* iterationNode = fFirstNode;
+
+			if (!iterationNode)
+			{
+    			fFirstNode = new  MutableLinkedList<T>();
+    			iterationNode = fFirstNode;
+			}
+
 			MUST_PASS(iterationNode);
 
 			while (iterationNode)
diff --git a/Kernel/Sources/HError.cxx b/Kernel/Sources/HError.cxx
index 937e983a..1f36d020 100644
--- a/Kernel/Sources/HError.cxx
+++ b/Kernel/Sources/HError.cxx
@@ -13,6 +13,7 @@ namespace NewOS
 	/// @return if error-free: true, otherwise false.
 	Boolean ke_bug_check(void) noexcept
 	{
-		return true;
+	/// TODO:
+		return false;
 	}
 } // namespace NewOS
diff --git a/Kernel/Sources/KeMain.cxx b/Kernel/Sources/KeMain.cxx
index e2f41464..60494ee3 100644
--- a/Kernel/Sources/KeMain.cxx
+++ b/Kernel/Sources/KeMain.cxx
@@ -220,9 +220,4 @@ EXTERN_C NewOS::Void KeMain(NewOS::Void)
 
 	auto cLoaderName = "SystemLauncher";
 	NewOS::execute_from_image(NewOS::Detail::SystemLauncher_Main, cLoaderName);
-
-	while (true)
-	{
-		NewOS::ProcessScheduler::The().Leak().Run();
-	}
 }
diff --git a/Kernel/Sources/ProcessScheduler.cxx b/Kernel/Sources/ProcessScheduler.cxx
index 08a7971e..7008eafe 100644
--- a/Kernel/Sources/ProcessScheduler.cxx
+++ b/Kernel/Sources/ProcessScheduler.cxx
@@ -18,7 +18,7 @@
 ///! BUGS: 0
 
 /***********************************************************************************/
-/* This file handles the process scheduling.
+/* This file handles the process scheduling. */
 /***********************************************************************************/
 
 namespace NewOS
@@ -42,7 +42,8 @@ namespace NewOS
 
 	void ProcessHeader::Crash()
 	{
-		kcout << this->Name << ": crashed. (id = " << number(kErrorProcessFault);
+		kcout << (*this->Name == 0 ? "Unknown" : this->Name) << ": crashed. (id = ";
+		kcout.Number(kErrorProcessFault);
 		kcout << ")\r";
 
 		if (this->Ring != kRingUserKind)
@@ -201,9 +202,6 @@ namespace NewOS
 	/// @return
 	SizeT ProcessScheduler::Add(Ref<ProcessHeader>& process)
 	{
-		if (!process)
-			return -1;
-
 		if (!process.Leak().Image)
 		{
 			if (process.Leak().Kind != ProcessHeader::kShLibKind)
@@ -212,7 +210,7 @@ namespace NewOS
 			}
 		}
 
-		if (!mTeam.AsArray().Count() > kSchedProcessLimitPerTeam)
+		if (mTeam.AsArray().Count() > kSchedProcessLimitPerTeam)
 			return -kErrorOutOfTeamSlot;
 
 		kcout << "ProcessScheduler::Add(Ref<ProcessHeader>& process)\r";
@@ -262,8 +260,8 @@ namespace NewOS
 		{
 			auto process = mTeam.AsArray()[processIndex];
 
-			MUST_PASS(process); //! no need for a MUST_PASS(process.Leak());, it is
-								//! recursive because of the nature of the class;
+			if (!process)
+				continue;
 
 			//! run any process needed to be scheduled.
 			if (ProcessHelper::CanBeScheduled(process.Leak()))
@@ -351,22 +349,11 @@ namespace NewOS
 
 	bool ProcessHelper::StartScheduling()
 	{
-		if (ProcessHelper::CanBeScheduled(
-				ProcessScheduler::The().Leak().GetCurrent()))
-		{
-			--ProcessScheduler::The().Leak().GetCurrent().Leak().PTime;
-			return false;
-		}
-
-		auto processRef = ProcessScheduler::The().Leak();
-
-		if (!processRef)
-			return false; // we have nothing to schedule. simply return.
+		auto& processRef = ProcessScheduler::The().Leak();
+		SizeT ret		 = processRef.Run();
 
-		SizeT ret = processRef.Run();
-
-		kcout << StringBuilder::FromInt(
-			"ProcessHelper::StartScheduling() Iterated over {%} jobs inside team.\r", ret);
+		kcout << "newoskrnl: Iterated over: " << number(ret);
+		kcout << " processes.\r";
 
 		return true;
 	}
@@ -384,30 +371,42 @@ namespace NewOS
 
 		for (SizeT index = 0UL; index < SMPManager::The().Leak().Count(); ++index)
 		{
-			if (SMPManager::The().Leak()[index].Leak().Kind() == kInvalidHart)
+			if (SMPManager::The().Leak()[index].Leak()->Kind() == kInvalidHart)
 				continue;
 
-			if (SMPManager::The().Leak()[index].Leak().StackFrame() == the_stack)
+			if (SMPManager::The().Leak()[index].Leak()->StackFrame() == the_stack)
 			{
-				SMPManager::The().Leak()[index].Leak().Busy(false);
+				SMPManager::The().Leak()[index].Leak()->Busy(false);
 				continue;
 			}
 
-			if (SMPManager::The().Leak()[index].Leak().IsBusy())
+			if (SMPManager::The().Leak()[index].Leak()->IsBusy())
 				continue;
 
-			if (SMPManager::The().Leak()[index].Leak().Kind() !=
+			if (SMPManager::The().Leak()[index].Leak()->Kind() !=
 					ThreadKind::kHartBoot &&
-				SMPManager::The().Leak()[index].Leak().Kind() !=
+				SMPManager::The().Leak()[index].Leak()->Kind() !=
 					ThreadKind::kHartSystemReserved)
 			{
-				SMPManager::The().Leak()[index].Leak().Busy(true);
+				SMPManager::The().Leak()[index].Leak()->Busy(true);
 				ProcessHelper::GetCurrentPID() = new_pid;
 
-				return SMPManager::The().Leak()[index].Leak().Switch(the_stack);
+				return SMPManager::The().Leak()[index].Leak()->Switch(the_stack);
 			}
 		}
 
 		return false;
 	}
+
+	/// @brief this checks if any process is on the team.
+	ProcessScheduler::operator bool()
+	{
+		return mTeam.AsArray().Count() > 0;
+	}
+
+	/// @brief this checks if no process is on the team.
+	bool ProcessScheduler::operator!()
+	{
+		return mTeam.AsArray().Count() == 0;
+	}
 } // namespace NewOS
diff --git a/Kernel/Sources/SMPManager.cxx b/Kernel/Sources/SMPManager.cxx
index 99a3b025..683343ff 100644
--- a/Kernel/Sources/SMPManager.cxx
+++ b/Kernel/Sources/SMPManager.cxx
@@ -117,7 +117,7 @@ namespace NewOS
 		}
 
 		rt_do_context_switch(fStack);
-		
+
 		return true;
 	}
 
@@ -143,12 +143,12 @@ namespace NewOS
 	}
 
 	/// @brief Get Stack Frame of Core
-	HAL::StackFramePtr SMPManager::GetStackFrame() noexcept
+	HAL::StackFramePtr SMPManager::Leak() noexcept
 	{
 		if (fThreadList[fCurrentThread].Leak() &&
 			ProcessHelper::GetCurrentPID() ==
-				fThreadList[fCurrentThread].Leak().Leak().fPID)
-			return fThreadList[fCurrentThread].Leak().Leak().fStack;
+				fThreadList[fCurrentThread].Leak().Leak()->fPID)
+			return fThreadList[fCurrentThread].Leak().Leak()->fStack;
 
 		return nullptr;
 	}
@@ -163,35 +163,35 @@ namespace NewOS
 		{
 			// stack != nullptr -> if core is used, then continue.
 			if (!fThreadList[idx].Leak() ||
-				!fThreadList[idx].Leak().Leak().IsWakeup() ||
-				fThreadList[idx].Leak().Leak().IsBusy())
+				!fThreadList[idx].Leak().Leak()->IsWakeup() ||
+				fThreadList[idx].Leak().Leak()->IsBusy())
 				continue;
 
 			// to avoid any null deref.
-			if (!fThreadList[idx].Leak().Leak().fStack)
+			if (!fThreadList[idx].Leak().Leak()->fStack)
 				continue;
-			if (fThreadList[idx].Leak().Leak().fStack->Rsp == 0)
+			if (fThreadList[idx].Leak().Leak()->fStack->Rsp == 0)
 				continue;
-			if (fThreadList[idx].Leak().Leak().fStack->Rbp == 0)
+			if (fThreadList[idx].Leak().Leak()->fStack->Rbp == 0)
 				continue;
 
-			fThreadList[idx].Leak().Leak().Busy(true);
+			fThreadList[idx].Leak().Leak()->Busy(true);
 
-			fThreadList[idx].Leak().Leak().fID = idx;
+			fThreadList[idx].Leak().Leak()->fID = idx;
 
 			/// I figured out this:
 			/// Allocate stack
 			/// Set APIC base to stack
 			/// Do stuff and relocate stack based on this code.
 			/// - Amlel
-			rt_copy_memory(stack, fThreadList[idx].Leak().Leak().fStack,
+			rt_copy_memory(stack, fThreadList[idx].Leak().Leak()->fStack,
 						   sizeof(HAL::StackFrame));
 
-			fThreadList[idx].Leak().Leak().Switch(fThreadList[idx].Leak().Leak().fStack);
+			fThreadList[idx].Leak().Leak()->Switch(fThreadList[idx].Leak().Leak()->fStack);
 
-			fThreadList[idx].Leak().Leak().fPID = ProcessHelper::GetCurrentPID();
+			fThreadList[idx].Leak().Leak()->fPID = ProcessHelper::GetCurrentPID();
 
-			fThreadList[idx].Leak().Leak().Busy(false);
+			fThreadList[idx].Leak().Leak()->Busy(false);
 
 			return true;
 		}
@@ -204,19 +204,25 @@ namespace NewOS
 	 * @param idx the index
 	 * @return the reference to the hardware thread.
 	 */
-	Ref<HardwareThread> SMPManager::operator[](const SizeT& idx)
+	Ref<HardwareThread*> SMPManager::operator[](const SizeT& idx)
 	{
 		if (idx == 0)
 		{
-			if (fThreadList[idx].Leak().Leak().Kind() != kHartSystemReserved)
+			if (fThreadList[idx].Leak().Leak()->Kind() != kHartSystemReserved)
 			{
-				fThreadList[idx].Leak().Leak().fKind = kHartBoot;
+				fThreadList[idx].Leak().Leak()->fKind = kHartBoot;
 			}
 		}
 		else if (idx >= kMaxHarts)
 		{
-			HardwareThread fakeThread;
-			fakeThread.fKind = kInvalidHart;
+			static HardwareThread* fakeThread = new HardwareThread();
+
+			if (!fakeThread)
+			{
+			    fakeThread = new HardwareThread();
+			}
+
+			fakeThread->fKind = kInvalidHart;
 
 			return {fakeThread};
 		}