feat: warning fixes and Semaphore API patches.

what:

- The Semaphore API is being preppared for v0.0.4

Signed-off-by: Amlal <amlal@nekernel.org>

7 files changed, 12 insertions, 11 deletions

diff --git a/dev/kernel/KernelKit/CoreProcessScheduler.h b/dev/kernel/KernelKit/CoreProcessScheduler.h
index b92d7393..a7908b7d 100644
--- a/dev/kernel/KernelKit/CoreProcessScheduler.h
+++ b/dev/kernel/KernelKit/CoreProcessScheduler.h
@@ -98,7 +98,7 @@ struct PROCESS_FILE_TREE {
   struct PROCESS_FILE_TREE<T>* Prev {
     nullptr
   };
-  
+
   struct PROCESS_FILE_TREE<T>* Next {
     nullptr
   };
diff --git a/dev/kernel/KernelKit/FileMgr.h b/dev/kernel/KernelKit/FileMgr.h
index d1334277..f925a96c 100644
--- a/dev/kernel/KernelKit/FileMgr.h
+++ b/dev/kernel/KernelKit/FileMgr.h
@@ -22,7 +22,6 @@
 #ifndef INC_FILEMGR_H
 #define INC_FILEMGR_H
 
-
 /// @file FileMgr.h
 /// @brief File Manager.
 /// @author Amlal El Mahrouss (amlal@nekernel.org)
diff --git a/dev/kernel/KernelKit/HardwareThreadScheduler.h b/dev/kernel/KernelKit/HardwareThreadScheduler.h
index 76327a93..168a0cc1 100644
--- a/dev/kernel/KernelKit/HardwareThreadScheduler.h
+++ b/dev/kernel/KernelKit/HardwareThreadScheduler.h
@@ -100,7 +100,7 @@ class HardwareThreadScheduler final : public ISchedulable {
  public:
   Ref<HardwareThread*> operator[](SizeT idx);
   bool                 operator!() noexcept;
-                       operator bool() noexcept;
+  operator bool() noexcept;
 
   Bool IsUser() override { return Yes; }
 
diff --git a/dev/kernel/KernelKit/KernelTaskScheduler.h b/dev/kernel/KernelKit/KernelTaskScheduler.h
index 222041e8..c0879769 100644
--- a/dev/kernel/KernelKit/KernelTaskScheduler.h
+++ b/dev/kernel/KernelKit/KernelTaskScheduler.h
@@ -29,8 +29,9 @@ class KERNEL_TASK final {
   UInt8*             StackReserve{nullptr};
   SizeT              StackSize{kSchedMaxStackSz};
   PROCESS_IMAGE      Image{};
-  /// @brief a KID is a Kernel Identification Descriptor, it is used to find a task running within the kernel.
-  KID                Kid{0};
+  /// @brief a KID is a Kernel Identification Descriptor, it is used to find a task running within
+  /// the kernel.
+  KID Kid{0};
 };
 
 /// @brief Equivalent of UserProcessHelper, but for kernel tasks.
diff --git a/dev/kernel/KernelKit/LoaderInterface.h b/dev/kernel/KernelKit/LoaderInterface.h
index 1f9b1e56..ed7d8364 100644
--- a/dev/kernel/KernelKit/LoaderInterface.h
+++ b/dev/kernel/KernelKit/LoaderInterface.h
@@ -23,9 +23,9 @@ class LoaderInterface {
 
  public:
   virtual _Output ErrorOr<VoidPtr> GetBlob()                                              = 0;
-  virtual _Output const Char* AsString()                                                  = 0;
-  virtual _Output const Char* MIME()                                                      = 0;
-  virtual _Output const Char* Path()                                                      = 0;
+  virtual _Output const Char*      AsString()                                             = 0;
+  virtual _Output const Char*      MIME()                                                 = 0;
+  virtual _Output const Char*      Path()                                                 = 0;
   virtual _Output ErrorOr<VoidPtr> FindStart()                                            = 0;
   virtual _Output ErrorOr<VoidPtr> FindSymbol(_Input const Char* name, _Input Int32 kind) = 0;
 };
diff --git a/dev/kernel/KernelKit/PCI/DMA.h b/dev/kernel/KernelKit/PCI/DMA.h
index 7e7d3f0c..c4e3b61a 100644
--- a/dev/kernel/KernelKit/PCI/DMA.h
+++ b/dev/kernel/KernelKit/PCI/DMA.h
@@ -47,7 +47,7 @@ class DMAWrapper final {
   T* Get(UIntPtr off = 0);
 
  public:
-       operator bool();
+  operator bool();
   bool operator!();
 
  public:
diff --git a/dev/kernel/KernelKit/Semaphore.h b/dev/kernel/KernelKit/Semaphore.h
index 930b245d..705d9f18 100644
--- a/dev/kernel/KernelKit/Semaphore.h
+++ b/dev/kernel/KernelKit/Semaphore.h
@@ -28,7 +28,7 @@ typedef UInt64 SemaphoreArr[kSemaphoreCount];
 
 /// @brief Checks if the semaphore is valid.
 inline BOOL rtl_sem_is_valid(const SemaphoreArr& sem, UInt64 owner = 0) {
-  return sem[kSemaphoreOwnerIndex] == owner && sem[kSemaphoreCountIndex] >= 0;
+  return sem[kSemaphoreOwnerIndex] == owner && sem[kSemaphoreCountIndex] > 0;
 }
 
 /// @brief Releases the semaphore, resetting its owner and count.
@@ -61,7 +61,8 @@ inline BOOL rtl_sem_acquire(SemaphoreArr& sem, UInt64 owner) {
 /// @param sem
 /// @param timeout
 /// @return
-inline BOOL rtl_sem_wait(SemaphoreArr& sem, UInt64 owner, UInt64 timeout, BOOL* condition = nullptr) {
+inline BOOL rtl_sem_wait(SemaphoreArr& sem, UInt64 owner, UInt64 timeout,
+                         BOOL* condition = nullptr) {
   if (!rtl_sem_is_valid(sem, owner)) {
     return FALSE;
   }