summaryrefslogtreecommitdiffhomepage
path: root/dev/kernel/StorageKit
diff options
context:
space:
mode:
authorAmlal El Mahrouss <amlal@nekernel.org>2025-04-18 18:24:44 +0200
committerAmlal El Mahrouss <amlal@nekernel.org>2025-04-18 18:27:15 +0200
commitb69c498953dc47900e6ccdd0f501727480836f23 (patch)
tree58411ba65eed2933d97657e16e85fab17f12ea01 /dev/kernel/StorageKit
parentc5b4c98fadd89fd114520e201e34a58a78025344 (diff)
kernel, IMP: GfxKit: GraphicsKit.
kernel, IMP: StorageKit: Remove usage of cleanup method on AHCI, DMA, and PIO. Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
Diffstat (limited to 'dev/kernel/StorageKit')
-rw-r--r--dev/kernel/StorageKit/AHCI.h7
-rw-r--r--dev/kernel/StorageKit/ATA.h4
-rw-r--r--dev/kernel/StorageKit/PRDT.h4
3 files changed, 7 insertions, 8 deletions
diff --git a/dev/kernel/StorageKit/AHCI.h b/dev/kernel/StorageKit/AHCI.h
index 7e2eaf68..68a42c46 100644
--- a/dev/kernel/StorageKit/AHCI.h
+++ b/dev/kernel/StorageKit/AHCI.h
@@ -12,12 +12,14 @@
namespace Kernel
{
+ /// @brief AHCIDeviceInterface class
+ /// @details This class is used to send and receive data from the AHCI device.
+ /// @note The class is derived from the IDeviceObject class.
class AHCIDeviceInterface NE_DEVICE<MountpointInterface*>
{
public:
explicit AHCIDeviceInterface(void (*out)(IDeviceObject* self, MountpointInterface* out),
- void (*in)(IDeviceObject* self, MountpointInterface* in),
- void (*cleanup)(void));
+ void (*in)(IDeviceObject* self, MountpointInterface* in));
virtual ~AHCIDeviceInterface() override;
@@ -40,7 +42,6 @@ namespace Kernel
AHCIDeviceInterface& operator>>(MountpointInterface* Data) override;
private:
- Void (*fCleanup)(Void) = {nullptr};
UInt16 fPortsImplemented{0U};
UInt32 fDriveIndex{0U};
};
diff --git a/dev/kernel/StorageKit/ATA.h b/dev/kernel/StorageKit/ATA.h
index 917fa12b..04cf88d7 100644
--- a/dev/kernel/StorageKit/ATA.h
+++ b/dev/kernel/StorageKit/ATA.h
@@ -18,8 +18,7 @@ namespace Kernel
{
public:
explicit ATADeviceInterface(void (*Out)(IDeviceObject*, MountpointInterface* outpacket),
- void (*In)(IDeviceObject*, MountpointInterface* inpacket),
- void (*Cleanup)(void));
+ void (*In)(IDeviceObject*, MountpointInterface* inpacket));
virtual ~ATADeviceInterface();
@@ -43,7 +42,6 @@ namespace Kernel
Void SetIndex(const UInt32& drv);
private:
- void (*fCleanup)(void) = {nullptr};
UInt32 fDriveIndex{0U};
UInt16 fIO, fMaster{0U};
};
diff --git a/dev/kernel/StorageKit/PRDT.h b/dev/kernel/StorageKit/PRDT.h
index 729b6e96..dde9c208 100644
--- a/dev/kernel/StorageKit/PRDT.h
+++ b/dev/kernel/StorageKit/PRDT.h
@@ -15,7 +15,7 @@
namespace Kernel
{
/// @brief Tranfer information about PRD.
- enum kPRDTTransfer
+ enum
{
kPRDTTransferInProgress,
kPRDTTransferIsDone,
@@ -23,7 +23,7 @@ namespace Kernel
};
/// @brief Physical Region Descriptor Table.
- struct PRDT
+ struct PRDT final
{
UInt32 fPhysAddress;
UInt32 fSectorCount;