diff options
| author | Amlal El Mahrouss <amlal@nekernel.org> | 2025-08-04 17:07:26 +0100 |
|---|---|---|
| committer | Amlal El Mahrouss <amlal@nekernel.org> | 2025-08-04 17:07:26 +0100 |
| commit | be0ec3d2db29c03d3da6d9d1080b399e0f43d16c (patch) | |
| tree | 908d40b79892f82422e403ebcf65f09a9cd205f5 /dev | |
| parent | 2a28b34b046904667fb5ccc50b367320095c08f5 (diff) | |
feat: PEFCodeMgr: make use of explicit types instead of `auto`
why:
- for better code clarity.
Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
Diffstat (limited to 'dev')
| -rw-r--r-- | dev/kernel/src/PEFCodeMgr.cc | 8 | ||||
| -rw-r--r-- | dev/kernel/src/PageMgr.cc | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/dev/kernel/src/PEFCodeMgr.cc b/dev/kernel/src/PEFCodeMgr.cc index 84afdabd..a6a28839 100644 --- a/dev/kernel/src/PEFCodeMgr.cc +++ b/dev/kernel/src/PEFCodeMgr.cc @@ -148,6 +148,7 @@ ErrorOr<VoidPtr> PEFLoader::FindSymbol(const Char* name, Int32 kind) { } error_or_symbol.Leak().Leak() += name; + if (KStringBuilder::Equals(container_header->Name, error_or_symbol.Leak().Leak().CData())) { if (container_header->Kind == kind) { if (container_header->Cpu != Detail::ldr_get_platform()) { @@ -166,9 +167,8 @@ ErrorOr<VoidPtr> PEFLoader::FindSymbol(const Char* name, Int32 kind) { kout << "PEFLoader: info: Loaded stub: " << container_header->Name << "!\r"; - auto ret = 0; - - auto pages_count = (container_header->VMSize + kPageSize - 1) / kPageSize; + Int32 ret = 0; + SizeT pages_count = (container_header->VMSize + kPageSize - 1) / kPageSize; for (SizeT i_vm{}; i_vm < pages_count; ++i_vm) { ret = HAL::mm_map_page((VoidPtr) (container_header->VMAddress + (i_vm * kPageSize)), @@ -243,7 +243,7 @@ namespace Utils { symname = ErrorOr<VoidPtr>{(VoidPtr) rt_alloc_string("USER_PROCESS")}; } - auto id = + ProcessID id = UserProcessScheduler::The().Spawn(reinterpret_cast<const Char*>(symname.Leak().Leak()), errOrStart.Leak().Leak(), exec.GetBlob().Leak().Leak()); diff --git a/dev/kernel/src/PageMgr.cc b/dev/kernel/src/PageMgr.cc index e78f4908..2aa2a79c 100644 --- a/dev/kernel/src/PageMgr.cc +++ b/dev/kernel/src/PageMgr.cc @@ -47,7 +47,7 @@ Bool PTEWrapper::Reclaim() { } /// @brief Request a PTE. -/// @param Rw r/w? +/// @param Rw Is it read write? or is it read only? /// @param User user mode? /// @param ExecDisable disable execution on page? /// @return |
