From 8153dc983802115951836f2b164af371ee6e3d73 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Wed, 24 Apr 2024 19:57:10 +0200
Subject: MHR-16: Add QR-code when bootloader crashes alongside other welcomed
 changes.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/Source/CDROM/SplashScreen.fmt      |  2 +-
 Private/NewBoot/Source/HEL/AMD64/BootAHCI.cxx      |  3 ++
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx       |  3 +-
 .../NewBoot/Source/HEL/AMD64/BootFileReader.cxx    |  2 ++
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx      |  6 ++--
 Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx  |  2 ++
 Private/NewBoot/Source/HEL/AMD64/BootString.cxx    |  2 ++
 .../NewBoot/Source/HEL/AMD64/BootTextWriter.cxx    |  2 ++
 Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx    |  2 ++
 Private/NewBoot/Source/HEL/AMD64/Support.cxx       | 32 ++++++++++++++++++++++
 Private/NewBoot/Source/makefile                    |  2 +-
 11 files changed, 51 insertions(+), 7 deletions(-)
 create mode 100644 Private/NewBoot/Source/HEL/AMD64/Support.cxx

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/Source/CDROM/SplashScreen.fmt b/Private/NewBoot/Source/CDROM/SplashScreen.fmt
index a3dba676..339b94e7 100644
--- a/Private/NewBoot/Source/CDROM/SplashScreen.fmt
+++ b/Private/NewBoot/Source/CDROM/SplashScreen.fmt
@@ -1,4 +1,4 @@
-Welcome to the NeWS.
+Welcome to NeWS.
 
 Brought to you by:
 * MicroKernel, Bootloader: Amlal EL Mahrouss.
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootAHCI.cxx b/Private/NewBoot/Source/HEL/AMD64/BootAHCI.cxx
index d736ac59..d04a94d3 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootAHCI.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootAHCI.cxx
@@ -15,4 +15,7 @@
  *
  */
 
+
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/HW/SATA.hxx>
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index 4e41ba2e..d3573064 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -15,8 +15,9 @@
  *
  */
 
-#include <BootKit/HW/ATA.hxx>
+#include <FirmwareKit/EFI.hxx>
 #include <BootKit/BootKit.hxx>
+#include <BootKit/HW/ATA.hxx>
 
 /// bugs: 0
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
index 33067380..aab5db1f 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
@@ -8,6 +8,8 @@
 
 ------------------------------------------- */
 
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
 #include <FirmwareKit/Handover.hxx>
 #include <cstddef>
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index 42852b5d..d314c949 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -4,6 +4,7 @@
 
 ------------------------------------------- */
 
+#include <FirmwareKit/EFI.hxx>
 #include <BootKit/BootKit.hxx>
 #include <BootKit/Rsrc/NewBoot.rsrc>
 #include <Builtins/Toolbox/Toolbox.hxx>
@@ -58,9 +59,6 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
       .Write(SystemTable->FirmwareVendor)
       .Write(L"\r\n");
 
-  BootDeviceATA ataDev;
-  Boolean isGptFound = No;
-
   UInt32 MapKey = 0;
   UInt32* SizePtr = nullptr;
   EfiMemoryDescriptor* Descriptor = nullptr;
@@ -185,7 +183,7 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
                             L"New Boot can't run this architecture.");
       }
 
-      BootMainKind main = (BootMainKind) nullptr;
+      NewOS::HEL::BootMainKind main = (NewOS::HEL::BootMainKind) nullptr;
 
       if (!main) {
         EFI::RaiseHardError(L"Bad-Exec",
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx b/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
index d0da09b7..f47e3532 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
@@ -4,6 +4,8 @@
 
 ------------------------------------------- */
 
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
 
 EXTERN_C void rt_hlt() { asm volatile("hlt"); }
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootString.cxx b/Private/NewBoot/Source/HEL/AMD64/BootString.cxx
index 1c6b528e..ef0e4744 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootString.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootString.cxx
@@ -11,6 +11,8 @@
 
 ------------------------------------------- */
 
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
 
 /// bugs 0
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
index 2ebde023..81aa6c9d 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
@@ -11,6 +11,8 @@
 
 ------------------------------------------- */
 
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
 
 /// BUGS: 0
diff --git a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
index 1bb2d9ca..77552ef8 100644
--- a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
@@ -4,6 +4,8 @@
 
 ------------------------------------------- */
 
+#include <BootKit/Platform.hxx>
+#include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
 #include <cstddef> /* Since we're using GCC for this EFI program. */
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/Support.cxx b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
new file mode 100644
index 00000000..c6b62630
--- /dev/null
+++ b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
@@ -0,0 +1,32 @@
+/* -------------------------------------------
+
+    Copyright Mahrouss Logic
+
+------------------------------------------- */
+
+#include <FirmwareKit/EFI/EFI.hxx>
+#include <FirmwareKit/Handover.hxx>
+#include <BootKit/Vendor/Support.hxx>
+
+/// @brief memset definition in C++.
+/// @param dst destination pointer.
+/// @param byte value to fill in.
+/// @param len length of of src.
+EXTERN_C VoidPtr memset(void *dst, int byte,
+                          long long unsigned int len) {
+  SetMem(dst, byte, len);
+  return dst;
+}
+
+/// @brief memcpy definition in C++.
+/// @param dst destination pointer.
+/// @param  src source pointer.
+/// @param len length of of src.
+EXTERN_C VoidPtr memcpy(void *dst, const void *src,
+                          long long unsigned int len) {
+  CopyMem(dst, src, len);
+  return dst;
+}
+
+/// @brief somthing specific to the microsoft ABI, regarding checking the stack.
+EXTERN_C void ___chkstk_ms(void) {}
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 2f9e3756..11c1da75 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -36,7 +36,7 @@ FLAG_GNU=-fshort-wchar -D__EFI_x86_64__ -mno-red-zone -D__KERNEL__ -D__NEWBOOT__
 invalid-recipe:
 	@echo "invalid-recipe: Use make bootloader-<arch> instead."
 
-KERNEL_OBJ=kernel.bin
+KERNEL_OBJ=boot.bin
 DD=dd
 IMG_CREATE=qemu-img
 MAX_KERNEL_SIZE=1024K
-- 
cgit v1.2.3


From f6a38d6c14b314d7b85855f311527ede869db96f Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 08:19:06 +0200
Subject: MHR-16: see below.

- Use QR-code to redirect to support page inside bootloader.
- Start working on NewLoader, since the PEF linker is done.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Doxyfile                                           |   5 +-
 Private/Docs/SPECIFICATION.md                      |  62 ++++++
 Private/Docs/TODO-LIST.md                          |  23 ++
 Private/Documentation/.gitkeep                     |   0
 Private/Documentation/Spec.md                      |  62 ------
 Private/Documentation/Todo.md                      |  21 --
 Private/Documentation/kernel-design.drawio         |  70 ------
 Private/FirmwareKit/EFI/API.hxx                    |  18 +-
 Private/NewBoot/BootKit/Vendor/Qr.hxx              |  36 ++-
 Private/NewBoot/BootKit/Vendor/QrVendor/base.h     |  25 +++
 Private/NewBoot/BootKit/Vendor/QrVendor/bit.h      | 245 +++++++++++++++++++++
 .../NewBoot/Source/HEL/AMD64/BootFileReader.cxx    |   6 +-
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx      |  10 +-
 Private/NewLoader/Source/.gitkeep                  |   0
 Private/makefile                                   |   5 +-
 15 files changed, 393 insertions(+), 195 deletions(-)
 create mode 100644 Private/Docs/SPECIFICATION.md
 create mode 100644 Private/Docs/TODO-LIST.md
 delete mode 100644 Private/Documentation/.gitkeep
 delete mode 100644 Private/Documentation/Spec.md
 delete mode 100644 Private/Documentation/Todo.md
 delete mode 100644 Private/Documentation/kernel-design.drawio
 create mode 100644 Private/NewBoot/BootKit/Vendor/QrVendor/base.h
 create mode 100644 Private/NewBoot/BootKit/Vendor/QrVendor/bit.h
 create mode 100644 Private/NewLoader/Source/.gitkeep

(limited to 'Private/NewBoot/Source')

diff --git a/Doxyfile b/Doxyfile
index a52de5be..7fd58842 100644
--- a/Doxyfile
+++ b/Doxyfile
@@ -943,7 +943,8 @@ WARN_LOGFILE           =
 # spaces. See also FILE_PATTERNS and EXTENSION_MAPPING
 # Note: If this tag is empty the current directory is searched.
 
-INPUT                  = ./Private/ \
+INPUT                  = ./ \
+                         ./Private/ \
                          ./Public/ \
 
 # This tag can be used to specify the character encoding of the source files
@@ -1159,7 +1160,7 @@ FILTER_SOURCE_PATTERNS =
 # (index.html). This can be useful if you have a project on for instance GitHub
 # and want to reuse the introduction page also for the doxygen output.
 
-USE_MDFILE_AS_MAINPAGE =
+USE_MDFILE_AS_MAINPAGE = ./ReadMe.md
 
 # The Fortran standard specifies that for fixed formatted Fortran code all
 # characters from position 72 are to be considered as comment. A common
diff --git a/Private/Docs/SPECIFICATION.md b/Private/Docs/SPECIFICATION.md
new file mode 100644
index 00000000..e218947e
--- /dev/null
+++ b/Private/Docs/SPECIFICATION.md
@@ -0,0 +1,62 @@
+===================================
+
+# 0: General Information
+
+===================================
+
+- ABI and Format: PEF/PE32+.
+- Kernel architecture: Portable hybrid kernel.
+- Language: C++/(Assembly (AMD64, X64000, X86S, ARM64, POWER, RISCV))
+
+===================================
+
+# 1: The NewKernel
+
+===================================
+
+- Drive/Device Abstraction.
+- SMP, Preemptive Multi Threading.
+- Separation of Files/Devices.
+- Networking.
+- Hardware Abstraction Layer.
+- Native Filesystem support (NewFS, FAT32 and ffs2).
+- Program Loaders.
+- Thread Local Storage.
+- Semaphore, Locks, Timers.
+- Canary mechanisms.
+- Dynamic Libraries.
+- Cross Platform.
+- Permission Selectors.
+
+===================================
+
+# 2: The Filesystem
+
+===================================
+
+- Catalog object with associated forks.
+- Large storage support.
+- Long file names.
+- UNIX path style.
+
+==================================
+
+# 3: Common naming conventions:
+
+==================================
+
+- Kernel -> ke_init_x
+- RunTime -> rt_copy_mem
+- Hal -> hal_foo_bar
+
+===================================
+
+# 4: The NewBoot
+
+===================================
+
+- Capable of booting from a network drive.
+- Loads a PE file which is the kernel.
+- Sanity checks, based on the number of sections.
+- Handover compliant.
+- Does check for a valid partition (useful in the case of recovering)
diff --git a/Private/Docs/TODO-LIST.md b/Private/Docs/TODO-LIST.md
new file mode 100644
index 00000000..c997ce10
--- /dev/null
+++ b/Private/Docs/TODO-LIST.md
@@ -0,0 +1,23 @@
+# TODO list.
+
+- We need preemptive multi-threading. [ X ]
+- We then need sync primitives. [ X ]
+- We also need a system library for the OS. [ X ]
+- We need a bootloader for AMD64 [ X ]
+  - Implement Boot Services [ X ]
+  - Design Handover [ X ]
+  - Load kernel into memory [ X ]
+  - Fix bug in kernel loader, which causes a 06 #UD. [ X ]
+  - Load Kernel [ X ]
+  - Add IDT [ X ]
+  - AHCI driver [ WiP ]
+- Context switch x87/SSE/AVX registers [ X ]
+- Framebuffer [ X ]
+- AHCI support [ ]
+- Make installer [ ]
+
+Status:
+
+NewBoot: Need to boot from EPM partition.
+<br>
+NewKernel: New Filesystem in progress.
diff --git a/Private/Documentation/.gitkeep b/Private/Documentation/.gitkeep
deleted file mode 100644
index e69de29b..00000000
diff --git a/Private/Documentation/Spec.md b/Private/Documentation/Spec.md
deleted file mode 100644
index e218947e..00000000
--- a/Private/Documentation/Spec.md
+++ /dev/null
@@ -1,62 +0,0 @@
-===================================
-
-# 0: General Information
-
-===================================
-
-- ABI and Format: PEF/PE32+.
-- Kernel architecture: Portable hybrid kernel.
-- Language: C++/(Assembly (AMD64, X64000, X86S, ARM64, POWER, RISCV))
-
-===================================
-
-# 1: The NewKernel
-
-===================================
-
-- Drive/Device Abstraction.
-- SMP, Preemptive Multi Threading.
-- Separation of Files/Devices.
-- Networking.
-- Hardware Abstraction Layer.
-- Native Filesystem support (NewFS, FAT32 and ffs2).
-- Program Loaders.
-- Thread Local Storage.
-- Semaphore, Locks, Timers.
-- Canary mechanisms.
-- Dynamic Libraries.
-- Cross Platform.
-- Permission Selectors.
-
-===================================
-
-# 2: The Filesystem
-
-===================================
-
-- Catalog object with associated forks.
-- Large storage support.
-- Long file names.
-- UNIX path style.
-
-==================================
-
-# 3: Common naming conventions:
-
-==================================
-
-- Kernel -> ke_init_x
-- RunTime -> rt_copy_mem
-- Hal -> hal_foo_bar
-
-===================================
-
-# 4: The NewBoot
-
-===================================
-
-- Capable of booting from a network drive.
-- Loads a PE file which is the kernel.
-- Sanity checks, based on the number of sections.
-- Handover compliant.
-- Does check for a valid partition (useful in the case of recovering)
diff --git a/Private/Documentation/Todo.md b/Private/Documentation/Todo.md
deleted file mode 100644
index 2c4af6e5..00000000
--- a/Private/Documentation/Todo.md
+++ /dev/null
@@ -1,21 +0,0 @@
-- We need preemptive multi-threading. [ X ]
-- We then need sync primitives. [ X ]
-- We also need a system library for the OS. [ X ]
-- We need a bootloader for AMD64 [ X ]
-    - Implement Boot Services [ X ]
-    - Design Handover [ X ]
-    - Load kernel into memory [ X ]
-    - Fix bug in kernel loader, which causes a 06 #UD. [ X ]
-    - Load Kernel [ X ]
-    - Add IDT [ X ]
-    - AHCI driver [ WiP ]
-- Context switch x87/SSE/AVX registers [ X ]
-- Framebuffer [ X ]
-- AHCI support [ ]
-- Make installer [ ]
-
-Status:
-
-NewBoot: Need to boot from EPM partition.
-NewKernel: New Filesystem in progress.
-
diff --git a/Private/Documentation/kernel-design.drawio b/Private/Documentation/kernel-design.drawio
deleted file mode 100644
index d78ac170..00000000
--- a/Private/Documentation/kernel-design.drawio
+++ /dev/null
@@ -1,70 +0,0 @@
-<mxfile host="app.diagrams.net" modified="2024-03-20T02:51:52.841Z" agent="Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36 Edg/122.0.0.0" etag="oPkzCtvrIkHoFdXP1Jzt" version="24.0.7" type="gitlab">
-  <diagram name="Page-1" id="mxOE_IV8GVOi3fDmlM2_">
-    <mxGraphModel dx="1002" dy="569" grid="1" gridSize="10" guides="1" tooltips="1" connect="1" arrows="1" fold="1" page="1" pageScale="1" pageWidth="827" pageHeight="1169" math="0" shadow="0">
-      <root>
-        <mxCell id="0" />
-        <mxCell id="1" parent="0" />
-        <mxCell id="dpAw-ApGermXuwIBdtFA-1" value="&lt;h1 style=&quot;margin-top: 0px;&quot;&gt;NewKernel.exe&lt;/h1&gt;&lt;p&gt;The kernel is a C++ app, designed to be scalable, reliable and object oriented.&lt;/p&gt;&lt;p&gt;We&#39;re actually working on the AHCI support for it is scheduled to be done by the end of april.&lt;/p&gt;" style="text;html=1;whiteSpace=wrap;overflow=hidden;rounded=0;" parent="1" vertex="1">
-          <mxGeometry x="40" y="40" width="400" height="120" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-2" value="MicroKernel" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="286" y="450" width="256" height="60" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-3" value="System Call Interface" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="286" y="420" width="256" height="30" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-4" value="System Object" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="286" y="330" width="254" height="70" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-5" value="User Defined Object #1" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="288" y="280" width="92" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-6" value="User Defined Object #2" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="390" y="280" width="70" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="dpAw-ApGermXuwIBdtFA-7" value="User Defined Object #3" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="470" y="280" width="70" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-1" value="&lt;h1 style=&quot;margin-top: 0px;&quot;&gt;&lt;span style=&quot;background-color: initial;&quot;&gt;SystemLib.lib&lt;/span&gt;&lt;/h1&gt;&lt;h1 style=&quot;margin-top: 0px;&quot;&gt;&lt;span style=&quot;background-color: initial; font-size: 12px; font-weight: normal;&quot;&gt;The System API is written in C/C++ and assembly, meant to interface with the SCI, it provides everything you need to make a NewOS application, properties, objects, threading, heap allocation.&lt;/span&gt;&lt;br&gt;&lt;/h1&gt;&lt;div&gt;&lt;span style=&quot;background-color: initial; font-size: 12px; font-weight: normal;&quot;&gt;You can also register you own user objects.&lt;/span&gt;&lt;/div&gt;" style="text;html=1;whiteSpace=wrap;overflow=hidden;rounded=0;" parent="1" vertex="1">
-          <mxGeometry x="40" y="560" width="360" height="190" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-2" value="System Object" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="281" y="820" width="254" height="70" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-3" value="User Defined Object #1" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="286" y="730" width="92" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-4" value="User Defined Object #2" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="388" y="730" width="70" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-5" value="User Defined Object #3" style="rounded=0;whiteSpace=wrap;html=1;" parent="1" vertex="1">
-          <mxGeometry x="468" y="730" width="70" height="40" as="geometry" />
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-6" value="" style="endArrow=classic;html=1;rounded=0;exitX=1;exitY=0;exitDx=0;exitDy=0;" parent="1" source="NTNQYUPq4CuizRvDkpOI-5" edge="1">
-          <mxGeometry width="50" height="50" relative="1" as="geometry">
-            <mxPoint x="390" y="770" as="sourcePoint" />
-            <mxPoint x="560" y="690" as="targetPoint" />
-          </mxGeometry>
-        </mxCell>
-        <mxCell id="NTNQYUPq4CuizRvDkpOI-7" value="/Manifest.xml&lt;div&gt;/NewOS/&lt;/div&gt;&lt;div&gt;&lt;span style=&quot;white-space: pre;&quot;&gt;&#x9;&lt;/span&gt;- Library.lib/Dll.dll (Subsystem 17)&lt;/div&gt;&lt;div&gt;/Resources/&lt;/div&gt;&lt;div&gt;&lt;br&gt;&lt;/div&gt;&lt;div&gt;&lt;br&gt;&lt;/div&gt;" style="rounded=0;whiteSpace=wrap;html=1;align=left;" parent="1" vertex="1">
-          <mxGeometry x="570" y="650" width="210" height="110" as="geometry" />
-        </mxCell>
-        <mxCell id="vm68-OaV5PJmx3jSNiIi-1" value="&lt;h1 style=&quot;margin-top: 0px;&quot;&gt;GraphicsLib.lib (merged with SystemLib)&lt;/h1&gt;&lt;p&gt;Handles input, graphics and sound.&lt;/p&gt;&lt;p&gt;Uses the ODF format to display graphics and sound is handled by XIFF.&lt;/p&gt;" style="text;html=1;whiteSpace=wrap;overflow=hidden;rounded=0;" vertex="1" parent="1">
-          <mxGeometry x="31" y="980" width="250" height="120" as="geometry" />
-        </mxCell>
-        <mxCell id="vm68-OaV5PJmx3jSNiIi-3" value="GraphicsLib.lib" style="rounded=0;whiteSpace=wrap;html=1;" vertex="1" parent="1">
-          <mxGeometry x="286" y="780" width="114" height="30" as="geometry" />
-        </mxCell>
-        <mxCell id="vm68-OaV5PJmx3jSNiIi-4" value="System Object" style="rounded=0;whiteSpace=wrap;html=1;" vertex="1" parent="1">
-          <mxGeometry x="298" y="1150" width="254" height="70" as="geometry" />
-        </mxCell>
-        <mxCell id="vm68-OaV5PJmx3jSNiIi-5" value="GraphicsLib.lib" style="rounded=0;whiteSpace=wrap;html=1;" vertex="1" parent="1">
-          <mxGeometry x="300" y="1110" width="114" height="30" as="geometry" />
-        </mxCell>
-        <mxCell id="vm68-OaV5PJmx3jSNiIi-6" value="SystemLib.lib" style="rounded=0;whiteSpace=wrap;html=1;" vertex="1" parent="1">
-          <mxGeometry x="406" y="780" width="124" height="30" as="geometry" />
-        </mxCell>
-      </root>
-    </mxGraphModel>
-  </diagram>
-</mxfile>
diff --git a/Private/FirmwareKit/EFI/API.hxx b/Private/FirmwareKit/EFI/API.hxx
index 212f3686..0e2ef200 100644
--- a/Private/FirmwareKit/EFI/API.hxx
+++ b/Private/FirmwareKit/EFI/API.hxx
@@ -61,9 +61,11 @@ enum {
 inline UInt32 Platform() noexcept { return kPEMachineAMD64; }
 
 /***
- * @brief Raise Hard kernel error.
+ * @brief Throw an error, stop execution as well.
+ * @param ErrorCode error code to be print.
+ * @param Reason reason to be print.
  */
-inline void RaiseHardError(const EfiCharType *ErrorCode,
+inline void ThrowError(const EfiCharType *ErrorCode,
                            const EfiCharType *Reason) noexcept {
 #ifdef __DEBUG__
   ST->ConOut->OutputString(ST->ConOut, L"\r\n*** STOP ***\r\n");
@@ -88,19 +90,19 @@ inline void RaiseHardError(const EfiCharType *ErrorCode,
 
   /// Show the QR code now.
 
-  constexpr auto ver = 7;
+  constexpr auto ver = 4;
   auto ecc = qr::Ecc::H;
-  auto str = "https://www.mahrouss-logic.com/help";
-  auto len = BStrLen(L"https://www.mahrouss-logic.com/help");
+  auto str = "https://el-mahrouss-logic.com/";
+  auto len = BStrLen(L"https://el-mahrouss-logic.com/");
 
   qr::Qr<ver> encoder;
   qr::QrDelegate encoderDelegate;
 
-  encoder.encode(str, len, ecc, -1);  // Automatic mask.
+  encoder.encode(str, len, ecc, 0); // Manual mask 0
 
   /// tell delegate to draw encoded QR.
-  encoderDelegate.draw<ver>(encoder, (kHandoverHeader->f_GOP.f_Width - encoder.side_size()) / 2,
-      (kHandoverHeader->f_GOP.f_Height - encoder.side_size()) - 20);
+  encoderDelegate.draw<ver>(encoder, (kHandoverHeader->f_GOP.f_Width - encoder.side_size()) - 20,
+      (kHandoverHeader->f_GOP.f_Height - encoder.side_size()) / 2);
 
 #endif  // ifdef __NEWBOOT__
 
diff --git a/Private/NewBoot/BootKit/Vendor/Qr.hxx b/Private/NewBoot/BootKit/Vendor/Qr.hxx
index 7fec429e..ca5eb566 100644
--- a/Private/NewBoot/BootKit/Vendor/Qr.hxx
+++ b/Private/NewBoot/BootKit/Vendor/Qr.hxx
@@ -5,6 +5,9 @@
 #include <stddef.h>
 #include <stdint.h>
 
+#include <BootKit/Vendor/QrVendor/base.h>
+#include <BootKit/Vendor/QrVendor/bit.h>
+
 #include <BootKit/Vendor/QrPrelude.hxx>
 #include <BootKit/Vendor/Support.hxx>
 #include <Builtins/Toolbox/Toolbox.hxx>
@@ -276,7 +279,7 @@ public:
   void apply_mask(int mask, uint8_t *patterns);
 
  private:
-  static_assert(V <= 40, "invalid version");
+  static_assert(V >= 1 && V <= 40, "invalid version");
   static constexpr int SIDE = 17 + V * 4;
   static constexpr int N_BITS = SIDE * SIDE;
   static constexpr int N_ALIGN = V == 1 ? 0 : V / 7 + 2;
@@ -286,42 +289,29 @@ public:
   static constexpr int N_VER_BITS = V > 6 ? 36 : 0;
   static constexpr int N_DAT_BITS =
       N_BITS - (192 + N_ALIGN_BITS + N_TIMING_BITS + 31 + N_VER_BITS);
-  static constexpr int N_BYTES = N_BITS;  // Actual number of bytes_in_bits
+  static constexpr int N_BYTES = utl::bytes_in_bits(N_BITS);  // Actual number of bytes_in_bits
                                           // required to store whole Qr code
-  static constexpr int N_DAT_BYTES =
-      N_DAT_BITS;  // Actual number of bytes_in_bits required to store
+  static constexpr int N_DAT_BYTES = utl::bytes_in_bits(N_DAT_BITS);  // Actual number of bytes_in_bits required to store
                    // [data + ecc]
   static constexpr int N_DAT_CAPACITY =
       N_DAT_BITS >> 3;  // Capacity of [data + ecc] without remainder bits
  private:
   /// @brief internal function to retrieve bit from a bitset.
-  uint8_t get_arr_bit(uint8_t *arr, uint64_t bit) const {
-    return ((volatile uint8_t *)arr)[bit];
+  uint8_t get_arr_bit(uint8_t *arr, unsigned bit) const {
+    return utl::get_arr_bit(arr, bit);
   }
 
   /// @brief internal function to set bit from a bitset.
-  bool set_arr_bit(uint8_t *arr, uint64_t bit) {
-    if (((volatile uint8_t *)arr)[bit] == 0) {
-      ((volatile uint8_t *)arr)[bit] = 1;
-
-      return true;
-    }
-
-    return false;
+  void set_arr_bit(uint8_t *arr, unsigned bit) {
+    utl::set_arr_bit(arr, bit);
   }
 
   /// @brief internal function to clear bit from a bitset.
-  bool clr_arr_bit(uint8_t *arr, uint64_t bit) {
-    if (((volatile uint8_t *)arr)[bit] == 1) {
-      ((volatile uint8_t *)arr)[bit] = 0;
-
-      return true;
-    }
-
-    return false;
+  void clr_arr_bit(uint8_t *arr, unsigned bit) {
+    utl::clr_arr_bit(arr, bit);
   }
 
-  uint8_t code[N_BITS] = {0};
+  uint8_t code[N_BYTES] = {};
 
   bool status = false;
 };
diff --git a/Private/NewBoot/BootKit/Vendor/QrVendor/base.h b/Private/NewBoot/BootKit/Vendor/QrVendor/base.h
new file mode 100644
index 00000000..d8261d1e
--- /dev/null
+++ b/Private/NewBoot/BootKit/Vendor/QrVendor/base.h
@@ -0,0 +1,25 @@
+#ifndef UTL_BASE_H
+#define UTL_BASE_H
+
+#include <cstdint>
+#include <cstddef>
+#include <cassert>
+
+namespace utl {
+
+/**
+ * @brief Helper to get number of elements in array. 
+ * 
+ * @tparam T Auto-deduced element type
+ * @tparam N Auto-deduced number of elements
+ * @return Array size
+ */
+template<class T, size_t N>
+constexpr size_t countof(T(&)[N]) 
+{ 
+    return N; 
+}
+
+}
+
+#endif
\ No newline at end of file
diff --git a/Private/NewBoot/BootKit/Vendor/QrVendor/bit.h b/Private/NewBoot/BootKit/Vendor/QrVendor/bit.h
new file mode 100644
index 00000000..646151b6
--- /dev/null
+++ b/Private/NewBoot/BootKit/Vendor/QrVendor/bit.h
@@ -0,0 +1,245 @@
+#ifndef UTL_BIT_H
+#define UTL_BIT_H
+
+#include <bit>
+
+namespace utl {
+
+/**
+ * @brief Size of object in terms of bits.
+ *
+ * @tparam T Object type
+ * @return Number of bits
+ */
+template<class T>
+constexpr auto bit_size()
+{
+    return sizeof(T) * 8;
+}
+
+/**
+ * @brief Integer with all bits set to 1.
+ *
+ * @tparam T Integer type
+ * @return All set integer
+ */
+template<class T>
+constexpr T bit_full()
+{
+    return T(-1);
+}
+
+/**
+ * @brief Wrap around mask for power of two number of bits
+ * within given integer type. For example:
+ * [ bit_wrap<uint8_t>  = 8  - 1 = 0b111   ]
+ * [ bit_wrap<uint16_t> = 16 - 1 = 0b1111  ]
+ * [ bit_wrap<uint32_t> = 32 - 1 = 0b11111 ]
+ *
+ * @tparam T Integer type
+ * @return Wrap around mask for number of bits
+ */
+template<class T>
+constexpr T bit_wrap()
+{
+    return bit_size<T>() - 1;
+}
+
+/**
+ * @brief Number of bits to fit bit_wrap<T> result, in other words
+ * bit width of (sizeof(T) * 8 - 1). For example:
+ * [ bit_shft<uint8_t>  = bit_width(0b111)      = 3 ]
+ * [ bit_shft<uint16_t> = bit_width(0b1111)     = 4 ]
+ * [ bit_shft<uint32_t> = bit_width(0b11111)    = 5 ]
+ *
+ * @tparam T Integer type
+ * @return Number of bits to shift to divide by sizeof(T) * 8
+ */
+template<class T>
+constexpr auto bit_shft()
+{
+    return std::bit_width(bit_wrap<T>());
+}
+
+/**
+ * @brief Round up division by number of bits within given integer type,
+ * which sizeof(T) * 8 is power of two.
+ *
+ * @tparam T Inetegr type
+ * @param x Dividend
+ * @return Quotient
+ */
+template<class T>
+constexpr auto bit_ceil(auto x)
+{
+    return (x + bit_wrap<T>()) >> bit_shft<T>();
+}
+
+/**
+ * @brief Count leading zeros.
+ *
+ * @param x Unsigned integer argument
+ * @return Number of leading zeros
+ */
+constexpr unsigned cntlz(auto x)
+{
+    if constexpr (std::is_same_v<decltype(x), int>)
+        return std::countl_zero(unsigned(x));
+    else
+        return std::countl_zero(x);
+}
+
+/**
+ * @brief Count trailing zeros.
+ *
+ * @param x Unsigned integer argument
+ * @return Number of trailing zeros
+ */
+constexpr unsigned cnttz(auto x)
+{
+    if constexpr (std::is_same_v<decltype(x), int>)
+        return std::countr_zero(unsigned(x));
+    else
+        return std::countr_zero(x);
+}
+
+/**
+ * @brief Get number of words (integers) required to store N bits.
+ *
+ * @tparam T Word integer type
+ * @param n Number of bits to store
+ * @return Number of words
+ */
+template<class T>
+constexpr size_t words_in_bits(size_t n)
+{
+    return (n >> bit_shft<T>()) + !!(n & bit_wrap<T>());
+}
+
+/**
+ * @brief Get number of bytes required to store N bits.
+ *
+ * @param n Number of bits to store
+ * @return Number of bytes
+ */
+constexpr size_t bytes_in_bits(size_t n)
+{
+    return words_in_bits<uint8_t>(n);
+}
+
+/**
+ * @brief Make integer with bit at given position.
+ *
+ * @tparam T Inetegr type
+ * @param n Bit position
+ * @return Integer with set bit
+ */
+template<class T = unsigned>
+constexpr T bit(int n)
+{
+    return T(1) << n;
+}
+
+/**
+ * @brief Get n-th bit of an integer.
+ *
+ * @tparam T Integer type
+ * @param x Integer
+ * @param n Bit position from LSB
+ * @return true if set
+ */
+template<class T>
+constexpr bool get_bit(T x, int n)
+{
+    return (x >> n) & 1;
+}
+
+/**
+ * @brief Set n-th bit of an integer.
+ *
+ * @tparam T Integer type
+ * @param x Integer
+ * @param n Bit position from LSB
+ */
+template<class T>
+constexpr void set_bit(T& x, int n)
+{
+    x |= 1 << n;
+}
+
+/**
+ * @brief Clear n-th bit of an integer.
+ *
+ * @tparam T Integer type
+ * @param x Integer
+ * @param n Bit position from LSB
+ */
+template<class T>
+constexpr void clr_bit(T& x, int n)
+{
+    x &= ~(1 << n);
+}
+
+/**
+ * @brief Get n-th bit in array of words (starting from LSB).
+ *
+ * @tparam T Word type
+ * @param p Array of words
+ * @param n Index of bit to get
+ * @return true if set
+ */
+template<class T>
+constexpr bool get_arr_bit(const T* p, unsigned n)
+{
+    return get_bit(p[n >> bit_shft<T>()], n & bit_wrap<T>());
+}
+
+/**
+ * @brief Set n-th bit in array of words (starting from LSB).
+ *
+ * @tparam T Word type
+ * @param p Array of words
+ * @param n Index of bit to set
+ */
+template<class T>
+constexpr void set_arr_bit(T* p, unsigned n)
+{
+    set_bit(p[n >> bit_shft<T>()], n & bit_wrap<T>());
+}
+
+/**
+ * @brief Clear n-th bit in array of words (starting from LSB).
+ *
+ * @tparam T Word type
+ * @param p Array of words
+ * @param n Index of bit to clear
+ */
+template<class T>
+constexpr void clr_arr_bit(T* p, unsigned n)
+{
+    clr_bit(p[n >> bit_shft<T>()], n & bit_wrap<T>());
+}
+
+/**
+ * @brief Shift bits left in array of integer elements from least significant bit
+ * and considering 0-th byte as the right most.
+ * uint16_t example: 0b10000000'11100001 ==> 0b00000001'11000010.
+ *
+ * @tparam T Integer type
+ * @tparam L Length of array
+ * @param x Array of integers, nullptr not acceptable!
+ * @param len Number of elements
+ */
+template<class T, size_t L>
+constexpr void shift_left(T (&x)[L])
+{
+    for (int i = L - 1; i > 0; --i) {
+        x[i] <<= 1;
+        x[i] |= x[i - 1] >> bit_wrap<T>();
+    }
+    x[0] <<= 1;
+}
+
+}
+
+#endif
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
index aab5db1f..0e126ada 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
@@ -66,7 +66,7 @@ BFileReader::BFileReader(const CharacterTypeUTF16* path,
 
   if (efp->OpenVolume(efp, &rootFs) != kEfiOk) {
     mWriter.Write(L"New Boot: Fetch-Protocol: No-Such-Volume").Write(L"\r\n");
-    EFI::RaiseHardError(L"NoSuchVolume", L"No Such volume.");
+    EFI::ThrowError(L"NoSuchVolume", L"No Such volume.");
     this->mErrorCode = kNotSupported;
     return;
   }
@@ -78,7 +78,7 @@ BFileReader::BFileReader(const CharacterTypeUTF16* path,
     mWriter.Write(L"New Boot: Fetch-Protocol: No-Such-Path: ")
         .Write(mPath)
         .Write(L"\r\n");
-    EFI::RaiseHardError(L"NoSuchPath", L"No Such file on filesystem.");
+    EFI::ThrowError(L"NoSuchPath", L"No Such file on filesystem.");
     this->mErrorCode = kNotSupported;
     return;
   }
@@ -110,7 +110,7 @@ Void BFileReader::ReadAll(SizeT until, SizeT chunk) {
     if (auto err = BS->AllocatePool(EfiLoaderCode, until, (VoidPtr*)&mBlob) !=
                    kEfiOk) {
       mWriter.Write(L"*** EFI-Code: ").Write(err).Write(L" ***\r\n");
-      EFI::RaiseHardError(L"NewBoot_PageError", L"Allocation error.");
+      EFI::ThrowError(L"NewBoot_PageError", L"Allocation error.");
     }
   }
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index d314c949..7120bcd9 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -67,7 +67,7 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
 
   if (BS->AllocatePool(EfiLoaderData, sizeof(UInt32), (VoidPtr*)&SizePtr) !=
       kEfiOk) {
-    EFI::RaiseHardError(L"Bad-Alloc", L"New Boot ran out of memory!");
+    EFI::ThrowError(L"Bad-Alloc", L"New Boot ran out of memory!");
   }
 
   /****
@@ -80,7 +80,7 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
 
   if (BS->AllocatePool(EfiLoaderData, sizeof(EfiMemoryDescriptor),
                        (VoidPtr*)&Descriptor) != kEfiOk) {
-    EFI::RaiseHardError(L"Bad-Alloc", L"New Boot ran out of memory!");
+    EFI::ThrowError(L"Bad-Alloc", L"New Boot ran out of memory!");
   }
 
   HEL::HandoverInformationHeader* handoverHdrPtr = nullptr;
@@ -179,14 +179,14 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
         headerKind->Magic[3] == kPefMagic[3] &&
         headerKind->Magic[4] == kPefMagic[4]) {
       if (headerKind->Abi != kPefAbi || headerKind->Cpu != kPefArchAMD64) {
-        EFI::RaiseHardError(L"Bad-Architecture",
+        EFI::ThrowError(L"Bad-Architecture",
                             L"New Boot can't run this architecture.");
       }
 
       NewOS::HEL::BootMainKind main = (NewOS::HEL::BootMainKind) nullptr;
 
       if (!main) {
-        EFI::RaiseHardError(L"Bad-Exec",
+        EFI::ThrowError(L"Bad-Exec",
                             L"New Boot can't recognize this executable.");
       }
 
@@ -200,7 +200,7 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
     }
   }
 
-  EFI::RaiseHardError(L"Invalid-PEF-Executable", L"PEF executable expected. Got something else.");
+  EFI::ThrowError(L"Invalid-PEF-Executable", L"PEF executable expected. Got something else.");
 
   return kEfiFail;
 }
diff --git a/Private/NewLoader/Source/.gitkeep b/Private/NewLoader/Source/.gitkeep
new file mode 100644
index 00000000..e69de29b
diff --git a/Private/makefile b/Private/makefile
index 41f70c81..673a4b56 100644
--- a/Private/makefile
+++ b/Private/makefile
@@ -28,10 +28,12 @@ COPY		= cp
 
 # Add assembler, linker, and object files variables.
 ASMFLAGS	= -f win64
+
+# NewOS subsystem is 17.
 LDFLAGS		= -e Main --subsystem=17
 LDOBJ		= Objects/*.obj
 
-# This file is the kernel, responsible of task management, memory, drivers and more.
+# This file is the kernel, responsible of task management and memory.
 KERNEL		= NewKernel.exe
 
 # The kernel entrypoint
@@ -39,6 +41,7 @@ SCRIPT		= --script=Linker/Platforms/PC.lds
 
 .PHONY: error
 error:
+	@echo "=== ERROR ==="
 	@echo "=> Use a specific target."
 
 MOVEALL=./MoveAll.sh
-- 
cgit v1.2.3


From 1cae0d2cde6e775ecb1625aa93a5d65d996efad0 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 09:38:24 +0200
Subject: MHR-16: Load NewLoader correctly.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/HALKit/AMD64/HalProcessor.cpp         |  2 +-
 Private/HALKit/AMD64/Storage/AHCI.cxx         |  8 ++++----
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx | 16 ++++++++--------
 ReadMe.md                                     |  4 ++--
 4 files changed, 15 insertions(+), 15 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/HALKit/AMD64/HalProcessor.cpp b/Private/HALKit/AMD64/HalProcessor.cpp
index 4fea4e7e..61d98c8c 100644
--- a/Private/HALKit/AMD64/HalProcessor.cpp
+++ b/Private/HALKit/AMD64/HalProcessor.cpp
@@ -8,7 +8,7 @@
 
 /**
  * @file Processor.cpp
- * @brief This file is about processor specific functions (in/out...)
+ * @brief This file is about processor specific functions (in/out/cli/std...)
  */
 
 namespace NewOS::HAL {
diff --git a/Private/HALKit/AMD64/Storage/AHCI.cxx b/Private/HALKit/AMD64/Storage/AHCI.cxx
index 5e6b3348..c9db540a 100644
--- a/Private/HALKit/AMD64/Storage/AHCI.cxx
+++ b/Private/HALKit/AMD64/Storage/AHCI.cxx
@@ -33,11 +33,11 @@ NewOS::Boolean drv_std_init(NewOS::UInt16& PortsImplemented) {
   for (SizeT devIndex = 0; devIndex < NEWOS_BUS_COUNT; ++devIndex) {
     if (iterator[devIndex].Leak().Subclass() == kSATASubClass &&
         iterator[devIndex].Leak().ProgIf() == kSATAProgIfAHCI) {
-      iterator[devIndex].Leak().EnableMmio();
-      kAhciDevice = iterator[devIndex].Leak();
+      iterator[devIndex].Leak().EnableMmio(); /// enable the memory i/o for this ahci device.
+      kAhciDevice = iterator[devIndex].Leak(); /// and then leak the reference.
 
       kcout << "NewKernel: [PCI] Found AHCI controller.\r\n";
-    
+
       return true;
     }
   }
@@ -54,4 +54,4 @@ NewOS::Void drv_std_read(NewOS::UInt64 Lba, NewOS::Char* Buf,
 
 NewOS::Void drv_std_write(NewOS::UInt64 Lba, NewOS::Char* Buf,
                            NewOS::SizeT SectorSz, NewOS::SizeT Size) {}
-#endif  // __AHCI__
\ No newline at end of file
+#endif  // __AHCI__
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index 7120bcd9..cdbb2f36 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -170,20 +170,20 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
   kernelFile.ReadAll(MIB(1), 4096);
 
   if (kernelFile.Blob()) {
-    PEFContainer* headerKind =
+    PEFContainer* containerKind =
         reinterpret_cast<PEFContainer*>(kernelFile.Blob());
 
-    if (headerKind->Magic[0] == kPefMagic[0] &&
-        headerKind->Magic[1] == kPefMagic[1] &&
-        headerKind->Magic[2] == kPefMagic[2] &&
-        headerKind->Magic[3] == kPefMagic[3] &&
-        headerKind->Magic[4] == kPefMagic[4]) {
-      if (headerKind->Abi != kPefAbi || headerKind->Cpu != kPefArchAMD64) {
+    if (containerKind->Magic[0] == kPefMagic[0] &&
+        containerKind->Magic[1] == kPefMagic[1] &&
+        containerKind->Magic[2] == kPefMagic[2] &&
+        containerKind->Magic[3] == kPefMagic[3] &&
+        containerKind->Magic[4] == kPefMagic[4]) {
+      if (containerKind->Abi != kPefAbi || containerKind->Cpu != kPefArchAMD64) {
         EFI::ThrowError(L"Bad-Architecture",
                             L"New Boot can't run this architecture.");
       }
 
-      NewOS::HEL::BootMainKind main = (NewOS::HEL::BootMainKind) nullptr;
+      NewOS::HEL::BootMainKind main = reinterpret_cast<NewOS::HEL::BootMainKind>(containerKind + containerKind->Start);
 
       if (!main) {
         EFI::ThrowError(L"Bad-Exec",
diff --git a/ReadMe.md b/ReadMe.md
index e3b6ff8c..c169c960 100644
--- a/ReadMe.md
+++ b/ReadMe.md
@@ -1,6 +1,6 @@
 <div align="center">
-<img src="Meta/Kernel.svg" width="96" height="96"/>
-<h1>NewKernel</h1>
+<img src="../Meta/Kernel.svg" width="96" height="96"/>
+<h1>NewOS</h1>
 </div>
 
 <br>
-- 
cgit v1.2.3


From d3c9b5287789534340146ffdb696f67aa8b7308d Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 12:12:19 +0200
Subject: MHR-16: Format, and revert previous staged commit.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/FirmwareKit/EFI/API.hxx               |  7 -------
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx | 18 +++++++++++-------
 2 files changed, 11 insertions(+), 14 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/FirmwareKit/EFI/API.hxx b/Private/FirmwareKit/EFI/API.hxx
index 093d10b3..0e2ef200 100644
--- a/Private/FirmwareKit/EFI/API.hxx
+++ b/Private/FirmwareKit/EFI/API.hxx
@@ -121,13 +121,6 @@ inline void InitEFI(EfiSystemTable *SystemTable) noexcept {
 
   ST->BootServices->SetWatchdogTimer(0, 0, 0, nullptr);
   ST->ConOut->EnableCursor(ST->ConOut, false);
-
-  if (ST->FirmwareVendor[0] != '@' ||
-      ST->FirmwareVendor[1] != 'M' ||
-      ST->FirmwareVendor[1] != 'H' ||
-      ST->FirmwareVendor[1] != 'R') {
-        EFI::ThrowError(L"Unsupported Firmware", L"Firmware is unsupported, please build OVMF by yourself.");
-    }
 }
 
 #ifdef __BOOTLOADER__
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index cdbb2f36..356db88b 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -4,13 +4,13 @@
 
 ------------------------------------------- */
 
-#include <FirmwareKit/EFI.hxx>
-#include <BootKit/BootKit.hxx>
 #include <BootKit/Rsrc/NewBoot.rsrc>
 #include <Builtins/Toolbox/Toolbox.hxx>
+#include <FirmwareKit/EFI.hxx>
 #include <KernelKit/MSDOS.hpp>
 #include <KernelKit/PEF.hpp>
 #include <NewKit/Ref.hpp>
+#include <BootKit/BootKit.hxx>
 
 /** Graphics related. */
 
@@ -178,16 +178,19 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
         containerKind->Magic[2] == kPefMagic[2] &&
         containerKind->Magic[3] == kPefMagic[3] &&
         containerKind->Magic[4] == kPefMagic[4]) {
-      if (containerKind->Abi != kPefAbi || containerKind->Cpu != kPefArchAMD64) {
+      if (containerKind->Abi != kPefAbi ||
+          containerKind->Cpu != kPefArchAMD64) {
         EFI::ThrowError(L"Bad-Architecture",
-                            L"New Boot can't run this architecture.");
+                        L"New Boot can't run this architecture.");
       }
 
-      NewOS::HEL::BootMainKind main = reinterpret_cast<NewOS::HEL::BootMainKind>(containerKind + containerKind->Start);
+      NewOS::HEL::BootMainKind main =
+          reinterpret_cast<NewOS::HEL::BootMainKind>(containerKind +
+                                                     containerKind->Start);
 
       if (!main) {
         EFI::ThrowError(L"Bad-Exec",
-                            L"New Boot can't recognize this executable.");
+                        L"New Boot can't recognize this executable.");
       }
 
       EFI::ExitBootServices(MapKey, ImageHandle);
@@ -200,7 +203,8 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
     }
   }
 
-  EFI::ThrowError(L"Invalid-PEF-Executable", L"PEF executable expected. Got something else.");
+  EFI::ThrowError(L"Invalid-PEF-Executable",
+                  L"PEF executable expected. Got something else.");
 
   return kEfiFail;
 }
-- 
cgit v1.2.3


From 14f26421cc6ebd678c2b5a2a04fe6cdc63ee5d38 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 13:44:36 +0200
Subject: MHR-16: Adding BDiskFormatFactory according to MHR-16, bug fixes and
 improvements as well.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/DriverKit/KernelCall.c                     |  24 +++++
 Private/DriverKit/KernelDev.h                      |   4 +
 Private/DriverKit/KernelDispatchCall.S             |   2 +-
 Private/DriverKit/KernelStd.c                      |  24 -----
 Private/FSKit/NewFS.hxx                            |   8 +-
 Private/NewBoot/BootKit/BootKit.hxx                | 108 ++++++++++++++++---
 Private/NewBoot/BootKit/HW/ATA.hxx                 |   4 +-
 Private/NewBoot/BootKit/Vendor/Qr.hxx              |   3 +
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx       |  11 +-
 Private/NewBoot/Source/HEL/AMD64/Support.cxx       |  14 +++
 Private/NewBoot/Source/HEL/POWER/BootCoreBoot.S    |  34 ------
 Private/NewBoot/Source/HEL/POWER/BootEPM.cxx       | 118 ---------------------
 Private/NewBoot/Source/HEL/POWER/CoreBootStartup.S |  34 ++++++
 Private/NewBoot/Source/makefile                    |   5 +-
 14 files changed, 192 insertions(+), 201 deletions(-)
 create mode 100644 Private/DriverKit/KernelCall.c
 delete mode 100644 Private/DriverKit/KernelStd.c
 delete mode 100644 Private/NewBoot/Source/HEL/POWER/BootCoreBoot.S
 delete mode 100644 Private/NewBoot/Source/HEL/POWER/BootEPM.cxx
 create mode 100644 Private/NewBoot/Source/HEL/POWER/CoreBootStartup.S

(limited to 'Private/NewBoot/Source')

diff --git a/Private/DriverKit/KernelCall.c b/Private/DriverKit/KernelCall.c
new file mode 100644
index 00000000..494ac0bc
--- /dev/null
+++ b/Private/DriverKit/KernelCall.c
@@ -0,0 +1,24 @@
+/* -------------------------------------------
+
+    Copyright Mahrouss Logic
+
+    Purpose: Kernel Definitions.
+
+------------------------------------------- */
+
+#include <DriverKit/KernelStd.h>
+#include <stdarg.h>
+
+DK_EXTERN __attribute__((naked)) void __kernelDispatchCall(int32_t cnt, ...);
+
+DK_EXTERN void* kernelCall(const char* kernelRpcName, int32_t cnt, ...) {
+    if (!kernelRpcName || cnt == 0) return NIL;
+
+    va_list arg;
+    va_start(arg, cnt);
+
+    __kernelDispatchCall(cnt, arg);
+
+    va_end(arg);
+
+}
diff --git a/Private/DriverKit/KernelDev.h b/Private/DriverKit/KernelDev.h
index daa60a7c..8b6888f0 100644
--- a/Private/DriverKit/KernelDev.h
+++ b/Private/DriverKit/KernelDev.h
@@ -10,7 +10,11 @@
 
 #include <DriverKit/KernelStd.h>
 
+struct _kernelDevice;
+
+/// @brief Kernel Device driver.
 typedef struct _kernelDevice {
+    char name[255]; // the device name. Could be /./DEVICE_NAME/
     int32_t(*read)(); // read from device.
     int32_t(*write)(); // write to device.
     struct _kernelDevice* (*open)(const char* path); // open device.
diff --git a/Private/DriverKit/KernelDispatchCall.S b/Private/DriverKit/KernelDispatchCall.S
index 4eec8ae0..64b6663e 100644
--- a/Private/DriverKit/KernelDispatchCall.S
+++ b/Private/DriverKit/KernelDispatchCall.S
@@ -14,7 +14,7 @@ __kernelDispatchCall:
 #elif defined(__powerpc64__)
 
 __kernelDispatchCall:
-    mflr 3
+    /* There is no specific interrupt request id for a system call in POWER. */
     sc
     blr
 
diff --git a/Private/DriverKit/KernelStd.c b/Private/DriverKit/KernelStd.c
deleted file mode 100644
index 494ac0bc..00000000
--- a/Private/DriverKit/KernelStd.c
+++ /dev/null
@@ -1,24 +0,0 @@
-/* -------------------------------------------
-
-    Copyright Mahrouss Logic
-
-    Purpose: Kernel Definitions.
-
-------------------------------------------- */
-
-#include <DriverKit/KernelStd.h>
-#include <stdarg.h>
-
-DK_EXTERN __attribute__((naked)) void __kernelDispatchCall(int32_t cnt, ...);
-
-DK_EXTERN void* kernelCall(const char* kernelRpcName, int32_t cnt, ...) {
-    if (!kernelRpcName || cnt == 0) return NIL;
-
-    va_list arg;
-    va_start(arg, cnt);
-
-    __kernelDispatchCall(cnt, arg);
-
-    va_end(arg);
-
-}
diff --git a/Private/FSKit/NewFS.hxx b/Private/FSKit/NewFS.hxx
index 339b9832..cc43f51b 100644
--- a/Private/FSKit/NewFS.hxx
+++ b/Private/FSKit/NewFS.hxx
@@ -82,7 +82,7 @@ default.
 #define kNewFSLbaType (NewOS::Lba)
 
 /// Start After the PM headers, pad 1024 bytes.
-#define kNewFSAddressAsLba (1024U)
+#define kNewFSAddressAsLba (1024)
 
 #define kResourceTypeDialog 10
 #define kResourceTypeString 11
@@ -95,6 +95,8 @@ default.
 #define kNewFSFlagUnallocated 0x00
 #define kNewFSFlagCreated 0x0F
 
+#define kNewFSMimeNameLen (216)
+
 typedef NewOS::Char NewCharType;
 
 enum {
@@ -106,10 +108,10 @@ enum {
   kNewFSDriveCount = 5,
 };
 
-/// @brief Ccatalog type.
+/// @brief Catalog type.
 struct PACKED NewCatalog final {
   NewCharType Name[kNewFSNodeNameLen];
-  NewCharType Mime[kNewFSNodeNameLen];
+  NewCharType Mime[kNewFSMimeNameLen];
 
   NewOS::Int32 Flags;
   NewOS::Int32 Kind;
diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index 5c3a531d..15700f54 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -11,6 +11,22 @@
 
 #pragma once
 
+#include <BootKit/HW/ATA.hxx>
+#include <CompilerKit/Version.hxx>
+
+/// include NewFS header and Support header as well.
+
+#include <FSKit/NewFS.hxx>
+#include <cstring>
+#include <BootKit/Vendor/Support.hxx>
+
+/***********************************************************************************/
+/// Include other APIs.
+/***********************************************************************************/
+
+#include <NewKit/Defines.hpp>
+#include "Builtins/ATA/ATA.hxx"
+
 /***********************************************************************************/
 /// Framebuffer helpers.
 /***********************************************************************************/
@@ -22,15 +38,6 @@ class BFileReader;
 class BFileRunner;
 class BVersionString;
 
-#include <BootKit/HW/ATA.hxx>
-#include <CompilerKit/Version.hxx>
-
-/***********************************************************************************/
-/// Include other APIs.
-/***********************************************************************************/
-
-#include <NewKit/Defines.hpp>
-
 ///! @note This address is reserved to NewKernel.
 #define kBootVirtualAddress (0xfffffff80000000)
 
@@ -39,12 +46,6 @@ using namespace NewOS;
 typedef Char *PEFImagePtr;
 typedef Char *PEImagePtr;
 
-enum {
-  kSegmentCode = 2,
-  kSegmentData = 4,
-  kSegmentBss = 6,
-};
-
 typedef WideChar CharacterTypeUTF16;
 typedef Char CharacterTypeUTF8;
 
@@ -169,3 +170,80 @@ static inline const UInt32 kRgbGreen = 0x0000FF00;
 static inline const UInt32 kRgbBlue = 0x00FF0000;
 static inline const UInt32 kRgbBlack = 0x00000000;
 static inline const UInt32 kRgbWhite = 0x00FFFFFF;
+
+/// @brief BootKit Disk Formatter.
+template <typename BootDev>
+class BDiskFormatFactory final {
+public:
+    /// @brief File entry for **BDiskFormatFactory**.
+    struct BFileDescriptor final {
+        Char fFilename[255];
+        Char fForkName[255];
+
+        VoidPtr fBlob;
+        SizeT fBlobSz;
+
+        struct BFileDescriptor* fPrev;
+        struct BFileDescriptor* fNext;
+    };
+
+public:
+    explicit BDiskFormatFactory() = default;
+    explicit BDiskFormatFactory(BootDev dev) : fDiskDev(dev) {}
+    ~BDiskFormatFactory() = default;
+
+    NEWOS_COPY_DELETE(BDiskFormatFactory);
+
+    /// @brief Format disk.
+    /// @param Partition Name
+    /// @param Blobs.
+    /// @param Number of blobs.
+    /// @retval True disk has been formatted.
+    /// @retval False failed to format.
+    Boolean Format(const char* partName, BFileDescriptor* fileBlobs, SizeT blobCount);
+
+private:
+    /// @brief Write all of the requested catalogs into the filesystem.
+    Boolean _AppendCatalogList(BFileDescriptor* fileBlobs, SizeT blobCount) {
+        return true;
+    }
+
+private:
+    BootDev fDiskDev;
+
+};
+
+/// @brief Format disk.
+/// @param Partition Name
+/// @param Blobs.
+/// @param Number of blobs.
+/// @retval True disk has been formatted.
+/// @retval False failed to format.
+template <typename BootDev>
+inline Boolean BDiskFormatFactory<BootDev>::Format(const char* partName,
+    BDiskFormatFactory::BFileDescriptor* fileBlobs, SizeT blobCount) {
+    // if (!fileBlobs || !blobCount) return false;
+
+    static_assert(kNewFSMinimumSectorSz == kATASectorSize, "Sector size doesn't match!");
+
+    Char buf[kNewFSMinimumSectorSz] = { 0 };
+    NewPartitionBlock* partBlock = reinterpret_cast<NewPartitionBlock*>(buf);
+
+    memcpy(partBlock->PartitionName, partName, strlen(partName));
+
+    /// @note A catalog roughly equal to a sector.
+
+    partBlock->CatalogCount = blobCount;
+    partBlock->Kind = kNewFSHardDrive;
+    partBlock->SectorCount = kNewFSMinimumSectorSz;
+    partBlock->FreeCatalog = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
+    partBlock->SectorCount = fDiskDev.GetSectorsCount();
+    partBlock->FreeSectors = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
+    partBlock->StartCatalog = kNewFSAddressAsLba + sizeof(NewPartitionBlock);
+
+    fDiskDev.Leak().mBase = (kNewFSAddressAsLba / kNewFSMinimumSectorSz);
+    fDiskDev.Leak().mSize = kNewFSMinimumSectorSz;
+    fDiskDev.Write(buf, kNewFSMinimumSectorSz);
+
+    return this->_AppendCatalogList(fileBlobs, blobCount);
+}
diff --git a/Private/NewBoot/BootKit/HW/ATA.hxx b/Private/NewBoot/BootKit/HW/ATA.hxx
index 9127e598..c557aeb8 100644
--- a/Private/NewBoot/BootKit/HW/ATA.hxx
+++ b/Private/NewBoot/BootKit/HW/ATA.hxx
@@ -34,6 +34,8 @@ class BootDeviceATA final : public Device {
  public:
   operator bool();
 
+  SizeT GetSectorsCount() noexcept;
+
   BootDeviceATA& Read(Char* Buf, const SizeT& SecCount) override;
   BootDeviceATA& Write(Char* Buf, const SizeT& SecCount) override;
 
@@ -41,4 +43,4 @@ class BootDeviceATA final : public Device {
 
  private:
   ATATrait mTrait;
-};
\ No newline at end of file
+};
diff --git a/Private/NewBoot/BootKit/Vendor/Qr.hxx b/Private/NewBoot/BootKit/Vendor/Qr.hxx
index ca5eb566..27db8060 100644
--- a/Private/NewBoot/BootKit/Vendor/Qr.hxx
+++ b/Private/NewBoot/BootKit/Vendor/Qr.hxx
@@ -12,6 +12,7 @@
 #include <BootKit/Vendor/Support.hxx>
 #include <Builtins/Toolbox/Toolbox.hxx>
 #include <cstdint>
+#include <CompilerKit/Detail.hxx>
 
 namespace qr {
 inline uint8_t min_poly =
@@ -811,6 +812,8 @@ public:
     explicit QrDelegate() = default;
     ~QrDelegate() = default;
 
+    NEWOS_COPY_DEFAULT(QrDelegate);
+
     /// @brief Draw method delegate.
     template <int V>
     bool draw(Qr<V>& subject, int x, int y) noexcept {
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index d3573064..10d4272d 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -25,7 +25,7 @@
 
 static Boolean kATADetected = false;
 static Int32 kATADeviceType = kATADeviceCount;
-static CharacterTypeUTF8 kATAData[kATADataLen] = {0};
+static UInt16 kATAData[kATADataLen] = {0};
 
 Boolean boot_ata_detected(Void);
 
@@ -82,8 +82,6 @@ ATAInit_Retry:
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_IDENTIFY);
 
-  BSetMem(kATAData, 0, kATADataLen);
-
   /// fetch serial info
   /// model, speed, number of sectors...
 
@@ -269,3 +267,10 @@ BootDeviceATA& BootDeviceATA::Write(CharacterTypeUTF8* Buf, const SizeT& SectorS
  * @return BootDeviceATA::ATATrait& the drive config.
  */
 BootDeviceATA::ATATrait& BootDeviceATA::Leak() { return mTrait; }
+
+/***
+    @brief Getter, gets the number of sectors inside the drive.
+*/
+SizeT BootDeviceATA::GetSectorsCount() noexcept {
+    return kATAData[60] + kATAData[61];
+}
diff --git a/Private/NewBoot/Source/HEL/AMD64/Support.cxx b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
index c6b62630..0508d491 100644
--- a/Private/NewBoot/Source/HEL/AMD64/Support.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
@@ -28,5 +28,19 @@ EXTERN_C VoidPtr memcpy(void *dst, const void *src,
   return dst;
 }
 
+/// @brief strlen definition in C++.
+EXTERN_C size_t strlen(const char *whatToCheck) {
+    if (!whatToCheck || *whatToCheck == 0) return 0;
+
+    SizeT len = 0;
+
+    while (whatToCheck[len] != 0) {
+        ++len;
+    }
+
+    return len;
+}
+
+
 /// @brief somthing specific to the microsoft ABI, regarding checking the stack.
 EXTERN_C void ___chkstk_ms(void) {}
diff --git a/Private/NewBoot/Source/HEL/POWER/BootCoreBoot.S b/Private/NewBoot/Source/HEL/POWER/BootCoreBoot.S
deleted file mode 100644
index c611467d..00000000
--- a/Private/NewBoot/Source/HEL/POWER/BootCoreBoot.S
+++ /dev/null
@@ -1,34 +0,0 @@
-/* -------------------------------------------
-
-    Copyright Mahrouss Logic
-
-------------------------------------------- */
-
-.section .boot_hdr
-.align 4
-
-/* NewBoot boot header begin */
-
-boot_hdr_mag:
-	.ascii "LX"
-boot_hdr_name:
-	// it has to match ten bytes.
-	.asciz "NewBoot\0\0\0"
-boot_hdr_ver:
-	.word 0x104
-boot_hdr_proc:
-	.long bootloader_start
-
-/* NewOS boot header end */
-
-.extern bootloader_main
-.extern bootloader_stack
-
-.globl bootloader_start
-bootloader_start:
-	mflr	4			/* real address of .Laddr */
-	lwz	0,(bootloader_stack-bootloader_start)(4)	/* stack address location */
-	mr	1,0			/* use user defined stack */
-
-    bl bootloader_main
-    blr
diff --git a/Private/NewBoot/Source/HEL/POWER/BootEPM.cxx b/Private/NewBoot/Source/HEL/POWER/BootEPM.cxx
deleted file mode 100644
index 72276ef9..00000000
--- a/Private/NewBoot/Source/HEL/POWER/BootEPM.cxx
+++ /dev/null
@@ -1,118 +0,0 @@
-/* -------------------------------------------
-
-    Copyright Mahrouss Logic
-
-------------------------------------------- */
-
-#include <BootKit/BootKit.hxx>
-#include <FSKit/NewFS.hxx>
-
-#define kEPMSectorSize (1024U)
-#define kEPMSwapSize MIB(16)
-
-// {310E1FC7-2060-425D-BE7B-75A37CC679BC}
-STATIC const BlockGUID kEPMGuid = {
-    0x310e1fc7,
-    0x2060,
-    0x425d,
-    {0xbe, 0x7b, 0x75, 0xa3, 0x7c, 0xc6, 0x79, 0xbc}};
-
-/// @brief Write epm partition to disk.
-/// @param namePart partition name
-/// @param namePartLength length of name
-/// @param bootDev disk interface.
-/// @return
-EXTERN_C Boolean boot_write_epm_partition(const Char* namePart, SizeT namePartLength,
-                                 BootDevice* bootDev) {
-  if (namePartLength > kEPMNameLength || !namePart) return No;
-  if (!bootDev) return No;
-
-  bootDev->Leak().mBase = kEPMStartPartitionBlk;
-  bootDev->Leak().mSize = kEPMSectorSize;
-
-  Char buf[kEPMSectorSize] = {0};
-
-  bootDev->Read(buf, 1);
-
-  BTextWriter writer;
-
-  writer.Write(L"NewBoot: Checking for an EPM partition...\r\n");
-
-  for (SizeT index = 0; index < kEPMMagicLength; ++index) {
-    if (buf[index] != kEPMMagic[index]) {
-      writer.Write(L"NewBoot: Writing an EPM partition...\r\n");
-
-      BootBlockType* bootBlock = (BootBlockType*)buf;
-
-      bootBlock->Version = kEPMRevision;
-      bootBlock->NumBlocks = 2;
-
-      for (SizeT i = 0; i < kEPMNameLength; ++i) {
-        bootBlock->Magic[i] = kEPMMagic[i];
-      }
-
-      for (SizeT i = 0; i < namePartLength; ++i) {
-        bootBlock->Name[i] = namePart[i];
-      }
-
-      bootBlock->LbaStart =
-          sizeof(BootBlockType) + (sizeof(PartitionBlockType) * kEPMMaxBlks);
-
-      bootBlock->SectorSz = kEPMSectorSize;
-
-      bootBlock->Uuid = kEPMGuid;
-
-      PartitionBlock* partBlock = (PartitionBlock*)(buf + sizeof(BootBlock));
-
-      char* fsName = "NewFS";
-      int fsNameLength = 6;
-
-      for (SizeT i = 0; i < fsNameLength; ++i) {
-        partBlock->Fs[i] = fsName[i];
-      }
-
-      partBlock->Version = kEPMNewOS;
-
-      char* partName = "System HD";
-      int partNameLength = 10;
-
-      for (SizeT i = 0; i < partNameLength; ++i) {
-        partBlock->Name[i] = partName[i];
-      }
-
-      partBlock->SectorSz = kEPMSectorSize;
-      partBlock->LbaStart = kEPMStartPartitionBlk + kEPMSwapSize;
-      partBlock->Version = kNewFSVersionInteger;
-      partBlock->Kind = kNewFSPartitionTypeStandard;
-      partBlock->LbaEnd = 0UL; ///! grows on the disk.
-
-      PartitionBlock* swapBlock = (PartitionBlock*)(buf + sizeof(BootBlock) + sizeof(PartitionBlock));
-
-      for (SizeT i = 0; i < fsNameLength; ++i) {
-        swapBlock->Fs[i] = fsName[i];
-      }
-
-      swapBlock->Version = kEPMNewOS;
-
-      partName = "Swap HD";
-      partNameLength = 8;
-
-      for (SizeT i = 0; i < partNameLength; ++i) {
-        swapBlock->Name[i] = partName[i];
-      }
-
-      swapBlock->SectorSz = kEPMSectorSize;
-      swapBlock->LbaStart = kEPMStartPartitionBlk;
-      swapBlock->Version = kNewFSVersionInteger;
-      swapBlock->Kind = kNewFSPartitionTypePage;
-      swapBlock->LbaEnd = kEPMSwapSize; /// 4 MIB swap partition.
-
-      bootDev->Write(buf, 1);
-
-      return No;
-    }
-  }
-
-  writer.Write(L"NewBoot: Partition found, everything's OK.\r\n");
-  return Yes;
-}
diff --git a/Private/NewBoot/Source/HEL/POWER/CoreBootStartup.S b/Private/NewBoot/Source/HEL/POWER/CoreBootStartup.S
new file mode 100644
index 00000000..41fc6ae2
--- /dev/null
+++ b/Private/NewBoot/Source/HEL/POWER/CoreBootStartup.S
@@ -0,0 +1,34 @@
+/* -------------------------------------------
+
+    Copyright Mahrouss Logic
+
+------------------------------------------- */
+
+.section .boot_hdr
+.align 4
+
+/* NewBoot boot header begin */
+
+boot_hdr_mag:
+	.ascii "CB"
+boot_hdr_name:
+	// it has to match ten bytes.
+	.asciz "NewBoot\0\0\0"
+boot_hdr_ver:
+	.word 0x104
+boot_hdr_proc:
+	.long bootloader_start
+
+/* NewOS boot header end */
+
+.extern bootloader_main
+.extern bootloader_stack
+
+.globl bootloader_start
+bootloader_start:
+	mflr	4			/* real address of .Laddr */
+	lwz	0,(bootloader_stack-bootloader_start)(4)	/* stack address location */
+	mr	1,0			/* use user defined stack */
+
+    bl bootloader_main
+    blr
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 11c1da75..7ed42abd 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -51,6 +51,7 @@ all: compile-amd64
 	$(DD) if=$(KERNEL_OBJ) of=$(BOOT_LOADER) bs=1 seek=0 conv=notrunc
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/BOOTX64.EFI
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/NEWBOOT.EFI
+	$(COPY) ../../$(KERNEL) CDROM/$(KERNEL)
 	$(COPY) $(BOOT_LOADER) ../../Root/Boot/$(BOOT_LOADER)
 
 ifneq ($(DEBUG_SUPPORT), )
@@ -68,8 +69,8 @@ run-efi-amd64:
 
 .PHONY: epm-img
 epm-img:
-	qemu-img create -f raw $(IMG) 256M
-	qemu-img create -f raw $(IMG_2) 512M
+	qemu-img create -f qcow2 $(IMG) 256M
+	qemu-img create -f qcow2 $(IMG_2) 512M
 
 .PHONY: download-edk
 download-edk:
-- 
cgit v1.2.3


From 9bf7420620393fe693576aa04c57ea4eefc925d7 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 15:05:50 +0200
Subject: MHR-16: Improve clean rule.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/Source/makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 7ed42abd..6eb14801 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -78,7 +78,7 @@ download-edk:
 
 .PHONY: clean
 clean:
-	$(REM) $(REM_FLAG) $(OBJ) NewBoot.exe NewKernel.exe OVMF.fd $(IMG) $(IMG_2)
+	$(REM) $(REM_FLAG) $(OBJ) NewBoot.exe NewKernel.exe OVMF.fd $(IMG) $(IMG_2) *.bin
 
 .PHONY: help
 help:
-- 
cgit v1.2.3


From d7420ce44209bf6225df644880c0da2b2fb8638a Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 15:14:28 +0200
Subject: MHR-16: Improve makefile, add $(TARGETS) which encapsulate all of the
 targets.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/Source/makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 6eb14801..f0e44ba2 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -76,9 +76,11 @@ epm-img:
 download-edk:
 	$(HTTP_GET) https://retrage.github.io/edk2-nightly/bin/DEBUGX64_OVMF.fd -O OVMF.fd
 
+TARGETS=$(REM_FLAG) $(OBJ) NewBoot.exe NewKernel.exe OVMF.fd $(IMG) $(IMG_2) *.bin
+
 .PHONY: clean
 clean:
-	$(REM) $(REM_FLAG) $(OBJ) NewBoot.exe NewKernel.exe OVMF.fd $(IMG) $(IMG_2) *.bin
+	$(REM) $(TARGETS)
 
 .PHONY: help
 help:
-- 
cgit v1.2.3


From 9679735cb60011490c92fd8d3b13d337120a22ea Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Thu, 25 Apr 2024 16:23:14 +0200
Subject: MHR-16: Made it better.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/Source/makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index f0e44ba2..93bb5e28 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -76,7 +76,10 @@ epm-img:
 download-edk:
 	$(HTTP_GET) https://retrage.github.io/edk2-nightly/bin/DEBUGX64_OVMF.fd -O OVMF.fd
 
-TARGETS=$(REM_FLAG) $(OBJ) NewBoot.exe NewKernel.exe OVMF.fd $(IMG) $(IMG_2) *.bin
+BINS=*.bin
+EXECUTABLES=NewBoot.exe NewKernel.exe OVMF.fd
+
+TARGETS=$(REM_FLAG) $(OBJ) $(BIN) $(IMG) $(IMG_2) $(EXECUTABLES)
 
 .PHONY: clean
 clean:
-- 
cgit v1.2.3


From 3b4a4a290b32fdb4a749b3e581afae450eb543c8 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 08:13:03 +0200
Subject: MHR-16: NewBoot - BDiskFormatter and QR.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/FSKit/NewFS.hxx                            |   9 +-
 Private/HALKit/AMD64/HalNewBoot.asm                |  14 +-
 Private/HALKit/AMD64/Storage/ATA-PIO.cxx           |   2 +-
 Private/HALKit/POWER/HalStartSequence.s            |   8 +-
 Private/Linker/16x0.json                           |   2 +-
 Private/Linker/32x0.json                           |   2 +-
 Private/Linker/64x0.json                           |   2 +-
 Private/NewBoot/BootKit/BootKit.hxx                | 149 ++++++++++++++++++---
 Private/NewBoot/BootKit/HW/ATA.hxx                 |   2 +
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx       |  26 +---
 Private/NewBoot/Source/HEL/AMD64/BootJump.S        |   9 ++
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx      |  94 ++++++++-----
 .../NewBoot/Source/HEL/AMD64/BootTextWriter.cxx    |   2 +-
 Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx    |  11 ++
 Private/NewBoot/Source/makefile                    |  13 +-
 Private/NewLoader/ReadMe.md                        |   9 --
 Private/NewLoader/Source/.gitkeep                  |   0
 Private/makefile                                   |  10 +-
 18 files changed, 253 insertions(+), 111 deletions(-)
 create mode 100644 Private/NewBoot/Source/HEL/AMD64/BootJump.S
 delete mode 100644 Private/NewLoader/ReadMe.md
 delete mode 100644 Private/NewLoader/Source/.gitkeep

(limited to 'Private/NewBoot/Source')

diff --git a/Private/FSKit/NewFS.hxx b/Private/FSKit/NewFS.hxx
index cc43f51b..d3b72803 100644
--- a/Private/FSKit/NewFS.hxx
+++ b/Private/FSKit/NewFS.hxx
@@ -38,7 +38,7 @@ default.
 
 #define kNewFSIdentLen 8
 #define kNewFSIdent " NewFS"
-#define kNewFSPadLen 16
+#define kNewFSPadLen 408
 
 /// @brief Partition GUID on EPM and GPT disks.
 #define kNewFSUUID "@{DD997393-9CCE-4288-A8D5-C0FDE3908DBE}"
@@ -83,6 +83,7 @@ default.
 
 /// Start After the PM headers, pad 1024 bytes.
 #define kNewFSAddressAsLba (1024)
+#define kNewFSCatalogStartAddress (kNewFSAddressAsLba + sizeof(NewPartitionBlock))
 
 #define kResourceTypeDialog 10
 #define kResourceTypeString 11
@@ -139,6 +140,9 @@ struct PACKED NewFork final {
 
   NewOS::Lba NextSibling;
   NewOS::Lba PreviousSibling;
+
+  /// To make a perfect sector.
+  NewOS::Char Padding[200];
 };
 
 /// @brief Partition block type
@@ -174,6 +178,9 @@ enum {
   kNewFSSubDriveCount,
 };
 
+/// \brief Resource fork kind.
+enum { kNewFSRsrcForkKind = 0, kNewFSDataForkKind = 1 };
+
 ///
 /// \name NewFSParser
 /// \brief NewFS parser class. (catalog creation, remove removal, root,
diff --git a/Private/HALKit/AMD64/HalNewBoot.asm b/Private/HALKit/AMD64/HalNewBoot.asm
index 995a848c..11b11c0c 100644
--- a/Private/HALKit/AMD64/HalNewBoot.asm
+++ b/Private/HALKit/AMD64/HalNewBoot.asm
@@ -23,22 +23,16 @@ HandoverMagic: dq kHandoverMagic
 HandoverType: dw kTypeKernel
 HandoverArch: dw kArchAmd64
 ;; This NewBootStart points to Main.
-HandoverStart: dq Main
+HandoverStart: dq __ImageStart
 
 section .text
 
-global Main
+global __ImageStart
 extern hal_init_platform
 
 ;; Just a simple setup, we'd also need to tell some before
-Main:
-    push rax
+__ImageStart:
     push rcx
     call hal_init_platform
     pop rcx
-    pop rax
-;; Go to sleep.
-MainLoop:
-    cli
-    hlt
-    jmp $
+    ret
diff --git a/Private/HALKit/AMD64/Storage/ATA-PIO.cxx b/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
index 3cbba6f7..652aa6f4 100644
--- a/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
+++ b/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
@@ -58,7 +58,7 @@ Void drv_std_select(UInt16 Bus) {
 
 Boolean drv_std_init(UInt16 Bus, UInt8 Drive, UInt16& OutBus,
                       UInt8& OutMaster) {
-  if (drv_std_detected()) return false;
+  if (drv_std_detected()) return true;
 
   UInt16 IO = Bus;
 
diff --git a/Private/HALKit/POWER/HalStartSequence.s b/Private/HALKit/POWER/HalStartSequence.s
index f50a4d4f..fd018304 100644
--- a/Private/HALKit/POWER/HalStartSequence.s
+++ b/Private/HALKit/POWER/HalStartSequence.s
@@ -4,11 +4,11 @@
 
 ------------------------------------------- */
 
-.globl Main
-.extern HalKernelMain
+.globl __ImageStart
+.extern hal_init_platform
 .align 4
 .text
 
-Main:
-	bl HalKernelMain
+__ImageStart:
+	bl hal_init_platform
 	blr
diff --git a/Private/Linker/16x0.json b/Private/Linker/16x0.json
index 1dd7abbd..5851a2d3 100644
--- a/Private/Linker/16x0.json
+++ b/Private/Linker/16x0.json
@@ -1,6 +1,6 @@
 {
   "executable_type": "kernel",
   "output_name": "NewKernel.exe",
-  "start_proc": "Main",
+  "start_proc": "__ImageStart",
   "format": "PEF"
 }
diff --git a/Private/Linker/32x0.json b/Private/Linker/32x0.json
index 1dd7abbd..5851a2d3 100644
--- a/Private/Linker/32x0.json
+++ b/Private/Linker/32x0.json
@@ -1,6 +1,6 @@
 {
   "executable_type": "kernel",
   "output_name": "NewKernel.exe",
-  "start_proc": "Main",
+  "start_proc": "__ImageStart",
   "format": "PEF"
 }
diff --git a/Private/Linker/64x0.json b/Private/Linker/64x0.json
index 1dd7abbd..5851a2d3 100644
--- a/Private/Linker/64x0.json
+++ b/Private/Linker/64x0.json
@@ -1,6 +1,6 @@
 {
   "executable_type": "kernel",
   "output_name": "NewKernel.exe",
-  "start_proc": "Main",
+  "start_proc": "__ImageStart",
   "format": "PEF"
 }
diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index 15700f54..6272e4c9 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -6,7 +6,7 @@
 
 /***********************************************************************************/
 /// @file Boot.hxx
-/// @brief Bootloader API.
+/// @brief Bootloader Programming Interface.
 /***********************************************************************************/
 
 #pragma once
@@ -25,7 +25,7 @@
 /***********************************************************************************/
 
 #include <NewKit/Defines.hpp>
-#include "Builtins/ATA/ATA.hxx"
+#include <Builtins/ATA/ATA.hxx>
 
 /***********************************************************************************/
 /// Framebuffer helpers.
@@ -49,6 +49,11 @@ typedef Char *PEImagePtr;
 typedef WideChar CharacterTypeUTF16;
 typedef Char CharacterTypeUTF8;
 
+namespace EFI  {
+    extern void ThrowError(const CharacterTypeUTF16 *ErrorCode,
+                               const CharacterTypeUTF16 *Reason) noexcept;
+}
+
 /**
  * @brief BootKit Text Writer class
  * Writes to UEFI StdOut.
@@ -58,7 +63,7 @@ class BTextWriter final {
 
  public:
   BTextWriter &Write(const Long &num);
-  BTextWriter &Write(const UChar *str);
+  BTextWriter &Write(const Char *str);
   BTextWriter &Write(const CharacterTypeUTF16 *str);
   BTextWriter &WriteCharacter(CharacterTypeUTF16 c);
 
@@ -171,14 +176,19 @@ static inline const UInt32 kRgbBlue = 0x00FF0000;
 static inline const UInt32 kRgbBlack = 0x00000000;
 static inline const UInt32 kRgbWhite = 0x00FFFFFF;
 
+#define kBKBootFileMime "boot-x/file"
+#define kBKBootDirMime  "boot-x/dir"
+
 /// @brief BootKit Disk Formatter.
 template <typename BootDev>
 class BDiskFormatFactory final {
 public:
     /// @brief File entry for **BDiskFormatFactory**.
     struct BFileDescriptor final {
-        Char fFilename[255];
-        Char fForkName[255];
+        Char fFileName[kNewFSNodeNameLen];
+        Char fForkName[kNewFSNodeNameLen];
+
+        UInt32 fKind;
 
         VoidPtr fBlob;
         SizeT fBlobSz;
@@ -190,6 +200,7 @@ public:
 public:
     explicit BDiskFormatFactory() = default;
     explicit BDiskFormatFactory(BootDev dev) : fDiskDev(dev) {}
+
     ~BDiskFormatFactory() = default;
 
     NEWOS_COPY_DELETE(BDiskFormatFactory);
@@ -204,7 +215,101 @@ public:
 
 private:
     /// @brief Write all of the requested catalogs into the filesystem.
-    Boolean _AppendCatalogList(BFileDescriptor* fileBlobs, SizeT blobCount) {
+    Boolean WriteContent(BFileDescriptor* fileBlobs, SizeT blobCount,
+                        SizeT sectorSz, NewPartitionBlock& partBlock) {
+        if (sectorSz != BootDev::kSectorSize) return false;
+
+        BFileDescriptor* blob = fileBlobs;
+        Lba startLba = partBlock.FreeCatalog;
+
+        BTextWriter writer;
+        while (blob) {
+            NewCatalog catalogKind{ 0 };
+
+            /// Fill catalog kind.
+            catalogKind.Kind = blob->fKind;
+
+            /// Allocate fork for blob.
+            catalogKind.FirstFork = (startLba + sizeof(NewCatalog));
+            catalogKind.LastFork = catalogKind.FirstFork;
+
+            NewFork forkKind{ 0 };
+
+            memcpy(forkKind.Name, blob->fForkName, strlen(blob->fForkName));
+            forkKind.Kind = (forkKind.Name[0] == kNewFSDataFork[0]) ? kNewFSDataForkKind : kNewFSRsrcForkKind;
+            forkKind.Flags = kNewFSFlagCreated;
+
+            /// We don't know.
+            forkKind.ResourceFlags = 0;
+            forkKind.ResourceId = 0;
+            forkKind.ResourceKind = 0;
+
+            /// We're the only fork here.
+            forkKind.NextSibling = catalogKind.FirstFork;
+            forkKind.PreviousSibling = catalogKind.FirstFork;
+
+            forkKind.DataOffset = (startLba + sizeof(NewCatalog) + sizeof(NewFork));
+            forkKind.DataSize = blob->fBlobSz;
+
+            Lba lbaStart = forkKind.DataOffset;
+            SizeT cur = 0UL;
+
+            while (cur < forkKind.DataSize) {
+                this->fDiskDev.Leak().mSize = BootDev::kSectorSize;
+                this->fDiskDev.Leak().mBase = forkKind.DataOffset / BootDev::kSectorSize;
+
+                this->fDiskDev.Write((Char*)(blob->fBlob) + cur, BootDev::kSectorSize);
+
+                cur += BootDev::kSectorSize;
+                lbaStart += BootDev::kSectorSize;
+            }
+
+            writer.Write((catalogKind.Kind == kNewFSCatalogKindFile) ? L"New Boot: Write-File: " :
+                L"New Boot: Write-Directory: " ).Write(blob->fFileName).Write(L"\r\n");
+
+            /// Set disk cursor here.
+
+            fDiskDev.Leak().mBase = startLba + sizeof(NewCatalog) / sectorSz;
+            fDiskDev.Leak().mSize = sizeof(NewFork);
+
+            fDiskDev.Write((Char*)&forkKind, 1);
+
+            /// Fork is done.
+
+            catalogKind.Kind = blob->fKind;
+            catalogKind.Flags |= kNewFSFlagCreated;
+
+            Lba catalogLba = (sizeof(NewCatalog) - startLba);
+
+            //// Now write catalog as well..
+
+            catalogKind.PrevSibling = startLba;
+            catalogKind.NextSibling = (sizeof(NewCatalog) + blob->fBlobSz);
+
+            /// this mime only applies to file.
+            if (catalogKind.Kind == kNewFSCatalogKindFile) {
+                memcpy(catalogKind.Mime, kBKBootFileMime, strlen(kBKBootFileMime));
+            } else  {
+                memcpy(catalogKind.Mime, kBKBootDirMime, strlen(kBKBootDirMime));
+            }
+
+            memcpy(catalogKind.Name, blob->fFileName, strlen(blob->fFileName));
+
+            fDiskDev.Leak().mBase = startLba / sectorSz;
+            fDiskDev.Leak().mSize = sizeof(NewCatalog);
+
+            fDiskDev.Write((Char*)&catalogKind, sectorSz);
+
+            startLba += (sizeof(NewCatalog) + blob->fBlobSz);
+
+            --partBlock.FreeCatalog;
+            --partBlock.FreeSectors;
+
+            ++partBlock.CatalogCount;
+
+            blob = blob->fNext;
+        }
+
         return true;
     }
 
@@ -222,28 +327,40 @@ private:
 template <typename BootDev>
 inline Boolean BDiskFormatFactory<BootDev>::Format(const char* partName,
     BDiskFormatFactory::BFileDescriptor* fileBlobs, SizeT blobCount) {
-    // if (!fileBlobs || !blobCount) return false;
+    if (!fileBlobs || !blobCount) return false; /// sanity check
 
-    static_assert(kNewFSMinimumSectorSz == kATASectorSize, "Sector size doesn't match!");
+    /// convert the sector into something that the disk understands.
+    SizeT sectorSz =  BootDev::kSectorSize;
+    Char buf[BootDev::kSectorSize] = { 0 };
 
-    Char buf[kNewFSMinimumSectorSz] = { 0 };
     NewPartitionBlock* partBlock = reinterpret_cast<NewPartitionBlock*>(buf);
 
+    memcpy(partBlock->Ident, kNewFSIdent, kNewFSIdentLen-1);
     memcpy(partBlock->PartitionName, partName, strlen(partName));
 
     /// @note A catalog roughly equal to a sector.
 
-    partBlock->CatalogCount = blobCount;
+    partBlock->CatalogCount = 0UL;
     partBlock->Kind = kNewFSHardDrive;
-    partBlock->SectorCount = kNewFSMinimumSectorSz;
+    partBlock->SectorSize = sectorSz;
     partBlock->FreeCatalog = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
     partBlock->SectorCount = fDiskDev.GetSectorsCount();
     partBlock->FreeSectors = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
-    partBlock->StartCatalog = kNewFSAddressAsLba + sizeof(NewPartitionBlock);
+    partBlock->StartCatalog = kNewFSCatalogStartAddress;
 
-    fDiskDev.Leak().mBase = (kNewFSAddressAsLba / kNewFSMinimumSectorSz);
-    fDiskDev.Leak().mSize = kNewFSMinimumSectorSz;
-    fDiskDev.Write(buf, kNewFSMinimumSectorSz);
+    if (this->WriteContent(fileBlobs, blobCount, sectorSz, *partBlock)) {
+        fDiskDev.Leak().mBase = (kNewFSAddressAsLba / sectorSz);
+        fDiskDev.Leak().mSize = BootDev::kSectorSize;
+
+        fDiskDev.Write(buf, sectorSz);
+
+        BTextWriter writer;
+        writer.Write(L"New Boot: Write-Partition, OK.\r\n");
+
+        return true;
+    } else {
+        EFI::ThrowError(L"Filesystem-Failure-Part", L"Filesystem couldn't be partitioned.");
+    }
 
-    return this->_AppendCatalogList(fileBlobs, blobCount);
+    return false;
 }
diff --git a/Private/NewBoot/BootKit/HW/ATA.hxx b/Private/NewBoot/BootKit/HW/ATA.hxx
index c557aeb8..4b96e9fa 100644
--- a/Private/NewBoot/BootKit/HW/ATA.hxx
+++ b/Private/NewBoot/BootKit/HW/ATA.hxx
@@ -23,6 +23,8 @@ class BootDeviceATA final : public Device {
 
   NEWOS_COPY_DEFAULT(BootDeviceATA);
 
+  enum { kSectorSize = kATASectorSize };
+
   struct ATATrait final : public Device::Trait {
     UInt16 mBus{kPrimary};
     UInt8 mMaster{0};
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index 10d4272d..8d923a50 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -132,7 +132,7 @@ ATAInit_Retry:
 
 Void boot_ata_read(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
                    SizeT SectorSz, SizeT Size) {
-  UInt8 Command = (!Master ? 0xE0 : 0xF0);
+  UInt8 Command = ((!Master) ? 0xE0 : 0xF0);
 
   boot_ata_wait_io(IO);
 
@@ -146,27 +146,15 @@ Void boot_ata_read(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO);
 
-  while ((In8(ATA_COMMAND(IO))) & ATA_SR_BSY) boot_ata_wait_io(IO);
-
-  UInt16 byte = In16(IO + ATA_REG_DATA);
-  SizeT IndexOff = 0UL;
-  Buf[IndexOff] = byte;
-
-  while (byte != 0xFF) {
-    if (IndexOff > Size) break;
-
-    ++IndexOff;
-
-    while ((In8(ATA_COMMAND(IO))) & ATA_SR_BSY) boot_ata_wait_io(IO);
-
-    byte = In16(IO + ATA_REG_DATA);
-    Buf[IndexOff] = byte;
+  for (SizeT IndexOff = 0; IndexOff < Size; ++IndexOff) {
+    boot_ata_wait_io(IO);
+    Buf[IndexOff] = In16(IO + ATA_REG_DATA);
   }
 }
 
 Void boot_ata_write(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
                     SizeT SectorSz, SizeT Size) {
-  UInt8 Command = (!Master ? 0xE0 : 0xF0);
+  UInt8 Command = ((!Master) ? 0xE0 : 0xF0);
 
   boot_ata_wait_io(IO);
 
@@ -209,10 +197,6 @@ BootDeviceATA::BootDeviceATA() noexcept {
       boot_ata_init(ATA_SECONDARY_IO, true, this->Leak().mBus,
                     this->Leak().mMaster)) {
     kATADetected = true;
-
-    BTextWriter writer;
-
-    writer.Write(L"New Boot: Drive is OnLine.\r\n");
   }
 }
 /**
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootJump.S b/Private/NewBoot/Source/HEL/AMD64/BootJump.S
new file mode 100644
index 00000000..af278cc7
--- /dev/null
+++ b/Private/NewBoot/Source/HEL/AMD64/BootJump.S
@@ -0,0 +1,9 @@
+.global rt_jump_to_address
+.text
+
+.code64
+.intel_syntax noprefix
+
+rt_jump_to_address:
+    jmp rcx
+    ret
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index 356db88b..ea3fcbf0 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -9,8 +9,15 @@
 #include <FirmwareKit/EFI.hxx>
 #include <KernelKit/MSDOS.hpp>
 #include <KernelKit/PEF.hpp>
-#include <NewKit/Ref.hpp>
+#include <NewKit/Macros.hpp>
 #include <BootKit/BootKit.hxx>
+#include <NewKit/Ref.hpp>
+#include <cstring>
+
+/// make the compiler shut up.
+#ifndef kMachineModel
+#define kMachineModel "NeWS HD"
+#endif // !kMachineModel
 
 /** Graphics related. */
 
@@ -18,6 +25,8 @@ STATIC EfiGraphicsOutputProtocol* kGop = nullptr;
 STATIC UInt16 kStride = 0U;
 STATIC EfiGUID kGopGuid;
 
+EXTERN_C Void rt_jump_to_address(VoidPtr blob);
+
 /**
     @brief Finds and stores the GOP.
 */
@@ -166,45 +175,66 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
     }
   }
 
-  BFileReader kernelFile(L"NewLoader.exe", ImageHandle);
-  kernelFile.ReadAll(MIB(1), 4096);
+  ///
+  /// The following checks for an exisiting partition
+  /// inside the disk, if it doesn't have one,
+  /// format the disk.
+  //
 
-  if (kernelFile.Blob()) {
-    PEFContainer* containerKind =
-        reinterpret_cast<PEFContainer*>(kernelFile.Blob());
+  /// need this as well, to invoke BExecutableLoader.
+  BFileReader readerKernel(L"NewKernel.exe", ImageHandle);
+  readerKernel.ReadAll(MIB(1), 4096);
 
-    if (containerKind->Magic[0] == kPefMagic[0] &&
-        containerKind->Magic[1] == kPefMagic[1] &&
-        containerKind->Magic[2] == kPefMagic[2] &&
-        containerKind->Magic[3] == kPefMagic[3] &&
-        containerKind->Magic[4] == kPefMagic[4]) {
-      if (containerKind->Abi != kPefAbi ||
-          containerKind->Cpu != kPefArchAMD64) {
-        EFI::ThrowError(L"Bad-Architecture",
-                        L"New Boot can't run this architecture.");
-      }
+  BDiskFormatFactory<BootDeviceATA> diskFormatter;
 
-      NewOS::HEL::BootMainKind main =
-          reinterpret_cast<NewOS::HEL::BootMainKind>(containerKind +
-                                                     containerKind->Start);
+  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor rootDesc{0};
 
-      if (!main) {
-        EFI::ThrowError(L"Bad-Exec",
-                        L"New Boot can't recognize this executable.");
-      }
+  memcpy(rootDesc.fFileName, "/", strlen("/"));
+  memcpy(rootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
 
-      EFI::ExitBootServices(MapKey, ImageHandle);
+  rootDesc.fBlobSz = strlen(kMachineModel " startup disk.");
+  rootDesc.fBlob = new Char[rootDesc.fBlobSz];
 
-      main(handoverHdrPtr);
+  memcpy(rootDesc.fBlob, kMachineModel " startup disk.",
+         strlen(kMachineModel " startup disk."));
 
-      EFI::Stop();
+  rootDesc.fKind = kNewFSCatalogKindDir;
 
-      CANT_REACH();
-    }
-  }
+  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor bootDesc{0};
+
+  bootDesc.fKind = kNewFSCatalogKindDir;
+
+  memcpy(bootDesc.fFileName, "/Boot", strlen("/Boot"));
+  memcpy(bootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
+  memcpy(bootDesc.fBlob, kMachineModel " startup folder.",
+         strlen(kMachineModel " startup folder."));
+
+  bootDesc.fBlobSz = strlen(kMachineModel " startup folder.");
+  bootDesc.fBlob = new Char[bootDesc.fBlobSz];
+
+  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor kernelDesc{0};
+
+  kernelDesc.fKind = kNewFSCatalogKindFile;
+
+  memcpy(kernelDesc.fFileName, "/Boot/NewKernel", strlen("/Boot/NewKernel"));
+  memcpy(kernelDesc.fForkName, kNewFSDataFork, strlen(kNewFSDataFork));
+
+  kernelDesc.fBlob = readerKernel.Blob();
+  kernelDesc.fBlobSz = readerKernel.Size();
+
+  rootDesc.fNext = &bootDesc;
+  rootDesc.fNext->fPrev = &rootDesc;
+
+  rootDesc.fNext->fNext = &kernelDesc;
+  rootDesc.fNext->fNext->fPrev = &bootDesc;
+
+  diskFormatter.Format(kMachineModel, &rootDesc, 3);
+
+  EFI::ExitBootServices(MapKey, ImageHandle);
+
+  rt_jump_to_address(readerKernel.Blob());
 
-  EFI::ThrowError(L"Invalid-PEF-Executable",
-                  L"PEF executable expected. Got something else.");
+  EFI::Stop();
 
-  return kEfiFail;
+  CANT_REACH();
 }
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
index 81aa6c9d..ff30ff95 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
@@ -32,7 +32,7 @@ BTextWriter &BTextWriter::Write(const CharacterTypeUTF16 *str) {
   return *this;
 }
 
-BTextWriter &BTextWriter::Write(const UChar *str) {
+BTextWriter &BTextWriter::Write(const Char *str) {
 #ifdef __DEBUG__
   if (!str || *str == 0) return *this;
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
index 77552ef8..01911c43 100644
--- a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
@@ -20,6 +20,17 @@ void* operator new(size_t sz)
     return buf;
 }
 
+/// @brief Allocates a new object.
+/// @param sz the size.
+/// @return
+void* operator new[](size_t sz)
+{
+    void* buf = nullptr;
+    BS->AllocatePool(EfiMemoryType::EfiLoaderData, sz, &buf);
+
+    return buf;
+}
+
 /// @brief Deletes the object.
 /// @param buf the object.
 void operator delete(void* buf)
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 93bb5e28..92128b02 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -18,6 +18,10 @@ else
 EMU=qemu-system-x86_64
 endif
 
+ifeq ($(NEWS_MODEL), )
+NEWOS_MODEL=-DkMachineModel="\"Generic NeWS HD\""
+endif
+
 IMG=epm.img
 IMG_2=epm-slave.img
 EMU_FLAGS=-net none -smp 4 -m 8G -M q35 -bios OVMF.fd -device piix3-ide,id=ide -drive id=disk,file=$(IMG),format=raw,if=none -device ide-hd,drive=disk,bus=ide.0 -drive file=fat:rw:CDROM,index=2,format=raw -d int -hdd epm-slave.img
@@ -46,13 +50,10 @@ KERNEL=NewKernel.exe
 .PHONY: all
 all: compile-amd64
 	mkdir -p CDROM/EFI/BOOT
-	$(LD_GNU) $(OBJ) $(LD_FLAGS) -o $(KERNEL_OBJ)
-	$(IMG_CREATE) create -f raw $(BOOT_LOADER) $(MAX_KERNEL_SIZE)
-	$(DD) if=$(KERNEL_OBJ) of=$(BOOT_LOADER) bs=1 seek=0 conv=notrunc
+	$(LD_GNU) $(OBJ) $(LD_FLAGS) -o $(BOOT_LOADER)
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/BOOTX64.EFI
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/NEWBOOT.EFI
 	$(COPY) ../../$(KERNEL) CDROM/$(KERNEL)
-	$(COPY) $(BOOT_LOADER) ../../Root/Boot/$(BOOT_LOADER)
 
 ifneq ($(DEBUG_SUPPORT), )
 DEBUG =  -D__DEBUG__
@@ -61,7 +62,7 @@ endif
 .PHONY: compile-amd64
 compile-amd64:
 	$(WINDRES) BootloaderRsrc.rsrc -O coff -o BootloaderRsrc.o
-	$(CC_GNU) $(FLAG_GNU) $(DEBUG) $(wildcard HEL/AMD64/*.cxx) $(wildcard *.cxx)
+	$(CC_GNU) $(NEWOS_MODEL) $(FLAG_GNU) $(DEBUG) $(wildcard HEL/AMD64/*.cxx) $(wildcard HEL/AMD64/*.S) $(wildcard *.cxx)
 
 .PHONY: run-efi-amd64
 run-efi-amd64:
@@ -69,7 +70,7 @@ run-efi-amd64:
 
 .PHONY: epm-img
 epm-img:
-	qemu-img create -f qcow2 $(IMG) 256M
+	qemu-img create -f qcow2 $(IMG) 512M
 	qemu-img create -f qcow2 $(IMG_2) 512M
 
 .PHONY: download-edk
diff --git a/Private/NewLoader/ReadMe.md b/Private/NewLoader/ReadMe.md
deleted file mode 100644
index 955f0651..00000000
--- a/Private/NewLoader/ReadMe.md
+++ /dev/null
@@ -1,9 +0,0 @@
-# NewLoader
-
-## New OS Stage 2 loader.
-
-Loads and runs the NewKernel and it's components.
-
-- Loads: NewKernel.exe, a MicroKernel in C++ (PEF)
-- Loads: Bonjour.exe, zeroconf driver. (PEF)
-- Loads: MahroussUpdate.exe, mahrouss system update driver. (PEF)
diff --git a/Private/NewLoader/Source/.gitkeep b/Private/NewLoader/Source/.gitkeep
deleted file mode 100644
index e69de29b..00000000
diff --git a/Private/makefile b/Private/makefile
index 673a4b56..977e33ac 100644
--- a/Private/makefile
+++ b/Private/makefile
@@ -5,7 +5,7 @@
 
 CC			= x86_64-w64-mingw32-gcc
 LD			= x86_64-w64-mingw32-ld
-CCFLAGS		= -c -ffreestanding -fPIE -fPIC -D__NEWOS_AMD64__ -mno-red-zone -fno-rtti -fno-exceptions -std=c++20 -D__FSKIT_NEWFS__ -D__KERNEL__ -D__HAVE_MAHROUSS_APIS__ -D__MAHROUSS__ -I../ -I./
+CCFLAGS		= -c -ffreestanding -fPIC -D__NEWOS_AMD64__ -mno-red-zone -fno-rtti -fno-exceptions -std=c++20 -D__FSKIT_NEWFS__ -D__KERNEL__ -D__HAVE_MAHROUSS_APIS__ -D__MAHROUSS__ -I../ -I./
 ASM 		= nasm
 
 ifneq ($(ATA_PIO_SUPPORT), )
@@ -30,7 +30,7 @@ COPY		= cp
 ASMFLAGS	= -f win64
 
 # NewOS subsystem is 17.
-LDFLAGS		= -e Main --subsystem=17
+LDFLAGS		= -e __ImageStart --subsystem=17
 LDOBJ		= Objects/*.obj
 
 # This file is the kernel, responsible of task management and memory.
@@ -59,17 +59,13 @@ newos-amd64-epm: clean
 
 OBJCOPY=x86_64-w64-mingw32-objcopy
 
-KERNEL_OBJ=kernel.bin
 DD=dd
 IMG_CREATE=qemu-img
 MAX_KERNEL_SIZE=1024K
 
 .PHONY: link-amd64-epm
 link-amd64-epm:
-	$(LD) $(LDFLAGS) $(LDOBJ) -o $(KERNEL_OBJ)
-	$(IMG_CREATE) create -f raw $(KERNEL) $(MAX_KERNEL_SIZE)
-	$(DD) if=$(KERNEL_OBJ) of=$(KERNEL) bs=1 seek=0 conv=notrunc
-	$(COPY) $(KERNEL) Root/Boot
+	$(LD) $(LDFLAGS) $(LDOBJ) -o $(KERNEL)
 
 .PHONY: all
 all: newos-amd64-epm link-amd64-epm
-- 
cgit v1.2.3


From 9cf4007cc5a2d37c8a49cbc25a564cde5981e7b0 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 08:26:54 +0200
Subject: MHR-16: Last fix and improvements.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/BootKit/BootKit.hxx           | 11 ++++++
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx  | 12 +++---
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx | 56 ++++++++++++++-------------
 3 files changed, 45 insertions(+), 34 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index 6272e4c9..ffa3af15 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -213,6 +213,17 @@ public:
     /// @retval False failed to format.
     Boolean Format(const char* partName, BFileDescriptor* fileBlobs, SizeT blobCount);
 
+    operator bool() noexcept {
+        fDiskDev.Leak().mBase = (kNewFSAddressAsLba / BootDev::kSectorSize);
+        fDiskDev.Leak().mSize = BootDev::kSectorSize;
+
+        Char buf[BootDev::kSectorSize] = { 0 };
+
+        fDiskDev.Read(buf, BootDev::kSectorSize);
+
+        return buf[0] == kNewFSIdent[0];
+    }
+
 private:
     /// @brief Write all of the requested catalogs into the filesystem.
     Boolean WriteContent(BFileDescriptor* fileBlobs, SizeT blobCount,
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index 8d923a50..bb634fbf 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -56,7 +56,7 @@ Void boot_ata_select(UInt16 Bus) {
 
 Boolean boot_ata_init(UInt16 Bus, UInt8 Drive, UInt16& OutBus,
                       UInt8& OutMaster) {
-  if (boot_ata_detected()) return false;
+  if (boot_ata_detected()) return true;
 
   BTextWriter writer;
 
@@ -135,14 +135,14 @@ Void boot_ata_read(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
   UInt8 Command = ((!Master) ? 0xE0 : 0xF0);
 
   boot_ata_wait_io(IO);
+  boot_ata_select(IO);
 
   Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
-  Out8(IO + ATA_REG_SEC_COUNT0, SectorSz);
+  Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
-  Out8(IO + ATA_REG_LBA3, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO);
 
@@ -157,14 +157,14 @@ Void boot_ata_write(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
   UInt8 Command = ((!Master) ? 0xE0 : 0xF0);
 
   boot_ata_wait_io(IO);
+  boot_ata_select(IO);
 
   Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
-  Out8(IO + ATA_REG_SEC_COUNT0, SectorSz);
+  Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
-  Out8(IO + ATA_REG_LBA3, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_WRITE_PIO);
 
@@ -190,8 +190,6 @@ Boolean boot_ata_detected(Void) { return kATADetected; }
  * @param void none.
  */
 BootDeviceATA::BootDeviceATA() noexcept {
-  if (boot_ata_detected()) return;
-
   if (boot_ata_init(ATA_PRIMARY_IO, true, this->Leak().mBus,
                     this->Leak().mMaster) ||
       boot_ata_init(ATA_SECONDARY_IO, true, this->Leak().mBus,
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index ea3fcbf0..5e9e2355 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -187,48 +187,50 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
 
   BDiskFormatFactory<BootDeviceATA> diskFormatter;
 
-  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor rootDesc{0};
+  if (!diskFormatter) {
+    BDiskFormatFactory<BootDeviceATA>::BFileDescriptor rootDesc{0};
 
-  memcpy(rootDesc.fFileName, "/", strlen("/"));
-  memcpy(rootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
+    memcpy(rootDesc.fFileName, "/", strlen("/"));
+    memcpy(rootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
 
-  rootDesc.fBlobSz = strlen(kMachineModel " startup disk.");
-  rootDesc.fBlob = new Char[rootDesc.fBlobSz];
+    rootDesc.fBlobSz = strlen(kMachineModel " startup disk.");
+    rootDesc.fBlob = new Char[rootDesc.fBlobSz];
 
-  memcpy(rootDesc.fBlob, kMachineModel " startup disk.",
-         strlen(kMachineModel " startup disk."));
+    memcpy(rootDesc.fBlob, kMachineModel " startup disk.",
+            strlen(kMachineModel " startup disk."));
 
-  rootDesc.fKind = kNewFSCatalogKindDir;
+    rootDesc.fKind = kNewFSCatalogKindDir;
 
-  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor bootDesc{0};
+    BDiskFormatFactory<BootDeviceATA>::BFileDescriptor bootDesc{0};
 
-  bootDesc.fKind = kNewFSCatalogKindDir;
+    bootDesc.fKind = kNewFSCatalogKindDir;
 
-  memcpy(bootDesc.fFileName, "/Boot", strlen("/Boot"));
-  memcpy(bootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
-  memcpy(bootDesc.fBlob, kMachineModel " startup folder.",
-         strlen(kMachineModel " startup folder."));
+    memcpy(bootDesc.fFileName, "/Boot", strlen("/Boot"));
+    memcpy(bootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
+    memcpy(bootDesc.fBlob, kMachineModel " startup folder.",
+            strlen(kMachineModel " startup folder."));
 
-  bootDesc.fBlobSz = strlen(kMachineModel " startup folder.");
-  bootDesc.fBlob = new Char[bootDesc.fBlobSz];
+    bootDesc.fBlobSz = strlen(kMachineModel " startup folder.");
+    bootDesc.fBlob = new Char[bootDesc.fBlobSz];
 
-  BDiskFormatFactory<BootDeviceATA>::BFileDescriptor kernelDesc{0};
+    BDiskFormatFactory<BootDeviceATA>::BFileDescriptor kernelDesc{0};
 
-  kernelDesc.fKind = kNewFSCatalogKindFile;
+    kernelDesc.fKind = kNewFSCatalogKindFile;
 
-  memcpy(kernelDesc.fFileName, "/Boot/NewKernel", strlen("/Boot/NewKernel"));
-  memcpy(kernelDesc.fForkName, kNewFSDataFork, strlen(kNewFSDataFork));
+    memcpy(kernelDesc.fFileName, "/Boot/NewKernel", strlen("/Boot/NewKernel"));
+    memcpy(kernelDesc.fForkName, kNewFSDataFork, strlen(kNewFSDataFork));
 
-  kernelDesc.fBlob = readerKernel.Blob();
-  kernelDesc.fBlobSz = readerKernel.Size();
+    kernelDesc.fBlob = readerKernel.Blob();
+    kernelDesc.fBlobSz = readerKernel.Size();
 
-  rootDesc.fNext = &bootDesc;
-  rootDesc.fNext->fPrev = &rootDesc;
+    rootDesc.fNext = &bootDesc;
+    rootDesc.fNext->fPrev = &rootDesc;
 
-  rootDesc.fNext->fNext = &kernelDesc;
-  rootDesc.fNext->fNext->fPrev = &bootDesc;
+    rootDesc.fNext->fNext = &kernelDesc;
+    rootDesc.fNext->fNext->fPrev = &bootDesc;
 
-  diskFormatter.Format(kMachineModel, &rootDesc, 3);
+    diskFormatter.Format(kMachineModel, &rootDesc, 3);
+  }
 
   EFI::ExitBootServices(MapKey, ImageHandle);
 
-- 
cgit v1.2.3


From ba80f513dd5cd82feae0b8f794b3367caf9ce8bb Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 10:20:01 +0200
Subject: MHR-16: a lot of fixes. Regarding the disk driver and the filesystem
 class BDiskFormatFactory.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/Builtins/ATA/ATA.hxx                  |   3 +-
 Private/HALKit/AMD64/Storage/ATA-PIO.cxx      |   6 +-
 Private/NewBoot/BootKit/BootKit.hxx           | 110 +++++++++++++++-----------
 Private/NewBoot/BootKit/HW/ATA.hxx            |   1 +
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx  |  67 +++++++---------
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx |  13 ++-
 Private/NewBoot/Source/makefile               |   2 +-
 7 files changed, 110 insertions(+), 92 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/Builtins/ATA/ATA.hxx b/Private/Builtins/ATA/ATA.hxx
index 66856d8a..a2ce79ba 100644
--- a/Private/Builtins/ATA/ATA.hxx
+++ b/Private/Builtins/ATA/ATA.hxx
@@ -102,7 +102,8 @@
 #define ATA_PRIMARY 0x00
 #define ATA_SECONDARY 0x01
 
-#define ATA_CYL_LOW 4
+#define ATA_CYL_LOW 3
+#define ATA_CYL_MID 4
 #define ATA_CYL_HIGH 5
 
 ///! IO Direction
diff --git a/Private/HALKit/AMD64/Storage/ATA-PIO.cxx b/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
index f2ae01a4..beb113d3 100644
--- a/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
+++ b/Private/HALKit/AMD64/Storage/ATA-PIO.cxx
@@ -134,12 +134,13 @@ Void drv_std_read(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf,
                    SizeT SectorSz, SizeT Size) {
   UInt8 Command = ((!Master )? 0xE0 : 0xF0);
 
-  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
+  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0x0F));
   Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
+  Out8(IO + ATA_REG_LBA4, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO);
 
@@ -156,12 +157,13 @@ Void drv_std_write(UInt64 Lba, UInt16 IO, UInt8 Master, Char* Buf,
                     SizeT SectorSz, SizeT Size) {
   UInt8 Command = ((!Master) ? 0xE0 : 0xF0);
 
-  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
+  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0x0F));
   Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
+  Out8(IO + ATA_REG_LBA4, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_WRITE_PIO);
 
diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index ffa3af15..b3a81160 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -214,14 +214,25 @@ public:
     Boolean Format(const char* partName, BFileDescriptor* fileBlobs, SizeT blobCount);
 
     operator bool() noexcept {
-        fDiskDev.Leak().mBase = (kNewFSAddressAsLba / BootDev::kSectorSize);
+        fDiskDev.Leak().mBase = (kNewFSAddressAsLba);
         fDiskDev.Leak().mSize = BootDev::kSectorSize;
 
         Char buf[BootDev::kSectorSize] = { 0 };
 
         fDiskDev.Read(buf, BootDev::kSectorSize);
 
-        return buf[0] == kNewFSIdent[0];
+        NewPartitionBlock* blockPart = reinterpret_cast<NewPartitionBlock*>(buf);
+
+        for (SizeT indexMag = 0UL; indexMag < kNewFSIdentLen; ++indexMag) {
+            if (blockPart->Ident[indexMag] != kNewFSIdent[indexMag])
+                return false;
+        }
+
+        BTextWriter writer;
+
+        writer.Write(L"Disk Partition: ").Write(blockPart->PartitionName).Write(L" is okay.\r\n");
+
+        return true;
     }
 
 private:
@@ -231,43 +242,55 @@ private:
         if (sectorSz != BootDev::kSectorSize) return false;
 
         BFileDescriptor* blob = fileBlobs;
-        Lba startLba = partBlock.FreeCatalog;
-
+        Lba startLba = partBlock.StartCatalog;
         BTextWriter writer;
+
         while (blob) {
-            NewCatalog catalogKind{ 0 };
+            NewCatalog* catalogKind = new NewCatalog();
+            memset(catalogKind, 0, sizeof(NewCatalog));
 
             /// Fill catalog kind.
-            catalogKind.Kind = blob->fKind;
+            catalogKind->Kind = blob->fKind;
 
             /// Allocate fork for blob.
-            catalogKind.FirstFork = (startLba + sizeof(NewCatalog));
-            catalogKind.LastFork = catalogKind.FirstFork;
+            catalogKind->FirstFork = (startLba + sizeof(NewCatalog));
+            catalogKind->LastFork = catalogKind->FirstFork;
 
-            NewFork forkKind{ 0 };
+            NewFork* forkKind = new NewFork();
+            memset(forkKind, 0, sizeof(NewFork));
 
-            memcpy(forkKind.Name, blob->fForkName, strlen(blob->fForkName));
-            forkKind.Kind = (forkKind.Name[0] == kNewFSDataFork[0]) ? kNewFSDataForkKind : kNewFSRsrcForkKind;
-            forkKind.Flags = kNewFSFlagCreated;
+            memcpy(forkKind->Name, blob->fForkName, strlen(blob->fForkName));
+            forkKind->Kind = (forkKind->Name[0] == kNewFSDataFork[0]) ? kNewFSDataForkKind : kNewFSRsrcForkKind;
+            forkKind->Flags = kNewFSFlagCreated;
 
             /// We don't know.
-            forkKind.ResourceFlags = 0;
-            forkKind.ResourceId = 0;
-            forkKind.ResourceKind = 0;
+            forkKind->ResourceFlags = 0;
+            forkKind->ResourceId = 0;
+            forkKind->ResourceKind = 0;
 
             /// We're the only fork here.
-            forkKind.NextSibling = catalogKind.FirstFork;
-            forkKind.PreviousSibling = catalogKind.FirstFork;
+            forkKind->NextSibling = catalogKind->FirstFork;
+            forkKind->PreviousSibling = catalogKind->FirstFork;
 
-            forkKind.DataOffset = (startLba + sizeof(NewCatalog) + sizeof(NewFork));
-            forkKind.DataSize = blob->fBlobSz;
+            forkKind->DataOffset = (startLba + sizeof(NewCatalog) + sizeof(NewFork));
+            forkKind->DataSize = blob->fBlobSz;
 
-            Lba lbaStart = forkKind.DataOffset;
+            Lba lbaStart = forkKind->DataOffset;
             SizeT cur = 0UL;
 
-            while (cur < forkKind.DataSize) {
+            writer.Write((catalogKind->Kind == kNewFSCatalogKindFile) ? L"New Boot: Write-File: " :
+                            L"New Boot: Write-Directory: " ).Write(blob->fFileName).Write(L"\r\n");
+
+            /// Set disk cursor here.
+
+            fDiskDev.Leak().mBase = startLba + sizeof(NewCatalog);
+            fDiskDev.Leak().mSize = sizeof(NewFork);
+
+            fDiskDev.Write((Char*)forkKind, sizeof(NewFork));
+
+            while (cur < forkKind->DataSize) {
                 this->fDiskDev.Leak().mSize = BootDev::kSectorSize;
-                this->fDiskDev.Leak().mBase = forkKind.DataOffset / BootDev::kSectorSize;
+                this->fDiskDev.Leak().mBase = (forkKind->DataOffset + cur);
 
                 this->fDiskDev.Write((Char*)(blob->fBlob) + cur, BootDev::kSectorSize);
 
@@ -275,48 +298,40 @@ private:
                 lbaStart += BootDev::kSectorSize;
             }
 
-            writer.Write((catalogKind.Kind == kNewFSCatalogKindFile) ? L"New Boot: Write-File: " :
-                L"New Boot: Write-Directory: " ).Write(blob->fFileName).Write(L"\r\n");
-
-            /// Set disk cursor here.
-
-            fDiskDev.Leak().mBase = startLba + sizeof(NewCatalog) / sectorSz;
-            fDiskDev.Leak().mSize = sizeof(NewFork);
-
-            fDiskDev.Write((Char*)&forkKind, 1);
 
             /// Fork is done.
 
-            catalogKind.Kind = blob->fKind;
-            catalogKind.Flags |= kNewFSFlagCreated;
+            catalogKind->Kind = blob->fKind;
+            catalogKind->Flags |= kNewFSFlagCreated;
 
             Lba catalogLba = (sizeof(NewCatalog) - startLba);
 
             //// Now write catalog as well..
 
-            catalogKind.PrevSibling = startLba;
-            catalogKind.NextSibling = (sizeof(NewCatalog) + blob->fBlobSz);
+            catalogKind->PrevSibling = startLba;
+            catalogKind->NextSibling = (sizeof(NewCatalog) + blob->fBlobSz);
 
             /// this mime only applies to file.
-            if (catalogKind.Kind == kNewFSCatalogKindFile) {
-                memcpy(catalogKind.Mime, kBKBootFileMime, strlen(kBKBootFileMime));
+            if (catalogKind->Kind == kNewFSCatalogKindFile) {
+                memcpy(catalogKind->Mime, kBKBootFileMime, strlen(kBKBootFileMime));
             } else  {
-                memcpy(catalogKind.Mime, kBKBootDirMime, strlen(kBKBootDirMime));
+                memcpy(catalogKind->Mime, kBKBootDirMime, strlen(kBKBootDirMime));
             }
 
-            memcpy(catalogKind.Name, blob->fFileName, strlen(blob->fFileName));
+            memcpy(catalogKind->Name, blob->fFileName, strlen(blob->fFileName));
 
-            fDiskDev.Leak().mBase = startLba / sectorSz;
+            fDiskDev.Leak().mBase = startLba;
             fDiskDev.Leak().mSize = sizeof(NewCatalog);
 
-            fDiskDev.Write((Char*)&catalogKind, sectorSz);
+            fDiskDev.Write((Char*)catalogKind, sizeof(NewCatalog));
 
-            startLba += (sizeof(NewCatalog) + blob->fBlobSz);
+            startLba += (sizeof(NewCatalog) + sizeof(NewFork) + blob->fBlobSz);
 
             --partBlock.FreeCatalog;
             --partBlock.FreeSectors;
 
-            ++partBlock.CatalogCount;
+            delete forkKind;
+            delete catalogKind;
 
             blob = blob->fNext;
         }
@@ -346,22 +361,23 @@ inline Boolean BDiskFormatFactory<BootDev>::Format(const char* partName,
 
     NewPartitionBlock* partBlock = reinterpret_cast<NewPartitionBlock*>(buf);
 
-    memcpy(partBlock->Ident, kNewFSIdent, kNewFSIdentLen-1);
+    memcpy(partBlock->Ident, kNewFSIdent, kNewFSIdentLen - 1);
     memcpy(partBlock->PartitionName, partName, strlen(partName));
 
     /// @note A catalog roughly equal to a sector.
 
-    partBlock->CatalogCount = 0UL;
+    partBlock->CatalogCount = blobCount;
     partBlock->Kind = kNewFSHardDrive;
     partBlock->SectorSize = sectorSz;
     partBlock->FreeCatalog = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
     partBlock->SectorCount = fDiskDev.GetSectorsCount();
     partBlock->FreeSectors = fDiskDev.GetSectorsCount() - partBlock->CatalogCount;
     partBlock->StartCatalog = kNewFSCatalogStartAddress;
+    partBlock->DiskSize = fDiskDev.GetDiskSize();
 
     if (this->WriteContent(fileBlobs, blobCount, sectorSz, *partBlock)) {
-        fDiskDev.Leak().mBase = (kNewFSAddressAsLba / sectorSz);
-        fDiskDev.Leak().mSize = BootDev::kSectorSize;
+        fDiskDev.Leak().mBase = (kNewFSAddressAsLba);
+        fDiskDev.Leak().mSize = sectorSz;
 
         fDiskDev.Write(buf, sectorSz);
 
diff --git a/Private/NewBoot/BootKit/HW/ATA.hxx b/Private/NewBoot/BootKit/HW/ATA.hxx
index 4b96e9fa..5bdcec56 100644
--- a/Private/NewBoot/BootKit/HW/ATA.hxx
+++ b/Private/NewBoot/BootKit/HW/ATA.hxx
@@ -37,6 +37,7 @@ class BootDeviceATA final : public Device {
   operator bool();
 
   SizeT GetSectorsCount() noexcept;
+  SizeT GetDiskSize() noexcept;
 
   BootDeviceATA& Read(Char* Buf, const SizeT& SecCount) override;
   BootDeviceATA& Write(Char* Buf, const SizeT& SecCount) override;
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index bb634fbf..41ea04ac 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -88,44 +88,13 @@ ATAInit_Retry:
   boot_ata_wait_io(IO);
 
   for (SizeT indexData = 0ul; indexData < kATADataLen; ++indexData) {
-    kATAData[indexData] = In16(IO + ATA_REG_DATA);
+    kATAData[indexData] = In8(IO + ATA_REG_DATA);
   }
 
   OutBus =
       (Bus == ATA_PRIMARY_IO) ? BootDeviceATA::kPrimary : BootDeviceATA::kSecondary;
-  OutMaster = (Bus == ATA_PRIMARY_IO) ? ATA_MASTER : ATA_SLAVE;
-
-  Out8(Bus + ATA_REG_HDDEVSEL, 0xA0 | ATA_MASTER << 4);
-
-  In8(Bus + ATA_REG_CONTROL);
-  In8(Bus + ATA_REG_CONTROL);
-  In8(Bus + ATA_REG_CONTROL);
-  In8(Bus + ATA_REG_CONTROL);
-
-  unsigned cl = In8(Bus + ATA_CYL_LOW); /* get the "signature bytes" */
-  unsigned ch = In8(Bus + ATA_CYL_HIGH);
-
-  /* differentiate ATA, ATAPI, SATA and SATAPI */
-  if (cl == 0x14 && ch == 0xEB) {
-    writer.Write(L"New Boot: PATAPI drive detected.\r\n");
-    kATADeviceType = kATADevicePATA_PI;
-  }
-  if (cl == 0x69 && ch == 0x96) {
-    writer.Write(L"New Boot: SATAPI drive detected.\r\n");
-    kATADeviceType = kATADeviceSATA_PI;
-  }
-
-  if (cl == 0x0 && ch == 0x0) {
-    writer.Write(L"New Boot: PATA drive detected.\r\n");
-    kATADeviceType = kATADevicePATA;
-  }
-
-  if (cl == 0x3c && ch == 0xc3) {
-    writer.Write(L"New Boot: SATA drive detected.\r\n");
-    kATADeviceType = kATADeviceSATA;
-  }
 
-  Out8(IO + ATA_REG_CONTROL, 0x02);
+  OutMaster = (Bus == ATA_PRIMARY_IO) ? ATA_MASTER : ATA_SLAVE;
 
   return true;
 }
@@ -137,12 +106,13 @@ Void boot_ata_read(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
   boot_ata_wait_io(IO);
   boot_ata_select(IO);
 
-  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
+  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0x0F));
   Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
+  Out8(IO + ATA_REG_LBA4, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_READ_PIO);
 
@@ -159,12 +129,13 @@ Void boot_ata_write(UInt64 Lba, UInt16 IO, UInt8 Master, CharacterTypeUTF8* Buf,
   boot_ata_wait_io(IO);
   boot_ata_select(IO);
 
-  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0xF));
+  Out8(IO + ATA_REG_HDDEVSEL, (Command) | (((Lba) >> 24) & 0x0F));
   Out8(IO + ATA_REG_SEC_COUNT0, 1);
 
   Out8(IO + ATA_REG_LBA0, (Lba));
   Out8(IO + ATA_REG_LBA1, (Lba) >> 8);
   Out8(IO + ATA_REG_LBA2, (Lba) >> 16);
+  Out8(IO + ATA_REG_LBA4, (Lba) >> 24);
 
   Out8(IO + ATA_REG_COMMAND, ATA_CMD_WRITE_PIO);
 
@@ -217,7 +188,9 @@ BootDeviceATA& BootDeviceATA::Read(CharacterTypeUTF8* Buf, const SizeT& SectorSz
 
   if (!Buf || SectorSz < 1) return *this;
 
-  boot_ata_read(this->Leak().mBase, this->Leak().mBus, this->Leak().mMaster,
+  auto lba = this->Leak().mBase / BootDeviceATA::kSectorSize;
+
+  boot_ata_read(lba, this->Leak().mBus, this->Leak().mMaster,
                 Buf, SectorSz, this->Leak().mSize);
 
   return *this;
@@ -238,7 +211,9 @@ BootDeviceATA& BootDeviceATA::Write(CharacterTypeUTF8* Buf, const SizeT& SectorS
 
   if (!Buf || SectorSz < 1) return *this;
 
-  boot_ata_write(this->Leak().mBase, this->Leak().mBus, this->Leak().mMaster,
+  auto lba = this->Leak().mBase / BootDeviceATA::kSectorSize;
+
+  boot_ata_write(lba, this->Leak().mBus, this->Leak().mMaster,
                 Buf, SectorSz, this->Leak().mSize);
 
   return *this;
@@ -256,3 +231,21 @@ BootDeviceATA::ATATrait& BootDeviceATA::Leak() { return mTrait; }
 SizeT BootDeviceATA::GetSectorsCount() noexcept {
     return kATAData[60] + kATAData[61];
 }
+
+SizeT BootDeviceATA::GetDiskSize() noexcept {
+    Out8(this->Leak().mBus + ATA_REG_COMMAND, 0xF8);
+
+    boot_ata_wait_io(this->Leak().mBus);
+
+    SizeT result = 0;
+
+    result += In8(this->Leak().mBus + ATA_CYL_LOW);
+    result += In8(this->Leak().mBus + ATA_CYL_MID) << 8;
+    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 16;
+    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 24;
+
+    BTextWriter writer;
+    writer.Write(L"Disk-Size: ").Write(result).Write(L"\r\n");
+
+    return result;
+}
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index 5e9e2355..a928a41a 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -193,9 +193,11 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
     memcpy(rootDesc.fFileName, "/", strlen("/"));
     memcpy(rootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
 
-    rootDesc.fBlobSz = strlen(kMachineModel " startup disk.");
+    rootDesc.fBlobSz = BootDeviceATA::kSectorSize;
     rootDesc.fBlob = new Char[rootDesc.fBlobSz];
 
+    memset(rootDesc.fBlob, 0, rootDesc.fBlobSz);
+
     memcpy(rootDesc.fBlob, kMachineModel " startup disk.",
             strlen(kMachineModel " startup disk."));
 
@@ -207,12 +209,15 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
 
     memcpy(bootDesc.fFileName, "/Boot", strlen("/Boot"));
     memcpy(bootDesc.fForkName, kNewFSResourceFork, strlen(kNewFSResourceFork));
+
+    bootDesc.fBlobSz = BootDeviceATA::kSectorSize;
+    bootDesc.fBlob = new Char[rootDesc.fBlobSz];
+
+    memset(bootDesc.fBlob, 0, bootDesc.fBlobSz);
+
     memcpy(bootDesc.fBlob, kMachineModel " startup folder.",
             strlen(kMachineModel " startup folder."));
 
-    bootDesc.fBlobSz = strlen(kMachineModel " startup folder.");
-    bootDesc.fBlob = new Char[bootDesc.fBlobSz];
-
     BDiskFormatFactory<BootDeviceATA>::BFileDescriptor kernelDesc{0};
 
     kernelDesc.fKind = kNewFSCatalogKindFile;
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 92128b02..4d8e1100 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -70,7 +70,7 @@ run-efi-amd64:
 
 .PHONY: epm-img
 epm-img:
-	qemu-img create -f qcow2 $(IMG) 512M
+	qemu-img create -f qcow2 $(IMG) 1G
 	qemu-img create -f qcow2 $(IMG_2) 512M
 
 .PHONY: download-edk
-- 
cgit v1.2.3


From e9b93cb61f130c2b07bdc031a2487e27ca5333f1 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 10:44:18 +0200
Subject: MHR-16: NewBoot - BDiskFormatter and QR.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/BootKit/BootKit.hxx                 | 18 ++++++++++++------
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx        | 13 +++++++++----
 Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx |  2 +-
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx       |  4 +++-
 4 files changed, 25 insertions(+), 12 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index b3a81160..76bfbfb0 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -213,6 +213,7 @@ public:
     /// @retval False failed to format.
     Boolean Format(const char* partName, BFileDescriptor* fileBlobs, SizeT blobCount);
 
+    /// @brief check if partition is good.
     operator bool() noexcept {
         fDiskDev.Leak().mBase = (kNewFSAddressAsLba);
         fDiskDev.Leak().mSize = BootDev::kSectorSize;
@@ -228,9 +229,17 @@ public:
                 return false;
         }
 
+        if (blockPart->DiskSize != this->fDiskDev.GetDiskSize()) {
+            EFI::ThrowError(L"Invalid-Disk-Geometry", L"Invalid disk geometry.");
+        }
+
+        if (blockPart->DiskSize < 1) {
+                    EFI::ThrowError(L"Invalid-Disk-Geometry", L"Invalid disk geometry.");
+        }
+
         BTextWriter writer;
 
-        writer.Write(L"Disk Partition: ").Write(blockPart->PartitionName).Write(L" is okay.\r\n");
+        writer.Write(L"Disk Partition: ").Write(blockPart->PartitionName).Write(L" is healthy.\r\n");
 
         return true;
     }
@@ -275,7 +284,6 @@ private:
             forkKind->DataOffset = (startLba + sizeof(NewCatalog) + sizeof(NewFork));
             forkKind->DataSize = blob->fBlobSz;
 
-            Lba lbaStart = forkKind->DataOffset;
             SizeT cur = 0UL;
 
             writer.Write((catalogKind->Kind == kNewFSCatalogKindFile) ? L"New Boot: Write-File: " :
@@ -288,16 +296,14 @@ private:
 
             fDiskDev.Write((Char*)forkKind, sizeof(NewFork));
 
-            while (cur < forkKind->DataSize) {
+            do {
                 this->fDiskDev.Leak().mSize = BootDev::kSectorSize;
                 this->fDiskDev.Leak().mBase = (forkKind->DataOffset + cur);
 
                 this->fDiskDev.Write((Char*)(blob->fBlob) + cur, BootDev::kSectorSize);
 
                 cur += BootDev::kSectorSize;
-                lbaStart += BootDev::kSectorSize;
-            }
-
+            } while (cur < forkKind->DataSize);
 
             /// Fork is done.
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index 41ea04ac..4bf7bc96 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -237,15 +237,20 @@ SizeT BootDeviceATA::GetDiskSize() noexcept {
 
     boot_ata_wait_io(this->Leak().mBus);
 
-    SizeT result = 0;
+    UInt64 result = 0;
 
-    result += In8(this->Leak().mBus + ATA_CYL_LOW);
+    result = In8(this->Leak().mBus + ATA_CYL_LOW);
     result += In8(this->Leak().mBus + ATA_CYL_MID) << 8;
     result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 16;
-    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 24;
+
+    Out8(this->Leak().mBus + ATA_REG_CONTROL, 0x80);
+
+    result += In8(this->Leak().mBus + ATA_CYL_LOW) << 24;
+    result += In8(this->Leak().mBus + ATA_CYL_MID) << 32;
+    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 40;
 
     BTextWriter writer;
-    writer.Write(L"Disk-Size: ").Write(result).Write(L"\r\n");
+    writer.Write(L"Device-Size: ").Write(result).Write(L"\r\n");
 
     return result;
 }
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
index 0e126ada..b2d728ae 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootFileReader.cxx
@@ -110,7 +110,7 @@ Void BFileReader::ReadAll(SizeT until, SizeT chunk) {
     if (auto err = BS->AllocatePool(EfiLoaderCode, until, (VoidPtr*)&mBlob) !=
                    kEfiOk) {
       mWriter.Write(L"*** EFI-Code: ").Write(err).Write(L" ***\r\n");
-      EFI::ThrowError(L"NewBoot_PageError", L"Allocation error.");
+      EFI::ThrowError(L"OutOfMemory", L"Allocation error.");
     }
   }
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index a928a41a..1c969b28 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -181,9 +181,11 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
   /// format the disk.
   //
 
+  constexpr auto binarySize = KIB(512);
+
   /// need this as well, to invoke BExecutableLoader.
   BFileReader readerKernel(L"NewKernel.exe", ImageHandle);
-  readerKernel.ReadAll(MIB(1), 4096);
+  readerKernel.ReadAll(binarySize, BootDeviceATA::kSectorSize);
 
   BDiskFormatFactory<BootDeviceATA> diskFormatter;
 
-- 
cgit v1.2.3


From 72b014b98fab4a6f875648a4b7b42347f780067e Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 11:00:27 +0200
Subject: MHR-16: bug fix Write number method, as well as an improved partition
 checker.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/BootKit/BootKit.hxx                 | 10 +++++-----
 Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx |  4 ++--
 Private/NewBoot/Source/makefile                     |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index 76bfbfb0..2d8b535d 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -229,12 +229,12 @@ public:
                 return false;
         }
 
-        if (blockPart->DiskSize != this->fDiskDev.GetDiskSize()) {
+        if (blockPart->DiskSize != this->fDiskDev.GetDiskSize() ||
+            blockPart->DiskSize < 1 ||
+            blockPart->SectorSize != BootDev::kSectorSize) {
             EFI::ThrowError(L"Invalid-Disk-Geometry", L"Invalid disk geometry.");
-        }
-
-        if (blockPart->DiskSize < 1) {
-                    EFI::ThrowError(L"Invalid-Disk-Geometry", L"Invalid disk geometry.");
+        } else if (blockPart->PartitionName[0] == 0) {
+            EFI::ThrowError(L"Invalid-Partition-Name", L"Invalid disk partition.");
         }
 
         BTextWriter writer;
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
index ff30ff95..fc91a02a 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootTextWriter.cxx
@@ -75,8 +75,8 @@ BTextWriter &BTextWriter::Write(const Long &x) {
 
 BTextWriter &BTextWriter::_Write(const Long &x) {
 #ifdef __DEBUG__
-  int y = x / 16;
-  int h = x % 16;
+  UInt64 y = (x > 0 ? x : -x) / 16;
+  UInt64 h = (x > 0 ? x : -x) % 16;
 
   if (y) this->_Write(y);
 
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 4d8e1100..92128b02 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -70,7 +70,7 @@ run-efi-amd64:
 
 .PHONY: epm-img
 epm-img:
-	qemu-img create -f qcow2 $(IMG) 1G
+	qemu-img create -f qcow2 $(IMG) 512M
 	qemu-img create -f qcow2 $(IMG_2) 512M
 
 .PHONY: download-edk
-- 
cgit v1.2.3


From fc19214c74c39177f85a4ee0748ac4ec9c1d4f33 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 12:23:00 +0200
Subject: MHR-16: Fix bug inside GetDiskSize, use a simple formula instead of
 doing stupid sh*t.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/NewBoot/BootKit/BootKit.hxx          |  7 ++++---
 Private/NewBoot/Source/HEL/AMD64/BootATA.cxx | 23 ++---------------------
 2 files changed, 6 insertions(+), 24 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/NewBoot/BootKit/BootKit.hxx b/Private/NewBoot/BootKit/BootKit.hxx
index 2d8b535d..f7f33958 100644
--- a/Private/NewBoot/BootKit/BootKit.hxx
+++ b/Private/NewBoot/BootKit/BootKit.hxx
@@ -229,6 +229,9 @@ public:
                 return false;
         }
 
+        BTextWriter writer;
+        writer.Write(L"Device Size: ").Write(this->fDiskDev.GetDiskSize()).Write(L"\r\n");
+
         if (blockPart->DiskSize != this->fDiskDev.GetDiskSize() ||
             blockPart->DiskSize < 1 ||
             blockPart->SectorSize != BootDev::kSectorSize) {
@@ -237,9 +240,7 @@ public:
             EFI::ThrowError(L"Invalid-Partition-Name", L"Invalid disk partition.");
         }
 
-        BTextWriter writer;
-
-        writer.Write(L"Disk Partition: ").Write(blockPart->PartitionName).Write(L" is healthy.\r\n");
+        writer.Write(L"Device Partition: ").Write(blockPart->PartitionName).Write(L" is healthy.\r\n");
 
         return true;
     }
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
index 4bf7bc96..8ab7dc20 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootATA.cxx
@@ -229,28 +229,9 @@ BootDeviceATA::ATATrait& BootDeviceATA::Leak() { return mTrait; }
     @brief Getter, gets the number of sectors inside the drive.
 */
 SizeT BootDeviceATA::GetSectorsCount() noexcept {
-    return kATAData[60] + kATAData[61];
+    return (kATAData[61] << 16)| kATAData[60];
 }
 
 SizeT BootDeviceATA::GetDiskSize() noexcept {
-    Out8(this->Leak().mBus + ATA_REG_COMMAND, 0xF8);
-
-    boot_ata_wait_io(this->Leak().mBus);
-
-    UInt64 result = 0;
-
-    result = In8(this->Leak().mBus + ATA_CYL_LOW);
-    result += In8(this->Leak().mBus + ATA_CYL_MID) << 8;
-    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 16;
-
-    Out8(this->Leak().mBus + ATA_REG_CONTROL, 0x80);
-
-    result += In8(this->Leak().mBus + ATA_CYL_LOW) << 24;
-    result += In8(this->Leak().mBus + ATA_CYL_MID) << 32;
-    result += In8(this->Leak().mBus + ATA_CYL_HIGH) << 40;
-
-    BTextWriter writer;
-    writer.Write(L"Device-Size: ").Write(result).Write(L"\r\n");
-
-    return result;
+    return this->GetSectorsCount() * BootDeviceATA::kSectorSize;
 }
-- 
cgit v1.2.3


From 313c303fab092b1c45e615f960826375e7eef093 Mon Sep 17 00:00:00 2001
From: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
Date: Fri, 26 Apr 2024 14:23:37 +0200
Subject: MHR-16: Last commit on branch, merging now.

- boot manager and micro kernel have been unified, as the USA design
  states.

Signed-off-by: Amlal El Mahrouss <amlal.elmahrouss@icloud.com>
---
 Private/HALKit/AMD64/HalNewBoot.asm               |  3 +++
 Private/NewBoot/Source/CDROM/SplashScreen.fmt     |  5 +++--
 Private/NewBoot/Source/HEL/AMD64/BootMain.cxx     | 25 ++++-------------------
 Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx |  9 ++++++++
 Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx   |  4 ++++
 Private/NewBoot/Source/HEL/AMD64/Support.cxx      |  5 ++++-
 Private/NewBoot/Source/makefile                   |  5 ++---
 Private/Source/Utils.cxx                          |  9 ++++++--
 8 files changed, 36 insertions(+), 29 deletions(-)

(limited to 'Private/NewBoot/Source')

diff --git a/Private/HALKit/AMD64/HalNewBoot.asm b/Private/HALKit/AMD64/HalNewBoot.asm
index 11b11c0c..e9034f05 100644
--- a/Private/HALKit/AMD64/HalNewBoot.asm
+++ b/Private/HALKit/AMD64/HalNewBoot.asm
@@ -28,9 +28,12 @@ HandoverStart: dq __ImageStart
 section .text
 
 global __ImageStart
+global __NewBootJumpProc
+
 extern hal_init_platform
 
 ;; Just a simple setup, we'd also need to tell some before
+__NewBootJumpProc:
 __ImageStart:
     push rcx
     call hal_init_platform
diff --git a/Private/NewBoot/Source/CDROM/SplashScreen.fmt b/Private/NewBoot/Source/CDROM/SplashScreen.fmt
index 339b94e7..857c63a1 100644
--- a/Private/NewBoot/Source/CDROM/SplashScreen.fmt
+++ b/Private/NewBoot/Source/CDROM/SplashScreen.fmt
@@ -1,6 +1,7 @@
 Welcome to NeWS.
 
-Brought to you by:
-* MicroKernel, Bootloader: Amlal EL Mahrouss.
+Brought to you by: Amlal EL Mahrouss.
+* NewBoot, NewKernel: Amlal EL Mahrouss.
 
+This copy can boot directly to NewKernel (Unified System).
 Copyright Mahrouss-Logic, all rights reserved.
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
index 1c969b28..68762089 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootMain.cxx
@@ -21,6 +21,8 @@
 
 /** Graphics related. */
 
+EXTERN_C Void hal_init_platform(HEL::HandoverInformationHeader* HIH);
+
 STATIC EfiGraphicsOutputProtocol* kGop = nullptr;
 STATIC UInt16 kStride = 0U;
 STATIC EfiGUID kGopGuid;
@@ -181,12 +183,6 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
   /// format the disk.
   //
 
-  constexpr auto binarySize = KIB(512);
-
-  /// need this as well, to invoke BExecutableLoader.
-  BFileReader readerKernel(L"NewKernel.exe", ImageHandle);
-  readerKernel.ReadAll(binarySize, BootDeviceATA::kSectorSize);
-
   BDiskFormatFactory<BootDeviceATA> diskFormatter;
 
   if (!diskFormatter) {
@@ -220,28 +216,15 @@ EFI_EXTERN_C EFI_API Int Main(EfiHandlePtr ImageHandle,
     memcpy(bootDesc.fBlob, kMachineModel " startup folder.",
             strlen(kMachineModel " startup folder."));
 
-    BDiskFormatFactory<BootDeviceATA>::BFileDescriptor kernelDesc{0};
-
-    kernelDesc.fKind = kNewFSCatalogKindFile;
-
-    memcpy(kernelDesc.fFileName, "/Boot/NewKernel", strlen("/Boot/NewKernel"));
-    memcpy(kernelDesc.fForkName, kNewFSDataFork, strlen(kNewFSDataFork));
-
-    kernelDesc.fBlob = readerKernel.Blob();
-    kernelDesc.fBlobSz = readerKernel.Size();
-
     rootDesc.fNext = &bootDesc;
     rootDesc.fNext->fPrev = &rootDesc;
 
-    rootDesc.fNext->fNext = &kernelDesc;
-    rootDesc.fNext->fNext->fPrev = &bootDesc;
-
-    diskFormatter.Format(kMachineModel, &rootDesc, 3);
+    diskFormatter.Format(kMachineModel, &rootDesc, 2);
   }
 
   EFI::ExitBootServices(MapKey, ImageHandle);
 
-  rt_jump_to_address(readerKernel.Blob());
+  hal_init_platform(kHandoverHeader);
 
   EFI::Stop();
 
diff --git a/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx b/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
index f47e3532..2ac90dd8 100644
--- a/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/BootPlatform.cxx
@@ -7,6 +7,9 @@
 #include <BootKit/Platform.hxx>
 #include <BootKit/Protocol.hxx>
 #include <BootKit/BootKit.hxx>
+#include "HALKit/AMD64/Processor.hpp"
+
+#if 0
 
 EXTERN_C void rt_hlt() { asm volatile("hlt"); }
 
@@ -50,3 +53,9 @@ EXTERN_C UInt32 In32(UInt16 port) {
 
   return value;
 }
+
+#else
+
+void rt_hlt() { NewOS::HAL::rt_halt(); }
+
+#endif // 0
diff --git a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
index 01911c43..909ccca6 100644
--- a/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/New+Delete.cxx
@@ -9,6 +9,8 @@
 #include <BootKit/BootKit.hxx>
 #include <cstddef> /* Since we're using GCC for this EFI program. */
 
+#if 0
+
 /// @brief Allocates a new object.
 /// @param sz the size.
 /// @return
@@ -45,3 +47,5 @@ void operator delete(void* buf, size_t size)
 {
     BS->FreePool(buf);
 }
+
+#endif // Inactive
diff --git a/Private/NewBoot/Source/HEL/AMD64/Support.cxx b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
index 0508d491..a8e2c275 100644
--- a/Private/NewBoot/Source/HEL/AMD64/Support.cxx
+++ b/Private/NewBoot/Source/HEL/AMD64/Support.cxx
@@ -8,6 +8,8 @@
 #include <FirmwareKit/Handover.hxx>
 #include <BootKit/Vendor/Support.hxx>
 
+#if 0
+
 /// @brief memset definition in C++.
 /// @param dst destination pointer.
 /// @param byte value to fill in.
@@ -41,6 +43,7 @@ EXTERN_C size_t strlen(const char *whatToCheck) {
     return len;
 }
 
-
 /// @brief somthing specific to the microsoft ABI, regarding checking the stack.
 EXTERN_C void ___chkstk_ms(void) {}
+
+#endif
diff --git a/Private/NewBoot/Source/makefile b/Private/NewBoot/Source/makefile
index 92128b02..8306f844 100644
--- a/Private/NewBoot/Source/makefile
+++ b/Private/NewBoot/Source/makefile
@@ -28,7 +28,7 @@ EMU_FLAGS=-net none -smp 4 -m 8G -M q35 -bios OVMF.fd -device piix3-ide,id=ide -
 
 LD_FLAGS=-e Main --subsystem=10
 
-OBJ=*.o
+OBJ=*.o ../../Objects/*.obj
 
 REM=rm
 REM_FLAG=-f
@@ -53,7 +53,6 @@ all: compile-amd64
 	$(LD_GNU) $(OBJ) $(LD_FLAGS) -o $(BOOT_LOADER)
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/BOOTX64.EFI
 	$(COPY) $(BOOT_LOADER) CDROM/EFI/BOOT/NEWBOOT.EFI
-	$(COPY) ../../$(KERNEL) CDROM/$(KERNEL)
 
 ifneq ($(DEBUG_SUPPORT), )
 DEBUG =  -D__DEBUG__
@@ -61,7 +60,7 @@ endif
 
 .PHONY: compile-amd64
 compile-amd64:
-	$(WINDRES) BootloaderRsrc.rsrc -O coff -o BootloaderRsrc.o
+	# $(WINDRES) BootloaderRsrc.rsrc -O coff -o BootloaderRsrc.o
 	$(CC_GNU) $(NEWOS_MODEL) $(FLAG_GNU) $(DEBUG) $(wildcard HEL/AMD64/*.cxx) $(wildcard HEL/AMD64/*.S) $(wildcard *.cxx)
 
 .PHONY: run-efi-amd64
diff --git a/Private/Source/Utils.cxx b/Private/Source/Utils.cxx
index e12041c8..fcdddc4a 100644
--- a/Private/Source/Utils.cxx
+++ b/Private/Source/Utils.cxx
@@ -169,10 +169,15 @@ char *rt_string_frofchar(char *str, const char chr) {
 }
 }  // namespace NewOS
 
-extern "C" void memset(void *dst, char src, size_t len) {
+EXTERN_C void memset(void *dst, char src, size_t len) {
   NewOS::rt_set_memory(dst, src, len);
 }
 
-extern "C" void memcpy(void *dst, void *src, size_t len) {
+EXTERN_C void memcpy(void *dst, void *src, size_t len) {
   NewOS::rt_copy_memory(src, dst, len);
 }
+
+/// @brief strlen definition in C++.
+EXTERN_C size_t strlen(const char *whatToCheck) {
+    return NewOS::rt_string_len(whatToCheck);
+}
-- 
cgit v1.2.3