From 9a86282760e642734bf5b6e233bc3728991fb4e4 Mon Sep 17 00:00:00 2001 From: Amlal EL Mahrouss Date: Mon, 26 Aug 2024 17:38:13 +0200 Subject: [IMP] DON'T USE STRINGVIEW FOR NAME (FindSymbol) Signed-off-by: Amlal EL Mahrouss --- dev/ZKA/Sources/PEFCodeManager.cxx | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'dev/ZKA/Sources') diff --git a/dev/ZKA/Sources/PEFCodeManager.cxx b/dev/ZKA/Sources/PEFCodeManager.cxx index 02303e1c..365f01c2 100644 --- a/dev/ZKA/Sources/PEFCodeManager.cxx +++ b/dev/ZKA/Sources/PEFCodeManager.cxx @@ -102,15 +102,12 @@ namespace Kernel VoidPtr PEFLoader::FindSymbol(const Char* name, Int32 kind) { - if (!fCachedBlob || fBad) + if (!fCachedBlob || fBad || !name) return nullptr; PEFContainer* container = reinterpret_cast(fCachedBlob); - StringView cPefHeaderStr; - cPefHeaderStr += name; - - auto blob = fFile->Read(cPefHeaderStr.CData()); + auto blob = fFile->Read(name); PEFCommandHeader* container_header = reinterpret_cast(blob); @@ -205,7 +202,7 @@ namespace Kernel if (errOrStart.Error() != 0) return false; - PROCESS_HEADER_BLOCK proc(errOrStart.Leak().Leak()); + PROCESS_HEADER_BLOCK proc(errOrStart.Leak().Leak()); Ref refProc = proc; proc.Kind = procKind; -- cgit v1.2.3