From c3856eddb5a8146751dac82ad1ba4433f5ca6d6d Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Fri, 11 Apr 2025 17:51:19 +0200 Subject: tweak kernel, boot: use -Wall, -Werror, -Wpedantic now. Signed-off-by: Amlal El Mahrouss --- dev/kernel/NewKit/Array.h | 6 +++--- dev/kernel/NewKit/ArrayList.h | 2 +- dev/kernel/NewKit/CxxAbi.h | 2 +- dev/kernel/NewKit/Defines.h | 9 +++++---- dev/kernel/NewKit/Json.h | 2 +- dev/kernel/NewKit/KString.h | 2 +- dev/kernel/NewKit/KernelPanic.h | 3 +-- dev/kernel/NewKit/MutableArray.h | 6 +++--- dev/kernel/NewKit/PageMgr.h | 2 +- dev/kernel/NewKit/Ref.h | 3 ++- dev/kernel/NewKit/Utils.h | 2 +- 11 files changed, 20 insertions(+), 19 deletions(-) (limited to 'dev/kernel/NewKit') diff --git a/dev/kernel/NewKit/Array.h b/dev/kernel/NewKit/Array.h index ca887153..1dcc6720 100644 --- a/dev/kernel/NewKit/Array.h +++ b/dev/kernel/NewKit/Array.h @@ -22,7 +22,7 @@ namespace Kernel Array& operator=(const Array&) = default; Array(const Array&) = default; - T& operator[](const SizeT& at) + T& operator[](SizeT at) { MUST_PASS(at < this->Count()); return fArray[at]; @@ -33,12 +33,12 @@ namespace Kernel return this->Count() > 0; } - const SizeT Capacity() + SizeT Capacity() { return N; } - const SizeT Count() + SizeT Count() { return N; } diff --git a/dev/kernel/NewKit/ArrayList.h b/dev/kernel/NewKit/ArrayList.h index 16220451..1ea69fc5 100644 --- a/dev/kernel/NewKit/ArrayList.h +++ b/dev/kernel/NewKit/ArrayList.h @@ -34,7 +34,7 @@ namespace Kernel return fList; } - T& operator[](int index) const + T& operator[](SizeT index) const { MUST_PASS(index < this->Count()); return fList[index]; diff --git a/dev/kernel/NewKit/CxxAbi.h b/dev/kernel/NewKit/CxxAbi.h index 32c91862..4bd3f662 100644 --- a/dev/kernel/NewKit/CxxAbi.h +++ b/dev/kernel/NewKit/CxxAbi.h @@ -13,7 +13,7 @@ struct atexit_func_entry_t { - void (*destructor_func)(void*); + void (*destructor_func)(); void* obj_ptr; void* dso_handle; }; diff --git a/dev/kernel/NewKit/Defines.h b/dev/kernel/NewKit/Defines.h index 72e3c552..15b1d907 100644 --- a/dev/kernel/NewKit/Defines.h +++ b/dev/kernel/NewKit/Defines.h @@ -135,8 +135,9 @@ namespace Kernel /// @param type (a1) the data. /// @return a1 as Char* template - Char* AsBytes(T type) noexcept + const Char* AsBytes(T type) noexcept { + NE_UNUSED(type); return nullptr; } @@ -180,19 +181,19 @@ namespace Kernel ISchedulable(const ISchedulable&) = default; /// @brief Is this object only accepting user tasks? - virtual const Bool IsUser() + virtual Bool IsUser() { return NO; } /// @brief Is this object only accepting kernel tasks? - virtual const Bool IsKernel() + virtual Bool IsKernel() { return NO; } /// @brief Is this object offloading to another CPU? - virtual const Bool HasMP() + virtual Bool HasMP() { return NO; } diff --git a/dev/kernel/NewKit/Json.h b/dev/kernel/NewKit/Json.h index 5f979ceb..3cbc61dd 100644 --- a/dev/kernel/NewKit/Json.h +++ b/dev/kernel/NewKit/Json.h @@ -45,7 +45,7 @@ namespace Kernel NE_COPY_DEFAULT(Json); - const Bool& IsUndefined() + Bool& IsUndefined() { return fUndefined; } diff --git a/dev/kernel/NewKit/KString.h b/dev/kernel/NewKit/KString.h index ff809bd3..0c9aaa34 100644 --- a/dev/kernel/NewKit/KString.h +++ b/dev/kernel/NewKit/KString.h @@ -30,7 +30,7 @@ namespace Kernel rt_set_memory(fData, 0, fDataSz); } - explicit KString(const SizeT& Sz) + explicit KString(SizeT Sz) : fDataSz(Sz) { MUST_PASS(Sz > 1); diff --git a/dev/kernel/NewKit/KernelPanic.h b/dev/kernel/NewKit/KernelPanic.h index 08f2990a..60a6519c 100644 --- a/dev/kernel/NewKit/KernelPanic.h +++ b/dev/kernel/NewKit/KernelPanic.h @@ -33,8 +33,7 @@ namespace Kernel #undef __MUST_PASS #endif -#define __MUST_PASS(EXPR, FILE, LINE) \ - Kernel::ke_runtime_check(EXPR, FILE, STRINGIFY(LINE)) +#define __MUST_PASS(EXPR, FILE, LINE) Kernel::ke_runtime_check(EXPR, FILE, STRINGIFY(LINE)) #ifdef __DEBUG__ #define MUST_PASS(EXPR) __MUST_PASS((EXPR), __FILE__, __LINE__) diff --git a/dev/kernel/NewKit/MutableArray.h b/dev/kernel/NewKit/MutableArray.h index b6bb0d98..40d61495 100644 --- a/dev/kernel/NewKit/MutableArray.h +++ b/dev/kernel/NewKit/MutableArray.h @@ -96,7 +96,7 @@ namespace Kernel } public: - T operator[](const SizeT& Index) const + T operator[](SizeT Index) const { TRY_FIND_NODE(first, fFirstNode); TRY_FIND_NODE(last, fLastNode); @@ -110,7 +110,7 @@ namespace Kernel } public: - Boolean Remove(const SizeT& Index) + Boolean Remove(SizeT Index) { TRY_REMOVE_NODE(fFirstNode); TRY_REMOVE_NODE(fLastNode); @@ -200,7 +200,7 @@ namespace Kernel } public: - Ref operator[](const SizeT& Index) const + Ref operator[](SizeT Index) const { TRY_FIND_NODE2(first, fFirstNode); TRY_FIND_NODE2(last, fLastNode); diff --git a/dev/kernel/NewKit/PageMgr.h b/dev/kernel/NewKit/PageMgr.h index 537b3225..bc8ee776 100644 --- a/dev/kernel/NewKit/PageMgr.h +++ b/dev/kernel/NewKit/PageMgr.h @@ -27,7 +27,7 @@ namespace Kernel PTEWrapper(const PTEWrapper&) = default; public: - const UIntPtr VirtualAddress(); + UIntPtr VirtualAddress(); Void NoExecute(const bool enable = false); Bool NoExecute(); diff --git a/dev/kernel/NewKit/Ref.h b/dev/kernel/NewKit/Ref.h index 2523c46a..7ec0825a 100644 --- a/dev/kernel/NewKit/Ref.h +++ b/dev/kernel/NewKit/Ref.h @@ -33,8 +33,9 @@ namespace Kernel } Ref(T cls) - : fClass(&cls) + : fClass(nullptr) { + fClass = new T(cls); } Ref& operator=(T ref) diff --git a/dev/kernel/NewKit/Utils.h b/dev/kernel/NewKit/Utils.h index 23f5c6c2..5fc77366 100644 --- a/dev/kernel/NewKit/Utils.h +++ b/dev/kernel/NewKit/Utils.h @@ -26,5 +26,5 @@ namespace Kernel Int rt_to_uppercase(Int c); Int rt_to_lower(Int c); voidPtr rt_string_in_string(const Char* in, const Char* needle); - char* rt_string_has_char(Char* str, const Char chr); + char* rt_string_has_char(Char* str, Char chr); } // namespace Kernel -- cgit v1.2.3