From 33ba5e743c9c993a0f6b02d2a85aa9796240f7e1 Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Tue, 17 Jun 2025 23:51:39 +0200 Subject: kernel: fix: Fix duplicates on `IPAddr.cc` and `AsciiUtils.cc`. fix: Fix dead code in `Bool USER_PROCESS::SpawnDylib()` Signed-off-by: Amlal El Mahrouss --- dev/kernel/src/Network/IPAddr.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) (limited to 'dev/kernel/src/Network/IPAddr.cc') diff --git a/dev/kernel/src/Network/IPAddr.cc b/dev/kernel/src/Network/IPAddr.cc index b341af8f..0a030dc8 100644 --- a/dev/kernel/src/Network/IPAddr.cc +++ b/dev/kernel/src/Network/IPAddr.cc @@ -89,18 +89,22 @@ bool IPFactory::IpCheckVersion4(const Char* ip) { if (!ip) return NO; Int32 cnter = 0; + Int32 dot_cnter = 0; for (SizeT base = 0; base < rt_string_len(ip); ++base) { if (ip[base] == '.') { cnter = 0; + ++dot_cnter; } else { - if (!rt_is_alnum(ip[base])) return false; - if (cnter == 3) return false; + if (!rt_is_alnum(ip[base])) return NO; + if (cnter == 3) return NO; ++cnter; } } - return true; + if (dot_cnter != 3) return NO; + + return YES; } } // namespace Kernel -- cgit v1.2.3 From 6c817b699af42ff454b601e592ff1d3e4894d2e5 Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Wed, 18 Jun 2025 10:19:56 +0200 Subject: meta: Ran `format.sh` Signed-off-by: Amlal El Mahrouss --- dev/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc | 6 +++--- dev/kernel/src/Network/IPAddr.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'dev/kernel/src/Network/IPAddr.cc') diff --git a/dev/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc b/dev/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc index 61a82314..e6f70f0e 100644 --- a/dev/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc +++ b/dev/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc @@ -11,16 +11,16 @@ #include EXTERN_C Kernel::Void int_handle_breakpoint(Kernel::UIntPtr rip); - EXTERN_C BOOL mp_handle_gic_interrupt_el0(Void); +EXTERN_C BOOL mp_handle_gic_interrupt_el0(Void); -EXTERN_C BOOL kEndOfInterrupt; +EXTERN_C BOOL kEndOfInterrupt; EXTERN_C UInt8 kEndOfInterruptVector; STATIC BOOL kIsRunning = NO; /// @note This is managed by the system software. STATIC void hal_int_send_eoi(UInt8 vector) { - kEndOfInterrupt = YES; + kEndOfInterrupt = YES; kEndOfInterruptVector = vector; } diff --git a/dev/kernel/src/Network/IPAddr.cc b/dev/kernel/src/Network/IPAddr.cc index 0a030dc8..ec7d8a35 100644 --- a/dev/kernel/src/Network/IPAddr.cc +++ b/dev/kernel/src/Network/IPAddr.cc @@ -88,7 +88,7 @@ ErrorOr IPFactory::ToKString(Ref& ipv4) { bool IPFactory::IpCheckVersion4(const Char* ip) { if (!ip) return NO; - Int32 cnter = 0; + Int32 cnter = 0; Int32 dot_cnter = 0; for (SizeT base = 0; base < rt_string_len(ip); ++base) { -- cgit v1.2.3