From e6185ca92212ab0686892a1a12efd392f895c1f7 Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Thu, 24 Apr 2025 09:49:26 +0200 Subject: dev, kernel: some improvements on BitMapMgr and fixes on BinaryMutex. Signed-off-by: Amlal El Mahrouss --- dev/kernel/src/BinaryMutex.cc | 11 ++++++----- dev/kernel/src/BitMapMgr.cc | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'dev/kernel/src') diff --git a/dev/kernel/src/BinaryMutex.cc b/dev/kernel/src/BinaryMutex.cc index f86be37b..c149b362 100644 --- a/dev/kernel/src/BinaryMutex.cc +++ b/dev/kernel/src/BinaryMutex.cc @@ -10,7 +10,7 @@ namespace Kernel { /***********************************************************************************/ - /// @brief Unlocks the semaphore. + /// @brief Unlocks the binary mutex. /***********************************************************************************/ Bool BinaryMutex::Unlock() noexcept { @@ -18,6 +18,7 @@ namespace Kernel { fLockingProcess = USER_PROCESS(); fLockingProcess.Status = ProcessStatusKind::kFrozen; + return Yes; } @@ -25,14 +26,14 @@ namespace Kernel } /***********************************************************************************/ - /// @brief Locks process in the semaphore. + /// @brief Locks process in the binary mutex. /***********************************************************************************/ Bool BinaryMutex::Lock(USER_PROCESS& process) { - if (!process || fLockingProcess) + if (!process || this->IsLocked()) return No; - fLockingProcess = process; + this->fLockingProcess = process; return Yes; } @@ -42,7 +43,7 @@ namespace Kernel /***********************************************************************************/ Bool BinaryMutex::IsLocked() const { - return fLockingProcess.Status == ProcessStatusKind::kRunning; + return this->fLockingProcess.Status == ProcessStatusKind::kRunning; } /***********************************************************************************/ diff --git a/dev/kernel/src/BitMapMgr.cc b/dev/kernel/src/BitMapMgr.cc index 96cbb803..1a1e2c0d 100644 --- a/dev/kernel/src/BitMapMgr.cc +++ b/dev/kernel/src/BitMapMgr.cc @@ -16,7 +16,6 @@ #include #define kBitMapMagic (0x10210U) -#define kBitMapPadSize (mib_cast(16)) #define kBitMapMagIdx (0U) #define kBitMapSizeIdx (1U) -- cgit v1.2.3