From ceabd82ac8e796249feacf39c836034ed5e11c6d Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Sat, 29 Nov 2025 15:01:34 -0500 Subject: chore: source code review and fixes. Signed-off-by: Amlal El Mahrouss --- src/kernel/NeKit/Crc32.h | 2 +- src/kernel/NeKit/Defines.h | 6 +++--- src/kernel/NeKit/Function.h | 4 +--- src/kernel/NeKit/Json.h | 9 ++++----- src/kernel/NeKit/Macros.h | 4 ++-- src/kernel/NeKit/MutableArray.h | 2 +- src/kernel/NeKit/New.h | 4 ++-- src/kernel/NeKit/OwnPtr.h | 2 +- src/kernel/NeKit/Ref.h | 6 +++--- src/kernel/NeKit/Variant.h | 8 ++++---- 10 files changed, 22 insertions(+), 25 deletions(-) (limited to 'src/kernel/NeKit') diff --git a/src/kernel/NeKit/Crc32.h b/src/kernel/NeKit/Crc32.h index 3c6a904f..125ee5b7 100644 --- a/src/kernel/NeKit/Crc32.h +++ b/src/kernel/NeKit/Crc32.h @@ -14,7 +14,7 @@ #include namespace Kernel { -UInt32 ke_calculate_crc32(const VoidPtr crc, Int32 len) noexcept; +UInt32 ke_calculate_crc32(const VoidPtr crc, Int32 len); } // namespace Kernel #endif // !NEKIT_CRC32_H diff --git a/src/kernel/NeKit/Defines.h b/src/kernel/NeKit/Defines.h index 1a6a2cf6..e53616a9 100644 --- a/src/kernel/NeKit/Defines.h +++ b/src/kernel/NeKit/Defines.h @@ -127,7 +127,7 @@ class ICodec { /// @param type (a1) the data. /// @return a1 as Char* template - const Char* AsBytes(T type) noexcept { + const Char* AsBytes(T type) { NE_UNUSED(type); return nullptr; } @@ -137,7 +137,7 @@ class ICodec { /// @param type (a1) the data. /// @return a1 as Char* template - OutputClass* Construct(Char* type) noexcept { + OutputClass* Construct(Char* type) { FactoryClass class_fac; return class_fac.template From(type); } @@ -148,7 +148,7 @@ class ICodec { /// @param type the class to cast. /// @return the class as Y. template - Y As(T type) noexcept { + Y As(T type) { if (type.template IsSerializable()) { return reinterpret_cast(type); } diff --git a/src/kernel/NeKit/Function.h b/src/kernel/NeKit/Function.h index 70242bc3..5dea8f85 100644 --- a/src/kernel/NeKit/Function.h +++ b/src/kernel/NeKit/Function.h @@ -41,11 +41,9 @@ class Function final { bool operator!() { return !fFn; } private: - T(*fFn) - (Args... args){nullptr}; + T (*fFn)(Args... args){nullptr}; }; template using FunctionOr = ErrorOr>; } // namespace Kernel - diff --git a/src/kernel/NeKit/Json.h b/src/kernel/NeKit/Json.h index 1e804354..82ce3b99 100644 --- a/src/kernel/NeKit/Json.h +++ b/src/kernel/NeKit/Json.h @@ -34,16 +34,15 @@ class JsonObject final { key += kNeJsonNullValue; this->AsKey() = key; - this->AsValue() = key; + this->AsValue() = key; } explicit JsonObject(SizeT lhsLen, SizeT rhsLen) : fKey(lhsLen), fValue(rhsLen) { - KBasicString key = KString(lhsLen); - this->AsKey() = key; + this->AsKey() = key; KBasicString value = KString(rhsLen); - this->AsValue() = value; + this->AsValue() = value; } ~JsonObject() = default; @@ -54,7 +53,7 @@ class JsonObject final { Bool& IsUndefined() { return fUndefined; } private: - Bool fUndefined; // is this instance undefined? + Bool fUndefined; // is this instance undefined? KBasicString fKey; KBasicString fValue; diff --git a/src/kernel/NeKit/Macros.h b/src/kernel/NeKit/Macros.h index 5949b414..80a2ff6c 100644 --- a/src/kernel/NeKit/Macros.h +++ b/src/kernel/NeKit/Macros.h @@ -16,7 +16,7 @@ #endif #ifndef kib_cast -#define kib_cast(X) (Kernel::UInt64)((X) *1024) +#define kib_cast(X) (Kernel::UInt64)((X) * 1024) #endif #ifndef MIB @@ -117,7 +117,7 @@ #define NE_UNUSED(X) ((Kernel::Void) X) #ifndef RGB -#define RGB(R, G, B) ((Kernel::UInt32)((0xFF << 24) | ((R) << 16) | ((G) << 8) | (B))) +#define RGB(R, G, B) ((Kernel::UInt32) ((0xFF << 24) | ((R) << 16) | ((G) << 8) | (B))) #endif // !RGB #ifdef __NE_AMD64__ diff --git a/src/kernel/NeKit/MutableArray.h b/src/kernel/NeKit/MutableArray.h index e1138b3b..e14afbfe 100644 --- a/src/kernel/NeKit/MutableArray.h +++ b/src/kernel/NeKit/MutableArray.h @@ -180,7 +180,7 @@ class MutableArray : public NullableMutableArray { SizeT Count() const { return fNodeCount; } - bool Contains(T& value) noexcept { + bool Contains(T& value) { MutableLinkedList* first = fFirstNode; while (first) { diff --git a/src/kernel/NeKit/New.h b/src/kernel/NeKit/New.h index 36830129..bd986347 100644 --- a/src/kernel/NeKit/New.h +++ b/src/kernel/NeKit/New.h @@ -15,6 +15,6 @@ typedef __SIZE_TYPE__ size_t; void* operator new(size_t); void* operator new[](size_t); -void operator delete(void*) noexcept; +void operator delete(void*); void operator delete(void*, unsigned long); -void operator delete[](void*) noexcept; +void operator delete[](void*); diff --git a/src/kernel/NeKit/OwnPtr.h b/src/kernel/NeKit/OwnPtr.h index c8ceb1a2..bec2813b 100644 --- a/src/kernel/NeKit/OwnPtr.h +++ b/src/kernel/NeKit/OwnPtr.h @@ -50,7 +50,7 @@ class OwnPtr final { Ref AsRef() { return Ref(fCls); } - operator bool() { return fCls; } + operator bool() { return fCls; } bool operator!() { return !fCls; } private: diff --git a/src/kernel/NeKit/Ref.h b/src/kernel/NeKit/Ref.h index dac701e0..59991442 100644 --- a/src/kernel/NeKit/Ref.h +++ b/src/kernel/NeKit/Ref.h @@ -37,13 +37,13 @@ class Ref final { public: T operator->() const { return fClass; } - T& Leak() noexcept { return fClass; } + T& Leak() { return fClass; } - T& TryLeak() noexcept { return fClass; } + T& TryLeak() { return fClass; } T operator*() { return fClass; } - operator bool() noexcept { return true; } + operator bool() { return true; } private: T fClass; diff --git a/src/kernel/NeKit/Variant.h b/src/kernel/NeKit/Variant.h index 7bcd0dff..1b0fbe5d 100644 --- a/src/kernel/NeKit/Variant.h +++ b/src/kernel/NeKit/Variant.h @@ -8,8 +8,8 @@ #include #include -#include #include +#include #include namespace Kernel { @@ -17,7 +17,7 @@ class Variant final { public: enum class VariantKind { kInvalid = 0, - kString = 200, + kString = 200, kBlob, kNull, kJson, @@ -55,10 +55,10 @@ class Variant final { /// @brief Returns the underlying pointer. /// @return the underlying pointer. /// ======================================================================== - VoidPtr Leak(); + VoidPtr Leak(); template - T* As() noexcept { + T* As() { return reinterpret_cast(fPtr); } -- cgit v1.2.3