From ceabd82ac8e796249feacf39c836034ed5e11c6d Mon Sep 17 00:00:00 2001 From: Amlal El Mahrouss Date: Sat, 29 Nov 2025 15:01:34 -0500 Subject: chore: source code review and fixes. Signed-off-by: Amlal El Mahrouss --- src/libDDK/DriverKit/c++/ddk.h | 2 +- src/libDDK/DriverKit/c++/driver_base.h | 10 +++++----- src/libDDK/src/ddk_kernel_call.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/libDDK') diff --git a/src/libDDK/DriverKit/c++/ddk.h b/src/libDDK/DriverKit/c++/ddk.h index 2c83f935..d8576a57 100644 --- a/src/libDDK/DriverKit/c++/ddk.h +++ b/src/libDDK/DriverKit/c++/ddk.h @@ -9,5 +9,5 @@ #pragma once +#include #include -#include diff --git a/src/libDDK/DriverKit/c++/driver_base.h b/src/libDDK/DriverKit/c++/driver_base.h index 89cc04d8..a0c22216 100644 --- a/src/libDDK/DriverKit/c++/driver_base.h +++ b/src/libDDK/DriverKit/c++/driver_base.h @@ -29,10 +29,10 @@ class IDriverBase { using PtrType = VoidPtr; - virtual BOOL IsCastable() { return NO; } - virtual constexpr BOOL IsActive() { return NO; } - virtual PtrType Leak() { return nullptr; } - virtual constexpr Int32 Type() { return 0; } + virtual BOOL IsCastable() { return NO; } + virtual constexpr BOOL IsActive() { return NO; } + virtual PtrType Leak() { return nullptr; } + virtual constexpr Int32 Type() { return 0; } }; /// @brief This concept requires the Driver to be IDriverBase compliant. @@ -43,6 +43,6 @@ concept IsValidDriver = requires(T a) { /// @brief Consteval helper to detect whether a template is truly based on IDriverBase. /// @note This helper is consteval only. -template +template inline consteval void ce_ddk_is_valid(T) {} } // namespace Kernel::DDK diff --git a/src/libDDK/src/ddk_kernel_call.c b/src/libDDK/src/ddk_kernel_call.c index 92652969..f4bf9130 100644 --- a/src/libDDK/src/ddk_kernel_call.c +++ b/src/libDDK/src/ddk_kernel_call.c @@ -12,8 +12,8 @@ #include /// @brief this is an internal call, do not use it. -DDK_EXTERN ATTRIBUTE(naked) ptr_t - __ke_call_dispatch(const int32_t name, int32_t cnt, void* data, size_t sz); +DDK_EXTERN ATTRIBUTE(naked) +ptr_t __ke_call_dispatch(const int32_t name, int32_t cnt, void* data, size_t sz); /// @brief This function hashes the path into a FNV symbol. /// @param path the path to hash. -- cgit v1.2.3