diff options
| author | Amlal El Mahrouss <amlal@nekernel.org> | 2025-11-20 09:34:21 -0500 |
|---|---|---|
| committer | Amlal El Mahrouss <amlal@nekernel.org> | 2025-11-20 09:34:21 -0500 |
| commit | bb9af1fde25f5c2b4feeaa474392797ae5c4599d (patch) | |
| tree | b9a3228913de5872bf411d1dfc4fc1e3a1f2df4d | |
| parent | 3bc2fca2c9beff13586b8bf3089ce439acb09de1 (diff) | |
feat: ChunkString: Linux fixes and improved unit test.
Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
| -rw-r--r-- | dev/lib/core/chunk_string.hpp | 1 | ||||
| -rw-r--r-- | dev/lib/net/url.hpp | 6 | ||||
| -rw-r--r-- | dev/tests/chunk_string/CMakeLists.txt | 4 | ||||
| -rw-r--r-- | dev/tests/chunk_string/chunk_test.cc | 2 |
4 files changed, 7 insertions, 6 deletions
diff --git a/dev/lib/core/chunk_string.hpp b/dev/lib/core/chunk_string.hpp index 7e5360c..0ecc73e 100644 --- a/dev/lib/core/chunk_string.hpp +++ b/dev/lib/core/chunk_string.hpp @@ -10,6 +10,7 @@ #include <lib/core/includes.hpp> #include <lib/io/print.hpp> +#include <cstring> namespace ocl { diff --git a/dev/lib/net/url.hpp b/dev/lib/net/url.hpp index e4eca2a..e5f6803 100644 --- a/dev/lib/net/url.hpp +++ b/dev/lib/net/url.hpp @@ -41,17 +41,17 @@ namespace ocl::net if (protocol.starts_with("https://")) { m_protocol_ = url_protocol::https; - this->operator/=(protocol.substr(strlen("https://"))); + this->operator/=(protocol.substr(std::size("https://"))); } else if (protocol.starts_with("http://")) { m_protocol_ = url_protocol::http; - this->operator/=(protocol.substr(strlen("http://"))); + this->operator/=(protocol.substr(std::size("http://"))); } else if (protocol.starts_with("mailto:")) { m_protocol_ = url_protocol::mailto; - this->operator/=(protocol.substr(strlen("mailto:"))); + this->operator/=(protocol.substr(std::size("mailto:"))); } } diff --git a/dev/tests/chunk_string/CMakeLists.txt b/dev/tests/chunk_string/CMakeLists.txt index 5a4a27c..89d0e4d 100644 --- a/dev/tests/chunk_string/CMakeLists.txt +++ b/dev/tests/chunk_string/CMakeLists.txt @@ -1,7 +1,7 @@ cmake_minimum_required(VERSION 3.27) project(BasicChunkUsage LANGUAGES CXX) -find_package(Boost REQUIRED COMPONENTS container) +# find_package(Boost REQUIRED COMPONENTS container) include(FetchContent) FetchContent_Declare( @@ -16,7 +16,7 @@ FetchContent_MakeAvailable(googletest) enable_testing() add_executable(BasicChunkUsage chunk_test.cc) -target_link_libraries(BasicChunkUsage PRIVATE gtest_main Boost::container) +target_link_libraries(BasicChunkUsage PRIVATE gtest_main) set_property(TARGET BasicChunkUsage PROPERTY CXX_STANDARD 20) target_include_directories(BasicChunkUsage PUBLIC ../../) diff --git a/dev/tests/chunk_string/chunk_test.cc b/dev/tests/chunk_string/chunk_test.cc index 7d68ae2..0cef647 100644 --- a/dev/tests/chunk_string/chunk_test.cc +++ b/dev/tests/chunk_string/chunk_test.cc @@ -27,5 +27,5 @@ TEST(ChunkTest, BasicChunkUsage) auto end = std::chrono::high_resolution_clock::now(); auto optimized_time = std::chrono::duration_cast<std::chrono::milliseconds>(end - start); - EXPECT_TRUE(optimized_time.count() < limit); + EXPECT_TRUE(optimized_time.count() < 100U); } |