diff options
| author | Amlal <amlal.elmahrouss@icloud.com> | 2024-10-29 20:32:23 +0100 |
|---|---|---|
| committer | Amlal <amlal.elmahrouss@icloud.com> | 2024-10-29 20:32:23 +0100 |
| commit | 708400a70921055b06013f9b149449be64a7d585 (patch) | |
| tree | fca84921803172a0d41b28fb605b13a1d3c8dc48 | |
| parent | 1f8df0670cbda950901162b720393d15acd70261 (diff) | |
IMP: Code quality fixes.
Signed-off-by: Amlal <amlal.elmahrouss@icloud.com>
| -rw-r--r-- | dev/ZBAKit/src/BootFileReader.cc | 12 | ||||
| -rw-r--r-- | dev/ZBAKit/src/BootTextWriter.cc | 4 | ||||
| -rw-r--r-- | dev/ZKAKit/HALKit/AMD64/HalDebugPort.cc | 2 | ||||
| -rw-r--r-- | dev/ZKAKit/HALKit/AMD64/HalInterruptAPI.asm | 2 |
4 files changed, 10 insertions, 10 deletions
diff --git a/dev/ZBAKit/src/BootFileReader.cc b/dev/ZBAKit/src/BootFileReader.cc index e984baf8..f76e2164 100644 --- a/dev/ZBAKit/src/BootFileReader.cc +++ b/dev/ZBAKit/src/BootFileReader.cc @@ -76,9 +76,9 @@ Boot::BFileReader::BFileReader(const CharacterTypeUTF16* path, return; } - EfiFileProtocol* KernelFile = nullptr; + EfiFileProtocol* fileFs = nullptr; - if (mRootFs->Open(mRootFs, &KernelFile, mPath, kEFIFileRead, kEFIReadOnly) != + if (mRootFs->Open(mRootFs, &fileFs, mPath, kEFIFileRead, kEFIReadOnly) != kEfiOk) { mWriter.Write(L"ZBA: Fetch-Protocol: No-Such-Path: ") @@ -94,7 +94,7 @@ Boot::BFileReader::BFileReader(const CharacterTypeUTF16* path, } mSizeFile = 0; - mFile = KernelFile; + mFile = fileFs; mErrorCode = kOperationOkay; } @@ -130,8 +130,8 @@ Void Boot::BFileReader::ReadAll(SizeT readUntil, SizeT chunkToRead, UIntPtr out_ { if (mBlob == nullptr) { - EfiFileInfo newPtrInfo; - UInt32 szInfo = 0; + EfiFileInfo newPtrInfo{}; + UInt32 szInfo = 0U; EfiGUID kFileInfoGUID = EFI_FILE_INFO_GUID; @@ -142,7 +142,7 @@ Void Boot::BFileReader::ReadAll(SizeT readUntil, SizeT chunkToRead, UIntPtr out_ else if (readUntil < 1) readUntil = newPtrInfo.FileSize; - mWriter.Write(L"ZBA: FileSize: ").Write(readUntil).Write("\r"); + mWriter.Write(L"ZBA: File size: ").Write(readUntil).Write("\r"); } if (!out_address) diff --git a/dev/ZBAKit/src/BootTextWriter.cc b/dev/ZBAKit/src/BootTextWriter.cc index cc9ff461..12342c40 100644 --- a/dev/ZBAKit/src/BootTextWriter.cc +++ b/dev/ZBAKit/src/BootTextWriter.cc @@ -16,8 +16,8 @@ #include <BootKit/Protocol.h> #include <BootKit/BootKit.h> -/// BUGS: 0 - +///////////////////////////////////////////////////////////////////////////////////////////////////////// +/// BUGS: 0 /// ///////////////////////////////////////////////////////////////////////////////////////////////////////// /** diff --git a/dev/ZKAKit/HALKit/AMD64/HalDebugPort.cc b/dev/ZKAKit/HALKit/AMD64/HalDebugPort.cc index bd2a0037..eba75654 100644 --- a/dev/ZKAKit/HALKit/AMD64/HalDebugPort.cc +++ b/dev/ZKAKit/HALKit/AMD64/HalDebugPort.cc @@ -34,7 +34,7 @@ namespace Kernel HAL::rt_wait_400ns(); if (HAL::In16(theHook->fPort[i] != kDebugUnboundPort)) - theHook->fBoundCnt++; + ++theHook->fBoundCnt; } } } // namespace Kernel diff --git a/dev/ZKAKit/HALKit/AMD64/HalInterruptAPI.asm b/dev/ZKAKit/HALKit/AMD64/HalInterruptAPI.asm index 942530d7..bf36194a 100644 --- a/dev/ZKAKit/HALKit/AMD64/HalInterruptAPI.asm +++ b/dev/ZKAKit/HALKit/AMD64/HalInterruptAPI.asm @@ -1,7 +1,7 @@ ;; /* ;; * --------------------------------------------------- ;; * -;; * Copyright EL Mahrouss Logic., all rights reserved. +;; * Copyright EL Mahrouss Logic, all rights reserved. ;; * ;; * File: HalInterruptAPI.asm ;; * Purpose: Interrupt API, redirect raw interrupts into their handlers. |