diff options
| author | Amlal <amlalelmahrouss@icloud.com> | 2024-12-22 16:50:01 +0100 |
|---|---|---|
| committer | Amlal <amlalelmahrouss@icloud.com> | 2024-12-22 16:50:01 +0100 |
| commit | 78772d95f14818efadc676651d30b04f6ae57c7d (patch) | |
| tree | 7d7ca223c00a60e6b1d8d98be306f53bd93bdac7 /dev/Kernel/src | |
| parent | d78bd7257f380888e9900f6357e6ec280240d451 (diff) | |
IMPL: Issue #4 Fixing a bug within the scheduler, which causes a SIGKILL
to happen.
Signed-off-by: Amlal <amlalelmahrouss@icloud.com>
Diffstat (limited to 'dev/Kernel/src')
| -rw-r--r-- | dev/Kernel/src/CodeMgr.cc | 3 | ||||
| -rw-r--r-- | dev/Kernel/src/DriveMgr.cc | 2 | ||||
| -rw-r--r-- | dev/Kernel/src/FileMgr.cc | 2 | ||||
| -rw-r--r-- | dev/Kernel/src/HardwareThreadScheduler.cc | 2 | ||||
| -rw-r--r-- | dev/Kernel/src/PEFCodeMgr.cc | 6 | ||||
| -rw-r--r-- | dev/Kernel/src/UserProcessScheduler.cc | 5 |
6 files changed, 11 insertions, 9 deletions
diff --git a/dev/Kernel/src/CodeMgr.cc b/dev/Kernel/src/CodeMgr.cc index 0450f56a..7946d424 100644 --- a/dev/Kernel/src/CodeMgr.cc +++ b/dev/Kernel/src/CodeMgr.cc @@ -16,7 +16,8 @@ namespace Kernel /// @return if the process was started or not. ProcessID rtl_create_process(rtl_main_kind main, const Char* process_name) noexcept { - if (*process_name == 0) + if (!process_name || + *process_name == 0) return kProcessInvalidID; UserProcess* process_hdr = new UserProcess(); diff --git a/dev/Kernel/src/DriveMgr.cc b/dev/Kernel/src/DriveMgr.cc index ec21b83c..036997cb 100644 --- a/dev/Kernel/src/DriveMgr.cc +++ b/dev/Kernel/src/DriveMgr.cc @@ -129,7 +129,7 @@ namespace Kernel /// @brief Unimplemented drive function. /// @param pckt the packet to read. /// @return - Void io_drv_unimplemented(DriveTrait::DrivePacket* pckt) + Void io_drv_unimplemented(DriveTrait::DrivePacket* pckt) noexcept { ZKA_UNUSED(pckt); } diff --git a/dev/Kernel/src/FileMgr.cc b/dev/Kernel/src/FileMgr.cc index c748e721..4f2994d2 100644 --- a/dev/Kernel/src/FileMgr.cc +++ b/dev/Kernel/src/FileMgr.cc @@ -7,7 +7,7 @@ #include <KernelKit/FileMgr.h> #include <NewKit/Utils.h> -/// BUGS: 0 +/// @file FileMgr.cc //! @brief File System Manager API. namespace Kernel diff --git a/dev/Kernel/src/HardwareThreadScheduler.cc b/dev/Kernel/src/HardwareThreadScheduler.cc index e93b2284..1c5b0a23 100644 --- a/dev/Kernel/src/HardwareThreadScheduler.cc +++ b/dev/Kernel/src/HardwareThreadScheduler.cc @@ -114,7 +114,7 @@ namespace Kernel /// @retval true stack was changed, code is running. /// @retval false stack is invalid, previous code is running. /***********************************************************************************/ - Bool HardwareThread::Switch(VoidPtr image, Ptr8 stack_ptr, HAL::StackFramePtr frame, const ProcessID& pid) + Bool HardwareThread::Switch(VoidPtr image, Ptr8 stack_ptr, HAL::StackFramePtr frame, const ThreadID& pid) { if (!frame || !image || diff --git a/dev/Kernel/src/PEFCodeMgr.cc b/dev/Kernel/src/PEFCodeMgr.cc index 5cde2da1..a27db7e3 100644 --- a/dev/Kernel/src/PEFCodeMgr.cc +++ b/dev/Kernel/src/PEFCodeMgr.cc @@ -14,9 +14,9 @@ #include <NewKit/KString.h> /// @brief PEF stack size symbol. -#define kPefStackSizeSymbol "SizeOfReserveStack" -#define kPefHeapSizeSymbol "SizeOfReserveHeap" -#define kPefNameSymbol "ProgramName" +#define kPefStackSizeSymbol "__PEFSizeOfReserveStack" +#define kPefHeapSizeSymbol "__PEFSizeOfReserveHeap" +#define kPefNameSymbol "__PEFProgramName" namespace Kernel { diff --git a/dev/Kernel/src/UserProcessScheduler.cc b/dev/Kernel/src/UserProcessScheduler.cc index d6e27bd6..cdf5dcee 100644 --- a/dev/Kernel/src/UserProcessScheduler.cc +++ b/dev/Kernel/src/UserProcessScheduler.cc @@ -284,7 +284,8 @@ namespace Kernel ProcessID UserProcessScheduler::Spawn(UserProcess* process) { - if (!process) + if (!process || + !process->Image) { return kProcessInvalidID; } @@ -522,7 +523,7 @@ namespace Kernel Bool UserProcessHelper::Switch(VoidPtr image_ptr, UInt8* stack, HAL::StackFramePtr frame_ptr, const PID& new_pid) { - if (!stack || !frame_ptr || !image_ptr || new_pid < 0) + if (!stack || !frame_ptr || !image_ptr) return No; if (!mm_is_valid_heap(image_ptr)) |
