chore: source code review and fixes.

Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>

8 files changed, 15 insertions, 19 deletions

diff --git a/src/kernel/HALKit/ARM64/ApplicationProcessor.h b/src/kernel/HALKit/ARM64/ApplicationProcessor.h
index 208bf82e..9768cebc 100644
--- a/src/kernel/HALKit/ARM64/ApplicationProcessor.h
+++ b/src/kernel/HALKit/ARM64/ApplicationProcessor.h
@@ -15,5 +15,5 @@
 /************************************************** */
 
 namespace Kernel {
-Void mp_init_cores(Void) noexcept;
+Void mp_init_cores(Void);
 }
\ No newline at end of file
diff --git a/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc b/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc
index 2a3c73e5..fff4282f 100644
--- a/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc
+++ b/src/kernel/HALKit/ARM64/HalApplicationProcessor.cc
@@ -131,7 +131,7 @@ EXTERN_C Bool mp_register_task(HAL::StackFramePtr stack_frame, ProcessID thrdid)
 /// @brief Initialize the Global Interrupt Controller.

 /// @internal

 /***********************************************************************************/

-Void mp_init_cores(Void) noexcept {

+Void mp_init_cores(Void) {

   if (!Detail::kGICEnabled) {

     Detail::kGICEnabled = YES;

     Detail::mp_setup_gic_el0();

diff --git a/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc b/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc
index b89f68bd..3c18e837 100644
--- a/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc
+++ b/src/kernel/HALKit/ARM64/HalCoreInterruptHandler.cc
@@ -56,8 +56,7 @@ EXTERN_C void int_handle_scheduler(Kernel::UIntPtr rsp) {
 
   hal_int_send_eoi(32);
 
-  while (kIsRunning)
-    ;
+  while (kIsRunning);
 
   kIsRunning = YES;
 
diff --git a/src/kernel/HALKit/ARM64/HalDebugOutput.cc b/src/kernel/HALKit/ARM64/HalDebugOutput.cc
index c0da9c3a..22a41dbf 100644
--- a/src/kernel/HALKit/ARM64/HalDebugOutput.cc
+++ b/src/kernel/HALKit/ARM64/HalDebugOutput.cc
@@ -63,7 +63,7 @@ EXTERN_C void ke_io_read(DeviceInterface<const Char*>* self, const Char* bytes)
 #endif  // __DEBUG__
 }
 
-TerminalDevice TerminalDevice::The() noexcept {
+TerminalDevice TerminalDevice::The() {
   TerminalDevice out(Kernel::ke_io_write, Kernel::ke_io_read);
   return out;
 }
diff --git a/src/kernel/HALKit/ARM64/HalKernelMain.cc b/src/kernel/HALKit/ARM64/HalKernelMain.cc
index e36535c3..1cd10838 100644
--- a/src/kernel/HALKit/ARM64/HalKernelMain.cc
+++ b/src/kernel/HALKit/ARM64/HalKernelMain.cc
@@ -57,7 +57,6 @@ EXTERN_C void hal_init_platform(Kernel::HEL::BootInfoHeader* handover_hdr) {
 
   Kernel::mp_init_cores();
 
-  while (YES)
-    ;
+  while (YES);
 }
 #endif
diff --git a/src/kernel/HALKit/ARM64/HalKernelPanic.cc b/src/kernel/HALKit/ARM64/HalKernelPanic.cc
index 6837ba1c..6c3afe83 100644
--- a/src/kernel/HALKit/ARM64/HalKernelPanic.cc
+++ b/src/kernel/HALKit/ARM64/HalKernelPanic.cc
@@ -22,7 +22,7 @@ namespace Kernel {
 /// @brief Dumping factory class.
 class RecoveryFactory final {
  public:
-  STATIC Void Recover() noexcept;
+  STATIC Void Recover();
 };
 
 /***********************************************************************************/
@@ -37,7 +37,7 @@ Void ke_panic(const Kernel::Int32& id, const Char* message) {
   RecoveryFactory::Recover();
 }
 
-Void RecoveryFactory::Recover() noexcept {
+Void RecoveryFactory::Recover() {
   while (YES) {
     HAL::rt_halt();
   }
diff --git a/src/kernel/HALKit/ARM64/Paging.h b/src/kernel/HALKit/ARM64/Paging.h
index 766210b3..e8bd0ac1 100644
--- a/src/kernel/HALKit/ARM64/Paging.h
+++ b/src/kernel/HALKit/ARM64/Paging.h
@@ -41,14 +41,10 @@
 
 /// Long format address range
 
-#define cPageMAll \
-  { 0b000, 0b000 }
-#define cPageMToMax(M) \
-  { M, 0b000 }
-#define cPageMaxToM(M) \
-  { 0b000, M }
-#define cPageMToN(M, N) \
-  { M, N }
+#define cPageMAll {0b000, 0b000}
+#define cPageMToMax(M) {M, 0b000}
+#define cPageMaxToM(M) {0b000, M}
+#define cPageMToN(M, N) {M, N}
 
 namespace Kernel::HAL {
 struct PACKED PTE_4KB final {
@@ -86,7 +82,9 @@ namespace Detail {
     PageEnable          = 31,
   };
 
-  inline UInt8 control_register_cast(ControlRegisterBits reg) { return static_cast<UInt8>(reg); }
+  inline UInt8 control_register_cast(ControlRegisterBits reg) {
+    return static_cast<UInt8>(reg);
+  }
 }  // namespace Detail
 
 struct PDE_4KB final {
diff --git a/src/kernel/HALKit/ARM64/Processor.h b/src/kernel/HALKit/ARM64/Processor.h
index 716d317b..de9f932e 100644
--- a/src/kernel/HALKit/ARM64/Processor.h
+++ b/src/kernel/HALKit/ARM64/Processor.h
@@ -60,7 +60,7 @@ struct PACKED StackFrame {
 
 typedef StackFrame* StackFramePtr;
 
-inline Void rt_halt() noexcept {
+inline Void rt_halt() {
   while (Yes) {
   }
 }