summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorAmlal El Mahrouss <amlal@nekernel.org>2026-03-26 09:20:25 +0100
committerAmlal El Mahrouss <amlal@nekernel.org>2026-03-26 09:23:38 +0100
commit9b85b2810a64fb512d3ab35b8965db3071618223 (patch)
tree063352a1e6e3c20bba085b59c1d0700cf4d2eeb0
parent7c506c9b48bbad8fd87da66882311089572dc767 (diff)
[FEAT&FIX] DebuggerKit: Fix compiler errors, update installer.
Signed-off-by: Amlal El Mahrouss <amlal@nekernel.org>
-rw-r--r--include/DebuggerKit/NeSystem.h6
-rwxr-xr-xinstall.sh2
-rw-r--r--src/DebuggerKit/src/NeSystem.cpp4
3 files changed, 6 insertions, 6 deletions
diff --git a/include/DebuggerKit/NeSystem.h b/include/DebuggerKit/NeSystem.h
index 299815d..a0f3c39 100644
--- a/include/DebuggerKit/NeSystem.h
+++ b/include/DebuggerKit/NeSystem.h
@@ -22,7 +22,7 @@ class NeSystemDebugger;
/// \brief NeKernel Debugger Contract
/// \author Amlal El Mahrouss
/// =========================================================== ///
-class NeSystemDebugger final DK_DEBUGGER_CONTRACT {
+class NeSystemDebugger DK_DEBUGGER_CONTRACT {
public:
NeSystemDebugger();
virtual ~NeSystemDebugger() override;
@@ -32,9 +32,9 @@ class NeSystemDebugger final DK_DEBUGGER_CONTRACT {
NeSystemDebugger(const NeSystemDebugger&) = default;
public:
- bool Attach(CompilerKit::STLString path, CompilerKit::STLString arg_v,
+ bool Attach(const CompilerKit::STLString& path, const CompilerKit::STLString& arg_v,
ProcessID& pid) noexcept override;
- bool BreakAt(CompilerKit::STLString symbol) noexcept override;
+ bool BreakAt(const CompilerKit::STLString& symbol) noexcept override;
bool Break() noexcept override;
bool Continue() noexcept override;
bool Detach() noexcept override;
diff --git a/install.sh b/install.sh
index 0f10aca..a257a2f 100755
--- a/install.sh
+++ b/install.sh
@@ -20,4 +20,4 @@ sudo cp ptx-necdrv /usr/local/bin/
echo "== WELCOME TO NECTAR =="
echo "== HELP =="
-echo "== HELP NEEDED: NECTAR NEEDS MORE CONTRIBUTORS! JOIN US ON GITHUB! =="
+echo "pef-amd64-necdrv <FLAGS> <FILES>"
diff --git a/src/DebuggerKit/src/NeSystem.cpp b/src/DebuggerKit/src/NeSystem.cpp
index ea3beb4..381d2db 100644
--- a/src/DebuggerKit/src/NeSystem.cpp
+++ b/src/DebuggerKit/src/NeSystem.cpp
@@ -18,7 +18,7 @@ using namespace DebuggerKit::NeKernel;
NeSystemDebugger::NeSystemDebugger() = default;
NeSystemDebugger::~NeSystemDebugger() = default;
-bool NeSystemDebugger::Attach(CompilerKit::STLString path, CompilerKit::STLString argv,
+bool NeSystemDebugger::Attach(const CompilerKit::STLString& path, const CompilerKit::STLString& argv,
ProcessID& pid) noexcept {
if (path.empty() || argv.empty()) return NO;
@@ -44,7 +44,7 @@ bool NeSystemDebugger::Attach(CompilerKit::STLString path, CompilerKit::STLStrin
return ret;
}
-bool NeSystemDebugger::BreakAt(CompilerKit::STLString symbol) noexcept {
+bool NeSystemDebugger::BreakAt(const CompilerKit::STLString& symbol) noexcept {
CompilerKit::STLString pkt = Detail::kDebugMagic;
pkt += ";SYM=\"";
pkt += symbol;