diff options
| author | Amlal El Mahrouss <amlal.elmahrouss@icloud.com> | 2025-08-18 21:23:32 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-08-18 21:23:32 +0200 |
| commit | f0b4a1cd84244f09c71496b6a08636fc81e5292f (patch) | |
| tree | a31e1ca4e551eb19a97efde983c634a939abf928 /dev/lib/net | |
| parent | fba6a836e1e6ec8a234da9bd4b5e7c7f53faa0fb (diff) | |
feat: network.hpp: Code quality improvements.
Diffstat (limited to 'dev/lib/net')
| -rw-r--r-- | dev/lib/net/network.hpp | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/dev/lib/net/network.hpp b/dev/lib/net/network.hpp index 67f3740..e078c93 100644 --- a/dev/lib/net/network.hpp +++ b/dev/lib/net/network.hpp @@ -37,8 +37,7 @@ namespace snu::net static constexpr auto local_address_ip6 = "127.0.0.1"; static constexpr auto local_address_ip4 = "::1"; - - static constexpr auto backlog_count = 18U; + static constexpr const auto backlog_count = 18U; socket_type fd_{}; @@ -60,7 +59,7 @@ namespace snu::net auto ret = ::recv(fd_, out, len, 0); - return ret > 0; + return ret > 0L; } template <typename ptr_type> @@ -76,7 +75,7 @@ namespace snu::net auto ret = ::send(fd_, out, len, 0); - return ret > 0; + return ret > 0L; } template <typename ptr_type> @@ -87,7 +86,7 @@ namespace snu::net auto ret = ::send(fd_, out.data(), out.size(), 0); - return ret > 0; + return ret > 0L; } template <int32_t af, int32_t kind, int32_t ip_proto, int32_t port> @@ -111,7 +110,7 @@ namespace snu::net if (!is_server) { const auto ret = ::connect(fd_, reinterpret_cast<struct sockaddr*>(&addr_), sizeof(decltype(addr_))); - return ret == 0; + return ret == 0L; } ::listen(fd_, basic_modem::backlog_count); @@ -127,7 +126,7 @@ namespace snu::net ::shutdown(fd_, SHUT_RDWR); ::close(fd_); - fd_ = 0U; + fd_ = 0L; return true; } |